| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Original patch by vipul.bhasin@gmail.com.
BUG=3333
TEST=None
Review URL: http://codereview.chromium.org/6625076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
First part of the remaining files.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6649001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=GL extension string should show a bunch of extensions in PPAPI
Review URL: http://codereview.chromium.org/6588056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Account for variable size icon resources (which should themselves be fixed as well)
2. remove excess padding from start of confirm infobars.
BUG=none
TEST=visual
Review URL: http://codereview.chromium.org/6626066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=none
Review URL: http://codereview.chromium.org/6635046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=64887
TEST=NONE
TBR=zea
Review URL: http://codereview.chromium.org/6648003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
called from WebCore::EventTarget::removeAllEventListeners.
BUG=75318
TEST=NONE
TBR=zea
Review URL: http://codereview.chromium.org/6646002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when the user is synced. This is the first step in the multi-profile UI implementation on Windows. The displayed tag consists of two parts:
1. A profile menu button with invisible border and background consisting of text and a dropdown arrow.
2. A tag image displayed on the browser frame beneath the profile menu button.
DETAILED CL DESCRIPTION:
1. Changes to the frame and view
* glass_browser_frame_view
adds the profile_menu button to the frame, along with methods for laying it out, and watching for user name changes.
2. New profile menu button
* profile_menu_button
sets up the actual menu button itself, and provides the method PaintProfileTag that draws the underlying tag image on the browser frame. a better way to do this might be to create a new kind of menu button that combines methods from ImageButton as well as TextButton -- but maybe that's overkill?
Review URL: http://codereview.chromium.org/6490022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also remove mention of about:tasks in release build,
where we don't generate any data for that about page.
R=eroman
Review URL: http://codereview.chromium.org/6626064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeOS and Win.
TBR=phajdan.jr@chromium.org
BUG=75134
TEST=none
Review URL: http://codereview.chromium.org/6623091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Call it ImporterProgressObserver.
- Add namespace importer around it.
- Put ImportStarted as the first method, as it's the first signal to be fired. And reorder the methods in the consumers.
- Add OVERRIDE to the implementations of ImporterProgressObserver.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6625036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
failure.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6625088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
performs many CGContextSaveGState/RestoreGState calls during the plugin's lifetime and it foolishly calls into the plugin's rendering code and resizing/shutdown code with a different gstate stack depth, which makes it unsound to call RestoreGState on the old CGContext when resizing or shutting down (which happened both explicitly in DestroyCairoSurface() and implicitly inside cairo_surface_destory()). This resulted in an assertion failure inside the CGContextRestoreGState as it tried to pop from an empty stack. To avoid this we have no choice but to create and destroy the Cairo surface on every frame. Luckily, there is no significant perf impact.
TEST=O2D on OSX 10.6.4 in FF 3.6.13, Safari 5.0.2, and Chrome 10.0.648.127; compared framerate and CPU usage in FF to the original code and verified there is no significant difference
BUG=none
Review URL: http://codereview.chromium.org/6624096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6626068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6633003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
complicated webpages without problems.
First, WebAccessibility now works around a "multiple inheritance problem"
in WebCore::AccessibilityObject where the same node appears as a child of
multiple parents. For example, a table cell appears as a child of both a
row and a column. This is solved by having each WebAccessibility parent
check whether the child lists itself as an ancestor. If not, it notes the
child's id only in a separate vector, so each child appears fully only once.
Second, BrowserAccessibility now has internal reference counting, which allows
BrowserAccessibilityManager to update any subtree while maximally reusing
as many objects as possible. This fixes many screen reader interaction
problems!
All of this new functionality is tested with new cross-platform tests.
BUG=67192
BUG=67620
TEST=Adds new unit tests and a browser test.
Review URL: http://codereview.chromium.org/6625042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This virtual method, implemented only by URLRequestJob and MockFilterContext,
was only used for testing purposes. The kFilterBufSize constant now lives
in filter.cc (the only place it was used), and for the few tests that needed
to override the buffer size, I've added a test-only method in filter.h.
The result is a smaller interface surface in URLRequestJob and simpler tests for most cases in gzip_filter_unittest.cc and sdch_filter_unittest.cc. I've done some further refactoring of the former to remove redundancy (most of Filter's complexity is exercised only in the SDCH test).
Review URL: http://codereview.chromium.org/6516025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Just the ability to read/write the data structure to a file. File
format is a simple header, the contents of the vectors, and a
checksum.
BUG=71832
TEST=none
Review URL: http://codereview.chromium.org/6625002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6621072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(see error at:
http://build.chromium.org/p/chromium.memory/builders/Chromium%20Mac%20%28valgrind%29/builds/2279/steps/memory%20test%3A%20net/logs/stdiohttp://build.chromium.org/p/chromium.memory/builders/Chromium%20Mac%20%28valgrind%29/builds/2279/steps/memory%20test%3A%20net/logs/stdio)
BUG=none
TEST=mac-valgrind is green
Review URL: http://codereview.chromium.org/6625086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Set-Cookie delimiter was a comma, but should have been a NUL.
- Requests with query strings containing 'http://' caused request url paths
to be truncated.
Fix from Kevin Lindsay (kelindsay@gmail.com)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6628084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
render because we didn't close out the SPDY stream.
Fix from Kevin Lindsay (kelindsay@gmail.com)
http://codereview.chromium.org/6597074/
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6628083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=74871
TEST=changing expanding items in the cookies list doesn't cause the items below to jiggle around as much
Review URL: http://codereview.chromium.org/6621054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This makes automatic generation of IPC messages much easier.
Convert autofill messsage to automatic generation in the process.
Attempt #2: fix build on chromeos, see http://codereview.chromium.org/6633001
for original CL.
Review URL: http://codereview.chromium.org/6625087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Move GetShowState to BrowserFrameWin rather than needlessly delegate to BrowserView. This removes a small amount of WIndows-specific code from BrowserView.
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6627079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=75296
TEST=NONE
TBR=zea
Review URL: http://codereview.chromium.org/6623088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The horizontal scrollbar is attached to the plugin, not to the page,
so it's only visible if the page is scrolled to the bottom.
BUG=74681
TEST=none
Review URL: http://codereview.chromium.org/6628080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6621055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72732
TEST=trybot, unit_tests, permissions warning for https://chrome.google.com/extensions/detail/pjmjjdikcijaponjlhnibejonnjlfohg
Review URL: http://codereview.chromium.org/6596085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This makes it easy to write automated serilization code for it.
Review URL: http://codereview.chromium.org/6621057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are very few reasons that the BrowserView needs to know anything specific about the TabStrip. Most of them have to do with drag and drop.
So we introduce in this patch, an AbstractTabStripView interface that is the BrowserView's interface to the tab strip (instead of BaseTabStrip). Furthermore, we acknowledge that the View and the Controller are tightly coupled (they know about each other) and are therefore bound together at creation time inside the factory function rather than by the caller of the factory function (which would have been the BrowserView.)
1) The extensions need to restrict the ability to move/remove tabs when a drop operation is active. So we have IsTabStripEditable() and IsTabStripCloseable().
2) The only other reason to know about the internals seems to be some notification of loading animations. So we have UpdateLoadingAnimations().
Ideally, some day a tab strip can just be a view from the browser's perspective. For now, we still need these three methods.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6597107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Convert autofill messages to use the new IPC macros. This requires
changing the FormField class to a struct with publically-visible members,
which was what should have been done in the first place, instead of the
trivial setters/getters which are accessed in various combinations
independently of each other throughout the code.
Review URL: http://codereview.chromium.org/6633001
TBR=tsepez@chromium.org
Review URL: http://codereview.chromium.org/6623086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
disable switch.
Since currently on download url is checked, this only enables download url checks.
Because the safe browsing server used by safe_browsing_test.cc does not understand the new list for safebrowsing download, we have to disable the download protect in that test.
TEST=safe browsing related tests stay green.
BUG=60822
Review URL: http://codereview.chromium.org/6611006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
changing the FormField class to a struct with publically-visible members,
which was what should have been done in the first place, instead of the
trivial setters/getters which are accessed in various combinations
independently of each other throughout the code.
Review URL: http://codereview.chromium.org/6633001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is part of a serie of patches to make the TreeNode more closer to style
used in the Views Tree API (see views/view.h for reference).
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6623037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, consolidate touch and mouse event constructions as much as possible.
BUG=clicking a webpage causes a crash
TEST=manually
Review URL: http://codereview.chromium.org/6624094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
at least in legal json format.
BUG=none
TEST=unittest
Review URL: http://codereview.chromium.org/6626058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6621045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6621070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6626073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=75274
TEST=NONE
TBR=erg,zea,andreip
Review URL: http://codereview.chromium.org/6626074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved the page and icon mapping from URLDatabase to
ThumbnailDatabase.
a. Created a new table icon_mappings in ThumbnailDatabase.
b. Migrated the mapping data during the upgrade.
c. Provided the new interface to access the icon_mapping data.
d. Removed the API to access the faviconID field in url database.
Support IconType.
a. Added additional column icon_type in favicons table.
b. Provided the APIs to access the icon_type field.
c. Currently hard-code all icon_type as FAV_ICON in history backend.
BUG=71571
TEST=new testcases in thumbnail_database_unittest.cc, and the existent
tests in history_backend_unittest.cc, history_unitest.cc,
bookmark_html_writer_unittest.cc etc.
Review URL: http://codereview.chromium.org/6620001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71558
TEST=A file named VERSION should show up in policy_templates.zip
Review URL: http://codereview.chromium.org/6596071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=X509CertificateNameVerifyTest.VerifyHostname, and also compiles with use_openssl=1 flag.
Review URL: http://codereview.chromium.org/6627051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Requested by: Wouter Timmermans
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The corresponding WebKit-side changed is
https://bugs.webkit.org/show_bug.cgi?id=55777
BUG=70845
TEST=none
Review URL: http://codereview.chromium.org/6624092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6638001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=touch compiles
TBR=msw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=steveblock
Review URL: http://codereview.chromium.org/6621069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77277 0039d316-1c4b-4281-b951-d872f2087c98
|