| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL eliminates direct calls to WebPluginDelegate::DidFinishLoadWithReason
from WebFrameLoaderClient.
This CL also moves WebDataSourceImpl into webkit/api/src. That change was
needed so that WebPluginContainerImpl can add a WebPluginLoadObserver to it,
which WebFrameLoaderClient uses to communicate back to the WebPlugin upon
completion of the frame load.
WebViewDelegate::DidFinishLoadWithReason is modified to include url and
notify_data parameters, eliminating the URLRequestRouted method. This is done
so that we can support overlapping NPN_GetURLNotify targetting different
frames.
WebPluginContainer grows an executeScriptURL method to deal with javascript:
URLs.
NOTE: I'm working on some UI tests to better cover the case of overlapping
NPN_GetURLNotify calls.
R=jam
BUG=10036
TEST=none yet
Review URL: http://codereview.chromium.org/174514
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reference
We now strip away the reference when comparing the url's (for the purpose of clearing the page action icons).
BUG=20398
TEST=None
Review URL: http://codereview.chromium.org/174613
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=yurys
Review URL: http://codereview.chromium.org/178003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=aa,rafaelw
Review URL: http://codereview.chromium.org/173586
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
infrastructure.
Also send events for the modifier keys. This matches Windows more closely. I needed this for an test I was writing which I decided to throw away as it was using the wrong approach.
Review URL: http://codereview.chromium.org/178002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/177004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173570
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174612
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Browser tests use the header files generated from the chrome_strings grd files,
thus they need a direct dependency on chrome_strings.
BUG=19866
TEST=None
Review URL: http://codereview.chromium.org/173583
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/177003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
And it is not the final set. The main goal of this patch
is to prevent further regressions.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/173547
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(Linux relies on the lazy generation provided by GenerateBitmap; having
to call GenerateTabImages() regressed linux startup; theoretically it'd be
nice if everything was done lazily...)
Review URL: http://codereview.chromium.org/180004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
holder at this point.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174596
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=One less error on the Mac UI valgrind bots
Review URL: http://codereview.chromium.org/177001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18984
TEST=Fewer Mac UI valgrind errors. Maybe even green someday. We can dream.
Review URL: http://codereview.chromium.org/180001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/174597
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=8630
TBR=levin
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the audio.
Previously we were calling NotifyEnded() when we had sent the last of the audio to the hardware. This is a small change to call NotifyEnded() when the audio hardware replies asking for additional data. Not perfect, but better than what we were doing before.
TEST=play a short seamless audio clip on loop, it should be closer to seamless looping
BUG=20349
Review URL: http://codereview.chromium.org/173520
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Content Scripts is in this CL because I moved some first-draft text
out of the overview and into it. It has a couple of other minor changes,
as well.
TBR=aa, rafaelw
Review URL: http://codereview.chromium.org/174230
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. It was possible to add empty rows to the list by repeatedly clicking the + button.
2. There was a crash when editing an existing item, clearing the text and pressing enter. CustomHomePagesEntry::setURL didn't handle a nil NSString passed to it in this condition.
I added a controlTextDidEndEditing method to PreferencesWindowController that forces a revalidation of the contents of the model backing the TableView.
http://crbug.com/19555
TEST=Click the + button below the custom home pages table view in the Basics page of Preferences. You should get an active edit but not add the item if you don't type anything. Also, try adding a few valid URLs, then click one to edit and delete the URL, then press enter. It should be removed from the table. See also attached unit test.
Review URL: http://codereview.chromium.org/174173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Purify.
BUG=19820
Review URL: http://codereview.chromium.org/180002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
of them.
TBR=levin
TEST=none
BUG=8630
Review URL: http://codereview.chromium.org/176001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
calculating the available tab width. The tabstrip and its tabs are not necessarily based at (0,0).
BUG=20329
TEST=Open many tabs until they resize smaller. Repeatedly close the left-most tab with the close button. The tabs should not resize at all until the mouse leaves the tabstrip.
Review URL: http://codereview.chromium.org/173559
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
being added to the tree.
Review URL: http://codereview.chromium.org/173530
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jorlow
TEST=none
BUG=14885
Review URL: http://codereview.chromium.org/173579
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
certificate validation code. This gives us proper hostname matching, multiple error codes (e.g., before a certificate could be marked as expired or untrusted, but not both), revocation checking, and EV certificate checking.
BUG=19286,10910,14733
TEST=https://www.paypal.com should work without warning. https://paypal.com should get a warning about a hostname mismatch. https://test-ssev.verisign.com:1443/test-SSEV-expired-verisign.html should give a warning about an expired certificate.
Review URL: http://codereview.chromium.org/174102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/173480
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=japhet
TEST=none
BUG=18412
Review URL: http://codereview.chromium.org/174618
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20234
TEST=Flash plugins that start offscreen should look correct when scrolled into view.
Review URL: http://codereview.chromium.org/173552
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
by decodeURLEscapeSequences.
See: https://bugs.webkit.org/show_bug.cgi?id=28767
TBR=darin (his original patch: http://codereview.chromium.org/174614)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173578
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r173550, due to WebKit failures.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=levin
TEST=none
BUG=8630
Review URL: http://codereview.chromium.org/174617
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=20359
TEST=none
TBR=jorlow
Review URL: http://codereview.chromium.org/173575
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
BUG=20399
TEST=none
Review URL: http://codereview.chromium.org/174615
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now scan more directories, sort file entries by mtime, use
realpath() before loading plugins (fixes a Java bug), and de-duplicate
multiple instances of the same plugin.
This matches the Mozilla plugin loading code more closely.
I encountered this while attempting to fix QuickTime (need to load
the Totem plugins) but the fix overlaps with the Java one. I believe
neither quite work yet, though.
BUG=16787,19712
TEST=about:plugins should show more plugins
Review URL: http://codereview.chromium.org/173550
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
InterceptRestartRequired fail.
The unit tests still fail, but don't crash which allows the other tests to run.
TEST=Run UrlRequest unit tests.
BUG=none
Review URL: http://codereview.chromium.org/173572
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dimich
BUG=19635
TEST=none
Review URL: http://codereview.chromium.org/173573
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=darin
Review URL: http://codereview.chromium.org/173574
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
TEST=none
http://crbug.com/19361
Review URL: http://codereview.chromium.org/173571
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Not getting rid of WaitForTitleMatching because I have to add few more calls to the automation framework (http://crbug.com/19395) to wait properly after navigating back and forward.
TEST=Covered by ui_tests and browser_tests.
http://crbug.com/18365, http://crbug.com/19361
Review URL: http://codereview.chromium.org/174179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This makes Linux extension shelf quite pretty now IMHO.
TEST=Just see it.
http://crbug.com/16759
Review URL: http://codereview.chromium.org/174585
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
does not
Review URL: http://codereview.chromium.org/174530
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/173560
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=mpcomplete@chormium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Give the user more information about which hosts an
extension can access.
- Remove the red severe warning because it doesn't play well
with themes and because it adds nothing when the other
text is more specific.
- Make the image a bit smaller.
Also integrate this new idea with the silent/not-silent update flow.
BUG=12129,12140,19582
Review URL: http://codereview.chromium.org/173463
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
getting accessed
after it was invalidated.
This should fix the embed-tag.html and object-embed-tag.html layout test failures.
TBR=jam
Review URL: http://codereview.chromium.org/174598
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We need to define ENABLE_DATALIST for them. We'll define it when the
WebKit's implementation is completed.
BUG=20292
TEST=none
Review URL: http://codereview.chromium.org/174595
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=12258
TEST=DiskCacheEntryTest.MemoryOnlyDoomSparseEntry
The sequence that caused this test to break was to doom to the entry while
it is still opened. Since closing the parent entry only delete itself and
then child entries are not cleaned up. This is corrected by using
InternalDoom() for destruction.
Review URL: http://codereview.chromium.org/174592
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
context of NPP_NewStream.
The plugin would invoke NPN_Evaluate to display an alert in the context of NewStream. This would cause the didFail IPC to be dispatched which would cause the plugin to invoke another call to NPP_NewStream which would repeat these steps and crash.
The didFail call from the renderer did not honor the deferred load flag which we set in WebPluginImpl
prior to dispatching stream IPCs to the plugin.
Fix is to dispatch the didFail call when we receive an ack from the plugin indicating that it is ready to accept stream data.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=20063
The other change is in WebPluginImpl::TearDownPluginInstance, where we run through the list of resource
clients and cancel them. We call didFail on these clients here, which occurs anyway through the PluginDestroyed
code path.
Bug=20063
Test=Convered by interactive UI test.
Review URL: http://codereview.chromium.org/174383
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24593 0039d316-1c4b-4281-b951-d872f2087c98
|