summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* More refactoring for WebPlugin.darin@chromium.org2009-08-2742-495/+761
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL eliminates direct calls to WebPluginDelegate::DidFinishLoadWithReason from WebFrameLoaderClient. This CL also moves WebDataSourceImpl into webkit/api/src. That change was needed so that WebPluginContainerImpl can add a WebPluginLoadObserver to it, which WebFrameLoaderClient uses to communicate back to the WebPlugin upon completion of the frame load. WebViewDelegate::DidFinishLoadWithReason is modified to include url and notify_data parameters, eliminating the URLRequestRouted method. This is done so that we can support overlapping NPN_GetURLNotify targetting different frames. WebPluginContainer grows an executeScriptURL method to deal with javascript: URLs. NOTE: I'm working on some UI tests to better cover the case of overlapping NPN_GetURLNotify calls. R=jam BUG=10036 TEST=none yet Review URL: http://codereview.chromium.org/174514 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24655 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 20398: PageAction icon disappears on reader.google.com when url includes ↵finnur@chromium.org2009-08-271-2/+9
| | | | | | | | | | | | | reference We now strip away the reference when comparing the url's (for the purpose of clearing the page action icons). BUG=20398 TEST=None Review URL: http://codereview.chromium.org/174613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24654 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: reset ScriptState in InspectorController on page refresh.pfeldman@chromium.org2009-08-273-20/+30
| | | | | | | | TBR=yurys Review URL: http://codereview.chromium.org/178003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24653 0039d316-1c4b-4281-b951-d872f2087c98
* Miscellaneous doc changes, nothing earthshaking.kathyw@google.com2009-08-279-21/+149
| | | | | | | | TBR=aa,rafaelw Review URL: http://codereview.chromium.org/173586 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24652 0039d316-1c4b-4281-b951-d872f2087c98
* Send release events as well as press events in linux event mocking ↵estade@chromium.org2009-08-271-35/+90
| | | | | | | | | | infrastructure. Also send events for the modifier keys. This matches Windows more closely. I needed this for an test I was writing which I decided to throw away as it was using the wrong approach. Review URL: http://codereview.chromium.org/178002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24650 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit deps roll 47827:47830jorlow@chromium.org2009-08-272-1/+5
| | | | | | | | | | TBR=ojan TEST=none BUG=none Review URL: http://codereview.chromium.org/177004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24649 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools l10n: inhibit until agreeded that it is needed.mnaganov@chromium.org2009-08-273-36/+12
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/173570 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24648 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: hook up SummaryBar which is added to WebKit @ r47822mnaganov@chromium.org2009-08-271-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/174612 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24647 0039d316-1c4b-4281-b951-d872f2087c98
* Adding in missing dependency on chrome_strings in browser_tests.bradnelson@google.com2009-08-271-0/+1
| | | | | | | | | | | | Browser tests use the header files generated from the chrome_strings grd files, thus they need a direct dependency on chrome_strings. BUG=19866 TEST=None Review URL: http://codereview.chromium.org/173583 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24646 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webkit deps to 47821:47827jorlow@chromium.org2009-08-272-1/+6
| | | | | | | | | | TBR=ojan TEST=none BUG=none Review URL: http://codereview.chromium.org/177003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24645 0039d316-1c4b-4281-b951-d872f2087c98
* Only allow in-process tests in few binaries.phajdan.jr@chromium.org2009-08-272-0/+13
| | | | | | | | | | | | And it is not the final set. The main goal of this patch is to prevent further regressions. TEST=none BUG=none Review URL: http://codereview.chromium.org/173547 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24644 0039d316-1c4b-4281-b951-d872f2087c98
* Add call to BrowserThemeProvider::GenerateBitmap removed in r24170.erg@google.com2009-08-272-1/+5
| | | | | | | | | | (Linux relies on the lazy generation provided by GenerateBitmap; having to call GenerateTabImages() regressed linux startup; theoretically it'd be nice if everything was done lazily...) Review URL: http://codereview.chromium.org/180004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24643 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the settings tab to options on chrome os. The contents is just a placesky@chromium.org2009-08-276-0/+95
| | | | | | | | | | holder at this point. BUG=none TEST=none Review URL: http://codereview.chromium.org/174596 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24642 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress a deliberate 'leak' in the Mac theme cachestuartmorgan@chromium.org2009-08-271-0/+12
| | | | | | | | | BUG=none TEST=One less error on the Mac UI valgrind bots Review URL: http://codereview.chromium.org/177001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24641 0039d316-1c4b-4281-b951-d872f2087c98
* Widen a suppression for a new stack variationstuartmorgan@chromium.org2009-08-271-0/+1
| | | | | | | | | BUG=18984 TEST=Fewer Mac UI valgrind errors. Maybe even green someday. We can dream. Review URL: http://codereview.chromium.org/180001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24640 0039d316-1c4b-4281-b951-d872f2087c98
* Fix code in effect_helper.cc that does not compile in GCC. maf@google.com2009-08-271-3/+6
| | | | | | Review URL: http://codereview.chromium.org/174597 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24639 0039d316-1c4b-4281-b951-d872f2087c98
* Add back repaint-related tests from fast/canvas.dglazkov@chromium.org2009-08-271-0/+3
| | | | | | | | | BUG=8630 TBR=levin TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24638 0039d316-1c4b-4281-b951-d872f2087c98
* Delay calling NotifyEnded() until the audio hardware has played the last of ↵scherkus@chromium.org2009-08-272-7/+18
| | | | | | | | | | | | | | the audio. Previously we were calling NotifyEnded() when we had sent the last of the audio to the hardware. This is a small change to call NotifyEnded() when the audio hardware replies asking for additional data. Not perfect, but better than what we were doing before. TEST=play a short seamless audio clip on loop, it should be closer to seamless looping BUG=20349 Review URL: http://codereview.chromium.org/173520 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24637 0039d316-1c4b-4281-b951-d872f2087c98
* Add a technical overview of extensions.kathyw@google.com2009-08-272-17/+407
| | | | | | | | | | | Content Scripts is in this CL because I moved some first-draft text out of the overview and into it. It has a couple of other minor changes, as well. TBR=aa, rafaelw Review URL: http://codereview.chromium.org/174230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24636 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a couple of bugs in the "custom home pages" list in the Preferences window.ben@chromium.org2009-08-274-1/+53
| | | | | | | | | | | | | 1. It was possible to add empty rows to the list by repeatedly clicking the + button. 2. There was a crash when editing an existing item, clearing the text and pressing enter. CustomHomePagesEntry::setURL didn't handle a nil NSString passed to it in this condition. I added a controlTextDidEndEditing method to PreferencesWindowController that forces a revalidation of the contents of the model backing the TableView. http://crbug.com/19555 TEST=Click the + button below the custom home pages table view in the Basics page of Preferences. You should get an active edit but not add the item if you don't type anything. Also, try adding a few valid URLs, then click one to edit and delete the URL, then press enter. It should be removed from the table. See also attached unit test. Review URL: http://codereview.chromium.org/174173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24635 0039d316-1c4b-4281-b951-d872f2087c98
* Skip ImporterTest.Firefox35Importer unit test again as it is still crashing ↵kuchhal@chromium.org2009-08-271-0/+3
| | | | | | | | | | Purify. BUG=19820 Review URL: http://codereview.chromium.org/180002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24634 0039d316-1c4b-4281-b951-d872f2087c98
* Create a larger filter for all repainting tests. We shouldn't be passing any ↵dglazkov@chromium.org2009-08-271-32/+1
| | | | | | | | | | | | of them. TBR=levin TEST=none BUG=8630 Review URL: http://codereview.chromium.org/176001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24632 0039d316-1c4b-4281-b951-d872f2087c98
* temp fix for bug with compressed texture clearinggman@google.com2009-08-271-19/+20
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24631 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Subtract the tabstrip x offset from the last tab x offset when ↵jhawkins@chromium.org2009-08-271-1/+1
| | | | | | | | | | calculating the available tab width. The tabstrip and its tabs are not necessarily based at (0,0). BUG=20329 TEST=Open many tabs until they resize smaller. Repeatedly close the left-most tab with the close button. The tabs should not resize at all until the mouse leaves the tabstrip. Review URL: http://codereview.chromium.org/173559 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24630 0039d316-1c4b-4281-b951-d872f2087c98
* Add myself to watchlists in an attempt to catch flakiness-inducing bugs ↵phajdan.jr@chromium.org2009-08-271-0/+8
| | | | | | | | being added to the tree. Review URL: http://codereview.chromium.org/173530 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24628 0039d316-1c4b-4281-b951-d872f2087c98
* Group all JSON failures under one bug.dglazkov@chromium.org2009-08-271-9/+6
| | | | | | | | | | TBR=jorlow TEST=none BUG=14885 Review URL: http://codereview.chromium.org/173579 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24627 0039d316-1c4b-4281-b951-d872f2087c98
* Enable SSLClientSocketTest unit tests on Mac OS X by implementing our own ↵hawk@chromium.org2009-08-277-97/+547
| | | | | | | | | | certificate validation code. This gives us proper hostname matching, multiple error codes (e.g., before a certificate could be marked as expired or untrusted, but not both), revocation checking, and EV certificate checking. BUG=19286,10910,14733 TEST=https://www.paypal.com should work without warning. https://paypal.com should get a warning about a hostname mismatch. https://test-ssev.verisign.com:1443/test-SSEV-expired-verisign.html should give a warning about an expired certificate. Review URL: http://codereview.chromium.org/174102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24625 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Remove base/values dependency from devtools.pfeldman@chromium.org2009-08-2730-635/+235
| | | | | | Review URL: http://codereview.chromium.org/173480 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24623 0039d316-1c4b-4281-b951-d872f2087c98
* Remove tests that are now passing from expectations.dglazkov@chromium.org2009-08-271-7/+0
| | | | | | | | | | TBR=japhet TEST=none BUG=18412 Review URL: http://codereview.chromium.org/174618 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24622 0039d316-1c4b-4281-b951-d872f2087c98
* Fix invalidates from off-screen plugins on the Mac.stuartmorgan@chromium.org2009-08-271-2/+12
| | | | | | | | | BUG=20234 TEST=Flash plugins that start offscreen should look correct when scrolled into view. Review URL: http://codereview.chromium.org/173552 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24621 0039d316-1c4b-4281-b951-d872f2087c98
* Fix test to account for the fact that %00 is now unescapedjorlow@chromium.org2009-08-271-2/+2
| | | | | | | | | | | | | | by decodeURLEscapeSequences. See: https://bugs.webkit.org/show_bug.cgi?id=28767 TBR=darin (his original patch: http://codereview.chromium.org/174614) BUG=none TEST=none Review URL: http://codereview.chromium.org/173578 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24619 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "linux: scan more plugin directories, fix bugs"evan@chromium.org2009-08-271-61/+11
| | | | | | This reverts commit r173550, due to WebKit failures. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24618 0039d316-1c4b-4281-b951-d872f2087c98
* Remove incorrect baseline for search-field-cancel test.dglazkov@chromium.org2009-08-273-26/+0
| | | | | | | | | | TBR=levin TEST=none BUG=8630 Review URL: http://codereview.chromium.org/174617 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24614 0039d316-1c4b-4281-b951-d872f2087c98
* Add inline-overflow.html to repaint failures pile.dglazkov@chromium.org2009-08-271-3/+1
| | | | | | | | | | BUG=20359 TEST=none TBR=jorlow Review URL: http://codereview.chromium.org/173575 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24613 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 47810:47821jorlow@chromium.org2009-08-272-1/+4
| | | | | | | | | | TBR=ojan BUG=20399 TEST=none Review URL: http://codereview.chromium.org/174615 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24612 0039d316-1c4b-4281-b951-d872f2087c98
* linux: scan more plugin directories, fix bugsevan@chromium.org2009-08-271-11/+61
| | | | | | | | | | | | | | | | | | We now scan more directories, sort file entries by mtime, use realpath() before loading plugins (fixes a Java bug), and de-duplicate multiple instances of the same plugin. This matches the Mozilla plugin loading code more closely. I encountered this while attempting to fix QuickTime (need to load the Totem plugins) but the fix overlaps with the Java one. I believe neither quite work yet, though. BUG=16787,19712 TEST=about:plugins should show more plugins Review URL: http://codereview.chromium.org/173550 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24611 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid crashing the test process when InterceptRedirector ↵tommi@chromium.org2009-08-271-2/+6
| | | | | | | | | | | | | InterceptRestartRequired fail. The unit tests still fail, but don't crash which allows the other tests to run. TEST=Run UrlRequest unit tests. BUG=none Review URL: http://codereview.chromium.org/173572 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24610 0039d316-1c4b-4281-b951-d872f2087c98
* Move Page cache-related tests into the WONTFIX section up at the topdglazkov@chromium.org2009-08-271-7/+7
| | | | | | | | | | TBR=dimich BUG=19635 TEST=none Review URL: http://codereview.chromium.org/173573 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24609 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r24606-24607. The tree didn't like them. :(phajdan.jr@chromium.org2009-08-2711-96/+32
| | | | | | | | TBR=darin Review URL: http://codereview.chromium.org/173574 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24608 0039d316-1c4b-4281-b951-d872f2087c98
* Wait correctly for navigations in ErrorPage UI test.phajdan.jr@chromium.org2009-08-271-4/+4
| | | | | | | | | | | TBR=darin TEST=none http://crbug.com/19361 Review URL: http://codereview.chromium.org/173571 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24607 0039d316-1c4b-4281-b951-d872f2087c98
* Mock the LinkDoctor for tests. Should greatly decrease ErrorPage test flakiness.phajdan.jr@chromium.org2009-08-2711-28/+92
| | | | | | | | | | | Not getting rid of WaitForTitleMatching because I have to add few more calls to the automation framework (http://crbug.com/19395) to wait properly after navigating back and forward. TEST=Covered by ui_tests and browser_tests. http://crbug.com/18365, http://crbug.com/19361 Review URL: http://codereview.chromium.org/174179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24606 0039d316-1c4b-4281-b951-d872f2087c98
* Draw background of Linux extension toolstrips.phajdan.jr@chromium.org2009-08-276-0/+36
| | | | | | | | | | | This makes Linux extension shelf quite pretty now IMHO. TEST=Just see it. http://crbug.com/16759 Review URL: http://codereview.chromium.org/174585 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24605 0039d316-1c4b-4281-b951-d872f2087c98
* Clear textures on creation for D3D because it gman@google.com2009-08-271-0/+41
| | | | | | | | does not Review URL: http://codereview.chromium.org/174530 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24603 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webkit 47804:47810jorlow@chromium.org2009-08-271-1/+1
| | | | | | | | | | TBR=ojan TEST=none BUG=none Review URL: http://codereview.chromium.org/173560 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24601 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak in ExtensionTest.aa@chromium.org2009-08-271-1/+0
| | | | | | TBR=mpcomplete@chormium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24600 0039d316-1c4b-4281-b951-d872f2087c98
* Update of the extension install UI:aa@chromium.org2009-08-2750-170/+656
| | | | | | | | | | | | | | | | | - Give the user more information about which hosts an extension can access. - Remove the red severe warning because it doesn't play well with themes and because it adds nothing when the other text is more specific. - Make the image a bit smaller. Also integrate this new idea with the silent/not-silent update flow. BUG=12129,12140,19582 Review URL: http://codereview.chromium.org/173463 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24599 0039d316-1c4b-4281-b951-d872f2087c98
* Test shell crashed while running layout tests due to an STL vector iterator ↵ananta@chromium.org2009-08-271-1/+4
| | | | | | | | | | | | | | getting accessed after it was invalidated. This should fix the embed-tag.html and object-embed-tag.html layout test failures. TBR=jam Review URL: http://codereview.chromium.org/174598 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24598 0039d316-1c4b-4281-b951-d872f2087c98
* Group failures for HTML5 datalist tests.tkent@chromium.org2009-08-271-4/+2
| | | | | | | | | | | We need to define ENABLE_DATALIST for them. We'll define it when the WebKit's implementation is completed. BUG=20292 TEST=none Review URL: http://codereview.chromium.org/174595 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24595 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DiskCacheEntryTest.MemoryOnlyDoomSparseEntryhclam@chromium.org2009-08-272-2/+2
| | | | | | | | | | | | | | BUG=12258 TEST=DiskCacheEntryTest.MemoryOnlyDoomSparseEntry The sequence that caused this test to break was to doom to the entry while it is still opened. Since closing the parent entry only delete itself and then child entries are not cleaned up. This is corrected by using InternalDoom() for destruction. Review URL: http://codereview.chromium.org/174592 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24594 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a crash caused due to a call to NPP_DestroyStream occuring in the ↵ananta@chromium.org2009-08-279-13/+145
| | | | | | | | | | | | | | | | | | | | | | | | | | context of NPP_NewStream. The plugin would invoke NPN_Evaluate to display an alert in the context of NewStream. This would cause the didFail IPC to be dispatched which would cause the plugin to invoke another call to NPP_NewStream which would repeat these steps and crash. The didFail call from the renderer did not honor the deferred load flag which we set in WebPluginImpl prior to dispatching stream IPCs to the plugin. Fix is to dispatch the didFail call when we receive an ack from the plugin indicating that it is ready to accept stream data. This fixes bug http://code.google.com/p/chromium/issues/detail?id=20063 The other change is in WebPluginImpl::TearDownPluginInstance, where we run through the list of resource clients and cancel them. We call didFail on these clients here, which occurs anyway through the PluginDestroyed code path. Bug=20063 Test=Convered by interactive UI test. Review URL: http://codereview.chromium.org/174383 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24593 0039d316-1c4b-4281-b951-d872f2087c98