| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Provide a method that allows the gears plugin to ask the browser
process to verify that its renderer has permission to access the
drop files. Update the copyright notices.
BUG=7995
Review URL: http://codereview.chromium.org/159074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=pkasting
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/159284
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Will talk to Scott when he comes back from vacation to get this re-enabled.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/159225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
modify test_shell on windows to check for vista-specific sys-deps as a
prelude to getting the layout_tests to run under vista as well.
BUG=none
TEST=none
R=ojan@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
as more tabs are added. Don't resize on selection when tabs are very small, except just enough to show a close box. Clip closebox and favicon as tab gets very small. Fix z-order to be consistent among all unselected tabs. Fix incognito man disappearing when dragging window via the tab. Tabs can now get about as small as they do on windows allowing many more to fit.
BUG=14911, 14913, 17372
TEST=adding and removing lots of tabs and making sure nothing goes wrong.
Review URL: http://codereview.chromium.org/159206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=13516
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit 26f9edf949e1678d4f8a3479518568b8a6e1972c.
Review URL: http://codereview.chromium.org/160033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=16095
Review URL: http://codereview.chromium.org/160020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change will allow two Windows users to install thier own copy of Chrome
and set it as default browser. There is a bunch of refactoring in this change.
- Divided the registry entries into three categories:
* Entries that are only read from HKLM
* Entries that actually tie file/protocol associations to Chrome. This will
almost always be in HKCU (except when it is a OEM install).
* Entries that we can create in HKCU if we fail to create them in HKLM.
- For single user machine nothing should change.
- For two users on the same machine (each with a different user level Chrome
installed), the second user's default browser will get renamed to
Chromium.<user> and the required registry entries will also be renamed so that
they do not overwrite first users's registry entries.
BUG=3641
TEST=Install and set Chromium as default browser from two different logins on the same machine for various combinations of XP/Vista, admin users/non admin user, user-level install/system-level install.
Review URL: http://codereview.chromium.org/159172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
data files, and I want a clean try of the actual code changes before I submit :)
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/159281
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rather than O3D, to allocate and register shared memory segments.
This is required in order to work in Protected Mode Internet
Explorer on Windows Vista and later. Fixed preexisting bugs in
MessageQueue related to shared memory mapping failures and
corruption of concurrent incoming messages.
Added the MessageQueue unit tests and Chrome's ConditionVariable
class to the build. These tests required restructuring and
multithreading. Wrote simple framework which detects test
failures and timeouts in child threads and reports them to the
main thread. Restructured existing MessageQueue tests. Added unit
test for Register/UnregisterSharedMemory and stress test for
above concurrency bug.
Buganizer ID: 1997023.
Review URL: http://codereview.chromium.org/155947
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159278
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=17401
TEST=none
Review URL: http://codereview.chromium.org/159244
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Basically, I introduce an additional GtkFixed into the GtkWidget hierarchy. When clipping is required, this is re-created with a X Window and clipping is performed. For some reason, Gtk+Cairo won't clip rendering to the parent GtkWidget if there isn't an associated X Window.
This also fixes the GetPreferredSize implementation for NativeButtonGtk which would return ever increasing values of size each time it was called.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Put recent skia failures into known_crashes.txt.
BUG=http://crbug.com/17569
TEST=Check that the reliability bot goes green.
Review URL: http://codereview.chromium.org/160030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
there were no other windows as drag targets, but only the first time.
BUG=11125
TEST=dragging tabs in and out of windows should show consistent feedback.
Review URL: http://codereview.chromium.org/160018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Hook up WebKit's Frame::eventHandler()->capsLockStateMayHaveChanged() in
WebViewImpl::KeyEvent() and -flagsChanged: to -keyEvent: in BaseView.)
Patch from viettrungluu@gmail.com.
BUG=http://crbug.com/15795
TEST=go to some password field (e.g., in gmail login), cycle capslock
Review URL: http://codereview.chromium.org/159215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change modifies AltErrorPageResourceFetcher to use Callback so that
we can eliminate Alt404PageResourceFetcher. This change also eliminates
dependencies from AltErrorPageResourceFetcher on WebCore.
BUG=15648
TEST=none
R=tony
Review URL: http://codereview.chromium.org/159262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
conditions.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/159275
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I chose to add an out parameter to OnReceivedRedirect because it allows for the
default behavior to remain the same.
I considered adding a ContinueAfterRedirect method that all OnReceivedRedirect
implementations would need to call, but this caused one annoying problem: In
the case of a ChromePlugin, it is possible for the URLRequest to get deleted
inside the handler for the redirect. This would make it hard to subsequently
call a method on the URLRequest since I would need to have a way to determine
if the URLRequest had been deleted.
TEST=covered by unit tests
BUG=16413,6442
R=eroman,wtc
Review URL: http://codereview.chromium.org/155897
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=17576
TEST=watch valgrind ui bots go green(er)
Review URL: http://codereview.chromium.org/160017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
that Chrome is currently using, and it removes "files" from the NPAPI
include paths and file location in third_party so that we can be consistent
with other Chrome third party directories.
TEST=build using gyp and scons and ran unit tests on each.
Review URL: http://codereview.chromium.org/159277
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=17572
TEST=none
TBR=levin
Review URL: http://codereview.chromium.org/160029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159279
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
worker tests failures.
Review URL: http://codereview.chromium.org/159276
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This initial patch contains no edits except for the chromium header and a brief
comment; it is uploaded as a basis for future diffs. Subsequent patches will
contain the edits for this port and tests.
Patch by Jennifer Braithwaite
R=darin
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/159237
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We also don't select all of the text if the user dragged to
highlight some text before releasing the button.
Tested by repeating the scenarios from:
http://codereview.chromium.org/151006
http://codereview.chromium.org/159185
plus checking that the following cases behave as expected:
1. Type some text into the omnibox. Click in Webkit to give
it the focus. Click once in the omnibox. All of its
text should be highlighted, and middle-clicking in
another window should show that the primary selection was
updated.
2. Click in the omnibox to clear its highlighted text and
click in Webkit again. Click in the omnibox again, but
this time drag to highlight some text before letting go
of the button. The highlighted text should be preserved
on button release, and the primary selection should be
updated.
3. Repeat step 2. Click a few times in the omnibox and
confirm that we don't select all of its text (that should
only happen at the end of the initial click that focuses
the omnibox).
(Patch from Dan Erat)
http://codereview.chromium.org/155971
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
finishing. This is an attempt to fix a memory leak.
BUG=17387
TEST=no
Review URL: http://codereview.chromium.org/155895
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/17493
TEST=HttpCache.UrlContainingHash
Review URL: http://codereview.chromium.org/155972
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155953
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
const_cast only where necessary.
Fix a FORWARD_NULL defect reported by Coverity. Pass
cmd_line to sandbox::WideToMultiByte only if cmd_line
is not NULL.
R=rvargas
BUG=http://crbug.com/17101
TEST=none
Review URL: http://codereview.chromium.org/155969
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155970
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If 'sep' is still NULL after the for loop, ix must be -1, so
ix == 0 cannot be true.
Update the comment for ExtractModuleName in the header to match
the implementation. I don't see any code that checks whether the
path is a full path.
R=rvargas
BUG=http://crbug.com/17101
TEST=none
Review URL: http://codereview.chromium.org/155979
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It turns out while I couldn't reproduce these valgrind errors locally,
they reproduce on the buildbot.
This reverts commit dd24218ae59e4c9665c6ebf9fa4ebb5784bf3d88 (r21396).
http://crbug.com/16089
TBR=dank
Review URL: http://codereview.chromium.org/160023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
out-of-date baselines.
I'll cycle back and rebaseline once the bots generate new
results.
TBR=pkasting
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/160021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
menu reload - the dialog is modal, but there may not be anything for it to be modal to.
This is a shorter term fix - a longer term fix will be to change the way the dialog is displayed and allow it to be routed through automation.
Review URL: http://codereview.chromium.org/160010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds ipc/ipc.gyp:* to the windows-only 'pull_in_all' target in chrome.gyp so
that it's built on the windows builders and removes the dependency from
unit_tests onto ipc/ipc.gyp:ipc_tests.
Renames file_descriptor_set_unittest.cc to file_descriptor_set_posix_unittest.cc
to match the .h/.cc files and so that it gets picked up by the exclusion filter
properly.
(Patch from James Robinson)
http://codereview.chromium.org/159272
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
crashes on reliability. It also seems to be causing
valgrind error.
Original change:
Switch the first thread in a child process to be the main thread, and make theIO thread be the second thread. The change is needed for plugins on mac.
Review URL: http://codereview.chromium.org/159274
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix an off-by-one in the zip filename reading code. It's pretty harmless, and
caused by a fairly lousy minizip API. It could lead to an out-of-bounds read
due to lack of null termination.
No way to reliably test.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/155984
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When we drag over a thumbnail we move the drop target 15px towards the
location it would be if we dropped the source.
BUG=14961
TEST=Drag a thumbnail. When dragging over an item the item should move
towards the location of where the source came from.
Review URL: http://codereview.chromium.org/155978
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/16089
Review URL: http://codereview.chromium.org/159207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
notification.
Review URL: http://codereview.chromium.org/155939
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/17519
TEST=change themes; tabs should theme too
Review URL: http://codereview.chromium.org/159271
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
error from the notification service. This error seems to be fixed.
BUG=15265
Test=This is a test
Review URL: http://codereview.chromium.org/155858
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
Review URL: http://codereview.chromium.org/160016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
were moved to IPC, but the source ones in chrome/common were kept.
Review URL: http://codereview.chromium.org/160014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/159249
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159258
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
together during a drag.
BUG=16386
TEST=dragging together windows of different sizes.
Review URL: http://codereview.chromium.org/159270
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21386 0039d316-1c4b-4281-b951-d872f2087c98
|