summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* GTK: unify the bookmark dragging icon generation code into bookmark utils.estade@chromium.org2010-04-3013-127/+247
| | | | | | | | | | | this also has the effect of standardizing the appearance of boomkark drags. On compositing window managers, the drag widget will have no background. BUG=42147 TEST=manual Review URL: http://codereview.chromium.org/1780016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46153 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix AppApiTest.AppProcess and ExtensionApiTest.Storage flakiness.kkania@chromium.org2010-04-304-15/+25
| | | | | | | | | BUG=42497,42943 TEST=none Review URL: http://codereview.chromium.org/1705025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46151 0039d316-1c4b-4281-b951-d872f2087c98
* First pass of a Nigori implementation for Chrome. Only unassisted keyfbarchard@chromium.org2010-04-301-1/+1
| | | | | | | | | | | | derivation is supported and there is no support for server authentication. BUG=37363 TEST=unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43220 Review URL: http://codereview.chromium.org/1357003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46143 0039d316-1c4b-4281-b951-d872f2087c98
* Do not show Vista elevation shield if UAC is disabled.mirandac@google.com2010-04-301-1/+2
| | | | | | | | | BUG=42571 TEST=disable UAC and run Chrome as first run, with import. check "make chrome your default browser" box. see no shield. Review URL: http://codereview.chromium.org/1732013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46142 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for bug 37909: "Clear All" in incognito downloads window will clear all, ↵georgey@chromium.org2010-04-309-0/+79
| | | | | | | | | | including non-incognito downloads. BUG=37909 TEST=Open regular and incognito download pages. "Clear all" on incognito will clear all, but pending downloads. In regular window it would clear all, but pending and incognito. Review URL: http://codereview.chromium.org/1807007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46141 0039d316-1c4b-4281-b951-d872f2087c98
* Refactored event handling code gman added to simpleviewer.html intokbr@google.com2010-04-302-98/+130
| | | | | | | | | | | | | | client.js. Fixed bug where window.event was being overwritten, which for some reason broke key event handling in Firefox even though the event wrapper wasn't being used. Tested pool sample in Firefox, WebKit and Chromium. BUG=none TEST=none Review URL: http://codereview.chromium.org/1826002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46140 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash bug when mouse hovers over system notification.oshima@chromium.org2010-04-304-1/+43
| | | | | | | | | BUG=http://crosbug.com/2940 TEST=new test NotificationTest.TestActivateDeactivate is added to cover this. Review URL: http://codereview.chromium.org/1824001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46139 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Use signal macros for most of BrowserWindowGtk.erg@google.com2010-04-302-140/+115
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1747023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46137 0039d316-1c4b-4281-b951-d872f2087c98
* Clean-up of the asynchronous behaviour of the experimental extension popup API. twiz@chromium.org2010-04-3016-86/+232
| | | | | | | | | | | | | | | | | - It was previously possible to programmatically launch two popups from the same extension. (Simply call popup.show twice in a row, or in a callback chain.) I removed this incorrect funcationality by registering ExtensionPopupHost to listen for EXTENSION_HOST_CREATED notifications. If a popup is shown, and a new ExtensionHost is constructed of type EXTENSION_POPUP, then the presently displayed popup is dismissed. - The callback function for popup.show(...) was previously called in response to EXTENSION_POPUP_VIEW_READY, as processed in response to a ViewHostMsg_DocumentAvailableInMainFrame message. This message wassent after PARSING of the conent of the popup view. Because of this behaviour, the API was difficult to use because one could not meaningfully interact with the popup page during the callback: The callback would race with completion of the onload handler within the popup, so some sort of polling for onload-complete was required. I fixed the problem by adding new notifications and messages so that EXTENSION_POPUP_VIEW_READY is now sent only after all onload handlers have been invoked.Corresponding unit-tests have also been added. BUG=None TEST=ExtensionApiTest.Popup Review URL: http://codereview.chromium.org/1512007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46136 0039d316-1c4b-4281-b951-d872f2087c98
* Modifies CookieMonster to ease support for the Chrome Extensions cookies API.cindylau@google.com2010-04-303-107/+441
| | | | | | | | | | | | Refactors/extracts some methods for reuse in setting cookies programatically, and in parsing cookie attribute tokens and values. BUG=38398 TEST=none Review URL: http://codereview.chromium.org/1566052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46135 0039d316-1c4b-4281-b951-d872f2087c98
* Send out notifications when logins are changed on Win and Linux.albertb@chromium.org2010-04-302-5/+182
| | | | | | | | | BUG=35039 TEST=PasswordStoreDefaultTest.Notifications Review URL: http://codereview.chromium.org/1758020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46132 0039d316-1c4b-4281-b951-d872f2087c98
* Add ability to disconnect from network and changing passwords.chocobo@chromium.org2010-04-304-5/+33
| | | | | | | | BUG=chromiumos:2981 TEST=manually tested both functionality in the UI. Review URL: http://codereview.chromium.org/1723022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46131 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak the First Run Search Engine dialog to improve look of text label ↵mirandac@google.com2010-04-301-8/+16
| | | | | | | | views, by making text labels bold, and a little bit larger. Review URL: http://codereview.chromium.org/1725020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46129 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a potential crash in ChromeOS options dialog.xiyuan@chromium.org2010-04-301-2/+13
| | | | | | | | | | | | | | | | This is because the gtk-based options page is based on NativeViewHost which does not provide CanClose function. The fix bypasses the check of CanClose for gtk-base options pages since this seems not supported. The crash does not happen now because OptionsWindowView does not set accept_ flag and thus CanClose is not called. However, we might want to patch this just in case. BUG=none TEST=Verify Chrome does not crash on ChromeOs when user presses "ESC" on gtk-based options page. Review URL: http://codereview.chromium.org/1825001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46127 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: rename app_mode_constants_mac.*.viettrungluu@chromium.org2010-04-304-9/+9
| | | | | | | | | | I foolishly gave these files a too-specialized name. BUG=none TEST=none Review URL: http://codereview.chromium.org/1727019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46125 0039d316-1c4b-4281-b951-d872f2087c98
* Throw something at the wall. See what sticks.mark@chromium.org2010-04-302-2/+28
| | | | | | | | | | | | | This is an attempt to fix or defer WorkerPoolMac pool stoppage. 1. Catch Objective-C exceptions thrown in task bodies. 2. Make sure the queue isn't suspended when posting tasks. BUG=20471 TEST=none Review URL: http://codereview.chromium.org/1699029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46124 0039d316-1c4b-4281-b951-d872f2087c98
* Add UI for changing auto-connect option on network.chocobo@chromium.org2010-04-309-16/+156
| | | | | | | | | Fixed crashing bug and ethernet not updating bug. BUG=chromiumos:2896,2939,2996 TEST=manual, in network options dialog, the new auto-connect checkbox should now control whether or not we automatically connect to this network. Review URL: http://codereview.chromium.org/1755013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46123 0039d316-1c4b-4281-b951-d872f2087c98
* Widen the suppression for the AutoFillProfile.willchan@chromium.org2010-04-301-1/+1
| | | | | | | | BUG=42965 Review URL: http://codereview.chromium.org/1796009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46122 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Popup windows that use the custom frame should use the tab image ↵erg@google.com2010-04-303-40/+109
| | | | | | | | | | | | | | instead of the frame. This is how mac does things, and Miranda is going to change the windows version, too. BUG=21672 TEST=none Review URL: http://codereview.chromium.org/1775012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46121 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Draggability of browser extensions in incognito modefeldstein@chromium.org2010-04-304-2/+26
| | | | | | | | | | | | | | There is a crash when you hide icons in incognito mode by dragging the container to zero width. Since these resizes aren't even persisted, and it would be a decent sized and possibly dangerous change this close to M5, I'm just disabling the draggability. BUG=42848 TEST=Shouldn't be able to drag in incognito mode, nor crash as per bug. Review URL: http://codereview.chromium.org/1817005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46116 0039d316-1c4b-4281-b951-d872f2087c98
* Update Dromaeo expectations.chase@chromium.org2010-04-301-1/+2
| | | | | | | | | | BUG=none TEST=dromaeo is being measured TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/1736027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46115 0039d316-1c4b-4281-b951-d872f2087c98
* Vertical scrolling arrows in bookmark bar folder windows when needed.jrg@chromium.org2010-04-309-40/+3283
| | | | | | | | | | | | | | | | | | | | | | pdfs from Cole. BUG=42026 TEST=\ 1) Small folders --> no arrows. 2) Big folders --> arrow at bottom initially. 3) Move browser to bottom of screen so a small folder falls off the bottom and has an arrow. Open it and gently use scroll wheel to scroll. Make sure transition to "no arrow" looks good. Close and reopen. Scroll super-fast. Make sure it ends up in the same nice place. 4) Open big big folder. Scroll so top goes offscreen so you now have 2 scroll arrows. Use scroll wheel to gently go up and down (arrow hides and shows). Make sure transitions OK. Scroll all the way so bottom arrow disappears. Gently up and down; watch for transitions. Now FAST up and down. Make sure destination looks OK. BookmarkBarFolderWindow.xib change: BookmarkBarFolderWindowScrollView border turned off. Review URL: http://codereview.chromium.org/1813003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46114 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac]Fix issue 34343: "Tab to search" hint on omnibox disappears on drag ↵suzhe@chromium.org2010-04-308-12/+42
| | | | | | | | | | | | | dropped tab. This CL is just a clone of http://codereview.chromium.org/1519005. As I just rebuilt my working environment. BUG=34343 TEST=Input www.google.com to trigger "tab to search" hint, then drag the tab into a new window, then check if "tab to search" hint is still there. Review URL: http://codereview.chromium.org/1523016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46112 0039d316-1c4b-4281-b951-d872f2087c98
* ffmpeg move a file from neon to arm section for build errorfbarchard@chromium.org2010-04-301-1/+1
| | | | | | | | | BUG=42845 TEST=arm chrome should build Review URL: http://codereview.chromium.org/1801009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46111 0039d316-1c4b-4281-b951-d872f2087c98
* More refactoring of TalkMediator and related classes to make them generic. ↵sanjeevr@chromium.org2010-04-3028-412/+350
| | | | | | | | | | | There is only one functional change in this changelist. This is the removal of the mediator_thread_->SendNotification call from TalkMediatorImpl::OnSubscriptionSuccess. Please review this part extra carefully. BUG=None TEST=Test Bookmarks Sync, sync unit-tests have been modified. Review URL: http://codereview.chromium.org/1790004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46109 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 46101 - Make a new yes/no messagebox wrapper function, use it in the ↵avi@chromium.org2010-04-307-77/+49
| | | | | | | | | | | | | | | | bookmark alert. BUG=http://crbug.com/34481; http://crbug.com/40011 TEST=on Mac/ChromeOS, have at least 15 bookmarks on bookmarks bar or other bookmarks, right click on one of those and click on Open all bookmarks. An confirmation dialog box should be shown. No other visible change. Review URL: http://codereview.chromium.org/1687017 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/1783014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46108 0039d316-1c4b-4281-b951-d872f2087c98
* Adding missing line ending which breaks the trybots..robertshield@chromium.org2010-04-301-1/+1
| | | | | | TBR=tommi git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46107 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix color/theme logic on the instructions label on the bookmark bar.erg@google.com2010-04-302-18/+24
| | | | | | | | | BUG=42957 TEST=none Review URL: http://codereview.chromium.org/1816005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46106 0039d316-1c4b-4281-b951-d872f2087c98
* ffmpeg configs for float pcmfbarchard@chromium.org2010-04-308-16/+16
| | | | | | | | | BUG=42861 TEST=http://fbarchard-kir.ad.corp.google.com/mediatests/sixmusictest-32float.wav should work with ffmpeg_tests, media_bench immediately. Other programs will require additional support. Review URL: http://codereview.chromium.org/1731022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46105 0039d316-1c4b-4281-b951-d872f2087c98
* r46025 reverted r46023 which caused a build break on chromeos.prasadt@chromium.org2010-04-3014-42/+180
| | | | | | | | | | | | | | | This change reverts r46025 and fixes the build break which is just a one line change in chrome/browser/first_run_gtk.cc to move the definition of Upgrade::new_command_line_ to be inside a #if. Details on the change and code review feedback for the original CL can be found at http://codereview.chromium.org/1633021. BUG=40975 TEST=none Review URL: http://codereview.chromium.org/1691022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46103 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress Autofill leak.willchan@chromium.org2010-04-301-0/+20
| | | | | | | | BUG=42965 Review URL: http://codereview.chromium.org/1703025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46102 0039d316-1c4b-4281-b951-d872f2087c98
* Make a new yes/no messagebox wrapper function, use it in the bookmark alert.avi@chromium.org2010-04-307-49/+77
| | | | | | | | | | | BUG=http://crbug.com/34481; http://crbug.com/40011 TEST=on Mac/ChromeOS, have at least 15 bookmarks on bookmarks bar or other bookmarks, right click on one of those and click on Open all bookmarks. An confirmation dialog box should be shown. No other visible change. Review URL: http://codereview.chromium.org/1687017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46101 0039d316-1c4b-4281-b951-d872f2087c98
* Merged in gman's fixes to make o3d-webgl samples work in Firefox.kbr@google.com2010-04-306-14/+123
| | | | | | | | | | | | | Resized poolballs.png to power-of-two dimensions. Retested all o3d-webgl samples in top of tree Firefox, WebKit and Chromium. BUG=none TEST=none TBR=gman,petersont Review URL: http://codereview.chromium.org/1695031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46100 0039d316-1c4b-4281-b951-d872f2087c98
* Fix contextual menu crash by disabling the contextual menu.avi@chromium.org2010-04-301-10/+11
| | | | | | | | | | BUG=http://crbug.com/42743 TEST=as in bug Review URL: http://codereview.chromium.org/1687025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46099 0039d316-1c4b-4281-b951-d872f2087c98
* Mark AppApiTest.AppProcess as flaky.willchan@chromium.org2010-04-301-1/+1
| | | | | | | | BUG=42497 Review URL: http://codereview.chromium.org/1691023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46096 0039d316-1c4b-4281-b951-d872f2087c98
* Move theme_dir to where it'll be found post-r46091.mark@chromium.org2010-04-301-9/+7
| | | | | | Review URL: http://codereview.chromium.org/1808005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46093 0039d316-1c4b-4281-b951-d872f2087c98
* Allow authenticated installs from the disk image.mark@chromium.org2010-04-309-151/+366
| | | | | | | | | | | | | | | | | | | | | When launching from a read-only disk image, if no installed copy exists in /Applications, and the user chooses to install from the disk image: If it appears that there isn't permission to write to /Applications, prompt the user to authenticate as an administrator. If authentication is successful, copy the application as root, set its permissions, and promote Keystone to use a system ticket. BUG=40265 TEST=Remove the application from /Applications and test, as both an admin user and a normal user, installation directly from the disk image. When installation occurs after authentication, Chrome should be on a system ticket. Also, make sure that normal in-app Keystone promotion continues to work as expected. Review URL: http://codereview.chromium.org/1792013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46091 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY dissector expects associated stream id in SYN_STREAM header.cbentzel@chromium.org2010-04-301-10/+33
| | | | | | | | This patch is a bit ugly. I think it might make sense to split out the SYN_STREAM parsing from the SYN_REPLY parsing at this point. Review URL: http://codereview.chromium.org/1769012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46089 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Alternate-Protocol to work for PAC proxies.willchan@chromium.org2010-04-302-27/+188
| | | | | | | | | | * Includes some IPv6 fixups for Alternate-Protocol. * Refactors some Alternate-Protocol code, moves the check from DoInitConnection() to DoResolveProxy() so we can send the updated endpoint to the ProxyResolver. BUG=42666 Review URL: http://codereview.chromium.org/1750020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46088 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress NPN_RegisterObject leak.willchan@chromium.org2010-04-301-0/+13
| | | | | | | | BUG=42958 Review URL: http://codereview.chromium.org/1712028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46087 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Make use of gtk signal macros in EditSearchEngineDialog.erg@google.com2010-04-302-27/+20
| | | | | | | | | | | BUG=None TEST=manually Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1741016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46086 0039d316-1c4b-4281-b951-d872f2087c98
* Update typed_url sync to support visits.zork@chromium.org2010-04-309-127/+602
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1775004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46085 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Re-enable some unit tests that were disabledrvargas@google.com2010-04-301-13/+6
| | | | | | | | | | | or marked as flaky. BUG=21110,38562 TEST=unittests Review URL: http://codereview.chromium.org/1800010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46084 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux] Mark ExtensionApiTest.Storage as flaky.kkania@chromium.org2010-04-301-1/+8
| | | | | | | | | | BUG=42943 TEST=none TBR=rafaelw Review URL: http://codereview.chromium.org/1810012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46083 0039d316-1c4b-4281-b951-d872f2087c98
* Advancing to latest gyp.bradnelson@google.com2010-04-302-60/+5
| | | | | | | | Reverting 46012. Review URL: http://codereview.chromium.org/1815003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46082 0039d316-1c4b-4281-b951-d872f2087c98
* Restore accidentally removed suppression. Widen ThumbnailGenerator suppression.willchan@chromium.org2010-04-301-13/+12
| | | | | | | | BUG=42896 Review URL: http://codereview.chromium.org/1712027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46081 0039d316-1c4b-4281-b951-d872f2087c98
* Adds TwoClientLiveAutofillSyncTest to test old school autofill. Includes ↵skrul@chromium.org2010-04-3012-88/+452
| | | | | | | | some refactoring of the WebDataServiceTest to allow some code sharing between the two. Review URL: http://codereview.chromium.org/1739017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46080 0039d316-1c4b-4281-b951-d872f2087c98
* Update Valgrind and Linux suppressions.willchan@chromium.org2010-04-301-10/+48
| | | | | | | | BUG=42941,42942 Review URL: http://codereview.chromium.org/1752023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46079 0039d316-1c4b-4281-b951-d872f2087c98
* Unpack extensions inside chrome's profile directory.skerner@chromium.org2010-04-3017-43/+198
| | | | | | | | | | | Other users of the temp directory will be altered in a subsequent CL. BUG=13044 TEST=SandboxedExtensionUnpackerTest.*, ScopedTempDir.UniqueTempDirUnderPath, FileUtilTest.CreateNewTempDirInDirTest, manual testing on win, linux, mac. Review URL: http://codereview.chromium.org/1582022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46078 0039d316-1c4b-4281-b951-d872f2087c98
* Have extension call windows.getLastFocused include incognito windows if thempcomplete@chromium.org2010-04-301-1/+2
| | | | | | | | | | extension is enabled for incognito. BUG=39113 Review URL: http://codereview.chromium.org/1789010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46076 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 12:22:23 +0000