summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix for minimum size checkevan@chromium.org2009-04-242-2/+6
| | | | | | | | cds->cbData is data length in bytes, and min_message_size is in characters. So it needs to be multiplied by sizeof(wchar_t) Review URL: http://codereview.chromium.org/93078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14482 0039d316-1c4b-4281-b951-d872f2087c98
* Pass the ExtensionID to the ExtensionFunctionDispatcher.finnur@chromium.org2009-04-246-8/+30
| | | | | | | | | | | | | | | | This is needed for PageActions that deal with IDs, so that we can check if one PageAction is trying to change another PageAction. This converts the object ExtensionFunctionDispatcher in RenderViewHost from a member to a scoped ptr so we can reset it on navigate. BUG=None TEST=Extensions should work as before (no visible change). Review URL: http://codereview.chromium.org/93125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14481 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Do not send stats from Chromium builds."kuchhal@chromium.org2009-04-248-63/+28
| | | | | | | | | | | | This reverts commit 4a0189db765fe94f5df360c0907a585e26c9f681. Revert "Fix build break." This reverts commit eada493cf28975e56395aa3e2d3a0dc267a7f2c7. Review URL: http://codereview.chromium.org/92162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14479 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break.kuchhal@chromium.org2009-04-241-1/+1
| | | | | | | | | BUG=1435533 Review URL: http://codereview.chromium.org/93154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14478 0039d316-1c4b-4281-b951-d872f2087c98
* Fix webworker layout test failures.darin@chromium.org2009-04-241-1/+1
| | | | | | | | | | | | Convert from WebString to string16 when posting a message to force a string copy. This is just a temporary workaround to get the tree green. This matches what we were previously doing. R=jam Review URL: http://codereview.chromium.org/92160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14476 0039d316-1c4b-4281-b951-d872f2087c98
* Add a gcc warning if we don't check the results of ReadParam. Sometc@google.com2009-04-242-7/+8
| | | | | | | | | | | | of the buildbots noticed that we weren't checking the results when generating log output. AGL gets the credit for tracking this down. Review URL: http://codereview.chromium.org/93126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14475 0039d316-1c4b-4281-b951-d872f2087c98
* Do not send stats from Chromium builds.kuchhal@chromium.org2009-04-248-28/+63
| | | | | | | | | BUG=1435533 Review URL: http://codereview.chromium.org/93109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14474 0039d316-1c4b-4281-b951-d872f2087c98
* Make uninstall dialog handle keyboard events (TAB).kuchhal@chromium.org2009-04-241-1/+1
| | | | | | | | | BUG=10950 Review URL: http://codereview.chromium.org/93140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14473 0039d316-1c4b-4281-b951-d872f2087c98
* Implement HTML selects as native Cocoa controls for Chrome.paul@chromium.org2009-04-2410-6/+205
| | | | | | | | BUG=8389 (http://crbug.com/8389) Review URL: http://codereview.chromium.org/57032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14471 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DCHECK when typing certain kinds of input on certain profiles.pkasting@chromium.org2009-04-241-1/+3
| | | | | | | | | This is actually a very old bug that some of my recent changes exposed more widely. In PromoteOrCreateShorterSuggestion(), we could create a totally bogus search base, which, if added to the history matches, would then break. In the old code, we'd create this match, but usually not add it to the history match set because we'd already have a What You Typed match; in my new code that's frequently no longer the case. BUG=10926 Review URL: http://codereview.chromium.org/92154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14470 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the SiteInstance leak from the known leaks now that it's fixed.brettw@chromium.org2009-04-241-10/+0
| | | | | | Review URL: http://codereview.chromium.org/92091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14469 0039d316-1c4b-4281-b951-d872f2087c98
* Add SDCH histogram to help detected delayed acksjar@chromium.org2009-04-241-0/+16
| | | | | | | | | | | | SDCH might compress so well, that the return of the ack may come late, and a server may stall on a congestion window limitation. This set of histograms is intended to track that issue during SDCH experimentation. r=huanr Review URL: http://codereview.chromium.org/92139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14468 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes for two benign race conditions and one bug detecteddkegel@google.com2009-04-241-21/+7
| | | | | | | | | | | | | by kcc's thread sanitizer: 1) remove extra '&' char; this fix is already upstream in libevent 2) delete unused and deprecated event_sigcb interface 3) avoid setting use_monotonic repeatedly. (Should really be protected with a mutex, but a simple init check seems to quiet the race detector.) Review URL: http://codereview.chromium.org/95012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14467 0039d316-1c4b-4281-b951-d872f2087c98
* Checkbox/RadioButton labels have to reserve space for the focus rects, even ↵ben@chromium.org2009-04-243-1/+10
| | | | | | | | | if they're not actively being painted as focused, otherwise layout breaks badly. http://crbug.com/10958 Review URL: http://codereview.chromium.org/93142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14464 0039d316-1c4b-4281-b951-d872f2087c98
* The accidental search infobar was almost never appearing. Fix that ↵pkasting@chromium.org2009-04-246-103/+87
| | | | | | | | | | | regression. Now we don't rely on the presence of a "what you typed" match in the result set; instead the AutocompleteResult determines the alternate nav URL directly. To do this I refactored some of the code from the history URL provider over to AutocompleteInput. BUG=10808 Review URL: http://codereview.chromium.org/92140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14463 0039d316-1c4b-4281-b951-d872f2087c98
* Create an about dialog for GTK Chromium.erg@google.com2009-04-246-4/+178
| | | | | | Review URL: http://codereview.chromium.org/93128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14462 0039d316-1c4b-4281-b951-d872f2087c98
* Use WebWorker and WebWorkerClient from the WebKit API.darin@chromium.org2009-04-2421-333/+336
| | | | | | | | | BUG=10995 R=jam Review URL: http://codereview.chromium.org/92144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14461 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile error on gcc.brettw@chromium.org2009-04-241-2/+13
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14456 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug in the size computation for Skia masking.brettw@chromium.org2009-04-241-2/+14
| | | | | | BUG=10736 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14454 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate a dependency on _com_issue_error() (via the use of _bstr_t)sgk@google.com2009-04-241-10/+0
| | | | | | | by removing a no-longer-necessary std::ostream operator<< overload. Review URL: http://codereview.chromium.org/92134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14453 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up cocoa popup menu handling in test_shell.paul@chromium.org2009-04-244-117/+217
| | | | | | | | | | | | | | The cocoa menu delegate, previously local to test_shell on Mac, now has the added responsibility of running the popup menu and processing the menu's actions. It is moved into its own files in order to use this class as-is in Chrome. BUG=8389 (http://crbug.com/8389) Review URL: http://codereview.chromium.org/92062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14452 0039d316-1c4b-4281-b951-d872f2087c98
* Override GtkTextView's size request width in the Linux Omnibox.deanm@chromium.org2009-04-242-0/+21
| | | | | | | | | | | GtkTextView requests enough space to fit all of the text. It turns out if you weren't doing something to restrict the window size (like using a tiling manager) long text in the edit would push the window to fit the text. Review URL: http://codereview.chromium.org/93127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14449 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where radio buttons would become unselected when clicked (more ↵jcampan@chromium.org2009-04-242-1/+6
| | | | | | | | | | specifically, when clicked on the button, not the label). BUG=10834 TEST=Open the option dialog, click on the button (not the label) of a selected radio-button. The button should stay selected. Make sure checkboxes and radio buttons still behave as expected. Review URL: http://codereview.chromium.org/97012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14447 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at adding a map between strings names and resource ids.tc@google.com2009-04-2412-1/+256
| | | | | | | | | | | | | This creates a mapping for all the entries in the theme_resources.grd file and adds a static method for querying the mapping. BUG=10639 Review URL: http://codereview.chromium.org/92085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14443 0039d316-1c4b-4281-b951-d872f2087c98
* Removes FindBar cruft from TabContentsViewMac.rohitrao@chromium.org2009-04-243-89/+2
| | | | | | | | | TEST=Ran Chromium, clicked around, found something in page. Nothing seems to have broken. Review URL: http://codereview.chromium.org/93124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14442 0039d316-1c4b-4281-b951-d872f2087c98
* Make messages in javascript's alert copyable.tc@google.com2009-04-243-1/+22
| | | | | | | | | | | | | | Now, we can copy the message by Ctrl-C. BUG=5879 Patch by hamaji@google.com via http://codereview.chromium.org/93112 Review URL: http://codereview.chromium.org/92133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14441 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of variable length arrays.willchan@chromium.org2009-04-244-11/+13
| | | | | | Review URL: http://codereview.chromium.org/92005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14440 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix root window co-ordinates.agl@chromium.org2009-04-241-2/+2
| | | | | | | | | | | (I screwed up. Thanks to Dean for noticing.) TBR=tony http://codereview.chromium.org/92132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14439 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome side of using WebPluginListBuilder.darin@chromium.org2009-04-2420-80/+112
| | | | | | | | | | | | | | I also broke glue/webplugininfo.h out of glue/webplugin.h as part of this change. Eventually, glue/webplugin.h will go away and be moved into the WebKit API, but the structures left in glue/webplugininfo.h need to remain since they are used extensively throughout Chrome. BUG=10922 R=dglazkov Review URL: http://codereview.chromium.org/93116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14438 0039d316-1c4b-4281-b951-d872f2087c98
* Adding missing null check in case of missing file version info.robertshield@google.com2009-04-241-1/+4
| | | | | | Review URL: http://codereview.chromium.org/88041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14436 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes issue where the placeholder text was not shown because there is no DOMarv@chromium.org2009-04-241-2/+3
| | | | | | | | | | | | | property for the placeholder attribute. BUG=10940 TEST=Make sure that the search boxes (not Search your history) on the new tab page has place holder text. Review URL: http://codereview.chromium.org/92107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14435 0039d316-1c4b-4281-b951-d872f2087c98
* Add media_bench.scons and media_bench.vcproj to svn:ignore.maruel@chromium.org2009-04-240-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14434 0039d316-1c4b-4281-b951-d872f2087c98
* Use the NotificationRegistrar for the remaining TAB_CONTENTS_DESTROYEDbrettw@chromium.org2009-04-244-38/+29
| | | | | | | notifications to see if it can fix a crash. Review URL: http://codereview.chromium.org/92129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14433 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Stop hitting a DCHECK in GoButtonGtk on shutdown.willchan@chromium.org2009-04-241-1/+8
| | | | | | | | | Turns out we can get 2 gtk leave events in a row on shutdown, if the cursor is already hovering over the go button. BUG=10851 Review URL: http://codereview.chromium.org/93055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14432 0039d316-1c4b-4281-b951-d872f2087c98
* Added tcmalloc to svn:ignore because of DEPS change in revision 14128.maruel@chromium.org2009-04-240-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14431 0039d316-1c4b-4281-b951-d872f2087c98
* Patch from kcc to add a --custom_valgrind_command flag, for use with e.g. ↵dkegel@google.com2009-04-242-21/+35
| | | | | | | | | thread race detection tools (From issue 95004) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14430 0039d316-1c4b-4281-b951-d872f2087c98
* Add 'fakeroot' to the list of packages, since this script uses itdkegel@google.com2009-04-241-3/+4
| | | | | | | | | Patch from Jeff Bailey. Also alphabetize the list. Review URL: http://codereview.chromium.org/92130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14429 0039d316-1c4b-4281-b951-d872f2087c98
* Add CSS to make toolstrip buttons look closer to native ones.aa@chromium.org2009-04-242-1/+46
| | | | | | | | | Please refer to this URL to have your mind blown: http://aaronboodman.com/z_dropbox/whoa/ Review URL: http://codereview.chromium.org/92119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14428 0039d316-1c4b-4281-b951-d872f2087c98
* Remove platform_sgk_vista_6_0 and svn for svn:ignore.maruel@chromium.org2009-04-240-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14427 0039d316-1c4b-4281-b951-d872f2087c98
* Remove src/third_party/svn since it is not needed anymore.maruel@chromium.org2009-04-241-3/+0
| | | | | | Review URL: http://codereview.chromium.org/93123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14426 0039d316-1c4b-4281-b951-d872f2087c98
* Disable TabDraggingTest.Tab1Tab3 due to flakiness.dglazkov@chromium.org2009-04-241-1/+2
| | | | | | | | | | TBR=ben BUG=10941 TEST=0 Review URL: http://codereview.chromium.org/93098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14425 0039d316-1c4b-4281-b951-d872f2087c98
* Unittest for FindBarCocoaController.rohitrao@chromium.org2009-04-247-11/+115
| | | | | | | TEST=The new unittest passes. BUG=10802 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14424 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r14328 for the linux file; I shouldn't be fixing things that ↵avi@google.com2009-04-241-4/+1
| | | | | | | | aren't broken. Review URL: http://codereview.chromium.org/92084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14423 0039d316-1c4b-4281-b951-d872f2087c98
* Disable TimerTest.RepeatingTimer_Cancel under Valgrindnirnimesh@chromium.org2009-04-241-1/+2
| | | | | | Review URL: http://codereview.chromium.org/93003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14422 0039d316-1c4b-4281-b951-d872f2087c98
* To avoid reauest and response json parsing caller_id is passed as ClientData ↵yurys@google.com2009-04-243-119/+49
| | | | | | | | parameter to the debugger. Review URL: http://codereview.chromium.org/93068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14421 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable memory tests and remove the fixed crash from the known crashes.levin@chromium.org2009-04-242-6/+3
| | | | | | | | | | BUG=10895 TEST=Just re-enabling some tests that I had to disable earlier today. Review URL: http://codereview.chromium.org/93115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14419 0039d316-1c4b-4281-b951-d872f2087c98
* The previous behavior of not focusing the HWND when focusing a ↵jcampan@chromium.org2009-04-242-6/+0
| | | | | | | | | | checkbox/radio-button was preventing focus to work as expected on these controls. It would leave the previous HWND focused, causing problems. BUG=10856 TEST=Open the Option dialog. Click the "Show home button..." checkbox. The close button should lose focus, the checkbox should get focus. Press space, the checkbox state should change. Click on a radio-button, it should become selected and get focused. Press the up/down arrow. The next/previous radio-button should get selected and focused. Review URL: http://codereview.chromium.org/93114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14417 0039d316-1c4b-4281-b951-d872f2087c98
* Kill WebContents by moving the remaining methods to TabContents. WebContentsbrettw@chromium.org2009-04-245-1879/+1884
| | | | | | | remains as a shell so I don't have to change all the callers in this CL. Review URL: http://codereview.chromium.org/92115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14414 0039d316-1c4b-4281-b951-d872f2087c98
* Linux valgrind: fix new[] / delete mismatchagl@chromium.org2009-04-241-1/+1
| | | | | | | | | TBR=abarth http://codereview.chromium.org/93113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14413 0039d316-1c4b-4281-b951-d872f2087c98
* Move another batch of functions for WebContents to TabContents. This alsobrettw@chromium.org2009-04-246-478/+447
| | | | | | | | updates the Dev tools manager to take a TabContents (a pointer was being passed from the TabContents which made it break). Review URL: http://codereview.chromium.org/92101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14412 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-29 11:06:09 +0000