summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Focusing a native button through a RequestFocus call would not result in the ↵jcampan@chromium.org2009-03-255-3/+29
| | | | | | | | | | | | | | actual button showing as focused. This is because the NativeButton is the one getting focused not the NativeControl wrapper. This CL adds forwarding the focus to the NativeControl so the HWND really gets focused. It also associates the NativeButton view with the NativeControl, so that when the HWND is focused (through a click for example), the focus manager has the NativeButton as the focused view (not the NativeControl wrapper). BUG=9253 TEST=Open the option panel. Press tab several times. The focus should move as expected to the different buttons and views in the page. Review URL: http://codereview.chromium.org/45042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12420 0039d316-1c4b-4281-b951-d872f2087c98
* Mark all HTTP tests as flaky on the mac.ojan@google.com2009-03-251-0/+7
| | | | | | Review URL: http://codereview.chromium.org/49025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12419 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug in RDH that it overlooked a resource messagehclam@chromium.org2009-03-251-0/+1
| | | | | | | | | | | | TBR=darin ViewHostMsg_DownloadProgress_ACK is a resource message but it is overlooked by RDH and thus not processed. This patch adds the message to ResourceDispatcherHost::IsResourceDispatcherHostMessage to enable processing the message. Review URL: http://codereview.chromium.org/53030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12418 0039d316-1c4b-4281-b951-d872f2087c98
* Folder path was not set correctly for media cachehclam@chromium.org2009-03-251-2/+2
| | | | | | | | | | TBR=darin Fixed a bug in ProfileImpl and OffTheRecordProfileImpl that path to media cache folder was set incorrectly. Review URL: http://codereview.chromium.org/45046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12417 0039d316-1c4b-4281-b951-d872f2087c98
* Disable failing test while I investigate.tc@google.com2009-03-251-1/+2
| | | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/53032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12416 0039d316-1c4b-4281-b951-d872f2087c98
* Modifes the in-application EULA outer frame to take a parameter ↵gwilson@google.com2009-03-2443-42/+50
| | | | | | | | | | ('innerframe') and set its inner iframe src to the value of that parameter. BUG=8894 Review URL: http://codereview.chromium.org/50039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12415 0039d316-1c4b-4281-b951-d872f2087c98
* Added a thread pool to WorkerPool for Linux that dynamically adds threads as ↵willchan@chromium.org2009-03-246-19/+504
| | | | | | | | needed. Review URL: http://codereview.chromium.org/39102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12414 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the eula innerframe param parsingcpu@google.com2009-03-241-2/+10
| | | | | | | | | | | - eula inner frame is supplied by chrome - removes fat from the installer (1M) - depends on another review (50039) from glen Review URL: http://codereview.chromium.org/42572 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12413 0039d316-1c4b-4281-b951-d872f2087c98
* Update symupload to the last version. (r319)nsylvain@chromium.org2009-03-241-0/+0
| | | | | | | | It has the fix to not timeout when the network is too slow. Review URL: http://codereview.chromium.org/53018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12412 0039d316-1c4b-4281-b951-d872f2087c98
* Updating test log inputs to include accumulative test duration at different ↵ace@chromium.org2009-03-241-10/+18
| | | | | | | | steps in testing. Review URL: http://codereview.chromium.org/52038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12411 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent data read errors from crashing the browser.thestig@chromium.org2009-03-241-0/+7
| | | | | | | | | | | In ResourceDispatcherHost::OnResponseStarted(), if Read() causes an error, it calls OnResponseCompleted(). For a download, this hits the NOTREACHED() in DownloadThrottlingResourceHandler::OnResponseCompleted(). This patch checks for the error status, and returns false, which causes the download to finish, which saves an empty file of size 0. BUG=8170 Review URL: http://codereview.chromium.org/42573 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12410 0039d316-1c4b-4281-b951-d872f2087c98
* Use scoped_ptr to prevent memory leaks on test failures.patrick@chromium.org2009-03-241-19/+12
| | | | | | Review URL: http://codereview.chromium.org/50027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12409 0039d316-1c4b-4281-b951-d872f2087c98
* Implement default css for toolstrips.aa@chromium.org2009-03-2411-36/+75
| | | | | | Review URL: http://codereview.chromium.org/42435 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12408 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly instantiate the string16 backer exactly once, avoiding problems inmark@chromium.org2009-03-242-0/+43
| | | | | | | shared library builds and an Apple ld bug Review URL: http://codereview.chromium.org/49023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12406 0039d316-1c4b-4281-b951-d872f2087c98
* standalone-image-drag-to-editable.html:tc@google.com2009-03-246-8/+35
| | | | | | | | | | | | | | | | I modified this test upstream so we could do the file drag/drop into an iframe. There are still font size differences and the image that gets dropped in the iframe has a size of 0x0 because it hasn't loaded by the time the render tree is snapshotted. It works fine in chrome when run manually, so just rebaseline with the 0x0 image size (the test still passes: it drops the image). invalid-syntax-for-function.html: The exception text changed from saying line 1 to line 2 (exception in a inline body onload handler). Not sure why it changed, but seems harmless. Review URL: http://codereview.chromium.org/53016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12405 0039d316-1c4b-4281-b951-d872f2087c98
* Use '.' instead of 'source' because sh on the buildbots (dash) doesn't like ↵mmoss@chromium.org2009-03-241-1/+1
| | | | | | | | | 'source'. Review URL: http://codereview.chromium.org/53025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12404 0039d316-1c4b-4281-b951-d872f2087c98
* Redone http://codereview.chromium.org/42571idanan@chromium.org2009-03-2415-43/+110
| | | | | | | | | | | Issue 6477: Support modifier clicks on UI elements Mouse event flags transformed to WindoOpenDisposition so that browser commands can all inteterpert event modifiers. Implemented home, forward and backwards middle-click andshift middle click. Previously working on issue 358 which was market a duplicate and concerned with the home and tabstrip subset of this behavior: Can't open a new tab by middle-clicking home button. No functionality has been lost or altered, only the use ofmodifiers give access to increased functionality. BUG=6477 TBR=maruel Review URL: http://codereview.chromium.org/53020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12403 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Linux: back off build to only require P3"agl@chromium.org2009-03-241-2/+2
| | | | | | | This reverts commit r12389. Maybe a GCC bug in it's SSE implementation. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12402 0039d316-1c4b-4281-b951-d872f2087c98
* SHARED_INTERMEDIATE_DIR is a better place for generated headers.mmoss@chromium.org2009-03-243-7/+5
| | | | | | | | | | Also, use chrome path calculated relative to version.sh, since the passed-in path isn't correct on the buildbot. Review URL: http://codereview.chromium.org/42574 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12401 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new histogram macro to replace a few explicit calls.rvargas@google.com2009-03-243-20/+29
| | | | | | | | There is no real change in functionality. Review URL: http://codereview.chromium.org/42514 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12400 0039d316-1c4b-4281-b951-d872f2087c98
* Readd test that is failing on mac/linux.ojan@google.com2009-03-241-0/+3
| | | | | | Review URL: http://codereview.chromium.org/53021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12399 0039d316-1c4b-4281-b951-d872f2087c98
* * Switch the posix FileStream code over to using WorkerPool for asynchronous ↵willchan@chromium.org2009-03-242-69/+752
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | operations. * Add a bunch of tests for asynchronous operations. * Fix lint errors. Before: Summary iterations 5 pages 20 milliseconds 18585 mean per set 3717.00 mean per page 185.85 timer lag 2663.00 timer lag per page 26.63 After: Summary iterations 5 pages 20 milliseconds 9279 mean per set 1855.80 mean per page 92.79 timer lag 689.00 timer lag per page 6.89 Review URL: http://codereview.chromium.org/48111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12398 0039d316-1c4b-4281-b951-d872f2087c98
* fix win buildestade@chromium.org2009-03-241-0/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12397 0039d316-1c4b-4281-b951-d872f2087c98
* fix win buildestade@chromium.org2009-03-241-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12396 0039d316-1c4b-4281-b951-d872f2087c98
* Implement basic ShowItemInFolder for linux.estade@chromium.org2009-03-2411-86/+163
| | | | | | | | | Note that this only works if you are using a gnome or kde session. Support for other sessions will be added in the future. Review URL: http://codereview.chromium.org/52034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12395 0039d316-1c4b-4281-b951-d872f2087c98
* loadable_modules are just like shared libs for code generation.thomasvl@chromium.org2009-03-241-1/+1
| | | | | | Review URL: http://codereview.chromium.org/45038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12392 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: back off build to only require P3agl@chromium.org2009-03-241-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | The current linux version of chromium will instantly crash with SIGILL on an Athlon/AthlonXP/AthlonMP class processor. It will presumably do the same thing on the pentium3. This is because it's built to use SSE2 instructions to implement floating point. We cannot build for i686 normally because we can't have the floating point results be different between debug/opt builds. Without forcing it to use SSE that happens (and it has a lot of noticeable effects on our tests). For builds which users actually use, I expect the distros will back off the compiler flags because people won't be using those builds for development. However, I'm landing this patch because there's little point in causing problems for SSE1 only chips because it will only make 3rd party contributions harder. Thanks. The only downside is minutely slower double precision floating point. (Patch from Elladan) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12389 0039d316-1c4b-4281-b951-d872f2087c98
* Switch some more ASCII locale code wstrings to strings.estade@chromium.org2009-03-249-260/+233
| | | | | | | | Also, don't alphabetize available spellchecker locale codes. Review URL: http://codereview.chromium.org/42531 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12388 0039d316-1c4b-4281-b951-d872f2087c98
* Include version information in Linux chrome.mmoss@chromium.org2009-03-244-24/+55
| | | | | | | | | | | This makes use of, and scons-enables, the Linux version header in Issue 45028. BUG=8132 Review URL: http://codereview.chromium.org/42542 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12387 0039d316-1c4b-4281-b951-d872f2087c98
* Removed unused parameter.darin@chromium.org2009-03-241-3/+2
| | | | | | | | R=mpcomplete Review URL: http://codereview.chromium.org/52033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12386 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r12383, caused a build breakage on all platforms.maruel@chromium.org2009-03-2411-100/+42
| | | | | | | TBR=idanan Review URL: http://codereview.chromium.org/42571 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12385 0039d316-1c4b-4281-b951-d872f2087c98
* Use #pragma pack as documented to work with GCC and MSVCmark@chromium.org2009-03-241-2/+2
| | | | | | Review URL: http://codereview.chromium.org/49017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12384 0039d316-1c4b-4281-b951-d872f2087c98
* Issue 6477: Support modifier clicks on UI elementsidanan@chromium.org2009-03-2411-42/+100
| | | | | | | | | | | | | | | | | | | Mouse event flags transformed to WindoOpenDisposition so that browser commands can all inteterpert event modifiers. Implemented home, forward and backwards middle-click andshift middle click. Previously working on issue 358 which was market a duplicate and concerned with the home and tabstrip subset of this behavior: Can't open a new tab by middle-clicking home button. No functionality has been lost or altered, only the use ofmodifiers give access to increased functionality. BUG=6477 TBR=ben@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12383 0039d316-1c4b-4281-b951-d872f2087c98
* First stage of implementing HTML select popup menus forpaulg@google.com2009-03-2412-86/+381
| | | | | | | | | | | | | | | | the Mac test_shell. Once the changes to WebKit/WebCore/platform/chromium/PopupMenuChromium* have been upstreamed (then landed in our tree), we can enable them in test_shell. The WebKit part is contained in this bug: https://bugs.webkit.org/show_bug.cgi?id=24692 BUG=5095 (http://crbug.com/5095) Review URL: http://codereview.chromium.org/48149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12382 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline test. This test was failing because we map courier to courier new ↵ojan@google.com2009-03-244-1/+26
| | | | | | | | | on Windows. This is the same as Windows Safari, but on the mac it's just courier. Review URL: http://codereview.chromium.org/42547 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12381 0039d316-1c4b-4281-b951-d872f2087c98
* Make the vsprops inheritance paths less relative.robertshield@google.com2009-03-241-2/+2
| | | | | | Review URL: http://codereview.chromium.org/42563 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12380 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed the following layout test:hclam@chromium.org2009-03-241-0/+8
| | | | | | | | | | | | | | LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-post.html The crash happens in simple_resource_loader_bridge.cc, there is a case when MaybeUpdateUploadProgress is posted as a task and in the queue while a redirect response by the server cancels the upload. Leaving request_->get_upload() returns NULL, and of cource using of the pointer failes. Review URL: http://codereview.chromium.org/50077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12379 0039d316-1c4b-4281-b951-d872f2087c98
* Make the find bar blue. Hooks up the prev/next buttons and thetc@google.com2009-03-242-12/+106
| | | | | | | | | close button. Review URL: http://codereview.chromium.org/50079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12378 0039d316-1c4b-4281-b951-d872f2087c98
* Start using upstreamed worker files and remove the old ones from webkit/port.dimich@google.com2009-03-248-653/+11
| | | | | | | Before submitting, I'll add DEPS with corresponding WebKit rev (see http://codereview.chromium.org/52007) Review URL: http://codereview.chromium.org/45035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12377 0039d316-1c4b-4281-b951-d872f2087c98
* New tab page was linking to the wrong URL for the history page. We don't ↵glen@chromium.org2009-03-242-31/+18
| | | | | | | | | | need the message and can just put an actual URL in the page. BUG=8961 Review URL: http://codereview.chromium.org/49014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12375 0039d316-1c4b-4281-b951-d872f2087c98
* Net module changes to support caching responses to a POST request.darin@chromium.org2009-03-245-48/+120
| | | | | | | | | | | The solution is to add a user-defined identifier to UploadData. If that identifier is set, and if the request method is POST, then HttpCache will enable caching for the response. (The cache key will be a composition of the identifier and the URL.) A subsequent POST request to the same URL with the same identifier will "hit" the previously generated cache entry. Reuse from the cache is subject to all of the standard rules. BUG=2636 R=wtc Review URL: http://codereview.chromium.org/52028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12374 0039d316-1c4b-4281-b951-d872f2087c98
* Collapse two conditions into a single one.thomasvl@chromium.org2009-03-241-2/+0
| | | | | | Review URL: http://codereview.chromium.org/42567 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12373 0039d316-1c4b-4281-b951-d872f2087c98
* Use a correct templatized WriteInto for all string typesmark@chromium.org2009-03-241-13/+5
| | | | | | Review URL: http://codereview.chromium.org/53014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12372 0039d316-1c4b-4281-b951-d872f2087c98
* Improve the Linux Omnibox ssl background / scheme coloring.deanm@chromium.org2009-03-241-8/+16
| | | | | | | | | | | We now correctly reset the background color on tab switches, and navigations from a ssl to non-ssl page. BUG=8236,9225 Review URL: http://codereview.chromium.org/49015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12371 0039d316-1c4b-4281-b951-d872f2087c98
* Add a copy of SunSpider 0.9 for performance testing.patrick@chromium.org2009-03-2434-0/+7680
| | | | | | | | | | This copy was fetched from: http://webkit.org/perf/sunspider-0.9/sunspider.html This copy is unmodified from its original source. Review URL: http://codereview.chromium.org/42549 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12370 0039d316-1c4b-4281-b951-d872f2087c98
* Generate header file of Linux version information (currently gyp-only).mmoss@chromium.org2009-03-243-0/+106
| | | | | | | | | | | | This isn't yet #included in file_version_info_linux.cc since we haven't officially cutover to the gyp build. BUG=8132 Review URL: http://codereview.chromium.org/45028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12369 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaselining cause it started failing with WebKit merge of rev 10232 though ↵mad@chromium.org2009-03-244-11/+11
| | | | | | | | | | | | | | | | | | we don't know why. The decision to rebaseline came from: 2009/3/20 Brett Wilson <brettw@google.com> Actual matches IE very closely, whereas expected doesn't. I had Idan check this and he says the new one is better, so we should rebaseline. Even though it is called "ATSUI," this test really tests some basic features of complex text that will apply to any font system (and I had to do some work to make ours look good). So it's important we run this test. Review URL: http://codereview.chromium.org/51005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12368 0039d316-1c4b-4281-b951-d872f2087c98
* Clicking a text field that is already focused triggers the autofill. However ↵jcampan@chromium.org2009-03-244-27/+54
| | | | | | | | | | | | the code triggering this was just checking that the focused element before and after processing the event was the same. We need to do a hit test to ensure the click is really on the text field, otherwise in cases where clicking somewhere in the page does not change the focus, we would bogusly bring up the autofill popup. BUG=8627 TEST=Ensure autocomplete popup still works as expected: when entering text, when using up/down arrows, when clicking selected text field. Also ensures the scenario from the bug does not trigger the popup. Review URL: http://codereview.chromium.org/50038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12367 0039d316-1c4b-4281-b951-d872f2087c98
* Add a progress meter to the downloads page.glen@chromium.org2009-03-244-12/+159
| | | | | | | | | | | | | | Add the progress status text indicator code from the old history page. Make 'cancel' visible when paused. More RTL fixes. BUG=8220,8334 Review URL: http://codereview.chromium.org/42550 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12366 0039d316-1c4b-4281-b951-d872f2087c98
* History import was exercising a codepath that didn't have code to update ↵glen@chromium.org2009-03-241-0/+6
| | | | | | | | | | | HistoryBackend::first_recorded_time_ BUG=8827 Review URL: http://codereview.chromium.org/42546 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12365 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 18:17:14 +0000