summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* One part of http://codereview.chromium.org/223013/showjorlow@chromium.org2009-09-302-0/+55
| | | | | | | | | | | Split so it's not a 2 sided patch. TEST=none BUG=none Review URL: http://codereview.chromium.org/242056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27575 0039d316-1c4b-4281-b951-d872f2087c98
* Add purify error to expected list.huanr@chromium.org2009-09-301-0/+65
| | | | | | | | | BUG=23396 TEST=None Review URL: http://codereview.chromium.org/244043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27574 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 219.9 to 220.0laforge@chromium.org2009-09-301-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27573 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary disabling a unit test that fails on Linux toolkit views while I ↵jcampan@chromium.org2009-09-301-0/+6
| | | | | | | | | | | investigate. BUG=23394 TBR=huanr Review URL: http://codereview.chromium.org/251039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27570 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Use a calculated border color in chrome theme mode instead of blue.erg@google.com2009-09-295-42/+26
| | | | | | Review URL: http://codereview.chromium.org/255012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27565 0039d316-1c4b-4281-b951-d872f2087c98
* WebView::DownloadImage refactoredyaar@chromium.org2009-09-296-75/+51
| | | | | | | | | The implementation was dependent on webkit_glue::image_resource_fetcher and had to be removed if we want to upstream WebView. DownloadImage has been moved into RenderView::DownloadImage. WebViewImpl's set of ImageResourceFetchers has been ripped off and moved into RenderView. Review URL: http://codereview.chromium.org/255006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27564 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the NativeViewHost refactoring (it was breaking the ChromeOS build). jcampan@chromium.org2009-09-2923-121/+268
| | | | | | | | | | | | | | | Refactoring some of the NativeViewHost and NativeControl focus management so their consumers don't have to explicitly set the focused view. See original review: http://codereview.chromium.org/235011/show BUG=None TEST=Run all tests. Make sure focus is stored/restored properly in Chrome. TBR=ben Review URL: http://codereview.chromium.org/246032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27563 0039d316-1c4b-4281-b951-d872f2087c98
* The RSS extension now renders the RSS HTML preview inside an IFRAME.finnur@chromium.org2009-09-295-85/+148
| | | | | | | | | BUG=None TEST=See browser tests. Review URL: http://codereview.chromium.org/242055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27562 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize stats_table_ in the constructor.jhawkins@chromium.org2009-09-291-3/+5
| | | | | | | | | CID=1648 BUG=none TEST=none Review URL: http://codereview.chromium.org/251037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27561 0039d316-1c4b-4281-b951-d872f2087c98
* sync-webkit-git: a better message when you're not on the right branchevan@chromium.org2009-09-291-3/+4
| | | | | | Review URL: http://codereview.chromium.org/235056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27560 0039d316-1c4b-4281-b951-d872f2087c98
* Use a helper to facilitate reading a file on a background thread.darin@chromium.org2009-09-296-38/+190
| | | | | | | | | | | | | | | | This fixes a thread-safety bug in ExecuteCodeInTabFunction caused by using RefCounted instead of RefCountedThreadSafe. Instead of changing ExecuteCodeInTabFunction to be RefCountedThreadSafe, I thought it would be better to fork off a helper class. R=aa BUG=none TEST=file_reader_unittest.cc and existing browser_tests (once my other patch lands which adds thread-safety assertions to NewRunnableMethod) Review URL: http://codereview.chromium.org/243033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27559 0039d316-1c4b-4281-b951-d872f2087c98
* Pull in make build fixes for yesterday's NaCl changes.tony@chromium.org2009-09-291-2/+2
| | | | | | | | TBR=bradnelson Review URL: http://codereview.chromium.org/242066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27558 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize has_indexed_affixes_ in the constructor.jhawkins@chromium.org2009-09-291-1/+2
| | | | | | | | | CID=1635 BUG=none TEST=none Review URL: http://codereview.chromium.org/249036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27557 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup some code in the render_view_host_manager unittest.brg@chromium.com2009-09-291-4/+3
| | | | | | | | | | The initialization of the ProfileSyncService was being called twice in one test. Test=RenderViewHostManagerTest in unittests Bug=none Review URL: http://codereview.chromium.org/248036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27556 0039d316-1c4b-4281-b951-d872f2087c98
* Rename setThemeEngine to SetThemeEngine to conform to Google style.dpranke@google.com2009-09-292-3/+3
| | | | | | | | | | R=darin@chromium.org TEST=none BUG=none Review URL: http://codereview.chromium.org/217006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27555 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize the os_event struct members to 0 in the constructor.jhawkins@chromium.org2009-09-291-0/+1
| | | | | | | | | CID=1642 BUG=none TEST=none Review URL: http://codereview.chromium.org/255013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27554 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for WebKit 48883:48904.senorblanco@chromium.org2009-09-292-1/+11
| | | | | | | | | | BUG=none TEST=pray for green TBR=atwilson Review URL: http://codereview.chromium.org/235057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27553 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash when using about:ipc with only NTP on Windows.jrg@chromium.org2009-09-291-2/+3
| | | | | | | | Must check iterator's Done() before dereferencing (list may be empty). Review URL: http://codereview.chromium.org/243040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27552 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 219.8 to 219.9laforge@chromium.org2009-09-291-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27551 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix a bookmark dragging crasher by initing a member var.estade@chromium.org2009-09-291-0/+1
| | | | | | | | | | | Not sure when this regressed. Looking at the svn history I can't even find a revision where it would have worked. We probably made some other change that revealed this long-standing bug. BUG=23233 TEST=drag a bookmark out of a bookmark bar folder Review URL: http://codereview.chromium.org/255011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27550 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Remove an unused variable.jhawkins@chromium.org2009-09-291-2/+1
| | | | | | | | | CID=1650 BUG=none TEST=none Review URL: http://codereview.chromium.org/251036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27549 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize type_ in the constructor.jhawkins@chromium.org2009-09-291-1/+2
| | | | | | | | | CID=2287 BUG=none TEST=none Review URL: http://codereview.chromium.org/242065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27548 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Add the typedef keyword to the ProfileType enum so we're not ↵jhawkins@chromium.org2009-09-291-1/+1
| | | | | | | | | | | creating an instance of the enum. CID=5718 BUG=none TEST=none Review URL: http://codereview.chromium.org/249035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27547 0039d316-1c4b-4281-b951-d872f2087c98
* Updating Native Client to get svn:ignore propertiesgregoryd@google.com2009-09-291-1/+1
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/242063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27546 0039d316-1c4b-4281-b951-d872f2087c98
* Modified output format to be accepted by Pulse. Updated DEPS to include ↵kkania@google.com2009-09-294-57/+65
| | | | | | | | newer revision from googlecode, which has screenshot name changes. Review URL: http://codereview.chromium.org/235041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27545 0039d316-1c4b-4281-b951-d872f2087c98
* These classes need to use thread safe reference counting.darin@chromium.org2009-09-291-2/+2
| | | | | | | | | | | | | Detected using this CL: http://codereview.chromium.org/251012 R=jcampan BUG=none TEST=covered by browser tests once my assertion to NewRunnableMethod lands. Review URL: http://codereview.chromium.org/251033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27544 0039d316-1c4b-4281-b951-d872f2087c98
* Modifies layout test formatter tool to have an option to only use local ↵gwilson@google.com2009-09-294-88/+244
| | | | | | | | | | | | | | baselines instead of scraping them. Greatly speeds up the tool and circumvents the need to scrape remote sites for the baselines. BUG=none R=ojan TEST=run "test_output_formatter.bat -l" -- the script should not scrape anything Review URL: http://codereview.chromium.org/211025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27543 0039d316-1c4b-4281-b951-d872f2087c98
* Add osx support to gypbuildgman@google.com2009-09-292-6/+49
| | | | | | | | | | | Step 1. It builds on OSX and I guessed on linux Will try that next. Also will start adding place holders for options next Review URL: http://codereview.chromium.org/251034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27542 0039d316-1c4b-4281-b951-d872f2087c98
* Fix breakpad unused variable warning.thestig@chromium.org2009-09-291-9/+7
| | | | | | | | | BUG=none TEST=none TBR=agl Review URL: http://codereview.chromium.org/251035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27541 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27520.mirandac@chromium.org2009-09-292-121/+61
| | | | | | Review URL: http://codereview.chromium.org/256003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27540 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline chromium-specific test expectations to use window.toString() ↵japhet@chromium.org2009-09-2914-400/+28
| | | | | | | | | | | | | output that matches jsc. http://trac.webkit.org/changeset/48841 BUG=none TEST=none Review URL: http://codereview.chromium.org/244040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27539 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize test_funcs_.test_make_request in the constructor.jhawkins@chromium.org2009-09-291-0/+1
| | | | | | | | | CID=5447 BUG=none TEST=none Review URL: http://codereview.chromium.org/243037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27538 0039d316-1c4b-4281-b951-d872f2087c98
* style fix. the header for .cc has to be the 1st include.oshima@chromium.org2009-09-291-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/242045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27537 0039d316-1c4b-4281-b951-d872f2087c98
* Update known crash signature.huanr@chromium.org2009-09-291-0/+1
| | | | | | Review URL: http://codereview.chromium.org/256002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27536 0039d316-1c4b-4281-b951-d872f2087c98
* Use a separate Breakpad product name for ChromeOS.thestig@chromium.org2009-09-291-0/+6
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/251032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27535 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline layout test LayoutTests/fast/frames/viewsource-on-image-file.html.jianli@chromium.org2009-09-296-3/+34
| | | | | | | | | BUG=15478 TEST=none Review URL: http://codereview.chromium.org/242057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27534 0039d316-1c4b-4281-b951-d872f2087c98
* Use Mac fonts in Mac Chrome.mark@chromium.org2009-09-292-52/+113
| | | | | | | | | | | | | | | Use Helvetica, Times, Courier, Apple Chancery, and Papyrus for sans-serif, serif, monospace, cursive, and fantasy, respectively. These are the fonts used by Safari and Firefox on the Mac, and the fonts that we run layout tests with on the Mac. BUG=19135 21458 TEST=http://www.w3.org/Style/Examples/007/fonts Check the fonts for sans-serif, serif, monospace, cursive, fantasy Note that the font used for "Helvetica, sans-serif" is actually Verdana Review URL: http://codereview.chromium.org/244039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27533 0039d316-1c4b-4281-b951-d872f2087c98
* Add a version of ReplaceStringPlaceholders that operates on std::stringtony@chromium.org2009-09-293-6/+42
| | | | | | | | | | | | | | instead of string16. BUG=none TEST=base unit tests Original patch by avd@google.com at: http://codereview.chromium.org/245046 Review URL: http://codereview.chromium.org/242061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27532 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Raise window after click on titlebar or border.derat@chromium.org2009-09-291-0/+5
| | | | | | | | | BUG=23318 TEST=checked that it matches native window behavior in metacity and kwin Review URL: http://codereview.chromium.org/246029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27531 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "linux: tickle the render sandbox early so it forks at the right time"evan@chromium.org2009-09-291-4/+0
| | | | | | This reverts the previous commit (compile failure). git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27530 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for WebKit 48871:48883.senorblanco@chromium.org2009-09-292-2/+2
| | | | | | | | | | BUG=none TEST=green is good TBR=atwilson Review URL: http://codereview.chromium.org/251030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27529 0039d316-1c4b-4281-b951-d872f2087c98
* linux: tickle the render sandbox early so it forks at the right timeevan@chromium.org2009-09-291-0/+4
| | | | | | | | | Otherwise, the first time the singleton is touched we've already started loading a page! We surely have a bunch of threads going at that point. Review URL: http://codereview.chromium.org/245039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27528 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in tool tip manager.sky@chromium.org2009-09-291-1/+8
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/242051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27527 0039d316-1c4b-4281-b951-d872f2087c98
* Import dialog fixup:thomasvl@chromium.org2009-09-292-68/+158
| | | | | | | | | | | | | | | - use one call string convert - load the nib from the main bundle - make the cancel button autosize to it's string - make the cancel button tweak it's position based on the string (not dialog position, but keep the right edge as is) - fix up some field overlaps, and position, dialog still isn't pretty, but this is how Cole said to leave it rather then reopen the discussion now. - use the WithFixup helpers to deal with ellipses TEST=button fits text, fields don't overlap any strings. BUG=20534 Review URL: http://codereview.chromium.org/235055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27526 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize got_thumbnail_callback_, query_url_success_, and ↵jhawkins@chromium.org2009-09-291-2/+7
| | | | | | | | | | | redirect_query_success_ in the constructor. CID=1653 BUG=none TEST=none Review URL: http://codereview.chromium.org/251031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27525 0039d316-1c4b-4281-b951-d872f2087c98
* This CL cleans-up the FindBarHost and fixes an assert that happens on the ↵jcampan@chromium.org2009-09-294-63/+11
| | | | | | | | | | | | | | | focus manager when closing Chrome (linux toolkit views). See original review at: http://codereview.chromium.org/220036/show BUG=None TEST=Make sure find works as expected on Chrome Linux toolkit views. TBR=ben Review URL: http://codereview.chromium.org/243035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27524 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix memleak in GetNodeDictionary again.mattm@chromium.org2009-09-291-3/+2
| | | | | | | | | | CID=4804 BUG=none TEST=none Review URL: http://codereview.chromium.org/246025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27523 0039d316-1c4b-4281-b951-d872f2087c98
* Unflakify SyncerThreadWithSyncerTest.Polling by using TimeTicks instead of ↵tim@chromium.org2009-09-291-15/+7
| | | | | | | | | | | system time. Should have done that first, but I had started writing the test before writing the code and learning how to use TimeTicks. TEST=SyncerThreadWithSyncerTest.Polling BUG=23336 Review URL: http://codereview.chromium.org/248034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27522 0039d316-1c4b-4281-b951-d872f2087c98
* Adds "gypbuild" command so developer does not have togman@google.com2009-09-292-0/+88
| | | | | | | | | | | know the details of how to build and run tests on every platform. This is just the initial checkin with lots of TODOs Review URL: http://codereview.chromium.org/248030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27521 0039d316-1c4b-4281-b951-d872f2087c98
* Change disk access on theme install from UI to File thread.mirandac@chromium.org2009-09-292-61/+121
| | | | | | | | | BUG= http://crbug.com/17696 TEST= none Review URL: http://codereview.chromium.org/222025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27520 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 16:31:45 +0000