| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
for 64-bit Windows.
This CL is required for supporting Native Client on 64-bit Windows. On Win64 we will use a 64-bit executable to load NaCl modules. Since we have only one version of Chrome on Windows, this executable has to be built together with 32-bit Chrome binaries.
For the targets that are required for both 32-bit and 64-bit builds, this CL moves the shared parts of the target definitions into target-specific gypi files (such as base.gypi). New 64-bit only targets are added. Since we would like to port as few code as possible at this point, some 64-bit targets include less source files or less dependencies than the original 32-bit targets. These targets will have nacl_win64 in their name - to emphasize that they should be used for NaCl only. Some 64-bit targets are identical to the 32-bit targets in everything except for the target platform - these will have only win64 in their name.
TEST=none
BUG=28176
Review URL: http://codereview.chromium.org/384068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/497003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added some explanatory comments.
BUG=30642
TEST=manual testing
Review URL: http://codereview.chromium.org/501108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
url different.
It was possible to make the existing code insert the image in the wrong tab by clicking the snapshot twice quickly. This change eliminates the race condition that made this possible.
BUG=none
TEST=Manual testing on Linux, windows.
Review URL: http://codereview.chromium.org/502060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
optimization. See:
http://www.zlib.net/zlib_faq.html#faq36
BUG=None
TBR=mbelshe
TEST=None
Review URL: http://codereview.chromium.org/503057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Verifier to work.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/503048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.FLAKY_Bookmarks
Review URL: http://codereview.chromium.org/503053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
host can
find it to transfer to the NaCl module.
Review URL: http://codereview.chromium.org/500121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
functions.
BUG=none
TEST=Run sync_unit_tests and observe that they pass.
Review URL: http://codereview.chromium.org/502061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Revert valgrind suppresion.
BUG=30762
Review URL: http://codereview.chromium.org/501115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dank
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/501111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(issue 29929).
Also, a little bit more UI polish:
Make sure really long titles don't destroy the layout of the subscribe page.
Move the Edit/Remove links closer to the combo box.
Add a link to the feed page so that people with desktop feed readers can get at the url.
BUG=http://crbug.com/29929
TEST=See bug 29929.
Review URL: http://codereview.chromium.org/500131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=12281
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/500110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PlatformCleanUp(). The latter is called multiple times, which results in
fontconfig being shutdown too early. Fixes buildbot failure introduced in
revision 34945.
BUG=9245
TEST=Run test_shell using valgrind. Memory leaks related to fontconfig should drop from around 138079 bytes to around 24573 bytes. Also use valgrind to check for invalid reads.
Patch from Jochen Eisinger <eisinger@google.com>.
Review URL: http://codereview.chromium.org/502072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/505051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=30488
TEST=N/A
Review URL: http://codereview.chromium.org/501074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=cpu
BUG=30711
TEST=Run in-product EULA, should not see "OEM" in the title.
Review URL: http://codereview.chromium.org/500107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
non-ASCII characters.
BUG=30736
TEST=Open chrome with --lang=sr and try to pack extension. It shouldn't crash, and files with be generated.
Review URL: http://codereview.chromium.org/503051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TODO: Make location bar to be freely shrinkable. Will be addressed in another CL.
BUG=11258
TEST=See bug report.
Review URL: http://codereview.chromium.org/507022
TBR=suzhe@chromium.org
Review URL: http://codereview.chromium.org/502073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TODO: Make location bar to be freely shrinkable. Will be addressed in another CL.
BUG=11258
TEST=See bug report.
Review URL: http://codereview.chromium.org/507022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The combined IPC means that scrolling only requires one transport DIB instead
of two. Previously, we'd use one in the ScrollRect IPC to pass up the pixels
for the exposed region, and then we'd use a second one in the PaintRect IPC to
pass up the pixels for the updated scroll bar rendering. Now all paints are
done using a single transport DIB.
Optimize RenderWidgetHostViewWin::OnPaint to only paint the damaged regions.
This means calling GetUpdateRgn and GetRegionData to enumerate the list of
damage rects. Then only those rects are copied from the backing store.
The same optimization is not done for Linux or Mac yet.
R=brettw
BUG=29591
TEST=none
Review URL: http://codereview.chromium.org/506013
TBR=darin@chromium.org
Review URL: http://codereview.chromium.org/506075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Somehow I managed to miss the drawing code I should have modified before.)
BUG=30188,30716
TEST=Make sure Omnibox border draws correctly (zoom in closely and look) and matches the buttons; do so with a wide variety of themes. Make sure the blue focus ring appears when appropriate.
Review URL: http://codereview.chromium.org/501103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The combined IPC means that scrolling only requires one transport DIB instead
of two. Previously, we'd use one in the ScrollRect IPC to pass up the pixels
for the exposed region, and then we'd use a second one in the PaintRect IPC to
pass up the pixels for the updated scroll bar rendering. Now all paints are
done using a single transport DIB.
Optimize RenderWidgetHostViewWin::OnPaint to only paint the damaged regions.
This means calling GetUpdateRgn and GetRegionData to enumerate the list of
damage rects. Then only those rects are copied from the backing store.
The same optimization is not done for Linux or Mac yet.
R=brettw
BUG=29591
TEST=none
Review URL: http://codereview.chromium.org/506013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fontconfig. The remaining leaks are due to static variables in pango holding
references to fontconfig data structures. These should go away for a more up to
date version of pango.
BUG=9245
TEST=Run test_shell using valgrind. Memory leaks related to fontconfig should drop from around 138079 bytes to around 24573 bytes
Patch by Jochen Eisinger <eisinger@google.com>.
Review URL: http://codereview.chromium.org/507038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This gets the version of V8 which allows for larger map space.
TEST=none
BUG=http://crbug.com/29428
Review URL: http://codereview.chromium.org/505050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Now Valgrind is able to intercept bash and Python allocation functions.
This prevents ui_tests from crashing because of mismatched
malloc/sh_malloc/free/sh_free calls inside Bash.
Review URL: http://codereview.chromium.org/502029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=20916
TEST=Load something big (http://cnn.com/) and hit escape. Page load will stop.
Review URL: http://codereview.chromium.org/491023
Patch from Jochen Eisinger.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As shown in http://crbug.com/30758, Japanese pages are rendered more nicely
with VLGothic than with Sazanami Gothic.
BUG=30758
TEST=Launched chrome with "LANGUAGE=ja chrome --user-data-dir=/tmp",
and open a Japanese page. Confirmed that Japanege pages were rendered
with Sazanami Gotchi before the change, and with VLGothic after the change
Review URL: http://codereview.chromium.org/506070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=cira
BUG=30762
TEST=Valgrind unit tests go green.
Review URL: http://codereview.chromium.org/502070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=LoginPromptTest.*
Review URL: http://codereview.chromium.org/501091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG= http://bugs.chromium.org/30627
R= kuchhal
TEST= Uninstall Google Chrome with a process still running and make
sure the dialog message says "Google Chrome".
Review URL: http://codereview.chromium.org/501110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixing error code and style issues in http://codereview.chromium.org/500018
BUG=29711
TEST=ExtensionApiTest.CrossOriginXHR
Review URL: http://codereview.chromium.org/503038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
FilePath cleanup while we're at it.
BUG=none
TEST=Net unittests do not time out on the fyi wine/valgrind test bot.
Review URL: http://codereview.chromium.org/501100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual testing
Review URL: http://codereview.chromium.org/500120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
implementation.
This is no longer used by chrome, and it is unlikely that embedders would want to use this.
The default will just use the DOMAIN addressing type.
BUG=29914
Review URL: http://codereview.chromium.org/507048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dank
BUG=none
TEST=wine_valgrind base_unittests turn green.
Review URL: http://codereview.chromium.org/502069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to open a new window instead of reusing the most recent tab for
opening cmdline URLs.
BUG=2843
TEST=Run with --new-window switch and confirm that a new window pops up
patch by <clemens [at] endorphin dot org>
original review: <http://codereview.chromium.org/464060>
Review URL: http://codereview.chromium.org/503023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) fix crasher triggered any time a drag from a different source hovers over the browser action bar.
2) fix graphical issue where changes to the ordering could possibly take a few seconds to propagate to other browser windows.
BUG=30639
TEST=a) drag a bookmark over the browser action toolbar, don't crash
b) open two windows. drag a browser action around, keep holding left mouse button and drag to a distant part of the screen, then release. The positional change should instantly take effect in the second browser window.
Review URL: http://codereview.chromium.org/506065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26162
TEST=<img height="100%">
Review URL: http://codereview.chromium.org/505047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- remove various invalid uses of ASCII functions
- properly escape resource requests
- clean up file path handling
Some work remains to be done on the last bullet point but this is enough to fix the bug.
BUG=30509
TEST=see bug
Review URL: http://codereview.chromium.org/501046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#tests=websocket
some websocket tests runs successfully.
websocket/tests/handshake-* should be fixed by webkit r52234
no crash on websocket/tests/bad-sub-protocol now
BUG=30185,30545
TEST=none
Review URL: http://codereview.chromium.org/501107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This patch exempts non-theme extensions (extensions not downloaded from theme minigallery) from showing the arrow download animation.
BUG=29632
TEST=Install extension from the gallery. No download arrow should be shown. Install theme from https://tools.google.com/chrome/intl/en/themes/index.html. Download arrow should be shown. Download random other stuff -> download arrow should be shown.
Review URL: http://codereview.chromium.org/504031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=FlipNetworkTransactionTest.LoadLog
Review URL: http://codereview.chromium.org/500083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=pkasting
TEST=canaries, try bots
BUG=NONE
Review URL: http://codereview.chromium.org/500126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
( patch by thiago.farina@gmail.com : http://codereview.chromium.org/503009 )
Review URL: http://codereview.chromium.org/504036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/503052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
name to resolve is too long.
This change is important when a site has @font-face rule like:
// http://paulirish.com/webkit-fontface-hang.html
@font-face{font-family:testfont;src:url('data:font/ttf;base64,AA.....<<looooooooooong base64 data>>.....aQ==')}
In such a case, WebCore first calls SkFontHost::CreateTypeface() with the (possibly very long) data-uri string itself, then calls SkFontHost::CreateTypefaceFromStream() with decoded byte stream. Since render_sandbox_host_linux.cc just ignores too long IPC message, the renderer process could block indefinitely waiting for a reply inside recvmsg() system call called from SkFontHost::CreateTypeface().
I'm not sure if the WebCore behavior (i.e. calling CreateTypeface with data-uris) is reasonable, but I believe the Skia part is better to be fixed anyway. Non data-uri font family names could be very long too:
@font-face{font-family:testfont;src:local('AA........AA');}
BUG=29861
TEST=First, set up your Linux SUID Sandbox binary: http://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment. Then start Chromium and visit http://paulirish.com/webkit-fontface-hang.html or http://typekit.com/. Verify that the renderer does not freeze.
Review URL: http://codereview.chromium.org/507037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
works as expected with synchronous responses.
As an added bonus, now changing the default test mode
of kRangeGET_TransactionOK doesn't end up with some tests
hanging, so it is easy to manually verify that all tests
work as expected.
BUG=26729
TEST=unittests
Review URL: http://codereview.chromium.org/501099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a memory leak of any V8 context that used an extension API. This
mostly affected popups and tab contents, since they are the extension views that
close.
BUG=30194
Review URL: http://codereview.chromium.org/504053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34912 0039d316-1c4b-4281-b951-d872f2087c98
|