| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
The issue for indexed images is the bits per channel is how many bits are used to look up the value
in the palette. The value that comes out is an RGB value.
Review URL: http://codereview.chromium.org/149060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Still needs an outline shader.
Because we can't do atomic commits the screenshot
for this is in another CL
Review URL: http://codereview.chromium.org/126208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jorlow
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/150068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/150056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/151044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
out of plugin_mac.mm into a new graphics_utils_mac.mm file.
Also remove period at end of fullscreen message.
Review URL: http://codereview.chromium.org/149052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* change name "childrenIds" to "children"
* add dateAdded and dateGroupModified properties
* add id to onRemoved
BUG=13994
BUG=14581
BUG=12217
TEST=load sample bookmarks extension and play around with Dump Bookmarks
Review URL: http://codereview.chromium.org/151032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
coordinates before whiting out unpainted areas.
BUG=None
TEST=Resize newly-created window, check for black areas.
Review URL: http://codereview.chromium.org/147232
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/150052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Created new histograms
to expose it. Also made some new histograms that use a derived time: begin_time. This is
the request_time if the page was requested by a user action, start time otherwise.
Review URL: http://codereview.chromium.org/150010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=None
TEST=None. No visible impact.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/150053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Added ENABLE_DATAGRID define temporarily (we will remove it once the V8Proxy stuff lands)
* Added new ContextMenuClient::isSpeaking method, which will be needed for http://trac.webkit.org/changeset/45333
R=darin
TEST=no regressions in layout tests.
BUG=none
Review URL: http://codereview.chromium.org/151035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/150048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/150050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/151037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/151036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=try to load an extension with a capital letter or two in the extension's extension. It should load.
Review URL: http://codereview.chromium.org/147017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=willchan
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/150049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/150036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
result. This is to make text-encoding.html work in UI test.
Also removed a couple files forgot to remove during last commit.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/150035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=jianli
Review URL: http://codereview.chromium.org/150043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/151031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Init
- Navigate
- DOMUI
Original review: http://codereview.chromium.org/126060
Patch by tyoshino@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=4361
TEST=many ui/layout tests.
Review URL: http://codereview.chromium.org/149114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also update the comment to properly describe the code. It was referring to the tab strip, but the code was using the toolbar.
BUG=15576
Review URL: http://codereview.chromium.org/150037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
official builds because the build location changed on filer. So added logic to handle it.
Review URL: http://codereview.chromium.org/141058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/147241
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/150029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=erg
Review URL: http://codereview.chromium.org/150033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=This is a UI test.
Nicolas, could you please review DEPS? I added a couple of new lines to DEPS in order to fetch a copy the following directory into UI test data directory:
LayoutTests/http/tests/resources
LayoutTests/http/tests/workers
LayoutTests/http/tests/xmlhttprequest
Review URL: http://codereview.chromium.org/147125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
standard widget. This may also fix some of our resizing
issues.
BUG=http://crbug.com/14663
TEST=The resizer widget should still work as expected.
Review URL: http://codereview.chromium.org/149094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we have several uses of %I64d in format strings to indicate
a 64-bit value. This does not work on Mac or Linux, where 'I'
indicates the use of locale specific digits.
Instead, we introduce base/format_macros.h which mimic the C99
standard macros for 64-bit values in a cross-platform manner.
Dean pointed out that V8 is handling this themselves rather than use
inttypes.h. Maybe we'll end up going down the same path but, for the
moment, we'll try and do it the 'correct' way and see how it works
out.
http://codereview.chromium.org/147154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/150028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST="make -r base_unittests; sh tools/valgrind/chrome-tests.sh -t base_unittests" on 64 bit ubuntu and verify no valgrind warnings from ld-*.so
Review URL: http://codereview.chromium.org/147254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Check that backing_store_ is non-NULL before using it. A drag can be initiated before the backing store has been created.
* Don't read a size greater than the size of the backing store image.
BUG=15387
TEST=Hard to reproduce. Quickly initiate a tab drag after opening a new tab.
Review URL: http://codereview.chromium.org/150008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Rearrange DND constants, create convenience functions
- (partially) implement drag onto home button
Note that the homepage is still hard-wired to the dev build splash page, so that it seems like this isn't working, but via debugging I ascertained that dragging a random file from the desktop onto the home button should successfully set that file as the homepage.
TEST=drag a lot of stuff all over the place (tabs, bookmarks, what have you), make sure nothing crashes
BUG=none
Review URL: http://codereview.chromium.org/147256
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/151027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
channel().
Motivation:
Currently, components that are using RenderProcessHost are checking its
liveness by null testing on channel(). I'd like to write unittests for those
components, but to mock out RenderProcessHost instances, I have to also
mock out the instance returned by RenderProcessHost::channel(), but there's
no interface class prepared. SyncChannel is directly used in RenderProcessHost.
Instead of dependency injection, I can let mock objects return invalid pointer
such as 0x1, but its bad test design. Rather than that, I'd like to introduce
HasConnection() method and override it to return true.
In fact, most of those components are not accessing channel()'s methods
directry. They're just checking channel() is null or not, and to issue IPCs,
they are calling Send method. So, it's OK to hide channel pointer from users, I
think.
Original review: http://codereview.chromium.org/147077
Patch by tyoshino@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/151026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=mbelshe
Review URL: http://codereview.chromium.org/149119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/150024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=15459
TEST=none
Review URL: http://codereview.chromium.org/149086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19488 0039d316-1c4b-4281-b951-d872f2087c98
|