summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Convert over to channel handlesdmaclach@chromium.org2010-12-0829-262/+143
| | | | | | | | | | | | This hides some of the internals of the posix channels from users, and gets rid of several #ifdef POSIX blocks. Generally simplifies usage of channels xplatform. BUG=none TEST=build Review URL: http://codereview.chromium.org/5598010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68621 0039d316-1c4b-4281-b951-d872f2087c98
* Add automated_ui_tests and interactive_ui_tests to the Valgrind test runnertimurrrr@chromium.org2010-12-081-0/+13
| | | | | | | TEST=They work locally Review URL: http://codereview.chromium.org/5639007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68620 0039d316-1c4b-4281-b951-d872f2087c98
* Submitting http://codereview.chromium.org/5623006/ oin behalf of ↵zelidrag@chromium.org2010-12-081-1/+2
| | | | | | | | | | | | | | | | | ellyjones@chromium.org: chromeos: Connect to networks in unknown activation state. This allows us to connect to GSM networks through the UI, which do not report an activation state. BUG=chromium-os:10077 TEST=Tried it TBR=ellyjones Review URL: http://codereview.chromium.org/5519017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68619 0039d316-1c4b-4281-b951-d872f2087c98
* Fix cpplint.py nits.wtc@chromium.org2010-12-082-4/+4
| | | | | | | | | R=joth BUG=none TEST=no compilation errors. Review URL: http://codereview.chromium.org/5511015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68615 0039d316-1c4b-4281-b951-d872f2087c98
* Bring BG mode out from behind the flag on Windows.atwilson@chromium.org2010-12-082-3/+6
| | | | | | | | | | | | | | | | | Revert 68523 - Put BG mode back behind a flag for now. Just makes Windows functionality match mac/linux by gating background mode on an about:flags setting. BUG=65657 TEST=Install extension with background page, no wrench menu badge Review URL: http://codereview.chromium.org/5552004 TBR=atwilson@chromium.org Review URL: http://codereview.chromium.org/5568009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68614 0039d316-1c4b-4281-b951-d872f2087c98
* Add one more error posting...mad@google.com2010-12-081-0/+1
| | | | | | | | | | | This was missed in rev http://src.chromium.org/viewvc/chrome?view=rev&revision=68481 :-( BUG=65440 TEST=None Review URL: http://codereview.chromium.org/5640005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68611 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Use high-quality interpolation to draw tabpose thumbnails.thakis@chromium.org2010-12-083-0/+36
| | | | | | | | | BUG=50307,65894 TEST=Activate tabpose, thumbnails should look nicer, but the feature shouldn't be visibly slower. Review URL: http://codereview.chromium.org/5526011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68610 0039d316-1c4b-4281-b951-d872f2087c98
* Linux build fix.mbelshe@chromium.org2010-12-081-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=willchan Review URL: http://codereview.chromium.org/5671001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68609 0039d316-1c4b-4281-b951-d872f2087c98
* Don't get tab id until tab window handle is ready.mad@google.com2010-12-081-0/+5
| | | | | | | | | | | There are rare cases where the executor manager will DCHECK that the window handle that we ask it to associate to our tab id doesn't have a valid IEFrame parent. This is because we send the request for id <-> handle association before the handle is completely ready... So wait until the tab window handle is valid before sending a mapping event. BUG=None yet... crbug down for maintenance :-( TEST=None Review URL: http://codereview.chromium.org/5632004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68607 0039d316-1c4b-4281-b951-d872f2087c98
* Add the "virtual" keyword on method overrides that are missing it.erg@google.com2010-12-08134-535/+638
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5648004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68606 0039d316-1c4b-4281-b951-d872f2087c98
* Add origin checking for server pushed resources.mbelshe@chromium.org2010-12-086-22/+232
| | | | | | | | | BUG=64108 TEST=PushedStream, ServerPushCrossOriginCorrectness Review URL: http://codereview.chromium.org/5516012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68605 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Minor changes for the instant preference for M9.rsesek@chromium.org2010-12-084-121/+83
| | | | | | | | | | | | | | | | XIB changes: * Make the OK button on the instant confirm dialog the default button. * Remove the experiment tag in the preferences. * Add another text field underneath the Instant checbox for the warning * Create a new GTMIBArray to continue the "Basics Search Engine Group" * Add the new text field and the link to the new Array object BUG=65386 TEST=visual Review URL: http://codereview.chromium.org/5560012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68604 0039d316-1c4b-4281-b951-d872f2087c98
* Some installer cleanup: introduced ChannelInfo class for fiddling with "ap" ↵grt@chromium.org2010-12-0810-159/+510
| | | | | | | | | | | ClientState value. BUG=61609 TEST=added to and modified chrome/installer_util_unittests.exe appropriately Review URL: http://codereview.chromium.org/5656002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68603 0039d316-1c4b-4281-b951-d872f2087c98
* Prerender: Add PrerenderManager and PrerenderContentscbentzel@chromium.org2010-12-0817-3/+700
| | | | | | | | | | | Contributed By: tburkard@chromium.org BUG=None TEST=trybots, no new unit tests Review URL: http://codereview.chromium.org/5180005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68602 0039d316-1c4b-4281-b951-d872f2087c98
* Fix includes in stubbed login that were broken by profile.h and ↵rjkroege@google.com2010-12-081-2/+2
| | | | | | | | | | | | | profile_manager.h moving. BUG=none TEST=none TBR=sky Review URL: http://codereview.chromium.org/5561007 Patch from Ryan Harrison <rharrison@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68601 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a link to an article on the extensions documentation pages, which ↵kathyw@chromium.org2010-12-082-2/+2
| | | | | | | | | | | | | | | currently points to an internal hostname. Committing for Peter Beverloo (peter@chromium.org) http://codereview.chromium.org/5523007/ BUG=none TEST=none Review URL: http://codereview.chromium.org/5664003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68600 0039d316-1c4b-4281-b951-d872f2087c98
* Turns out RSA_generate_key is deprecated and is removed on some platforms, ↵joth@chromium.org2010-12-081-4/+9
| | | | | | | | | | | | | so using the lesser-documented RSA_generate_key_ex method instead. Also removes usage of the imaginary vector<>::data() method. BUG=None TEST=base_unittests filter=*RSA* Review URL: http://codereview.chromium.org/5603013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68598 0039d316-1c4b-4281-b951-d872f2087c98
* Propagate is_editable_node in the FOCUS_CHANGED_IN_PAGE notification.bryeung@google.com2010-12-088-53/+94
| | | | | | | | | | | Also fixes up types and a bug in WindowedNotificationObserverWithDetails. BUG=none TEST=updated BrowserFocusTest.FocusTraversal Review URL: http://codereview.chromium.org/5516005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68597 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 73510:73514.yutak@chromium.org2010-12-081-1/+1
| | | | | | | | | | TBR=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/5637006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68596 0039d316-1c4b-4281-b951-d872f2087c98
* Small fix to properly return the appropriate type.mad@google.com2010-12-081-1/+6
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/5588008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68595 0039d316-1c4b-4281-b951-d872f2087c98
* Set default image for new logged in user right after login.avayvod@chromium.org2010-12-083-11/+6
| | | | | | | | | BUG=chromium-os:9891 TEST=After login with new user, lock screen on image screen and verify that user image is of different color for each user. Review URL: http://codereview.chromium.org/5646002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68593 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 73496:73510.yutak@chromium.org2010-12-081-1/+1
| | | | | | | | | | TBR=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/5670001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68592 0039d316-1c4b-4281-b951-d872f2087c98
* Fix handling of 'Use system proxy settings' policygfeher@chromium.org2010-12-086-15/+54
| | | | | | | | | | | | | | | | The problem is that using system proxy settings is triggered when the internal proxy prefs of Chrome are set to their default values. Unfortunately it is possible that these prefs are set to their defaults but they are not controlled by the default pref store. This CL fixes this by checking for the default values and not only for the origin of prefs. A longer term solution is described in http://crbug.com/65732 BUG=65736 TEST=manual Review URL: http://codereview.chromium.org/5664001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68591 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in ExtensionPrefTestbattre@chromium.org2010-12-084-25/+40
| | | | | | | | | BUG=65642 TEST=look at valgrind build bots, introduced new unit test Review URL: http://codereview.chromium.org/5511010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68590 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 73487:73496.yutak@chromium.org2010-12-081-1/+1
| | | | | | | | | | TBR=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/5660006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68589 0039d316-1c4b-4281-b951-d872f2087c98
* Enable DevToolsSanityTest.TestProfilerTab.mnaganov@chromium.org2010-12-081-2/+1
| | | | | | | | | | | | Works OK locally, let's see what will happen on bots. TBR=pfeldman@chromium.org BUG=54592 TEST=DevToolsSanityTest.TestProfilerTab Review URL: http://codereview.chromium.org/5608006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68585 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash where the chrome_frame_ gets used after it was released.mad@google.com2010-12-081-0/+6
| | | | | | | | | | See bug description for more details, all we need to do is check the pointer before using it. BUG=65826 TEST=This is most likely happening when the use closes a tab very quickly after creating it. Review URL: http://codereview.chromium.org/5611007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68584 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 605.0 to 606.0chrome-release@google.com2010-12-081-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68582 0039d316-1c4b-4281-b951-d872f2087c98
* Fix OpenSSL buildjoth@chromium.org2010-12-081-3/+6
| | | | | | | | | | | - remapping the unknown protocol error code for consistency with NSS socket. BUG=None TEST=SSLClientSocketTest.PrematureApplicationData Review URL: http://codereview.chromium.org/5593005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68579 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new GetInstance() method for singleton classes, take 2.satish@chromium.org2010-12-0854-175/+247
| | | | | | | | | | | | | | | | | | This is a small step towards making all singleton classes use the Singleton<T> pattern within their code and not expect the callers to know about it. This CL includes all files except those under chrome/browser, chrome/net, chrome/service and third_party/WebKit (these will be done in future CLs). Suggested files to focus for reviewers: - joi@ for files under src/ceee - tommi@ for files under src/chrome_frame - maruel@ for the rest of the files. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5581008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68577 0039d316-1c4b-4281-b951-d872f2087c98
* Tracking down flakiness in PrepopulateRespectBlank.finnur@chromium.org2010-12-081-1/+3
| | | | | | | | | | | | | | | It seems the problem with the crash_service window eating input has been eliminated, but there is still some flakiness left. My traces indicate that probably no window has focus, so lets try to force the browser window to have focus, like we do in the browser focus tests. BUG=62937 TEST=Fixing a test. Review URL: http://codereview.chromium.org/5566006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68576 0039d316-1c4b-4281-b951-d872f2087c98
* Remove suppression for bug 61210.bauerb@chromium.org2010-12-081-7/+0
| | | | | | | | | | BUG=61210 TEST=TSan TBR=timurrrr Review URL: http://codereview.chromium.org/5550005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68575 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up pref change notification handling.mnissler@chromium.org2010-12-0837-1472/+1576
| | | | | | | | | | | | | | | This is a complete overhaul of PrefValueStore, PrefStore, PrefNotifier, and PrefService. Specifically: - Add an observer interface to PrefStore that can be used to notify the upper layers of the pref system about value changes. Currently, it's unused mostly, but that'll change when we refactor ExtensionPrefStore and ConfigurationPolicyPrefStore. - Make PrefNotifier be a dependency of PrefValueStore. That helps in keeping the pref change detection handling local to PrefValueStore. - Clean up related unit tests, removing redundant mocks and gmockify others. BUG=64893 TEST=Compiles and passes tests Review URL: http://codereview.chromium.org/5441002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68574 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed minor atomicity issue in PrefProxyConfigService::GetLatestProxyConfig ↵battre@chromium.org2010-12-084-35/+16
| | | | | | | | | | | | | and remaining comments of 5005002. See http://codereview.chromium.org/5005002. BUG=48930 TEST=none Review URL: http://codereview.chromium.org/5537002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68573 0039d316-1c4b-4281-b951-d872f2087c98
* Fix browser crash in ExtensionPrefs.finnur@chromium.org2010-12-081-0/+2
| | | | | | | | | | | | | | | | | | I am unable to repro this, despite numerous attempts, but from looking at the crash dump it seems that we get a valid ExtensionPrefs pointer but a NULL DictionaryValue pointer. Looking at the other callers for GetExtensionPref shows that they all expect a potentially NULL result, for example in GetExtensionState (which even documents that it can be NULL for --load-extension). I think a NULL check here is therefore in order too. BUG=64853 TEST=QA will need to test this manually because I can't get it to crash for me. Review URL: http://codereview.chromium.org/5601005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68572 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Fixed crash on XMPP reconnectionakalin@chromium.org2010-12-0810-58/+241
| | | | | | | | | | | | | | | Tied lifetime of invalidation packet callback to ChromeInvalidationClient. Added some tests for ChromeInvalidationClient. Created FakeBaseTask class for testing. BUG=64652 TEST=New unittests Review URL: http://codereview.chromium.org/5625010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68571 0039d316-1c4b-4281-b951-d872f2087c98
* Mark BrowserKeyEventsTest.ReservedAccelerators as flaky.phajdan.jr@chromium.org2010-12-081-1/+2
| | | | | | | | | | | TBR=suzhe BUG=65847 TEST=interactive_ui_tests Review URL: http://codereview.chromium.org/5572006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68570 0039d316-1c4b-4281-b951-d872f2087c98
* Teach PPAPI proxy to share image memory on Mac OS Xabarth@chromium.org2010-12-087-76/+159
| | | | | | | | | | | | | | | | | Instead of just using base::SharedMemory, we use SysV shared memory on Linux so that we can share memory with X. Normally we abstract this detail away with TransportDIB, but the TransportDIB lives in chrome/app, which is outside the dependency cone of ppapi/proxy. This patch creates a new abstraction at this layer of the dependency graph called ImageData::ImageHandle that represents shared memory for the purpose of image data. This patch also fills in the implementation of this abstraction on Mac OS X. Consequently, out-of-process PPAPI plugins on Mac can now draw to the screen. Review URL: http://codereview.chromium.org/5658003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68569 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up automation provider side:phajdan.jr@chromium.org2010-12-084-215/+145
| | | | | | | | | | | | | | | - remove unneeded code - get rid of poorly written code like private inheritation - simplify the thread-related code - remove a few fatal assertions from test code - minor style cleanups BUG=none TEST=none Review URL: http://codereview.chromium.org/5510002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68568 0039d316-1c4b-4281-b951-d872f2087c98
* Make webkit/glue/plugins no longer depend on ppapi/proxy directly. This causesbrettw@chromium.org2010-12-0815-205/+263
| | | | | | | | | | | | | things that use webkit but otherwise don't need IPC to include the IPC directory. This patch moves the set-up of the proxy into the renderer. I also did a lot of clean-up of the initialization and it seems much nicer now. BUG=63684 TEST=manual PPAPI proxy testing git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68567 0039d316-1c4b-4281-b951-d872f2087c98
* Adds NULL checks to AeroPeekManager.hbono@chromium.org2010-12-081-9/+25
| | | | | | | | | | This change just adds NULL checks to prevent crashes when TabStipModel calls its observers with NULL pointers. BUG=63854 TEST=launch Chromium with a '--enable-aero-peek-tabs' option. Review URL: http://codereview.chromium.org/5275004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68566 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 73455:73487.yutak@chromium.org2010-12-081-1/+1
| | | | | | | | | | TBR=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/5652003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68563 0039d316-1c4b-4281-b951-d872f2087c98
* Fix support for --disable-extensions flag.jstritar@chromium.org2010-12-083-17/+60
| | | | | | | | | BUG=65137 TEST=ExtensionsServiceTest Review URL: http://codereview.chromium.org/5533005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68560 0039d316-1c4b-4281-b951-d872f2087c98
* Roll deps for Skia r626:632.thestig@chromium.org2010-12-081-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5606010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68558 0039d316-1c4b-4281-b951-d872f2087c98
* Addressing code review comments from Tommi from the orignal CL ↵ananta@chromium.org2010-12-081-10/+9
| | | | | | | | | | | http://codereview.chromium.org/5632003/ BUG=65295 TEST=As described in the bug Review URL: http://codereview.chromium.org/5535008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68554 0039d316-1c4b-4281-b951-d872f2087c98
* Provide a safety net for Windows hooks.mad@google.com2010-12-085-8/+58
| | | | | | | | | | | | | As mentioned in http://crbug.com/65655, we have seen cases where the IE process would crash in a Windows Hook called after static uninitialization. We are guessing that this occurs when the thread running the CEEE BHO got terminated without tearing down the BHO and thus we never unhooked. This CL adds a module level set of hooks to be unhooked when the module gets terminated (before the static uninitialization). BUG=65655 TEST=None Review URL: http://codereview.chromium.org/5544014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68552 0039d316-1c4b-4281-b951-d872f2087c98
* Update perf expectations after V8 roll.chase@chromium.org2010-12-081-5/+5
| | | | | | | | | | | | | | | | | | | | | | | v8_benchmark improved on the following platforms after r68477: - linux-release-hardy v8_benchmark - mac-release-10.5 v8_benchmark - mac-release-10.6 v8_benchmark - vista-release-dual-core v8_benchmark - xp-release-dual-core v8_benchmark We should be curious about the linux-release-hardy results, which don't show a score increase like the other platforms. BUG=none TEST=v8_benchmark is green TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/5573012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68551 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Fix leak in PluginList by actually calling Shutdown().thestig@chromium.org2010-12-081-1/+2
| | | | | | | | | BUG=none TEST=Valgrind goes green this time. TBR=bauerb Review URL: http://codereview.chromium.org/5574005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68550 0039d316-1c4b-4281-b951-d872f2087c98
* Update WebKit to r73455.pkasting@chromium.org2010-12-081-1/+1
| | | | | | | | | BUG=none TEST=none TBR=yutak Review URL: http://codereview.chromium.org/5578006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68549 0039d316-1c4b-4281-b951-d872f2087c98
* Re-design the phishing interstitial page. The change is mostly about: make ↵lzheng@chromium.org2010-12-083-18/+57
| | | | | | | | | | | | | | | the 'go back' button big and green in a central place, and put the 'proceed' into a link at the bottom of the page. sample screenshot: https://docs1.google.com/document/d/1peJV0yfVSgjbdydInshy8FSU2Q9kUivTtdyMpIDIP1w/edit?authkey=CLCQl9sE# Patch from Ke Wang <kewang@google.com> BUG=60813 TEST=unit_tests. To see the UI change, start the browser and try load some sites in malware blacklist. Review URL: http://codereview.chromium.org/5560003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68548 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 04:54:06 +0000