| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Linux interactive_ui_tests were sad.
TBR=zmo@google.com
Review URL: http://codereview.chromium.org/3330009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sleeping is an unreliable method to wait for things.
Instead, we set up an observer.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3300011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3310013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
rare at least).
BUG=53991
TEST=no
TBR=aa
Review URL: http://codereview.chromium.org/3305011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the fork, before we do any mach IPC.
The MachPortSender constructor can sometimes hang forever (gets stuck in bootstrap_look_up()), so it is important to reset the child's signal handlers as early as possible.
Nico would like me to mention that this was his idea.
BUG=35374
TEST=If in the forever backwards spinner state, closing the tab should not quit the browser.
TEST=In general, renderers and extensions and plugins should still work.
Review URL: http://codereview.chromium.org/3302009
TBR=rohitrao@chromium.org
Review URL: http://codereview.chromium.org/3322013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:6441 (valgrind error)
TEST=Run Valgrind, verify it doesn't fail in PowerMenuButton.
Original CL: http://codereview.chromium.org/3158014/show
Two changes:
1. Re-ordered the member variables so that members used by GetLabelAt() are initialized before power_menu_ which calls into GetLabelAt().
2. Modified GetLabelAt() to explicitly check for index == 1 for the second line, just for clarity.
Review URL: http://codereview.chromium.org/3291010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
before we do any mach IPC.
The MachPortSender constructor can sometimes hang forever (gets stuck in bootstrap_look_up()), so it is important to reset the child's signal handlers as early as possible.
Nico would like me to mention that this was his idea.
BUG=35374
TEST=If in the forever backwards spinner state, closing the tab should not quit the browser.
TEST=In general, renderers and extensions and plugins should still work.
Review URL: http://codereview.chromium.org/3302009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=rafaelw@chromium.org
BUG=39963
TEST=none
Review URL: http://codereview.chromium.org/3361006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53978
TEST=Install an app. Expand and collapse sections. Things should swish.
Review URL: http://codereview.chromium.org/3346006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
product logo.
BUG=53970
TEST=
Review URL: http://codereview.chromium.org/3336004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The removed directories are:
bar
bar/toolbar
bar/toolbar/cld
bar/toolbar/cld/i18n
gcl does not show any of them and does not even allow uploading the cl. So, I removed the empty line (last line) in README.chromium for the recording purpose.
BUG=None
TEST=CLD builds just fine.
TBR=jcivelli
Review URL: http://codereview.chromium.org/3329011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
test_shell side of the DRT changes in https://bugs.webkit.org/show_bug.cgi?id=45155 .
BUG=none
TEST=New version of layout test on https://bugs.webkit.org/show_bug.cgi?id=45155 should pass.
Review URL: http://codereview.chromium.org/3329010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=""
TESTED=
Review URL: http://codereview.chromium.org/3326012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
off for applications/extensions in M7. This change is aiming for a small diff, since I'm going to turn it right back on once this is cherrypicked. Thus there's some small redundancy, e.g. in render_view.cc.
BUG=45881
TEST=included
Review URL: http://codereview.chromium.org/3324002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to just 'Spdy'.
Now, instead of tests being named:
SpdyNetworkingTest/SpdyNetworkTransactionTest.Foo
they are
Spdy/SpdyNetworkingTest.Foo
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3354007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
UI Tests currently leaks a temp dir which contains another empty dir named
test_user_data which appears to be unused. Get rid of it, so that we don't
create and leak temp dirs.
BUG=54271
TEST=No leftover temp dir when running ui_tests or pyauto tests
Review URL: http://codereview.chromium.org/3333013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Verify screen reader accessibility during events like nagivating toolbar or menus.
Review URL: http://codereview.chromium.org/3292007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are two categories of operations that can be performed on the Chrome OS owner-signed settings store:
1) doing stuff to the whitelist (adding/removing/checking)
2) Storing/Retrieving arbitrary name=value pairs
Unfortunately, it is currently a limitation that only one of a each category can be in-flight at a time. I've filed an issue on me to remove that restriction.
The pattern of use here is that the caller instantiates some subclass of SignedSettings by calling one of the create methods. Then, call Execute() on this object from the UI thread. It'll go off and do work (on the FILE thread and over DBus), and then call the appropriate method of the Delegate you passed in -- again, on the UI thread.
BUG=chromium-os:4488
TEST=Unit tests
Review URL: http://codereview.chromium.org/3345002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Use string16 instead.
BUG=23581
Review URL: http://codereview.chromium.org/3200010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test flaking out closed the tree earlier today.
TBR=phajdan.jr
BUG=54445
TEST=net_unittests ... ConnectClientAuthCertRequested
Review URL: http://codereview.chromium.org/3332005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
server.
Review URL: http://codereview.chromium.org/3327010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
redundant, so it is removed. Next changelist will refactor the way we do
headers from the HttpNetworkTransaction, which will move the header logging
back into the stream. then I think I'm done.
BUG=53956
TEST=none
Review URL: http://codereview.chromium.org/3331012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
failures, unfortunately so I haven't been able to test.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3322012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
VideoDecodeEngine doesn't need refcounting, all decode engines live on one
thread so there isn't a problem posting task to a random thread. Also
the stop is asynchronous, we can always until the stop is done before we
destroy the object and doesn't need refcounting to destroy it.
TEST=media_unittests
Review URL: http://codereview.chromium.org/3125032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is not directly
caused by ChromeFrame as such and occurs because of buggy IE plugins which intercept urlmon
and wininet and crash due to these dlls being unloaded while leaving vtable patches or hooks
in place.
Approach we are attempting is to use the Chrome HTTP stack via the URLFetcher object to
upload UMA data.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=54419
Bug=54419
Review URL: http://codereview.chromium.org/3296006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This class creates features for n-grams in the page text that appear in the
phishing classification model. It will eventually operate on the plain text
that is extracted by RenderView::CaptureText().
To make it harder for phishers to enumerate the terms in the classification
model, they will be supplied as SHA-256 hashes rather than plain text. The
term feature extractor hashes the words in the document in order to check
whether they match the model. Since this is potentially expensive, the term
feature extractor limits how long it will run on each iteration, similar to
the PhishingDOMFeatureExtractor.
TEST=PhishingTermFeatureExtractorTest
BUG=none
Review URL: http://codereview.chromium.org/3214002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=all tests still pass, notably nacl_ui_tests
Review URL: http://codereview.chromium.org/3357008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=visit chrome://net-internals and [::1] in a debug build, it shouldn't crash
BUG=NONE
Review URL: http://codereview.chromium.org/3359006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If host resolution is restricted to a single address family and the results of a resolution are all localhost of that type, try again without the address family restriction.
Also make --disable-ipv6 apply to resolution of ip literals.
BUG=42058, 49024, 32522
TEST=Manual testing in various network configurations. See https://spreadsheets.google.com/ccc?key=0AhSnKEusL6UgdFZIRmxTUnYtZDhjX3lKclBqMHo4YUE&hl=en&authkey=CLKDxMYB
Review URL: http://codereview.chromium.org/3231005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/3342009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
windows.
It's that large.
TBR=nsylvain
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3296005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53915
TEST=ExtensionsServiceTest.ExternalPrefProvider
Review URL: http://codereview.chromium.org/3233008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53127
TEST=chrome_frame_helper.exe connects to the crash process.
Review URL: http://codereview.chromium.org/3287008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Just use a NewRunnableMethod task posted to the IO thread. The RDH
is guaranteed to live longer than the IO thread.
BUG=48913
TEST=none
Review URL: http://codereview.chromium.org/3331009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual, use speech input on windows and verify that the popup has a cancel button.
Review URL: http://codereview.chromium.org/3367009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:5601 (http://code.google.com/p/chromium-os/issues/detail?id=5601)
TEST=Check that hover text over status bar icons seems reasonable. Test different states of network (disconnected, ethernet, connecting to a wifi network, connected to a wifi network) and battery (plugged in, unplugged).
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57234
Review URL: http://codereview.chromium.org/3158014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change makes it two points larger than the popup and
tab text. I am hesitant to make a similar change to the
GTK version, at least in this change, since there have
already been a bunch of omnibox-font-sizing problems there.
BUG=50568
TEST=built and tried it
Review URL: http://codereview.chromium.org/3181023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
added during http://src.chromium.org/viewvc/chrome?view=rev&revision=57989.
BUG=53875
TEST="error" in the log is not followed by a ':' and an error code.
Review URL: http://codereview.chromium.org/3316002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also simplifies the way initial window state is set, by sending the same message
that's used for later changes just after initialization instead of adding
parameters to the init message. While this means we send one more async message
if the plugin's renderer is visible, we remove an unnecessary synchronous call
to the browser procces for plugins in background tabs, and we defer that
synchronous call until after plugin initialization has started in the visible
case.
BUG=51391
TEST=Plugins loaded in a foreground page should react to keystrokes without having to switch tabs. Mouseovers should continue to work as before.
Review URL: http://codereview.chromium.org/3356006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Revert r58230.
BUG=54305,53138
TEST=Make sure ethernet is plugged in. Run Chrome. Unplug ethernet. Does not crash.
Review URL: http://codereview.chromium.org/3350009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In this patch a ggl::Context is connected to the GpuVideoDecoderHost in the
renderer process. In the GPU process the GpuVideoDecoder is connected to a
gles2::GLES2Decoder.
These changes will be used in the future to switch context before issuing
video decode commands. This is also needed by the GPU process to translate
a client texture ID to a service texture ID in the GPU video decoder.
BUG=53714
TEST=none
Review URL: http://codereview.chromium.org/3266008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=53714
A GpuVideoDecodeServiceHost needs to be connected with a ggl::Contect and its
associated comand buffer for the following reasons:
1. The gpu video decoder in gpu process needs to be in the correct GLES2 context.
2. On context lost the gpu video decoder needs to destroy itself.
This patch is able to connect the GpuVideoDecoderHost to the context although
the context is not passed into the decoder, so the code path is currently broken.
In a future patch we need to do the following:
1. Inject a ggl::Context into IpcVideoDecoder.
2. Complete the plumbing so that inside the gpu process we can associate a
video decoder with a GLES2 context.
Review URL: http://codereview.chromium.org/3215008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
for now to avoid
regressions in look or startup time penalty. Once the compositor is baked in a bit better we can
look into re-enabling them.
BUG=51691
TEST=NONE
Review URL: http://codereview.chromium.org/3315011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
WebKit roll.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=54345
TEST=gcf:http://www.google.com should not work by default
and should work only if 'AllowUnsafeURLs' is set to a
non-zero value in registry.
Review URL: http://codereview.chromium.org/3365008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Quit the message loop by posting a quit task instead of calling quit directly.
BUG=
TEST=
Review URL: http://codereview.chromium.org/3342012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=54417
TEST= install chrome. during install, click on another app. search engine dialog should appear on top.
Review URL: http://codereview.chromium.org/3350008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
That way, we can remove default entries in app_locale_settings_*.xtb files. This
doesn't make any change in the build output.
I realize this 'problem while reviewing http://codereview.chromium.org/3275008
In addition, I increased the minimum font size for Indic locales and Thai to 10 (Hindi and Arabic already have that set to 10. For other Indian languages and Thai, 5 is too small).
BUG=NONE
TEST=Build works fine on Windows.
Review URL: http://codereview.chromium.org/3323003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need to fill the part of the RWHVMac not covered by the compositor subview with white.
Resizing smaller is still a bit jumpy. We also still paint an uninitialized IOSurface every now and then.
BUG=53165
TEST=Enable compositor, make window larger. Right bottom part of window shouldn't be transparent.
Review URL: http://codereview.chromium.org/3319004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58504 0039d316-1c4b-4281-b951-d872f2087c98
|