| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* implement some stubbed functions
* comment out some unimplemented IPC calls
* hack a webcontents widget into BrowserWindow so that something displays
Review URL: http://codereview.chromium.org/20204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- history
- autocomplete
- bookmarks
These were all reviewed separately but turned out to be interdependent. :~(
Review URL: http://codereview.chromium.org/21170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glen
Review URL: http://codereview.chromium.org/24007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Split FD tests into a separate file in preparation for additional tests.
Review URL: http://codereview.chromium.org/20202
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
For example, ./Hammer/chrome --renderer-cmd-prefix="gdb --args"
Review URL: http://codereview.chromium.org/21190
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I forgot to to update the browser_resources.rc path in
unit_tests.vcproj.
TBR=deanm
Review URL: http://codereview.chromium.org/21196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The computed-style tests needed to have the text output
rebaselined since the expectations have changed upstream.
The text-overflow-ellipsis test looks like it is working
to me (only difference I see is that our font doesn't look
like the Mac font, which is expected).
Review URL: http://codereview.chromium.org/21189
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=amanda
Review URL: http://codereview.chromium.org/21193
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
refactoring. More cleanup. Change tabstrip layout to match opaque frame.
BUG=5054
Review URL: http://codereview.chromium.org/20161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
under C:\Program Files (x86) instead.
R=dglazkov
Review URL: http://codereview.chromium.org/25001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
Review URL: http://codereview.chromium.org/20197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
handle.
Constructor added to both _win and _posix implementations and provided a unit test.
Review URL: http://codereview.chromium.org/20137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Account for the renaming of toRange to toNormalizedRange done by Eric Seidel.
R=amanda
Review URL: http://codereview.chromium.org/20192
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
side.R=darin,brettw
Review URL: http://codereview.chromium.org/19725
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/fast/canvas/toDataURL-supportedTypes.html. We won't fully
support this until we support GIF/JPG encoders, which isn't going to
happen soon.
BUG=none
TEST=none
TBR=tc
Review URL: http://codereview.chromium.org/23015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test redirects to a hanging page implemented with a php script.
Because of some network stack related issue (see https://bugs.webkit.org/show_bug.cgi?
id=9001#c9), the script sends few chars causing the test to fail for us.
We could fix it but that would require changing the user-agent of the test_shell.
Following Darin's suggestion of skipping for now and implementing the user-agent if more cases like these happen.
Review URL: http://codereview.chromium.org/20160
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Quite a bit of TODOs in the code, but it displays and properly
enables/disables buttons and routes mouse clicks.
This also moves all the gtk files into the gtk/ folder, at Ben's request.
Review URL: http://codereview.chromium.org/21176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that my color change landed everything looks good with this
test. Have to rebaseline because of font differences, and color
conversion differences.
BUG=2969
TEST=none
Review URL: http://codereview.chromium.org/20193
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
We now hit the TabContentsDelegate in temp_scaffolding_stubs.h.
Review URL: http://codereview.chromium.org/21178
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I removed the flatten_html visual studio rule and just rolled the
functionality directly into GRIT.
The sln change is to have browser depend on browser_resources (now needed for browser_resources.h).
Review URL: http://codereview.chromium.org/21148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
It doesn't seem to occur anywhere in the SCons code nor in ours(?).
Review URL: http://codereview.chromium.org/20174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r9411.
Brett's revert requires this.
TBR=brettw
Review URL: http://codereview.chromium.org/20194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20190
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and state are now tracked and configurable.
Review URL: http://codereview.chromium.org/21177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
* Implement no-op sandbox functions.
* Fix up the --renderer-startup-dialog dialog.
Review URL: http://codereview.chromium.org/20186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=mad
Review URL: http://codereview.chromium.org/20187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To display a resize bitmap and handle the mouse interactions as requested in
http://code.google.com/p/chromium/issues/detail?id=458.
BUG=458
There are unfortunately two cases to handle and they must be handled separately.
The first one is when there are no bottom shelf like the download bar,
and the case where there is one.
For the case without, we must draw on top of what we receive from WebKit,
so we intercept the bitmap in RenderWidgetHostViewWin::OnPaint() so that we
can draw the resize corner bitmap on top of it (taking into account whether
we are in a right to left language or not).
For the case where we have a bottom shelf, we use a dedicated view that we
properly layout on top of the bottom shelf view (which takes care of handling
the RTL language case for us).
Same split for the mouse interactions. Without the bottom shelf, we must deal
with it in RenderWidgetHostViewWin::OnMouseEvent() by sending the root window
a WM_NCLBUTTONDOWN message with either HTBOTTOMRIGHT or HTBOTTOMLEFT (based on
the RTL setting) and let the OS take care of the resizing. IF we have a bottom
shelf, we must deal with the mouse interaction in
BrowserView::NonClientHitTest()
to either return HTBOTTOMRIGHT or HTBOTTOMLEFT (again, based on the RTL setting)
and, again, let the OS take care of the resizing.
More details here:
http://code.google.com/p/chromium/wiki/BrowserViewResizer
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GtkContainer to a GtkFixed container.
Our previous custom container did not track its children, which meant it couldn't propagate size-request and size-allocate. In some ways this is what we wanted, however it prevented GtkSocket from running some important code. Specifically an expose event wouldn't trigger initially on the GtkSocket, leaving the widget window unpainted.
Instead of writing / copying container code to manage children, it is much easier if we can reuse an existing container. This changes makes the drawing area a GtkFixed backed by a GdkWindow, and we paint into its window. We implement a small custom widget around GtkSocket, which allows us to control the size requisition phase. This solves the problem of controlling the GtkSocket layout within the container.
Plugins are now painted correctly, without having to jiggle the scrollbar.
This change additionally groups all of the widget code in a class of statics. GtkFixedSocket implements the GtkSocket with custom size requisition. WebWidgetHostGtkWidget is just a GtkFixed with a window, along with the signal connection handlers.
This also means we'll have no custom container implementation to share across test_shell and the browser.
It seems we still don't handle keyboard focus exactly right, and youtube videos still need mouse events to repaint. I believe these are subtle issues, and can be solved while keeping the GtkFixed container approach.
Review URL: http://codereview.chromium.org/20128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
corresponding (disabled) unit test.
Issue=1503
Review URL: http://codereview.chromium.org/23013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20178
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
its registered commands.
Review URL: http://codereview.chromium.org/20180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
not close the process handle that they do not own.
Review URL: http://codereview.chromium.org/24004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
worker context.
For now, we still execute the worker script in the same renderer process with v8 locker. It will be rerouted once we have worker process ready.
Review URL: http://codereview.chromium.org/18821
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
locally so I am checking this in again and debugging
live.
TBR=nsylvain (already reviewed by mbelshe)
Review URL: http://codereview.chromium.org/21175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was caused by a change in the PopupMenuChromium where the popup would first hide itself before setting the selection.
We use to delete our client on hide, causing a crasher when setting the selection.
This new CL makes the autocomplete popup and client live as long as the WebView is alive and the WebView reuse them (we just hide the popup when necessary).
TEST=In a form, type some text in an input field. Make sure the autocomplete popups up and behaves as expected.
BUG=7435
Review URL: http://codereview.chromium.org/21153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mark
Review URL: http://codereview.chromium.org/20184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Relanding merge for the third time. Darin will fix mac build.
Review URL: http://codereview.chromium.org/20183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Merge still broken on a mac clobber build.
Review URL: http://codereview.chromium.org/20182
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Try again to land webkit merge.
Review URL: http://codereview.chromium.org/21173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9393 0039d316-1c4b-4281-b951-d872f2087c98
|