| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This also rewrites the affected UI bits to make it easier to do this, get rid of unnecessary code, and be more consistent with the blocked content bubble code.
BUG=32719
TEST=Content settings windows now have radio buttons that work, and remember their settings. The Flash link works too.
Review URL: http://codereview.chromium.org/558060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32719
TEST=none
Review URL: http://codereview.chromium.org/549218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=pkasting
Review URL: http://codereview.chromium.org/552247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes:
1- net::CookiePolicy becomes an interface.
2- Old implementaiton of CookiePolicy copied to StaticCookiePolicy.
3- ChromeULRRequestContext implements CookiePolicy.
4- HostContentSettingsMap gets a global "BlockThirdPartyCookies" pref.
R=pkasting
Review URL: http://codereview.chromium.org/556095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
message loop on receiving the
NewWindow event as it needs to ensure that the new popup window shunted correctly into Chrome.
This should ensure that this test passes now.
TBR=amit
Review URL: http://codereview.chromium.org/548213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=pkasting
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/555187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extract button dragging out of BookmarkButton into DraggableButton. Make BookmarkButton a subclass of DraggableButton. Create new class DownloadItemButton and make it a subclass of DraggableButton.
xib change: Make download item a DownloadItemButton instead of an NSButton.
BUG=15776
TEST=Download something, wait for it to complete, then drag it from the download shelf to somewhere. It should now work. Bookmarks should still be draggable in the bookmarks bar.
Review URL: http://codereview.chromium.org/180036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=sky
BUG=33314
TEST=none
Review URL: http://codereview.chromium.org/558059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=33314
TEST=none
Review URL: http://codereview.chromium.org/558056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
won't compile them.
TBR=darin
BUG=33314
TEST=none
Review URL: http://codereview.chromium.org/553165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=33314
TEST=none
Review URL: http://codereview.chromium.org/557069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
hooked to anything, so they'll never appear.
BUG=33314
TEST=none
Review URL: http://codereview.chromium.org/556077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently this limit is very high (50), but it can be tuned through a variable.
BUG=9598
TEST=
HostResolverImplTest.HigherPriorityRequestsStartedFirst
HostResolverImplTest.CancelPendingRequest
HostResolverImplTest.QueueOverflow
Review URL: http://codereview.chromium.org/542086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Build builds
Review URL: http://codereview.chromium.org/556088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Interface not well-designed for the actual uses
* Objects in URL request context must be refcounted since Profile is destroyed before the UI thread
BUG=33314
TEST=none
Review URL: http://codereview.chromium.org/555184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/557068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/553162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/553160
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=33606
TEST=none
Review URL: http://codereview.chromium.org/548210
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
patch by Dominic Mazzoni <dmazzoni [at] google>
review url: http://codereview.chromium.org/402099/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gets destroyed before the IO thread.
Also some other random misc. cleanup.
TBR=darin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/554140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Persist changes from Incognito (per UI leads)
* Clear the zoom settings when the user does "reset to defaults" in prefs
BUG=none
TEST=Open incognito, change a zoom level, restart, see that it's persisted
Review URL: http://codereview.chromium.org/551213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
before setting the WebKit client to NULL.
TEST=none
BUG=32228,32226
Review URL: http://codereview.chromium.org/545178
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=yaar
Review URL: http://codereview.chromium.org/548212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
omx_test now uses FFmpeg demuxer and bistream converters. It
can now parse mp4 files and convert them to H264 Annex B stream
for input to OpenMAX decoder.
Also refactored the file to move different reader methods to
separate classes.
BUG=32753
TEST=this is a test by itself
Review URL: http://codereview.chromium.org/556032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(This was clearly wrong; I can't believe I was the first
to notice it.)
Also added some alt text, while I was in there.
TEST=none
BUG=none
TBR=aa
Review URL: http://codereview.chromium.org/555181
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
run, or rather if run completes and another message comes
through. This can happen during tests and the windows side explicitly
allows this case to work.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/558048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bypass the host network stack.
In this case we don't get control over the navigation as window.open calls expect to carry the opener
relationship over to the new window. This basically means that navigation occurs in Chrome and the
new tab/window created by the host attaches to the newly created ExternalTabContainer instance.
In IE8 the new tab opens in a new IE process, which basically uses a new automation channel to talk to
Chrome. The host network stack implementation routes network requests issued by registered render views
to the host browser over the automation channel. There is a timing window between the new window getting
created and issuing network requests and the channel being established with the new iexplore instance.
As a result network requests issued by the new window don't use the host network stack.
Fix is to register the render view and process as a pending view when we get notified about the new TabContents
in the original ExternalTabContainers implementation of TabContentsDelegate::AddNewContents. Any network requests
issued for this view would result in the corresponding URLRequestAutomationJob instances getting created as
pending as well. When the host browser connects to the new ExternalTabContainer instance, we pass over the new
automation channel and tab handle to the URLRequestAutomationJob instances and resume them.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=33516
Bug=33516
Test=Login to gmail in IE8 in ChromeFrame. Open up a new conversation and click on New Window which opens up
a tear off window. This should not bring up the login prompt again.
Will think about a good approach to write a unit test for this behavior and send out a separate CL for that.
Review URL: http://codereview.chromium.org/554134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Make sure unit tests still pass.
BUG=33332
Review URL: http://codereview.chromium.org/555178
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts the page's text to its original (pre-translation) value.
BUG=None
TEST=None
Review http://codereview.chromium.org/554104/show
Review URL: http://codereview.chromium.org/555175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
processes on 64bit Windows systems.
BUG=28176
TEST=none
Review URL: http://codereview.chromium.org/542030
TBR=gregoryd@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/554138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Windows systems.
BUG=28176
TEST=none
Review URL: http://codereview.chromium.org/542030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=cira
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/558050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
NOTE: The clipboard backend is not working on Mac yet.
BUG=4890
TEST=Manually try Ctrl+C, Ctrl+V, Shift+Insert etc and also try from the old bookmark manager to the new bookmark manager
Review URL: http://codereview.chromium.org/551200
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=existing tests apply + valgrind
Review URL: http://codereview.chromium.org/552236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved IsValidName to public (where it was before the change),
and made test cases for it cleaner by explicitly using std::string() around var name. Template IsValidName method had to be defined within .h file to avoid linking error on mac release build.
Add reserved messages to ExtensionMessageBundle dictionary. They are of the form @@somename, i.e. @@ui_locale.
TEST=If user specified any reserved messages in the messages.json we should show error. In memory dictionary should have @@ui_locale set to current Chrome UI locale.
Review URL: http://codereview.chromium.org/555159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
info bar telling the user that the extension has crashed should disappear in ALL windows should the user choose to hit the 'reload' button.
NOTE: If the user 'x's out the info bar, the bars in the other windows will remain.
BUG=33396
TEST=none
Review URL: http://codereview.chromium.org/548206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the following functions:
copy(idList)
cut(idList)
paste(parentId)
canPaste(parentId, callback)
BUG=32194
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.BookmarkManager
Review URL: http://codereview.chromium.org/557050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is required to support the fast/harness/override-preferences.html layout test.
TBR=pkasting
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/555179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=31297
TEST=none.
Review URL: http://codereview.chromium.org/557064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to result in ERR_NO_SUPPORTED_PROXIES rather than falling back to DIRECT.
BUG=32316
TEST=
No unit-test yet.
To test manually:
(1) create a PAC script with contents:
function FindProxyForURL(url, host) {
throw "FAILURE!"
}
(2) Change the proxy settings to point at this file (can use a file:// URL if it is local).
(3) Load http://www.google.com/. Should succeed. Without the bug fix, it would fail with ERR_NO_SUPPORTED_PROXIES.
Review URL: http://codereview.chromium.org/549204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebMessagePortImpl::postMessage() now frees the incoming WebMessagePortArray when it
is done with it.
TEST=none (existing tests suffice)
BUG=22932
Review URL: http://codereview.chromium.org/342082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/548209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
origin basis.
BUG=none
TEST=get permission and create notifications
Review URL: http://codereview.chromium.org/553144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Still lacks UI polish
BUG=33026
TEST=can be tested for functionality and UI presence, but not for controls size/position/color
Review URL: http://codereview.chromium.org/549208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Thanks go to Jeff Bailey for writing most of this CL.
Also, bump version to 0.1.43.1 so that it exceeds the version of the previous O3D packages.
TEST=build, install, and run on Ubuntu
Review URL: http://codereview.chromium.org/556071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=33077
TEST=See bug.
Review URL: http://codereview.chromium.org/556082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
extent are URLPatterns, like other parts of the extension system.
Review URL: http://codereview.chromium.org/552209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37559 0039d316-1c4b-4281-b951-d872f2087c98
|