| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:7037
TEST=ExtensionsserviceTest.External*,ExtensionManagementTest.ExternalUrlUpdate
Review URL: http://codereview.chromium.org/3966001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20(ChromiumOS%20dbg)/builds/1895/steps/ui_tests/logs/LoadOptionsByURL )- Add LeakTracker<URLRequestContext> to IOThread::CleanUp().
Move LeakTracker<URLRequest> up to CleanUp also. No URLRequest should be getting killed in DestructionObservers anymore.
BUG=59630
TEST=existing
Review URL: http://codereview.chromium.org/4064004
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/4069002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
webkit_glue::BufferedDataSource::ReadInternal)
Suppress uninitialized reads/writes in SQLite (bug 60556)
Add a new suppression for bug 19775 (leak in SQLite)
TBR=shess
BUG=60556,60381,19775
Review URL: http://codereview.chromium.org/4070004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
version of the host IE browser.
BUG=52601
TEST=[chrome_frame_unittests / UtilTests.XUaCompatibleDirectiveTest], [chrome_frame_tests / HeaderTest.*]
Review URL: http://codereview.chromium.org/3978001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
constructor. This needs to be done so the browser launch arguments can include the correct port in the mapping rules.
I considered adding an ASSERT in the constructor, but this warns against it:
http://code.google.com/p/googletest/wiki/AdvancedGuide#Assertion_Placement
BUG=56814
TEST=ui_tests --gtest_filter="*TestIsSearchProviderInstalled*"
Review URL: http://codereview.chromium.org/4007011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I've missed these stacks:
==2556== T0 (L{}):
==2556== #0 scoped_refptr<net::GrowableIOBuffer>::operator-> base/ref_counted.h:245
==2556== #1 remoting::TCPChannelTester::CheckResults remoting/protocol/jingle_chromoting_connection_unittest.cc:291
...
==2556== T11 (L{}):
==2556== #0 scoped_refptr<net::GrowableIOBuffer>::operator= base/ref_counted.h:264
==2556== #1 remoting::TCPChannelTester::InitBuffers remoting/protocol/jingle_chromoting_connection_unittest.cc:306
BUG=60536
TEST=TSan/Win should go green
TBR=glider
Review URL: http://codereview.chromium.org/3969007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49600
TEST=manual
Review URL: http://codereview.chromium.org/4005008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=57832
TBR=glider
Review URL: http://codereview.chromium.org/3979014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactors a few functions from nsNSSCertHelper into common.
(no functional change when using NSS).
Implements some of the x509_certificate_model functions for OpenSSL.
BUG=none
TEST=Compile w/ use_openssl=1, check that the fields in certificate viewer are displayed.
Review URL: http://codereview.chromium.org/3815012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=57277
TEST=NPAPIVisiblePluginTester.ClickToPlay:ClickToPlayPluginTest.*
Review URL: http://codereview.chromium.org/3539002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60536
TBR=glider
TEST=TSan/Win should go green
Review URL: http://codereview.chromium.org/3977008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Extensions that are silent-installed by an admin policy will have EXTERNAL_POLICY_DOWNLOAD set as their locations. It will not be possible to uninstall them and they will be silently updated.
BUG=59782
TEST=none
Review URL: http://codereview.chromium.org/3938005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
login, with a different UI container that is built on the new tab-modal constrained html dialogs.
Hooked it up to the webstore extensions api with the desired behavior of turning on apps sync after a successful webstore login.
BUG=56383
TEST=manual only for now
Review URL: http://codereview.chromium.org/4033001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
call on TCP disconnect.
The failures which caused me to revert the original looked sporadic. Relanding.
The HttpProxyClientSocket reuses the same TcpClientSocket in the case that it is trying to establish a tunnel through
an authenticating proxy, but the proxy closed the TCP connection.
Also, fix SetOmniboxSpeculation on the TCPClientSocket implementations.
BUG=54062
TEST=Tried normal connections to make sure histograms were only emitted once, as well as https tunnels through an authenticating proxy to ensure that the use_history was correctly reset.
Review URL: http://codereview.chromium.org/3360007
TBR=cbentzel@chromium.org
Review URL: http://codereview.chromium.org/4006004
TBR=cbentzel@chromium.org
Review URL: http://codereview.chromium.org/3978008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://code.google.com/p/chromium-os/issues/detail?id=7950
TEST=manual
Review URL: http://codereview.chromium.org/3952001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
new tab contents approach.
BUG=57885
TEST=none
Review URL: http://codereview.chromium.org/4030002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=dglazkov,loislo
Review URL: http://codereview.chromium.org/4041004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This policy and preference will hold the list of extensions that should be
silently installed.
BUG=59782
TEST=none (real logic comes in later CLs)
Review URL: http://codereview.chromium.org/4014007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The execution time of the test is close to the timeout, so I split it in two. Also, I'm now loading the second iframe in the onload hook of the first iframe, so hopefully it's less flaky.
BUG=60229
TEST=*.WebNavigationEvents*
Review URL: http://codereview.chromium.org/3979006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add command-line override for testers that don't want the throttle.
BUG=60369
TEST=
Review URL: http://codereview.chromium.org/3977007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=dglazkov
Review URL: http://codereview.chromium.org/3967005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11321
TEST=Exercise the default zoom level setting in the 'Under the hood' panel.
Review URL: http://codereview.chromium.org/3807001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
tree to be green even for FLAKY and FAILS tests, so I am marking it as DISABLED.
BUG=56033
Review URL: http://codereview.chromium.org/4043006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=dglazkov
Review URL: http://codereview.chromium.org/3989007
TBR=yuzo@chromium.org
Review URL: http://codereview.chromium.org/4046006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=dglazkov
Review URL: http://codereview.chromium.org/3989007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
doesn't suffer the plethora of threading issues that exist with the
current version. Here's the breakdown of what was refactored:
. TopSitesCache: Contains the most visited urls and thumbnails.
. TopSitesBackend: All mutations to topsites data end up calling into
the backend on the UI thread. TopSitesBackend processes the method on
the DB thread calling through to the TopSitesDatabase.
. TopSites: uses two TopSitesCache. One that contains the raw history
data, the other contains the processed data (pinned/blacklisted). The
processed cache can be accessed on any thread.
TopSites waits until history loads to know if it should migrate or use
it's own db. I could probably make these execute in parallel, but for
now this is how it works.
This patch also makes it so the dom ui accesses the thumbnails on the
IO thread.
BUG=56382
TEST=Make sure all your thumbnails are correctly updated and you don't
see problems.
Review URL: http://codereview.chromium.org/3440018
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/4048005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/4054008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Renamed "events" to "event".
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3988002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59834
TEST=none
Review URL: http://codereview.chromium.org/3991005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
doesn't suffer the plethora of threading issues that exist with the
current version. Here's the breakdown of what was refactored:
. TopSitesCache: Contains the most visited urls and thumbnails.
. TopSitesBackend: All mutations to topsites data end up calling into
the backend on the UI thread. TopSitesBackend processes the method on
the DB thread calling through to the TopSitesDatabase.
. TopSites: uses two TopSitesCache. One that contains the raw history
data, the other contains the processed data (pinned/blacklisted). The
processed cache can be accessed on any thread.
TopSites waits until history loads to know if it should migrate or use
it's own db. I could probably make these execute in parallel, but for
now this is how it works.
This patch also makes it so the dom ui accesses the thumbnails on the
IO thread.
BUG=56382
TEST=Make sure all your thumbnails are correctly updated and you don't
see problems.
Review URL: http://codereview.chromium.org/3440018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds guid generation to default constructor of AutoFillProfile.
BUG=60380
TEST=manual.
TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/4063003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tools/valgrind/gtest_exclude
If I receive an LGTM, I'll land this patch (with updated .txt files of course)
during the weekend in the Europe afternoon to minimize possible damages.
Then I'll update all the docs accordingly
For the record,
I got the list of the files by doing
find . | grep -v "\.svn" | grep "valgrind.*gtest" | sed "s/\.gtest.*$//" | \
sed "s/\/[a-z_]\+$//" | sort | uniq | tee list_dirs
And then
for F in `cat list_dirs`; do svn mv $F/*.txt tools/valgrind/gtest_exclude/; done
TEST=ran a few tests locally under Valgrind and TSan
Review URL: http://codereview.chromium.org/4054004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
wifi/cellular button fix.
BUG=chromium-os:7880
TEST=make sure overlay pages in chrome:settings don't paint control buttons at the bottom of the page
TBR=xiyuan
Review URL: http://codereview.chromium.org/3979012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
both OS_CHROMEOS and TOOLKIT_VIEWS
BUG=60444
Review URL: http://codereview.chromium.org/3972007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I disabled it.
BUG=58269
Review URL: http://codereview.chromium.org/3989005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
a chroot.
BUG=60363
Review URL: http://codereview.chromium.org/4077001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Move LeakTracker<URLRequest> up to CleanUp also. No URLRequest should be getting killed in DestructionObservers anymore.
BUG=59630
TEST=existing
Review URL: http://codereview.chromium.org/4064004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Subclass base::Thread so we can control initialization and shutdown for the helper thread.
BUG=59630
TEST=none
Review URL: http://codereview.chromium.org/3986004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Fix PathServiceTest.Get on POSIX on new slaves
BUG=none
Review URL: http://codereview.chromium.org/4023006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
disconnect.
There were a few repeating failures after I landed this CL. They looked unrelated, but I decided to revert since I didn't have a ton of time to continue investigating. Will hopefully reland soon.
The HttpProxyClientSocket reuses the same TcpClientSocket in the case that it is trying to establish a tunnel through
an authenticating proxy, but the proxy closed the TCP connection.
Also, fix SetOmniboxSpeculation on the TCPClientSocket implementations.
BUG=54062
TEST=Tried normal connections to make sure histograms were only emitted once, as well as https tunnels through an authenticating proxy to ensure that the use_history was correctly reset.
Review URL: http://codereview.chromium.org/3360007
TBR=cbentzel@chromium.org
Review URL: http://codereview.chromium.org/4006004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See more details from http://code.google.com/p/chromium/issues/detail?id=58319.
BUG=58319
TEST=none
Review URL: http://codereview.chromium.org/3832005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=stoyan
BUG=60409
TEST=None
Review URL: http://codereview.chromium.org/4072005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The HttpProxyClientSocket reuses the same TcpClientSocket in the case that it is trying to establish a tunnel through
an authenticating proxy, but the proxy closed the TCP connection.
Also, fix SetOmniboxSpeculation on the TCPClientSocket implementations.
BUG=54062
TEST=Tried normal connections to make sure histograms were only emitted once, as well as https tunnels through an authenticating proxy to ensure that the use_history was correctly reset.
Review URL: http://codereview.chromium.org/3360007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=56814,53632
TEST=browser_tests --gtest_filter="*AppBackgroundPageApiTest*"
Review URL: http://codereview.chromium.org/4074001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
intervening Delete/Take calls.
BUG=None
TEST=base_unittests --gtest_filter="*ScopedTempDir*", all other tests pass.
Review URL: http://codereview.chromium.org/3980006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=53073, 60384, 60393
TEST=none
TBR=scherkus, zmo
Review URL: http://codereview.chromium.org/4032006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Mark functions in file_util_posix as requiring permission to perform
disk actions.
- Mark the IO thread as disallowed from performing disk actions.
- Temporarily work around the protections in places where we currently
have bugs.
BUG=59847,59849,60207,60211,60394
TEST=no dchecks in debug builds
Review URL: http://codereview.chromium.org/3872002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63636 0039d316-1c4b-4281-b951-d872f2087c98
|