| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
This version contains support for destingushing between calling a non function as a function or as a constructor.
Review URL: http://codereview.chromium.org/115634
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
EXCLUDE_SKIA_DEPENDENCIES block
This will cause compile failures if EXCLUDE_SKIA_DEPENDENCIES is defined.
TBR=mpcomplete
Review URL: http://codereview.chromium.org/113705
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
would be cleaner to refactor. I'll do that later on though. I've added
a TODO to that effect.
Review URL: http://codereview.chromium.org/113679
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=12011
Review URL: http://codereview.chromium.org/115633
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
tab_cold timing on the perf bot, but that's expected. Future CLs will tinker.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
do a GetProcAddress of NtCreateFile.
TEST:Nothing to test
BUG:11789
Review URL: http://codereview.chromium.org/113659
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113383
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115632
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added new test
LayoutTests/fast/block/float/selection-gap-clip-out-tiger-crash.html
TBR=paul
BUG=0
TEST=no additional regressions
Review URL: http://codereview.chromium.org/113701
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115630
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12350
TEST=LayoutTests/fast/forms/select-style.html
Review URL: http://codereview.chromium.org/113699
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113700
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113693
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Unsupported events may cause additional troubles. E.g. ScriptCollected event handling crashes on call to GetEventContext(this should be fixed on v8 side).
Review URL: http://codereview.chromium.org/113695
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Upstream change https://bugs.webkit.org/show_bug.cgi?id=25742 modified the
test.
Original patch by tyoshino@google.com.
(see http://codereview.chromium.org/115623)
r=levin
BUG=12350
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=paul
BUG=0
TEST=no additional regressions
Review URL: http://codereview.chromium.org/113697
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
handling the event.
Review URL: http://codereview.chromium.org/113629
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
<app_name>/Contents/Resources and read them from there.
Review URL: http://codereview.chromium.org/115587
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115624
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
responsible for buffering data from the data source, and writing the buffers to the output device. This design blocks while waiting for data to be retrieved from the data source, which can lead to unnecessary buffer underruns in the audio device. This will be solved later after the non-blocking AudioSource interface is written.
Review URL: http://codereview.chromium.org/115276
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IPC message. Attempting
to prepare a backing store for a NULL view fails and crashes subsequently due to a NULL pointer dereference.
This fixes http://code.google.com/p/chromium/issues/detail?id=12167
Bug=12167
Review URL: http://codereview.chromium.org/113677
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
remove fail expectations
LayoutTests/http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
LayoutTests/http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
LayoutTests/http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
BUG=11909
TEST=no additional test regressions
Review URL: http://codereview.chromium.org/115622
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a DidCreateDataSource method to WebViewDelegate,
which the embedder uses to know if their LoadRequest
resulted in a navigation. The embedder then associates the
ExtraData with the WebDataSource at that point. The
WebDataSource then proceeds to be treated as the provisional
data source, possibly failing or being committed. We then
inspect WebFrame::GetDataSource in DidCommitLoadForFrame to
recover the ExtraData.
We have to take care to handle reference fragment
navigations since those do not result in a new WebDataSource
being created. So, in DidChangeLocationWithinPage, we
update the ExtraData associated with the WebDataSource
returned by WebFrame::GetDataSource.
One thing that is important to note: In
DidCommitLoadForFrame, we would previously always inspect
the value of GetDataSource returned from the main frame
instead of looking at the frame passed to
DidCommitLoadForFrame. This explains why WebFrameImpl::
LoadRequest needed to cached ExtraData on the current
WebDataSource, and I think doing so is awkward and wrong.
My change is to always store the ExtraData on the first
WebDataSource to be created as a result of LoadRequest.
Then in DidCommitLoadForFrame, I always inspect the
ExtraData from the given WebFrame. This means that for
history navigations that only navigate a subframe, we'll end
up with ExtraData associated with the WebDataSource of a
subframe. I think this is OK even though the old code was
trying to avoid this scenario. See the DCHECK removed in
RenderView::UpdateURL.
BUG=11423
R=brettw
Review URL: http://codereview.chromium.org/115575
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
keyboard object for implementors of TextField::Controller.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=ben
Review URL: http://codereview.chromium.org/115604
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
away the keystroke message that is passed. It turns out implementoars only ever
check for enter and escape messages, so I wrote two functions in TextField
that will decode the new Keyboard event.
This design is not optimal. Ideally we would have something more like the
WebInputEvent so that callers can check for anything in a cross-platform way.
This was branched off from the original review:
http://codereview.chromium.org/113639
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=paul
BUG=0
TEST=no additional test regressions
Review URL: http://codereview.chromium.org/113685
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113689
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115621
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113688
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=sky
Review URL: http://codereview.chromium.org/113687
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=sky
Review URL: http://codereview.chromium.org/113686
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=sky
Review URL: http://codereview.chromium.org/115620
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
suppressions so it matches in Release builds.
BUG=12366
Review URL: http://codereview.chromium.org/115617
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
this location.
http://crbug.com/11387
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to ERR_CERT_AUTHORITY_INVALID.
R=ukai
BUG=12359
TEST=Visit https://www.grounation.org/. The SSL error page
should say "The site's security certificate is not trusted!"
rather than "Invalid Server Certificate".
Review URL: http://codereview.chromium.org/115597
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113674
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=aa
TEST=This will eventually be covered by layout tests once I change the upstream code to use this API.
Review URL: http://codereview.chromium.org/113672
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
* Add browser/views/browser_bubble{,_win}.{cc,h}
* Rename of browser/views/tabs/native_view_photobooth{,_win}.{cc,h}
* Old omitted browser/views/frame/browser_frame.h
Review URL: http://codereview.chromium.org/115614
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115491
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Turns out vorbis packets only have an accurate timestamp every second or so while the rest of the packets have a timestamp of zero. Problem was we were overwriting |last_fill_buffer_time_| with zeros and then updating the clock, effectively causing a ton of drift.
Review URL: http://codereview.chromium.org/115593
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=2381
Review URL: http://codereview.chromium.org/115607
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=2381
Review URL: http://codereview.chromium.org/115606
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit ebb5f616663f9d5ee78584187da16bba4ce96811.
Review URL: http://codereview.chromium.org/113680
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
but we don't select
a folder by default when we're adding a new bookmark.
Review URL: http://codereview.chromium.org/115598
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Set the error_recognition and error_concealment flags in the codec context similar to ffplay.c. Also silently drops frames that didn't decode properly instead of stops the entire pipeline.
Review URL: http://codereview.chromium.org/113653
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the NotificationService instances, by checking whether the service exists before calling RemoveObserver() on it.
Also add comments in NotificationService telling people to use NotificationRegistrar.
BUG=2381
Review URL: http://codereview.chromium.org/115601
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and expose the names to webkit.
Review URL: http://codereview.chromium.org/113665
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16553 0039d316-1c4b-4281-b951-d872f2087c98
|