| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
* Match both the name and the label when sending FormData values for the renderer to fill.
* Use a vector of bools to indicate which WebFormControlElements are extracted instead of matching on element name, which is not guaranteed to be unique.
BUG=38325
TEST=FormManagerTest.InferredLabelsWithSameName
Review URL: http://codereview.chromium.org/1558029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
using #fragments in the URL.
(This way you can link to the DNS tab for example).
BUG=37421
Review URL: http://codereview.chromium.org/1525016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
apparently slipped through the cracks because of my carelessness deciding which files to include in the cls. I will add inline comments explaining each one.
Review URL: http://codereview.chromium.org/1626006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed Tools
Put Import/Export at the bottom of "organize"
Moved Add Page/Folder to top of "organize"
Moved Delete into the group with cut/copy/paste
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1559020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
settings are updated.
BUG=none
TEST=GeolocationContentSettingsTest
Review URL: http://codereview.chromium.org/1570015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a chromium build, this should produce no output. For official
builds, we print warnings about untranslated strings.
This is the first step in trying to have grit produce useful
warning messages.
BUG=39417
Review URL: http://codereview.chromium.org/1518018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
bar folders.
BUG=http://crbug.com/40430
TEST=see bug
Review URL: http://codereview.chromium.org/1613006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG:none
TEST: click the "customize sync" button in the sync setup wizard or in options->personal stuff. There should be a Themes checkbox. Theme sync still has a bug (see http://codereview.chromium.org/1633002/show) but will be fixed soon.
Review URL: http://codereview.chromium.org/1508025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40739
TEST=See steps in bug.
Review URL: http://codereview.chromium.org/1600014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Bug=40736
Review URL: http://codereview.chromium.org/1517023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Add a ScopedPrefUpdate in various places as well as fix a bug that prevented the live update of the main translate pref in the options dialog.
Review URL: http://codereview.chromium.org/1547025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Disconnect some more signal handlers on shutdown.
BUG=40735
TEST=watch waterfall
Review URL: http://codereview.chromium.org/1542019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=Should appear on the bottom left in autofill dialog and should work when clicked :)
BUG=none
Review URL: http://codereview.chromium.org/1551020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When parsing the extension update manifest results, we bail out of there was an
error from any of the <app> tags in the xml. With the changes from
http://src.chromium.org/viewvc/chrome?view=rev&revision=42899
we now can get a "error-unknownApplication" for ids that Omaha doesn't know
about, so we need to not have that stop other updates.
BUG=40519
TEST=Install an extension you packaged yourself that doesn't have an
update_url specified, and install an older verison of one in the gallery. When
you do an "update now" you should get the update for the gallery one.
Review URL: http://codereview.chromium.org/1633002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
content settnigs are update.
BUG=none
TEST=HostContentSettingsMapTest
Review URL: http://codereview.chromium.org/1606016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38563
TEST=Follow the instructions on the bug.
Review URL: http://codereview.chromium.org/1545024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
hostname for FTP.
BUG=39830 (comment #9)
TEST=FtpNetworkTransactionTest.StripBracketsFromIPv6Literals
Review URL: http://codereview.chromium.org/1585022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now it lists all permissions explicitly and includes the new
"notifications" permission.
BUG=39862
TEST=none
Review URL: http://codereview.chromium.org/1525010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed ShowHtmlDialog() on OS X to return the created window.
BUG=34209
TEST=manual
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43796
Review URL: http://codereview.chromium.org/1535018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also got primitives.html working and added it to o3d-webgl-samples directory.
Review URL: http://codereview.chromium.org/1300002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Convert ACEViewGtk to use the macros.
BUG=none
TEST=compile + click around
Review URL: http://codereview.chromium.org/1591021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also fix ClientSocketPool to free idle sockets when we've hit the socket limit.
BUG=32817
Review URL: http://codereview.chromium.org/1574015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is closer to what Windows does, and makes the text much more readable.
BUG=40135
Review URL: http://codereview.chromium.org/1595015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1584017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
away from the new tab page (or another DOMUI page) before the DOMUI page commits, the subsequent page will inherit the SiteInstance of the original page.
BUG=12718,40575
TEST=included unit test
Review URL: http://codereview.chromium.org/1519025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
OpenGL ES 2.0 semantics.
BUG=40172
TEST=ran Worlds of WebGL demo and verified point sprites change size
Review URL: http://codereview.chromium.org/1567027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
just fine on Windows in Release mode.
BUG=40671
TEST=Enable one more test on perf bots; perf bots remain green.
Review URL: http://codereview.chromium.org/1634001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
window.
(Client code can still use a toplevel widget as the anchor.)
BUG=40068
TEST=tried all popups in LTR and RTL
Review URL: http://codereview.chromium.org/1575019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
windows and to properly blend transparent themes with black. Also adds a way to pass an offset in to the theme drawing code.
BUG=40213
TEST=Android robot theme should draw properly, not be pure black.
Review URL: http://codereview.chromium.org/1527020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with trusted Pepper plugins. The shared memory was not being used to create
the skia bitmap due to a missing mmap() call. Adding this call (via
TransportDIB::Map()) generates the right shared mem region.
Note: this is an interim fix. Really, the browser should make the TransportDIB
as it does onthe Mac for the GPU plugin.
BUG=40701
TEST=Run any Pepper 2D application as a .nexe
Review URL: http://codereview.chromium.org/1542016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/1542015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1612008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The old way this was written was trying to re-use the Add() method to "merge" the new langauge string with the existing list. But in the case when a syncd browser sends a re-ordering or delete change, this would not detect the change and never fire the observer. I changed this to simply make SetAcceptLanguagesString replace the current langages_ list.
BUG=40486
TEST=Language lists should stay in sync between two browsers.
Review URL: http://codereview.chromium.org/1566024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1625005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=compiles and the close button still works as before
Patch from Thiago Farina <thiago.farina@gmail.com>
Review URL: http://codereview.chromium.org/1575018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to make sure the process name is only getting set in ways we expect.
BUG=40583
TEST=none
Review URL: http://codereview.chromium.org/1628007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=compiles and the menu still works as before.
Review URL: http://codereview.chromium.org/1601007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=green
BUG=None
Review URL: http://codereview.chromium.org/1564013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Adds unit test for BoundsAnimator and SlideAnimation.
. Fixes leak in BoundsAnimator.
. Fixes possibility of deleting delegate twice.
. Makes sure delegate is notified when new animation is set for view.
. Fixes crashes in TabStrip that resulted from dragging a tab back in.
BUG=40475
TEST=make sure dragging tabs out/in to a tabstrip doesn't cause
problems.
Review URL: http://codereview.chromium.org/1585020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit 5c19b0409f047111de901755b5670efa5a2d4e8c.
Review URL: http://codereview.chromium.org/1517020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gtk_util.h
BUG=None
TEST=compiles
Patch from Thiago Farina <thiago.farina@gmail.com>
Review URL: http://codereview.chromium.org/1610003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1545023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
separately.
BUG=none
TEST=none
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/1629007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This patch doesn't actually make it succeed, but it at least stops us from going into an infinite series of connecton attempts.
BUG=40561
TEST=None (manually attempt to connect to a test server)
Review URL: http://codereview.chromium.org/1551018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
determined). Mac OS sometimes rapidly reports two alternating sizes, causing the animations to seize up and flicker.
BUG=38083
TEST=visit http://www/~johnnyg/38083.html, or otherwise invoke the javascript in the bug. there should be no animation problems.
Review URL: http://codereview.chromium.org/1589020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
profile path used varies across these browsers.
This changed in the recent fixes for privacy where on IE6 and IE7 the profile is in temporary internet files. The ChromeFrame
net tests assumed the profile would always be in the default path which caused the tests to not work.
Added a helper function in chrome_Frame_test_utils.cc/.h to retrieve the correct profile path based on IE version and use this.
This should get the net tests up and running on the FYI IE6 builder.
Review URL: http://codereview.chromium.org/1553015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
like WidgetWin does.
BUG=none
TEST=manual: web notification in linux/toolkitview build will work.
Review URL: http://codereview.chromium.org/1628006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=compiles
Patch from Thiago Farina <thiago.farina@gmail.com>
Review URL: http://codereview.chromium.org/1564011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's making Windows Perf startup_tests red.
BUG=40671
TEST=greener bot
TBR=thestig@chromium.org
Review URL: http://codereview.chromium.org/1599022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43852 0039d316-1c4b-4281-b951-d872f2087c98
|