| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the previous patch, the try bots failed with mysterious messages, so I ignored them, patched it into my windows box and tested it there manually, and found no problems. As it turns out, the try failures were real :(. But nsylvain and I found the problem: the behavior of file_util::GetDirectoryFromPath() differs from DirName() when the path is empty (officially, GetDirectoryFromPath is not supposed to support non-absolute paths, but that is not enforced).
Here is a green win try result: http://build.chromium.org/buildbot/try-server/builders/win/builds/3705
mac: http://build.chromium.org/buildbot/try-server/builders/mac/builds/3491
linux: http://build.chromium.org/buildbot/try-server/builders/linux/builds/3466
I also applied this patch locally in Windows to test that it doesn't break the chrome frame compile or tests, since that's not covered by the trybots yet.
Review URL: http://codereview.chromium.org/271099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
doesn't work well for Windows root drives.
BUG=24722
TEST=existing tests are enough.
Review URL: http://codereview.chromium.org/271086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG:9798
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r28006 reverted to an earlier version of tcmalloc,
and consequently we got slower by 15ms on the morejs
page cycler.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/280001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=5737
TEST=none
Review URL: http://codereview.chromium.org/264065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG:22111
Review URL: http://codereview.chromium.org/278016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
on the buildbots.
TBR=nsylvain
Review URL: http://codereview.chromium.org/280004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is no associated depth buffer.
There's something I don't get here. I thought
the dimensions of the depth-stencil and the
render target had to match but apparently they
don't?
Review URL: http://codereview.chromium.org/270100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/276040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/280003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tbr=nsylvain
Review URL: http://codereview.chromium.org/274063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23450
TEST=valgrind_webkit_tests.sh LayoutTests/fast/text/drawBidiText.html
Review URL: http://codereview.chromium.org/271098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=xji
Review URL: http://codereview.chromium.org/273064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
death to the wstring
TEST=trybots
BUG=none
Review URL: http://codereview.chromium.org/276016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24842
TEST=unit tests pass, app still works
Review URL: http://codereview.chromium.org/271094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=themes stopped working on Linux and Mac
TEST=unittests
Review URL: http://codereview.chromium.org/269083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The warnings indicate that a public/protected method of a class
visible outside of a .cc file returns a type that's declared in
the anonymous namespace in that file (and hence not visible outside
the file).
BUG=23073
TEST=none
Review URL: http://codereview.chromium.org/273058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Failing on one trybot.
BUG=None
TEST=None
TBR=gspencer
Review URL: http://codereview.chromium.org/264064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Eliminate code duplication
- Cover other 3 databases
- Still doing the same as before, sending UMA histograms
BUG=11908
TEST=none
Review URL: http://codereview.chromium.org/270101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=erikkay@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/17627
TEST=See bug.
Review URL: http://codereview.chromium.org/273022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
as that has been deprecated.
Review URL: http://codereview.chromium.org/274042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23879
TEST=Install sample gmail browser action sample.
Review URL: http://codereview.chromium.org/264046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24241
TEST=not crashing
Review URL: http://codereview.chromium.org/276032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Moved the is_showing_before_unload_dialog_ stuff from RenderViewHost to TabContents since we need that bit there as well.
Review URL: http://codereview.chromium.org/274057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/278011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
os. maximized is the default state on chrome os, so this effectively
gives us no window controls just as we have now.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/273055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
npapi_layout_test_plugin with a modification of the MIME type. We will enhance
this code from here to support new pepper features.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/269087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=no
Review URL: http://codereview.chromium.org/274059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/279007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The results difference among mac, win and linux is due to
a workaround on mac. Mac is pasting simple text in this
case. This causes mac has different editing delegate callback,
selection range and text run outputs. See bug for more details.
R=japhet
BUG=21807
TEST=none
Review URL: http://codereview.chromium.org/271092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows shift-esc to work again in Gmail chat windows.
BUG=none
TEST=Open Gmail, start a chat, repeatedly press SHIFT+ESC and watch it switch between the chat "window" and the mail list. The Task Manager should not open.
Review URL: http://codereview.chromium.org/274028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
TEST=none
BUG=10322
Review URL: http://codereview.chromium.org/276034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
interval. If the nudge
still leaves the syncer with more work to do, don't accept any further nudges for this interval,
and keep the exponent stage for exponential backoff the same.
As a result of the patch, the unittest can now explicitly determine if exponential backoff
kicked in or not.
We really need to wire this up directly to the error codes to be precise, because the current impl (and
it's the same with my patch) appears to trigger exponential backoff in other cases (ShouldSyncAgain).
TEST=SyncerThreadTest
Review URL: http://codereview.chromium.org/275015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
the Linux and Mac builds.
Review URL: http://codereview.chromium.org/267108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Stuff when the default theme is already set, Windows side.
BUG= http://crbug.com/18585
TEST= Install a default theme, note that button is disabled. Install a non-default theme, note that button is enabled.
Review URL: http://codereview.chromium.org/279005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Stuff when the default theme is already set.
This change is for the Mac OS; Windows change in a separate patch.
BUG= http://crbug.com/18585
TEST= Install a default theme, note that button is disabled. Install a non-default theme, note that button is enabled. Rinse, repeat.
Review URL: http://codereview.chromium.org/278004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/23405
TEST=try to cancel extension load; it should work.
Review URL: http://codereview.chromium.org/279006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
WebKit does. Also fix a bunch of small issues in EventSendingController.
BUG=12197,12477
TEST=existing layout tests
Review URL: http://codereview.chromium.org/266076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
my CL last week.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/276020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is just a first pass, to avoid patch-hugeness.
R=darin
TEST=LayoutTests/accessibility
BUG=10322
Review URL: http://codereview.chromium.org/275009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=5730,5731,5732
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/271027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- This version is different from last three
TEST=chrome should start and you can browse
BUG=11789
Review URL: http://codereview.chromium.org/275014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=21827
TEST=none
Review URL: http://codereview.chromium.org/273060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR since it breaks the dashboard.
TBR=tony@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Replace it with base_i18n which encapsulates all ICU dependencies.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/267048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=b/2071330
TEST=unittests
Review URL: http://codereview.chromium.org/267101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29035 0039d316-1c4b-4281-b951-d872f2087c98
|