| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115864
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113953
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113951
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Now data for each profiling session is collected separately (previously they were accumulated in a single profile).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113950
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use CERT_PKIXVerifyCert() with CRL to verify certificate.
With OCSP, CERT_PKIXVerifyCert() failed with
SEC_ERROR_INVALID_ARGS.
Increase stack size. It was not enough size if we use
CERT_PKIXVerifyCert() on some sites. For example,
https://www.google.com/ works, but https://bugs.webkit.org/
or https://www.thawte.com/ would die by SIGSEGV. This is
because pkix_List_Destroy() routine destroys PKIX_List
recursively, so if there are some long PKIX_Lists, it
consumes stack a lot and dies by stack overflow.
Note that X509Certificate::Verify isn't used in SSLClientSocketNSS yet.
BUG=10911
TEST=net_unittests passes
Review URL: http://codereview.chromium.org/113578
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Initially these will be drop in replacements for the existing projects.
These were generated mechanically in lieu of a looping syntax.
Review URL: http://codereview.chromium.org/115853
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
XP Modules.
Learned how to do a clobber build so retrying with that. Hope springs eternal.
Original Review URL: http://codereview.chromium.org/113807
Review URL: http://codereview.chromium.org/113938
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
XP Modules.
Review URL: http://codereview.chromium.org/115854
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This checkin adds gmock, and a small example of how to write a gmock-based unittest.
Original Review URL: http://codereview.chromium.org/113807
Review URL: http://codereview.chromium.org/115846
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* test/ui/sandbox_uitest.cc
* test/ui/v8_benchmark_uitest.cc
* worker/worker_uitest.cc
* browser/autocomplete/search_provider_unittest.cc
* browser/extensions/extension_process_manager_unittest.cc
* browser/extensions/extension_view_unittest.cc
* browser/find_backend_unittest.cc
* browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
* browser/search_engines/template_url_scraper_unittest.cc
Also the utility module:
* test/ui/javascript_test_util.cc
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115844
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
bsdiff and bspatch. svn:ignore the new generated ones.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115819
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115850
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
link stub is not necessary.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113937
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115827
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/115848
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is possible that the size for the index table is reduced when
the cache is restarted (the available disk space could be lower
than what it was when the cache was originally created). If that
is the case, not resetting mask_ to 0 will prevent the mask to
be set correctly for the new table size, resulting in a crash.
BUG=12378
TEST=unittests
Review URL: http://codereview.chromium.org/113930
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pages into an HTML label tag, to make it clickable and more friendly to screen
readers.
TEST= Navigate to ianfette.org and click on the text "I understand that visiting
this site may harm my computer". Checkbox should toggle.
BUG= 12714
Original patch by chromium@willhirsch.co.uk
Original review: http://codereview.chromium.org/115815
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ben
BUG=11904
TEST=See bug, verify that home buttons don't look like provided image.
Review URL: http://codereview.chromium.org/115845
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=10638
TEST=Go to about:credits and verify that there's no reference to JSCRE
Original review URL:
http://codereview.chromium.org/113683
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115728
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Since media in chrome renderer doesn't use file handle
anymore, and these two files are deprecated, remove
them from the tree.
Review URL: http://codereview.chromium.org/115841
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=ran gclient sync to verify syntax of DEPS change.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
installer_unittests, installer_util, mini_installer, mini_installer_test,
setup.
Added msvs_guid settings for all targets.
Moved some variables that are used by multiple targets
to the top level.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115810
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
GetBrowserViewForNativeWindow()
This simplifies things on linux where the native window is not the same type
as the native view.
Review URL: http://codereview.chromium.org/115830
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=12042
Review URL: http://codereview.chromium.org/115838
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11780
TEST=go to cygwin.com, click "install or update now". The download shelf should appear with a dangerous download dialog, which should animate properly and without undue jank. Clicking "cancel" should delete the item and hide the shelf (since it's the only thing in the shelf). Clicking "save" should make it become a normal download item.
Review URL: http://codereview.chromium.org/113920
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113923
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to not be selectable for much of the right endcap.
Review URL: http://codereview.chromium.org/115836
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113926
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
is not built or referenced at all by the chrome build yet, and doesn't
yet build in it's new home. We'll change that shortly.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WidgetWin rather than Widget and the associated ATL classes, the class name based comparison for a window
to check if it is an external tab container window is no longer valid.
We now check if a window is an external tab window by looking for the existence of the kWindowObjectKey window property, which is only set on external tab container windows.
Review URL: http://codereview.chromium.org/115833
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115834
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This regressed recently during porting. When
comparing to see who is registered we need to
be comparing against a class that implements
FocusChangeListener (and registers as such
with AddFocusChangeListener). In this case,
host_ does not implement that interface and
doesn't register as a listener, so it will
never be registered. We should be comparing
using 'this', not 'host_'.
I've fixed this and added a browser_test to
catch this in the future.
BUG=12729
TEST=Open Find, press Esc, press Esc again
and the Find box should not briefly appear
and hide again. Also, make sure Esc works
to cancel navigations.
Review URL: http://codereview.chromium.org/115832
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
memory instead of MD5 of text section.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113893
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The crash server requires an MDRawSystemInfo stream in order to process the
file, although it actually only needs a single value in it.
Additionally, it needs a PDB7 structure for each module, so we remove those
modules which probably aren't shared libraries and XOR the first page of data
to get a signature for them. The previous code opened the file and MD5 summed
the text segment. However, we can't know if the shared library is still linked
on disk, nor if the whole text segment is mapped in memory. Thus, we only
assume that a single page is mapped.
dump_syms will need to be forked and updated to match the signature scheme used
in this patch.
http://codereview.chromium.org/113875
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
easier for callers. Also gets bookmark menu button to compile.
I'm also removing a function I just added to gtk_util as it's not
needed. GTK offers gtk_widget_get_toplevel which does what I need.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115831
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
system's thumbnail storage.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/12725
TEST=repro test mentioned in http://code.google.com/p/chromium/issues/detail?id=12725#c4
Review URL: http://codereview.chromium.org/113922
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"""
Fixed StatusBubbleViews::AvoidMouse() to support the mirrored UI (RTL) mode.
BUG=12148
TEST=Start chromium with --lang=he. Hover a mouse cursor on a link in the bottom
right corner, verify that the status bubble appears to the left. Verify that the
status bubble appears in a normal (right) position for all other links.
"""
Original review URL:
http://codereview.chromium.org/115461
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/6590
TEST=Cause the download shelf to appear by initiating a download. Hover
over a link in the extreme lower left corner of the browser window. The
status bubble should avoid your mouse by moving to the right, instead of
moving down and obscuring the download shelf.
Review URL: http://codereview.chromium.org/113671
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=12653
Review URL: http://codereview.chromium.org/115829
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* activex_test_control.dll
* browser_tests.dll
* browser_tests.exe
* memory_watcher.dll
* rlz.dll
* security_tests.dll
* test_chrome_plugin.dll
* themes/default.dll
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113915
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
make chrome app depend on pdfsqueeze
add a rule to run pdfs through pdfsqueeze
BUG=7654
TEST=pdf files in resources should be smaller now.
Review URL: http://codereview.chromium.org/113911
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem was related to an infobar (the default browser one) showing.
When the tab is closed, InfoBarClosed is called on the infobar delegates, triggering a delete of the delegate. Then a notification that the tab is destroyed is sent, causing the tab contents to layout its infobars accessing the deleted delegates.
BUG=12668
TEST=All UI tests should pass (especially the LoginPromptTest ones).
Make IE your default browser, start Chrome. The default browser infobar should show. Close the tab.
Review URL: http://codereview.chromium.org/113906
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17021 0039d316-1c4b-4281-b951-d872f2087c98
|