| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Description:
Massage test names into allowed set of characteres.
Luckily currently massaged names are still unique.
Review URL: http://codereview.chromium.org/269096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I forgot to add a test case that was failing before r29035
BUG=b/2071330
TEST=unittests
Review URL: http://codereview.chromium.org/281004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
of white, black, and blue (respectively).
BUG=22967
TEST=Change system theme, start Chrome w/no theme, observe the NTP respects the system colors.
Review URL: http://codereview.chromium.org/273043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bug number. This should also allow linux to pass this test, since the failure appears to be win-specific.
BUG=24904
BUG=10353
TEST=no new redness
Review URL: http://codereview.chromium.org/281003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mac) can use it.
I will switch Windows over to the common function in a follow-up patch.
BUG=23882
TEST=gmail browser action sample extension
Review URL: http://codereview.chromium.org/279008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
link stage.
BUG=None
TEST=None
TBR=gspencer
Review URL: http://codereview.chromium.org/273067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
limit for a single browser test. I have therefore split it into three and added a more descriptive error message for when we time out.
I will remove the traces and the FLAKY_ label after a successful run or two on the bots.
BUG=23686
TEST=Tested by automated test.
Review URL: http://codereview.chromium.org/274066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=
*Search for something. Switch to textedit, search for something else. Switch back to chrome. The outdated "x of y" text should be invisble in the find bar, but the prev/next find result buttons should be enabled. Hit enter. Pages should be searched, "x of y " text should return.
* Open a findbar, search for something. Open new chrome window, hit cmd-f. findbar in new window should contain the text you searched for in the last window.
Review URL: http://codereview.chromium.org/267022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
results in thumbnails.
I could have added this directly to the new tab startup tests, but
that would mean turning on DOM automation for the new tab tests.
I was trying to avoid the extra code in the new tab startup tests.
Review URL: http://codereview.chromium.org/269060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
crash it appears that we're starting a drag for an index beyond that of
the model.
BUG=24132
TEST=none
Review URL: http://codereview.chromium.org/275023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
was happenening because BrowserActionContainer, on receiving notification about an extension load/unload/change, deletes all BrowserAction views, re-adds all the views again, and asks the toolbar to SetBounds for the BrowserActionContainer. However, during deletion, it does not re-set the bounds. As a result, when SetBounds is called by the toolbar again, it does not see any changed in BrowserActionContainer, and does not layout again, causing all the browser actions to disappear. The solution lies in forcing Layout() after SetBounds() in ToolbarView.
BUG=23593
TEST=none
Review URL: http://codereview.chromium.org/276033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24902
TEST=Go to about:plugins, and verify that plugins in ~/Library/Internet Plug-Ins come before those in /Library/Internet Plug-Ins
Review URL: http://codereview.chromium.org/276045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The race is known but is not very severe and cannot be easily
fixed using locks due to the complexity of the third-party audio code.
BUG=24801
Review URL: http://codereview.chromium.org/282001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/274062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
tab into it (allowing drags to window whose tab strip is fully obscured).
BUG=22283
TEST=all tab dragging between windows.
Review URL: http://codereview.chromium.org/281001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
context menu. Fix a typo in the grd file for adding a bookmark.
BUG=24363
TEST=bookmark all tabs, edit dialog still dims OK when url is invalid for bookmarks that aren't folders.
Review URL: http://codereview.chromium.org/269080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BrowserWindow::Activate(). Before this would ignore the existence of fullscreen windows.
BUG=http://crbug.com/21145
TEST=Trigger a javascript alert dialog. The original non-fullscreen window should not appear.
Review URL: http://codereview.chromium.org/274060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
wstring. After this patch, I'm able to start chrome in a
user data dir with non-ascii characters on non-utf8 systems.
BUG=24444
Review URL: http://codereview.chromium.org/267085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
compiled one
and maintain it.
This is the first step towards shipping privacy blacklists in extensions.
The next step will be to make Profile own a BlacklistManager, and make ExtensionsService a BlacklistPathsProvider.
TEST=Covered by unit_tests.
BUG=21541
Review URL: http://codereview.chromium.org/164535
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/242141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=24851,24852,24855,24856
TEST=none
Review URL: http://codereview.chromium.org/271103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
introduced a typo when converting CreateWebStorageNamespaceIfNecessary to use a conditional.
BUG=23400
TEST=none
TBR=jorlow
Review URL: http://codereview.chromium.org/282005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
underlying WebCore objects that manage the sqlite DB, causing its memory caches to be eliminated, and then recreates the objects on demand.
BUG=23400
TEST=none
Review URL: http://codereview.chromium.org/264062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HandleAuthChallenge.
Add a "const GURL& auth_origin" parameter to PopulateAuthChallenge, InvalidateRejectedAuthFromCache, and
SelectNextAuthIdentityToTry to eliminate the
AuthOrigin(target) calls in those three functions.
R=eroman
BUG=22264
TEST=none
Review URL: http://codereview.chromium.org/277005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BookmarkEditorController invalid for subsequent bookmark manipulation
(e.g. it can and does do a remove/add instead of an in-place edit).
Review URL: http://codereview.chromium.org/274039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=apavlov
Review URL: http://codereview.chromium.org/274065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add an |BREAKPAD_DUMP_LOCATION| environmental variable to allow overriding the default location
for minidump generation.
This is for ChromeBot who need a single copy of the Chrome bundle which can be run several times
alternating the location of crash dumps.
This isn't implemented as a command line flag because only some command line flags are passed to child processes and we need a robust solution.
TEST=Minidumps should still be written for browser and renderer crashes.
Review URL: http://codereview.chromium.org/264038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=knorton
Review URL: http://codereview.chromium.org/267119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
any more.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/268037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
remove it from test_expectations
TBR=dglazkov
BUG=20826
TEST=none
Review URL: http://codereview.chromium.org/269089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/22219
TEST=load a theme, see "Loading..."
Review URL: http://codereview.chromium.org/267031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/274058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(strip_from_xcode).
This is a corner case that probably nobody else has ever hit, but it hits me
because I often do official release build testing without mac_real_dsym set.
This builds all of Breakpad for that just-like-official-release taste, but
doesn't give me real .dSYMs or dumped symbols, saving me the time of having to
run real dsymutil when I don't need these.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/275025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
baselines.
R=ojan
BUG=none
TEST=run test_output_formatter.py -- html output for upstream baselines should be consistent with other images.
Review URL: http://codereview.chromium.org/273061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Linux builds and tests to be archived for Windows builds. This patch goes hand in hand with: http://codereview.chromium.org/267087/show
BUG=None
TEST=Build program files, symbols and tests are correctly archived by the builder.
Review URL: http://codereview.chromium.org/275024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
files (I didn't change the other .cc files since I think we'll delete most of
them when I figure out what's going on). Add Skia dependency so we can add
graphics later.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/273066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/271097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/svg/custom/invisible-text-after-scrolling.xhtml
BUG:9798
Review URL: http://codereview.chromium.org/271101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG:24889
Review URL: http://codereview.chromium.org/276043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24769
TEST=None
Review URL: http://codereview.chromium.org/276036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
MMX2 to avoid EMMS
LEA to remove 2 instructions from Scale loop
shuffle to remove one instruction
sub at top of loop avoids one branch
Review URL: http://codereview.chromium.org/269088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/267110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
toplevel window.
BUG=19082 "Linux: Omnibox auto-complete popup is on top of IME candidate window when using SCIM"
TEST=Please refer to the bug report for how to test.
Review URL: http://codereview.chromium.org/274046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
because WebKit@49557 was not rolled.
BUG=24805
Review URL: http://codereview.chromium.org/271100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Removing a line that I put in just to get perf data from the build bots.
TBR=mbelshe
Review URL: http://codereview.chromium.org/267114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
bring up an inspector, as that doesn't work
anymore.
TBR=kathyw@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser actions).
Test failure was a fluke. I forgot that changing
resources always makes the first bot run fail.
TBR=mpcomplete@chromium.org
BUG=24379,24671
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29098 0039d316-1c4b-4281-b951-d872f2087c98
|