summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Revert my recent changes regarding title directionality.evan@chromium.org2011-04-2533-239/+116
| | | | | | | | | | | | | | | | This reverts: r82400: Plumb direction of document title through IPC layer. r82582: Add and use a base::i18n::StringWithDirection for carrying titles. r82778: Change NavigationEntry's title fields to carry the text direction. I'm going to take an alternative approach; after getting this far, I can see that this approach was too complicated. BUG=27094 Review URL: http://codereview.chromium.org/6901003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82908 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Change status button menu"saintlou@chromium.org2011-04-2516-589/+376
| | | | | | | | | | | This reverts commit d73c5c63912ce402c82777bee1ec8f1a31544d9f. BUG=none TEST=none Review URL: http://codereview.chromium.org/6904003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82906 0039d316-1c4b-4281-b951-d872f2087c98
* Make update-copyrights.sh to work on both Linux and BSD (such as OS X)thakis@chromium.org2011-04-251-1/+1
| | | | | | | | | | | | Linux mktemp: http://linux.die.net/man/1/mktemp BSD mktemp: http://www.manpagez.com/man/1/mktemp/ BUG=none TEST=Run tools/git/update-copyrights.sh, it should work on both OS X and Linux Review URL: http://codereview.chromium.org/6900040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82905 0039d316-1c4b-4281-b951-d872f2087c98
* Sync: Remove extra logging.jhawkins@chromium.org2011-04-251-12/+0
| | | | | | | | | | BUG=none TEST=none TBR=csilv Review URL: http://codereview.chromium.org/6903005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82904 0039d316-1c4b-4281-b951-d872f2087c98
* Widen suppression for FileSystemURLRequestJobTest::SetUpcbentzel@chromium.org2011-04-251-0/+1
| | | | | | | | | BUG=80472 TEST=None Review URL: http://codereview.chromium.org/6904002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82903 0039d316-1c4b-4281-b951-d872f2087c98
* Update netflix version in chromeos plugin checknirnimesh@chromium.org2011-04-251-1/+1
| | | | | | | | | | R=krisr@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6902001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82902 0039d316-1c4b-4281-b951-d872f2087c98
* Unittests for P2P TCP Sockets Host.sergeyu@chromium.org2011-04-259-85/+629
| | | | | | | | | BUG=None TEST=Unittests Review URL: http://codereview.chromium.org/6883054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82899 0039d316-1c4b-4281-b951-d872f2087c98
* LUCKY 13laforge@chromium.org2011-04-251-1/+1
| | | | | | | | | Several successful sports figures have worn the number 13. Ozzie Guillén, manager of the 2005 World Series Champion Chicago White Sox, has worn the number throughout his baseball career. Alex Rodriguez began wearing it upon joining the New York Yankees (three, the number he had previously worn, is retired by the Bronx Bombers to honor Babe Ruth). Dan Marino, an American football player known for passing the 2nd most yards in NFL history, wore the number 13. Basketball great Wilt Chamberlain wore the number 13 on his jersey throughout his NBA career. Also, FIBA rules require a player to wear the number in international competitions (only numbers from 4 to 15 could be worn, and as there are 12 players, one must wear 13); Chris Mullin, who wore #20 in college and #17 in the NBA, wore #13 for both (1984 and 1992) of his Olympic appearances. Shaquille O'Neal wore #13 in 1996; Tim Duncan wore #13 in 2004. Steve Nash is currently wearing it for the Phoenix Suns. Yao Ming wore it in the 2008 Olympics in Beijing. Mats Sundin, Pavel Datsyuk, Bill Guerin, and Michael Cammalleri wear 13 in the NHL. One of Iceland's all time best handball players, Sigurður Sveinsson, wore the number 13 when he played for the national team. In association football, both Gerd Müller and Michael Ballack have favoured the number 13, among others. In Italy, 13 is also considered to be a lucky number, although in Campania the expression 'tredici' (meaning 13) is said when one considers their luck to have turned for the worse. Colgate University also considers 13 to be a lucky number. They were founded in 1819 by 13 men with 13 dollars, 13 prayers and 13 articles.[5] (To this day, members of the Colgate community consider the number 13 a good omen.) In fact, the campus address is 13 Oak Drive in Hamilton, New York, and the male a cappella group is called the Colgate 13. In the Mayan Tzolk'in calender, trecenas mark cycles of 13 day periods. The pyramids are also set up in 9 steps divided into 7 days and 6 nights, 13 days total. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82897 0039d316-1c4b-4281-b951-d872f2087c98
* Widen MalwareDetailsTest::HttpCache suppression even further.cbentzel@chromium.org2011-04-251-2/+1
| | | | | | | | | BUG=79685 TEST=waterfall.sh match Review URL: http://codereview.chromium.org/6902002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82895 0039d316-1c4b-4281-b951-d872f2087c98
* Heapchecker suppressions for FileSystemDirURLRequestJobTestcbentzel@chromium.org2011-04-251-0/+6
| | | | | | | | | BUG=80473 TEST=None Review URL: http://codereview.chromium.org/6883136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82894 0039d316-1c4b-4281-b951-d872f2087c98
* Heapchecker suppression for FileSystemURLRequestJobTest::SetUpcbentzel@chromium.org2011-04-251-0/+5
| | | | | | | | | BUG=80472 TEST=None Review URL: http://codereview.chromium.org/6883135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82892 0039d316-1c4b-4281-b951-d872f2087c98
* Extend PathService::Get to be able to return the X86 program files path.abodenha@chromium.org2011-04-253-13/+15
| | | | | | | | | | | | | | | | Cloud print's virtual driver needs this to be able to find the Chrome install directory. Since the port monitor is a 64 bit DLL on 64 bit Windows it needs to request the X86 folder explicitly. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82567 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82686 Review URL: http://codereview.chromium.org/6873159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82891 0039d316-1c4b-4281-b951-d872f2087c98
* Suppressions for TextInputControllercbentzel@chromium.org2011-04-251-0/+34
| | | | | | | | | BUG=80462 TEST=waterfall.sh match Review URL: http://codereview.chromium.org/6901002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82890 0039d316-1c4b-4281-b951-d872f2087c98
* Add some ScopedNSAutoreleasePools to things that can happen during earlymark@chromium.org2011-04-252-5/+16
| | | | | | | | | | initialization. This prevents some really minor leaks. BUG=none TEST=none Review URL: http://codereview.chromium.org/6880159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82889 0039d316-1c4b-4281-b951-d872f2087c98
* Fix users of platform_util::GetVersionStringModifier that really only caremark@chromium.org2011-04-2511-77/+166
| | | | | | | | | | | | | | | about the channel name to use the new platform_util::GetInstallationChannel. GetVersionStringModifier should only be used for display purposes. Use GetInstallationChannel to determine the channel name for comparisons. Fix the upgrade detector to treat the canary channel the same way that it treats the dev channel, using a shorter notification interval. BUG=79814 TEST=none Review URL: http://codereview.chromium.org/6899034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82888 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate unused function.pkasting@chromium.org2011-04-252-10/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6898028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82886 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move LinkController into its own header file.tfarina@chromium.org2011-04-2547-231/+278
| | | | | | | | | | | | | | | | | | | While I'm here, did some changes: - Rename the LinkController interface to LinkListener. - Move the interface to link_listener.h - Rename the event from LinkActivated to LinkClicked. - Changed the get/set accessors to listener()/set_listener(). - Add OVERRIDE to LinkClicked methods. BUG=None TEST=None R=sky@chromium.org Review URL: http://codereview.chromium.org/6881099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82885 0039d316-1c4b-4281-b951-d872f2087c98
* Delete a few unused functions.thakis@chromium.org2011-04-2510-105/+1
| | | | | | | | | BUG=none TEST=Compiles. Review URL: http://codereview.chromium.org/6880164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82884 0039d316-1c4b-4281-b951-d872f2087c98
* roll clang 129729:130080thakis@chromium.org2011-04-251-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=evan Review URL: http://codereview.chromium.org/6880160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82883 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress leak in ExtensionService::RecordPermissionMessagesHistogramcbentzel@chromium.org2011-04-251-0/+6
| | | | | | | | | BUG=80467 TEST=none Review URL: http://codereview.chromium.org/6898052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82882 0039d316-1c4b-4281-b951-d872f2087c98
* Encapsulated FaviconHelper.michaelbai@google.com2011-04-259-667/+787
| | | | | | | | | | | Added FaviconHandlder to handle a specific type of icon. FaviconHelper was changed to create and work with FaviconHelper to fetch favicons. BUG=71571 TEST=Tested with existing unit test. Review URL: http://codereview.chromium.org/6896024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82879 0039d316-1c4b-4281-b951-d872f2087c98
* Return NULL instead of a WeakPtr.cbentzel@chromium.org2011-04-252-2/+2
| | | | | | | | | | | | I'm not sure why this worked without a compiler warning. BUG=77930 TEST=Existing unit tests and browser tests. Review URL: http://codereview.chromium.org/6897025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82876 0039d316-1c4b-4281-b951-d872f2087c98
* Deleting a typed URL no longer sends out a TYPED_URL_MODIFIED notificationatwilson@chromium.org2011-04-252-37/+4
| | | | | | | | | BUG=80292 TEST=Run history unit tests. Review URL: http://codereview.chromium.org/6880140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82874 0039d316-1c4b-4281-b951-d872f2087c98
* Move UILayoutTest.MediaUILayoutTest valgrind suppression into shared ↵scherkus@chromium.org2011-04-253-5/+3
| | | | | | | | | | | | suppressions file. BUG=53825 TEST=should still be suppressed TBR=timurrrr Review URL: http://codereview.chromium.org/6897047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82873 0039d316-1c4b-4281-b951-d872f2087c98
* PrintPreview: Added code to print using system dialog.kmadhusu@chromium.org2011-04-256-4/+33
| | | | | | | | | BUG=79534 TEST=Print preview a webpage. Click the "Print using system dialog" link in preview tab. System dialog is displayed. Click the print button. Review URL: http://codereview.chromium.org/6900005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82872 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing whitespace, as per http://codereview.chromium.org/6898019/kushi.p@gmail.com2011-04-251-1/+1
| | | | | | | | | BUG=58409 Review URL: http://codereview.chromium.org/6898045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82871 0039d316-1c4b-4281-b951-d872f2087c98
* views: Add Link example.tfarina@chromium.org2011-04-254-0/+82
| | | | | | | | | | | | BUG=None TEST=compile with toolkit_views=1, run out/Debug/views_examples. You should see a link tab, and a link with "Click me!" and make sure it works. R=oshima@chromium.org,sky@chromium.org Review URL: http://codereview.chromium.org/6883122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82870 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the Json tests that cause V8 to install the SIGPROF handlerglider@chromium.org2011-04-251-0/+5
| | | | | | | | | | and time out the calls to fork() BUG=79320 TBR=timurrrr Review URL: http://codereview.chromium.org/6898046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82869 0039d316-1c4b-4281-b951-d872f2087c98
* Suppressions for ThumbnailGeneratorTestcbentzel@chromium.org2011-04-251-1/+12
| | | | | | | | | BUG=80458 TEST=waterfall.sh match Review URL: http://codereview.chromium.org/6880174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82867 0039d316-1c4b-4281-b951-d872f2087c98
* options: Get rid of the unused OptionsGroup enum.tfarina@chromium.org2011-04-2513-48/+23
| | | | | | | | | | | | | | While I'm here, move the enum OptionsPage to options_util.h, so we can get rid of the options_window.h header file too. BUG=None TEST=None R=jhawkins@chromium.org Review URL: http://codereview.chromium.org/6898036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82866 0039d316-1c4b-4281-b951-d872f2087c98
* Cancels prerendering in the case that the prerenderingmmenke@chromium.org2011-04-254-0/+31
| | | | | | | | | | | RenderView crashes. BUG=79599 TEST=PrerenderBrowserTest.PrerenderRendererCrash Review URL: http://codereview.chromium.org/6879114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82865 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 82854 - Fx the disabled test in thumbnail_generator_unittest.ccsatorux@chromium.org2011-04-251-44/+40
| | | | | | | | | | | | | | Broke Chromium Memory on Linux Tests (valgrind)(1)... BUG=65936 TEST=try bots Review URL: http://codereview.chromium.org/6816051 TBR=satorux@chromium.org Review URL: http://codereview.chromium.org/6897045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82862 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes another case of object getting deleted while menu is showingsky@chromium.org2011-04-252-1/+17
| | | | | | | | | | | | | | | causing problems. We seem to get a never ending stream of bugs because of this. I'm beginning to think we should convert to using non-native menus and no longer block in Run. That way problems like this should go away. BUG=80099 TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6882105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82859 0039d316-1c4b-4281-b951-d872f2087c98
* Added network panel timing, size and raw headers text tests for DevToolsvsevik@chromium.org2011-04-252-0/+75
| | | | | | Review URL: http://codereview.chromium.org/6851024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82858 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 82838 - Temporary change to test perf regression (full)This change ↵sail@chromium.org2011-04-2514-349/+123
| | | | | | | | | tests which part of this review:http://codereview.chromium.org/6897013/is causing a performance regression. This change will be reverted later tonight. TBR=sail@chromium.org Review URL: http://codereview.chromium.org/6895050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82856 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 82841 - Adding missing files from r82838sail@chromium.org2011-04-253-198/+0
| | | | | | | TBR=sail@chromium.org Review URL: http://codereview.chromium.org/6895049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82855 0039d316-1c4b-4281-b951-d872f2087c98
* Fx the disabled test in thumbnail_generator_unittest.ccsatorux@chromium.org2011-04-251-40/+44
| | | | | | | | | BUG=65936 TEST=try bots Review URL: http://codereview.chromium.org/6816051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82854 0039d316-1c4b-4281-b951-d872f2087c98
* Further improvements to DCHECK() usage, within /src/chromekushi.p@gmail.com2011-04-255-19/+19
| | | | | | | | | BUG=58409 Review URL: http://codereview.chromium.org/6898019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82853 0039d316-1c4b-4281-b951-d872f2087c98
* Mark WorkerTest.TerminateQueuedWorkers flakykinuko@chromium.org2011-04-251-0/+5
| | | | | | | | | | BUG=80446 TEST=greener tree TBR=robertshield,jar,georgey Review URL: http://codereview.chromium.org/6895048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82852 0039d316-1c4b-4281-b951-d872f2087c98
* Moving slideshow to extension.serya@google.com2011-04-2511-338/+277
| | | | | | | | | | TEST=none BUG=chromium-os:11430 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82509 Review URL: http://codereview.chromium.org/6873100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82851 0039d316-1c4b-4281-b951-d872f2087c98
* Make sign-in button disable if error happensglotov@google.com2011-04-251-1/+1
| | | | | | | | | BUG=chromium-os:12838 TEST=wysiwyg Review URL: http://codereview.chromium.org/6898021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82850 0039d316-1c4b-4281-b951-d872f2087c98
* Utilize a smarter "file path prefix cutter" for Memcheck.timurrrr@chromium.org2011-04-251-6/+10
| | | | | | | | | | This will avoid stupid paths in reports (like uild/buildd/zlib-1.2.3.3.dfsg/inflate.c:959) TBR=glider TEST=./tools/valgrind/chrome_tests.sh -t base --gtest_filter="*Sanity*" Review URL: http://codereview.chromium.org/6899060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82849 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind/Lucid: exclude failing tests, widen two suppressionstimurrrr@chromium.org2011-04-252-0/+14
| | | | | | | BUG=73722,79651,80438 Review URL: http://codereview.chromium.org/6898041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82848 0039d316-1c4b-4281-b951-d872f2087c98
* Update quota database schema to store quota per-host instead of per-origin.kinuko@chromium.org2011-04-253-218/+141
| | | | | | | | | BUG=61676 TEST=QuotaDatabaseTest.* Review URL: http://codereview.chromium.org/6882012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82847 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Fixed order of enable/focus. Clear focus before settingavayvod@chromium.org2011-04-251-2/+10
| | | | | | | | | BUG=chromium-os:13993 TEST=Type wrong password at any login screen pod. Verify that focus is back at password field. Review URL: http://codereview.chromium.org/6900046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82846 0039d316-1c4b-4281-b951-d872f2087c98
* ui_tests TestCancelAuth on Linux seems to be broken by the change.avayvod@chromium.org2011-04-252-1/+34
| | | | | | | | Revert 82834 - Webkit Roll r846845:r84766. TBR=dpranke@chromium.org Review URL: http://codereview.chromium.org/6897041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82845 0039d316-1c4b-4281-b951-d872f2087c98
* Adding missing files from r82838sail@chromium.org2011-04-253-0/+198
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82841 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 747.0 to 748.0chrome-release@google.com2011-04-251-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82840 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary change to test perf regression (full)sail@chromium.org2011-04-2514-123/+349
| | | | | | | | This change tests which part of this review: http://codereview.chromium.org/6897013/ is causing a performance regression. This change will be reverted later tonight. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82838 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 82836 - Temporary change to test perf regression (skia_utils)This ↵sail@chromium.org2011-04-251-3/+0
| | | | | | | | | change tests which part of this review:http://codereview.chromium.org/6897013/is causing a performance regression. This change will be reverted later tonight. TBR=sail@chromium.org Review URL: http://codereview.chromium.org/6895046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82837 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-06 09:14:13 +0000