| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
up today. We should have these documented. Now we do.
BUG=0
TEST={}
Review URL: http://codereview.chromium.org/274043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
created.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/264056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
nerds" screen.
TEST=none
BUG=http://code.google.com/p/nativeclient/issues/detail?id=108
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28875
Review URL: http://codereview.chromium.org/267043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
That required minor modification of Dromaeo benchmark to enable automation.
BUG=none
TEST=none
Committing for Anton Muhin (antonm@chromium.org).
Review URL: http://codereview.chromium.org/274020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23882
TEST=run it
Review URL: http://codereview.chromium.org/274025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
My first Chromium linux build greeted me with a backtrace of mangled symbols
(FWIW, my /dev/shm permission was wrong). That made me write this patch.
BEFORE:
../sconsbuild/Debug/base_unittests(_ZN10StackTraceC1Ev+0x20) [0x817795e]
../sconsbuild/Debug/base_unittests(_ZN30StackTrace_OutputToStream_Test8TestBodyEv+0x18) [0x805fc98]
../sconsbuild/Debug/base_unittests(_ZN7testing4Test3RunEv+0x7e) [0x82005ea]
AFTER:
../sconsbuild/Debug/base_unittests(StackTrace::StackTrace()+0x20) [0x817778c]
../sconsbuild/Debug/base_unittests(StackTrace_OutputToStream_Test::TestBody()+0x18) [0x805fc98]
../sconsbuild/Debug/base_unittests(testing::Test::Run()+0x7e) [0x8200786]
BUG=none
TEST=manually tested. also ran base_unittests
Review URL: http://codereview.chromium.org/267074
Patch from Satoru Takabayashi <satorux@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
WillLooseFocus needs to check if acc_focused_view is set, if it is, then it will properly remove it.
BUG=3510
TEST=ALT+SHIFT+T all the way to the menu button, select options/about chromium menu option and hit enter to select one of them. The menu will be not hottracked.
Review URL: http://codereview.chromium.org/270072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
under the following circumstances:
(a) There were two or more bookmarks with the
same title in a folder.
(b) A change notification event occured for
the bookmark (in my case it was a favicon
loaded event; these would happen every
startup, and maybe on every page visit too),
but the bookmark properties didn't
actually change.
What was happening is that we were filtering out redundant
property changes for the title, but only after we'd uniquified
the name. This wasn't necessary, and for cases where
there was a sibling with an identical name, the newly
generated uniquified name would result in a false positive.
The fix is to do the filtering on the non-unique name only.
This is the only property visible to syncapi clients.
BUG=24770
TEST=See bug.
Review URL: http://codereview.chromium.org/271083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/272042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=Select an item from the autocomplete popup and press shift+del.
Clear the autocomplete and start typing again. Verify that the
item doesn't re-appear.
Review URL: http://codereview.chromium.org/271063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=yaar
Review URL: http://codereview.chromium.org/274038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
2. Exclude invalid or default value state from the hash URL.
Review URL: http://codereview.chromium.org/266074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/270098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24672
Review URL: http://codereview.chromium.org/276012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
if given 30-40 seconds!
Review URL: http://codereview.chromium.org/269071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
table are current.
By default, the NTP only uses data from the last 90 days, but the
generated profile was created back in late 2008. Manually migrate
the dates before launching chrome.
This will probably impact the NTP perf tests, but it should give
us a more realistic baseline.
BUG=24369
TBR=brettw
(Take 3 at landing this patch, this time with the proper fix for
non-existent History files).
Review URL: http://codereview.chromium.org/264053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17826,19403
TEST=none
Review URL: http://codereview.chromium.org/270019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23536
TEST=Open Chrome Linux w/a theme and no bookmarks, verify instructional text in bookmarks bar has correct color.
Review URL: http://codereview.chromium.org/274034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I still don't know why it failed, but the only difference
that I could see in this test between xp and vista is that
xp accepts a lot of small IOs before returning pending, so
this change results in similar behavior in both platforms
and a faster run on xp.
BUG=23862
TEST=none
Review URL: http://codereview.chromium.org/273024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
until they are fixed.
BUG:24769
Review URL: http://codereview.chromium.org/274037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/271076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Adds unmonitoring of network status changes.
Fixed a few edge case bugs.
BUG=23923
TEST=none
Review URL: http://codereview.chromium.org/272019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
widget_gtk when building chromeos build. We need a #ifdef for
CHROMEOS but not using TOOLKIT_VIEWs for the browser window. I'm
temporarily adding this one.
This bug is the result of Oshima making TOOLKIT_VIEWS set OS_CHROMEOS.
Review URL: http://codereview.chromium.org/270092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/270094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(Long term intention is to add a subset of cpplint.py to the presubmit script.)
Review URL: http://codereview.chromium.org/276008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=domincc
Original review: http://codereview.chromium.org/271069
Enables use-machine-stack.html worker test.
As of WebKit revision 49427 Workers now set an appropriate stack
limit on OS X, so this test can be enabled.
Submitt this patch for Dominic Cooney <dominicc@google.com>
Review URL: http://codereview.chromium.org/271082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Preserves backwards compatability with the old manifest format.
BUG=24635
Review URL: http://codereview.chromium.org/275007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also add some FilePath methods in disk_cache_util.h and obsolete
the old.
BUG=24444
Review URL: http://codereview.chromium.org/266069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24672
TEST=still compiles
Review URL: http://codereview.chromium.org/270077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Main entry point
- sqlite error handler
BUG=none
TEST=none
TBR=huanr
Review URL: http://codereview.chromium.org/274033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Get the printing support class stack building and hooked up on the Mac.
Add support for creating NativeMetafile objects with PDF print data on the renderer side, and passing them to the browser via the existing printing IPC system.
Flip on the simpler printing unit tests (those that don't require PDF -> bitmap conversion).
BUG=13158
TEST=Print on the Mac--it should work!
Review URL: http://codereview.chromium.org/276004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
setting, ignoring the CRL setting. Not a problem at the moment since revocation isn't hooked up at the lower level, but it would have been a problem in due time.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/215014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
always there but it only became an issue when accessibility changes
landed.
BUG=http://crbug.com/24758
TEST=Open menu. See "add page" sheet show up.
Review URL: http://codereview.chromium.org/270096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
not deleting the blocked popup container view views,
which resulted in a reliability crash. This differs from the first patch in that BlockedPopupContainerViewViews::Destroy now does
a delete this.
From the original patch:
I had to fix a couple of additional things here:
. Avoid doing anything in OnSizeAllocation if the size hasn't
changed. Because of how gtk works I was getting stuck in a loop if I
OnSizeAllocate did anything if the size hadn't changed.
. Applied similar shortcut to TabContentsViewGtk.
. Made SimpleMenuModel only ask delegate for checked state if the item
is a check.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/274019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Adds accelerator to list of files compiled on views/gtk.
. Adds function to Screen to get monitor bounds from a window.
. Adds BrowserFrameGtk::GetAccelerator to match windows.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/275005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/271043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
description:
Numerous fixes to get parts of Chrome Sync to compile on OS X.
Fixes include:
- Added missing definitions for some static const class variables.
- Added some missing dependencies.
- Marked some Windows-only dependencies as such.
- Added stub files for some platform-specific classes.
BUG=none
TEST=Put through trybots.
Review URL: http://codereview.chromium.org/266065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23536
TEST=With an empty bookmark bar and any theme, the helper text color should match the "other bookmarks" color.
Review URL: http://codereview.chromium.org/276005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Chromium changes that correspond to this WebKit change:
https://bugs.webkit.org/show_bug.cgi?id=30135
Review URL: http://codereview.chromium.org/274024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/274029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"stats for nerds" screen.
TEST=none
BUG=http://code.google.com/p/nativeclient/issues/detail?id=108
Review URL: http://codereview.chromium.org/267043
TBR=gregoryd@google.com
Review URL: http://codereview.chromium.org/266067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
segment_usage"""
startup_tests are failing.
This reverts commit r28870.
TBR=finnur
Review URL: http://codereview.chromium.org/274026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23569
TEST=https://rbacpro.sftcomp.ru/ should report "invalid certificate" rather than crash
Review URL: http://codereview.chromium.org/270034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
have the full certificate chain.
BUG=23122
TEST=https://www.paypal.com should have "This certificate is valid" in View Page Info->View Certificate Information
Review URL: http://codereview.chromium.org/256064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=24337
Review URL: http://codereview.chromium.org/269065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
process count change.
BUG=22608
Review URL: http://codereview.chromium.org/261056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/270090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28878 0039d316-1c4b-4281-b951-d872f2087c98
|