| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
I've addressed the comments and added the test to the visual studio project. I'll commit when the tree opens.
Review URL: http://codereview.chromium.org/3049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
issued a DCHECK when I manlually deleted the NavigationController because the
tabs were still there. Calling destroy fixes this, although I have to manually
NULL out some test pointers to prevent double-frees.
Review URL: http://codereview.chromium.org/3070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2411
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
build sqlite.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
this is covered by issue 2303, 2304, 2306, 2307
Review URL: http://codereview.chromium.org/2868
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Note that this flag might not play well on Windows 2k and XP prior to SP2.
BUG:2281 Theme dll file can be used to execute code on pre-Vista OSs
Review URL: http://codereview.chromium.org/2857
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
causes an assertion in debug mode. I think this needs to be done another way.
Review URL: http://codereview.chromium.org/2873
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also commit some comment changes which were supposed to go in my original patch but missed it.
TBR=sky
BUG=1291
Review URL: http://codereview.chromium.org/2870
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Image & Option functions should have precendence than document elements.
Review URL: http://codereview.chromium.org/1968
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
are subject to change as the rest of the rendering and event handling paths
come together.
Review URL: http://codereview.chromium.org/3062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2809
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(rfind of # isn't quite right, as reference might contain hashes).
Review URL: http://codereview.chromium.org/2827
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
default search engine is Google. Our existing restrictions still apply: no fetches before five seconds after startup, and no more than one fetch per run.
Because of lazy initialization everywhere, this was hairier than I'd hoped. We have to ensure we don't try to fetch until the profile has been created, lest GetDefaultRequestContext() return NULL. Note that this was actually a bug in the existing product: if you set your startup page to, say, about:blank, and started the browser and did nothing at all for five seconds, we'd crash.
BUG=1291
Review URL: http://codereview.chromium.org/1942
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the user choices are persistent.
Patch by Arthur Lussos <developer0420@gmail.com>
Original issue at http://codereview.chromium.org/3014
Review URL: http://codereview.chromium.org/3059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2859
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to the 3.1 branch, r31616. The ones corresponding to the new WebCore are already in there, and when they land this copy will be deleted.
Review URL: http://codereview.chromium.org/2853
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2814
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
makes it requires a default constructor on its members.
Review URL: http://codereview.chromium.org/2851
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
when linking in SANDBOX_EXPORTS mode. Add pragmas to
be sure these hooks are included.
Review URL: http://codereview.chromium.org/3050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
because of the locked desktop. Replace this call in the non-interactive ui tests with a call to GetBrowserWindow(0), which is what GetActiveTab (called a few lines earlier) does anyway.
B=2235
Review URL: http://codereview.chromium.org/2844
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
B=2270
Review URL: http://codereview.chromium.org/2843
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the test since it would give the same page ID to two different pages in the
same site instance, which should not happen.
Review URL: http://codereview.chromium.org/2842
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- fix broken window resizing using the sizing borders... || should have been an &&, resulted in all non-client areas being treated as window caption.
- use the width of the client view to size the tabstrip rather than the width of the non-client view. this was causing the new tab button to be clipped.
B=2218,2267
Review URL: http://codereview.chromium.org/2841
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
in the window caption area.
B=1031854
Review URL: http://codereview.chromium.org/2840
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
NavigationController logic. The approach is that the NavigationController should be responsible for the logic and memory management of navigation. Previously, half the logic and memory management lived in WebContents which made it very hard to figure out what was going on.
I split out the various navigation types into separate functions, which then copy and update any existing NavigationEntry as necessary. Previously, WebContents would make a new one which would be manually populated with random fields (I think some were forgotten, too), and then the NavigationController may or may not commit it.
Review URL: http://codereview.chromium.org/479
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
last change to context menu encodings.
Review URL: http://codereview.chromium.org/2831
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
B=1031854
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
B=1031854
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- in the UI tests, SimulateOSClick was taking screen coordinates and the browser automation provider was treating them as client. For a click, screen coordinates seems better and is what most users were sending. This was causing the focus tests to fail since tabs weren't getting clicked on. Not sure why this wasn't affecting non-new-frames!
- a math error in BrowserView2 was leading to incorrect window sizing in constrained window tests.
- new frames mean layout is slightly different, and a constant in the constrained window test needed to be adjusted.
Review URL: http://codereview.chromium.org/2828
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
B=2235
Review URL: http://codereview.chromium.org/3039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
permit release mode building in VC++2008 SP1. The current allocators do not conform with the C++ spec for allocators, and unlike previous versions, VC++2008 requires conformant allocators.
The reason that the allocators are not conformant is that any allocator, say, template<typename T> struct Alloc; must have a constructor of the following form:
template<typename U> Alloc(const Alloc<U>& other)
to allow construction of an Alloc<T> from an Alloc<U>. The constructors cannot be explicit, because they're (essentially) copy constructors, and so are not called explicitly.
StackAllocator has no converting copy constructor at all, and PrivateHookAllocator's is declared explicit, preventing it from being usable.
Without the StackAllocator constructor, StackVectors fail (due to the std::vector member, base\stack_container.h(216)).
Patch by Peter Bright <drpizza@quiscalusmexicanus.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2822
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
B=2205
Review URL: http://codereview.chromium.org/2825
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
browser/download/
browser/views/
Review URL: http://codereview.chromium.org/2826
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2166 0039d316-1c4b-4281-b951-d872f2087c98
|