summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Simple unit test, written mostly just to become familiar with the code.dkegel@google.com2008-09-153-0/+123
| | | | | | | I've addressed the comments and added the test to the visual studio project. I'll commit when the tree opens. Review URL: http://codereview.chromium.org/3049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2249 0039d316-1c4b-4281-b951-d872f2087c98
* Try again to fix the memory problems in NavigationController. The previous onebrettw@google.com2008-09-151-5/+9
| | | | | | | | | issued a DCHECK when I manlually deleted the NavigationController because the tabs were still there. Calling destroy fixes this, although I have to manually NULL out some test pointers to prevent double-frees. Review URL: http://codereview.chromium.org/3070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2247 0039d316-1c4b-4281-b951-d872f2087c98
* Adding sync plugin messages, and plugin broadcasts to the renderer processeszork@google.com2008-09-1510-18/+163
| | | | | | Review URL: http://codereview.chromium.org/2411 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2246 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to get a small part of chrome/SConscript building. For now, just ↵tc@google.com2008-09-153-240/+261
| | | | | | build sqlite. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2245 0039d316-1c4b-4281-b951-d872f2087c98
* All these tests are failing in the jail.nsylvain@chromium.org2008-09-151-0/+57
| | | | | | | this is covered by issue 2303, 2304, 2306, 2307 Review URL: http://codereview.chromium.org/2868 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2244 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure we don't execute code from the theme dll.nsylvain@chromium.org2008-09-151-1/+1
| | | | | | | | | Note that this flag might not play well on Windows 2k and XP prior to SP2. BUG:2281 Theme dll file can be used to execute code on pre-Vista OSs Review URL: http://codereview.chromium.org/2857 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2243 0039d316-1c4b-4281-b951-d872f2087c98
* Revert my last fix for a memory leak in the navigation controller tests. Thisbrettw@google.com2008-09-151-2/+2
| | | | | | | causes an assertion in debug mode. I think this needs to be done another way. Review URL: http://codereview.chromium.org/2873 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2239 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak in the unit tests.brettw@google.com2008-09-151-2/+2
| | | | | | Review URL: http://codereview.chromium.org/3067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2237 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore LayoutTests.maruel@google.com2008-09-150-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2236 0039d316-1c4b-4281-b951-d872f2087c98
* First stab at lib dependenciesavi@google.com2008-09-152-1/+396
| | | | | | Review URL: http://codereview.chromium.org/3065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2235 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unittest bustage due to NULL pointer deref (only in unittest mode, I hope).pkasting@chromium.org2008-09-153-12/+18
| | | | | | | | | | | Also commit some comment changes which were supposed to go in my original patch but missed it. TBR=sky BUG=1291 Review URL: http://codereview.chromium.org/2870 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2233 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the issue http://code.google.com/p/v8/issues/detail?id=43fqian@google.com2008-09-154-16/+39
| | | | | | | | Image & Option functions should have precendence than document elements. Review URL: http://codereview.chromium.org/1968 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2232 0039d316-1c4b-4281-b951-d872f2087c98
* Add test shell WebView and WebWidget host classes. This are stopgaps andamanda@chromium.org2008-09-156-4/+1147
| | | | | | | | are subject to change as the rest of the rendering and event handling paths come together. Review URL: http://codereview.chromium.org/3062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2230 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the link paths.avi@google.com2008-09-151-4/+12
| | | | | | Review URL: http://codereview.chromium.org/3061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2228 0039d316-1c4b-4281-b951-d872f2087c98
* Make jsbindings target depend on libxml_config (r=me/pink)mark@chromium.org2008-09-151-0/+85
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2227 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to test shell on Mac.avi@google.com2008-09-153-123/+95
| | | | | | Review URL: http://codereview.chromium.org/2809 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2226 0039d316-1c4b-4281-b951-d872f2087c98
* Address a TODO for properly stripping references from request URL.ericroman@google.com2008-09-154-10/+65
| | | | | | | | (rfind of # isn't quite right, as reference might contain hashes). Review URL: http://codereview.chromium.org/2827 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2225 0039d316-1c4b-4281-b951-d872f2087c98
* Make the GoogleURLTracker only fetch the Google hostname if the user's ↵pkasting@chromium.org2008-09-156-30/+168
| | | | | | | | | | | default search engine is Google. Our existing restrictions still apply: no fetches before five seconds after startup, and no more than one fetch per run. Because of lazy initialization everywhere, this was hairier than I'd hoped. We have to ensure we don't try to fetch until the profile has been created, lest GetDefaultRequestContext() return NULL. Note that this was actually a bug in the existing product: if you set your startup page to, say, about:blank, and started the browser and did nothing at all for five seconds, we'd crash. BUG=1291 Review URL: http://codereview.chromium.org/1942 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2223 0039d316-1c4b-4281-b951-d872f2087c98
* Add preferences for the clear browsing data dialog so thattc@google.com2008-09-155-5/+48
| | | | | | | | | | | the user choices are persistent. Patch by Arthur Lussos <developer0420@gmail.com> Original issue at http://codereview.chromium.org/3014 Review URL: http://codereview.chromium.org/3059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2222 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the unneeded pending entry from the unit tests.brettw@google.com2008-09-151-17/+0
| | | | | | Review URL: http://codereview.chromium.org/2859 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2220 0039d316-1c4b-4281-b951-d872f2087c98
* Add in a temp copy of the WebKit SPI files. These are the ones corresponding ↵avi@google.com2008-09-155-6/+329
| | | | | | | | to the 3.1 branch, r31616. The ones corresponding to the new WebCore are already in there, and when they land this copy will be deleted. Review URL: http://codereview.chromium.org/2853 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2219 0039d316-1c4b-4281-b951-d872f2087c98
* Turn off ActiveX for non-Windows platformsavi@google.com2008-09-152-1/+9
| | | | | | Review URL: http://codereview.chromium.org/2814 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2216 0039d316-1c4b-4281-b951-d872f2087c98
* An early optimization in std::pair<> in Visual Studio 2008 Service Pack 1 ↵maruel@google.com2008-09-151-0/+9
| | | | | | | | makes it requires a default constructor on its members. Review URL: http://codereview.chromium.org/2851 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2212 0039d316-1c4b-4281-b951-d872f2087c98
* For some reasons the linker excludes 2 of our hooksnsylvain@chromium.org2008-09-151-0/+4
| | | | | | | | | when linking in SANDBOX_EXPORTS mode. Add pragmas to be sure these hooks are included. Review URL: http://codereview.chromium.org/3050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2211 0039d316-1c4b-4281-b951-d872f2087c98
* Occasionally GetLastActiveBrowserWindow fails on the build bots, probably ↵beng@google.com2008-09-151-1/+1
| | | | | | | | | | because of the locked desktop. Replace this call in the non-interactive ui tests with a call to GetBrowserWindow(0), which is what GetActiveTab (called a few lines earlier) does anyway. B=2235 Review URL: http://codereview.chromium.org/2844 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2210 0039d316-1c4b-4281-b951-d872f2087c98
* Hit test zone for the new tab button should follow its visible shape.beng@google.com2008-09-141-1/+57
| | | | | | | B=2270 Review URL: http://codereview.chromium.org/2843 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2209 0039d316-1c4b-4281-b951-d872f2087c98
* Revert these changes now the experiment is complete.beng@google.com2008-09-143-5/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2208 0039d316-1c4b-4281-b951-d872f2087c98
* Yet another test, this time with a tweak to the find test.beng@google.com2008-09-143-1/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2207 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a debug assertin when running the web contents unit test. The error is inbrettw@google.com2008-09-141-0/+3
| | | | | | | | the test since it would give the same page ID to two different pages in the same site instance, which should not happen. Review URL: http://codereview.chromium.org/2842 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2206 0039d316-1c4b-4281-b951-d872f2087c98
* A couple of tweaks to the AeroGlassNonClientView:beng@google.com2008-09-141-2/+2
| | | | | | | | | | - fix broken window resizing using the sizing borders... || should have been an &&, resulted in all non-client areas being treated as window caption. - use the width of the client view to size the tabstrip rather than the width of the non-client view. this was causing the new tab button to be clipped. B=2218,2267 Review URL: http://codereview.chromium.org/2841 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2205 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back frame test now buildbots have cycled.beng@google.com2008-09-142-3/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2204 0039d316-1c4b-4281-b951-d872f2087c98
* Test frames on the builders again to see if notification change helped.beng@google.com2008-09-142-0/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2203 0039d316-1c4b-4281-b951-d872f2087c98
* Include the area to the right of the tabstrip underneath the window controls ↵beng@google.com2008-09-141-3/+11
| | | | | | | | | in the window caption area. B=1031854 Review URL: http://codereview.chromium.org/2840 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2202 0039d316-1c4b-4281-b951-d872f2087c98
* This is almost a complete rewrite of DidNavigate and the associated ↵brettw@google.com2008-09-1424-990/+1304
| | | | | | | | | | NavigationController logic. The approach is that the NavigationController should be responsible for the logic and memory management of navigation. Previously, half the logic and memory management lived in WebContents which made it very hard to figure out what was going on. I split out the various navigation types into separate functions, which then copy and update any existing NavigationEntry as necessary. Previously, WebContents would make a new one which would be manually populated with random fields (I think some were forgotten, too), and then the NavigationController may or may not commit it. Review URL: http://codereview.chromium.org/479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2201 0039d316-1c4b-4281-b951-d872f2087c98
* Update overridden function signature for the test to bring it in sync with mybrettw@google.com2008-09-142-4/+2
| | | | | | | last change to context menu encodings. Review URL: http://codereview.chromium.org/2831 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2190 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back frames now test run is complete.beng@google.com2008-09-142-3/+0
| | | | | | | B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2188 0039d316-1c4b-4281-b951-d872f2087c98
* Test new frames on buildbots again.beng@google.com2008-09-142-0/+3
| | | | | | B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2183 0039d316-1c4b-4281-b951-d872f2087c98
* Fix interactive UI tests...beng@google.com2008-09-143-8/+15
| | | | | | | | | | - in the UI tests, SimulateOSClick was taking screen coordinates and the browser automation provider was treating them as client. For a click, screen coordinates seems better and is what most users were sending. This was causing the focus tests to fail since tabs weren't getting clicked on. Not sure why this wasn't affecting non-new-frames! - a math error in BrowserView2 was leading to incorrect window sizing in constrained window tests. - new frames mean layout is slightly different, and a constant in the constrained window test needed to be adjusted. Review URL: http://codereview.chromium.org/2828 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2180 0039d316-1c4b-4281-b951-d872f2087c98
* Get the new frames to pass the accessibility UI tests.beng@google.com2008-09-144-8/+90
| | | | | | | | B=2235 Review URL: http://codereview.chromium.org/3039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2177 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an include path.paulg@google.com2008-09-141-1/+1
| | | | | | Review URL: http://codereview.chromium.org/3041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2176 0039d316-1c4b-4281-b951-d872f2087c98
* Provide necessary constructors in StackAllocator and PrivateHookAllocator to ↵maruel@google.com2008-09-143-5/+24
| | | | | | | | | | | | | | | | | permit release mode building in VC++2008 SP1. The current allocators do not conform with the C++ spec for allocators, and unlike previous versions, VC++2008 requires conformant allocators. The reason that the allocators are not conformant is that any allocator, say, template<typename T> struct Alloc; must have a constructor of the following form: template<typename U> Alloc(const Alloc<U>& other) to allow construction of an Alloc<T> from an Alloc<U>. The constructors cannot be explicit, because they're (essentially) copy constructors, and so are not called explicitly. StackAllocator has no converting copy constructor at all, and PrivateHookAllocator's is declared explicit, preventing it from being usable. Without the StackAllocator constructor, StackVectors fail (due to the std::vector member, base\stack_container.h(216)). Patch by Peter Bright <drpizza@quiscalusmexicanus.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2175 0039d316-1c4b-4281-b951-d872f2087c98
* Move the Save Page code to the browser/download/ directory.paulg@google.com2008-09-1422-92/+96
| | | | | | Review URL: http://codereview.chromium.org/3040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2174 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit test for HttpResponseHeaders::GetStatusText()ericroman@google.com2008-09-132-10/+38
| | | | | | Review URL: http://codereview.chromium.org/2822 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2173 0039d316-1c4b-4281-b951-d872f2087c98
* fix build bustagebeng@google.com2008-09-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2172 0039d316-1c4b-4281-b951-d872f2087c98
* fix build bustagebeng@google.com2008-09-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2171 0039d316-1c4b-4281-b951-d872f2087c98
* fix build bustagebeng@google.com2008-09-132-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2170 0039d316-1c4b-4281-b951-d872f2087c98
* Move more UI stuff into browser/viewsbeng@google.com2008-09-1353-109/+109
| | | | | | | B=2205 Review URL: http://codereview.chromium.org/2825 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2169 0039d316-1c4b-4281-b951-d872f2087c98
* turn off new frames again.beng@google.com2008-09-131-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2168 0039d316-1c4b-4281-b951-d872f2087c98
* testing new frames on one cycle of buildbotsbeng@google.com2008-09-131-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2167 0039d316-1c4b-4281-b951-d872f2087c98
* Move the download code to new directories:paulg@google.com2008-09-1335-94/+96
| | | | | | | | | browser/download/ browser/views/ Review URL: http://codereview.chromium.org/2826 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2166 0039d316-1c4b-4281-b951-d872f2087c98