summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* A build fix for gcc 4.3 (and later).craig.schlenter@chromium.org2009-09-171-25/+35
| | | | | | | | | | | | Comparing a function with NULL has been prohibited since gcc 4.3 and produces a compilation error. This change encloses your code which compares a function with NULL with "#if defined(OS_MACOSX) && MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_5" and "#endif". BUG=none TEST=build chromium with gcc 4.3 (and later) Review URL: http://codereview.chromium.org/206024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26449 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Update 48423:48468.dglazkov@chromium.org2009-09-172-1/+7
| | | | | | | | | | TBR=ukai BUG=none TEST=none Review URL: http://codereview.chromium.org/214009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26448 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the memcheck suppression rule for bug 22109.tyoshino@google.com2009-09-171-4/+0
| | | | | | | | | | | | The signature was too specific. Extend the matching rule for similar failures. BUG=22109 TEST=none Review URL: http://codereview.chromium.org/215009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26447 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ExtensionViews and toolstrip browser tests becausensylvain@chromium.org2009-09-171-2/+4
| | | | | | | | | they crash all the time on the new vista bot (in skia). BUG:22135 Review URL: http://codereview.chromium.org/209015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26446 0039d316-1c4b-4281-b951-d872f2087c98
* Unhang valgrind webkit tests.dank@chromium.org2009-09-171-0/+2
| | | | | | | | BUG=22134 Review URL: http://codereview.chromium.org/215010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26444 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing gclient dependencies to .gitignore.maruel@chromium.org2009-09-1727-3969/+3970
| | | | | | | | | | | | | | Fix the format of many directories so they don't show up in git status anymore. Run dos2unix on *.cc, caught many inconsistent and CRLF files. TBR=evan TEST=still build, git status shows nothing BUG=none Review URL: http://codereview.chromium.org/211010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26441 0039d316-1c4b-4281-b951-d872f2087c98
* Fix EOL inconsistency on extension_message_service.cc.maruel@chromium.org2009-09-171-1/+1
| | | | | | | | | | | | NO CODE CHANGE. The presubmit check should have warned you. Please listen to it. This causes breakage on the try slaves because SVN is too stupid to revert a file with inconsistent EOL, go figure. TBR=mpcomplete TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26439 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress valgrind leak report. Bug 22109tyoshino@google.com2009-09-171-0/+15
| | | | | | | | | | BUG=22109 TBR=mbelshe TEST=none Review URL: http://codereview.chromium.org/210008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26436 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new reliability test failure in ↵tyoshino@google.com2009-09-171-0/+3
| | | | | | | | | | | DeleteTask<webkit_glue::WebPluginImpl>::Run to known_crashes.txt TBR=agl BUG=22106 Review URL: http://codereview.chromium.org/215006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26435 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mouse over status bubble.darin@chromium.org2009-09-171-1/+1
| | | | | | | | | | R=dglazkov BUG=22050 TEST=none Review URL: http://codereview.chromium.org/215001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26434 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress Valgrind leak base::MessagePumpLibevent::WatchFileDescriptor.tyoshino@google.com2009-09-171-0/+23
| | | | | | | | | | TBR=agl BUG=22098 TEST=none Review URL: http://codereview.chromium.org/215005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26433 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r26431.craig.schlenter@chromium.org2009-09-171-6/+0
| | | | | | | | | It broke the tree which seems unrelated but Mark also wants hbono's patch landed instead of this one. Review URL: http://codereview.chromium.org/211007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26432 0039d316-1c4b-4281-b951-d872f2087c98
* Squash warnings about backtrace et. al. not being NULL on Linux.craig.schlenter@chromium.org2009-09-171-0/+6
| | | | | | | | | The warnings are legit but it seems cleaner to do this than to do tons of #if defined(OS_MACOSX) bits to handle the changes from r26285. Review URL: http://codereview.chromium.org/206026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26431 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 26419.tyoshino@google.com2009-09-176-226/+91
| | | | | | | | | | | | | | | | | | | | | | Looks like this CL caused failure in Modules Linux (valgrind) http://chrome-buildbot.corp.google.com:8010/builders/Modules%20Linux%20(valgrind)/builds/1104/steps/valgrind%20test:%20base/logs/stdio http://chrome-buildbot.corp.google.com:8010/builders/Modules%20Linux%20(valgrind)/builds/1103/steps/valgrind%20test:%20base/logs/stdio [----------] 6 tests from ClipboardTest [ RUN ] ClipboardTest.ClearTest command timed out: 1200 seconds without output, killing pid 7479 process killed by signal 9 program finished with exit code -1 TBR=phajdan.jr Review URL: http://codereview.chromium.org/212007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26430 0039d316-1c4b-4281-b951-d872f2087c98
* linux: add names to some widgets for parasite's benefitevan@chromium.org2009-09-174-0/+4
| | | | | | Review URL: http://codereview.chromium.org/212002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26424 0039d316-1c4b-4281-b951-d872f2087c98
* Make WeakPtr harder to misuse.phajdan.jr@chromium.org2009-09-171-2/+20
| | | | | | | | | | | | Well, I managed to misuse it (issue caught in review), and these DCHECKS will catch it. TEST=none BUG=none Review URL: http://codereview.chromium.org/207005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26422 0039d316-1c4b-4281-b951-d872f2087c98
* Changing command buffer to use structs instead ofgman@google.com2009-09-175-646/+1254
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | arrays, step 1 I hope I'm not stepping on any toes here. I wanted to write some command buffer code but I didn't want to go poking values into arrays so I thought I'd attempt to refactor a little. I hope I'm not steping on any toes. Some answers to possible questions. O3D_COMMAND_ARGS_FLAG_AT_LEAST_N is a macro because it needs to be a compile time constant so I can generate the table. All the commands with a FixMe are to be done in another CL. The Structs don't follow the style guide because it's just busy work to match up SET_TOKEN and SetToken. It seems like a reasonable exception to me. This way the functions, IDs and structs all match easily and therefore lists that use them be automatically generated and kept in sync. The next step is I want to uncompress some of the commands. As an example, it doesn't seem like CreateTexture2D should squeeze width and height into 16bits halfs of a 32bit value. This API is not targeted at machines with 2K of memory and the amount of code and other scaffolding around decoding those 2 16bit halfs far outways saving 16bits in a command that allocates a texture. It also makes it harder to use the command because the person generating it has to also go through the same hoops. Review URL: http://codereview.chromium.org/206020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26421 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Windows: Warn about outdated plugins."agl@chromium.org2009-09-168-302/+1
| | | | | | | This reverts commit r26409. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26420 0039d316-1c4b-4281-b951-d872f2087c98
* Cache login identity for NewFTP transactions.phajdan.jr@chromium.org2009-09-166-91/+226
| | | | | | | | | TEST=net_unittests BUG=21184 Review URL: http://codereview.chromium.org/201083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26419 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't put a blank line in the tooltip for nameless bookmark bar bookmarks.estade@chromium.org2009-09-161-1/+1
| | | | | | | | | | | | | Man, why is it so hard to get this right?? BUG=none TEST=look at tooltips for a bookmark that has a) no title b) no url (folder) c) both title and url Review URL: http://codereview.chromium.org/207003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26418 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak the sidenav. Also remove unnecessary end-of-line white spacekathyw@google.com2009-09-1628-1236/+1283
| | | | | | | | | | from the template, so that we'll have fewer presubmit warnings. TBR=aa Review URL: http://codereview.chromium.org/214001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26417 0039d316-1c4b-4281-b951-d872f2087c98
* Restore logging of preference errors.darin@chromium.org2009-09-162-2/+7
| | | | | | | | | | | | Sadly, this means we again fail some tests. R=dglazkov BUG=none TEST=none Review URL: http://codereview.chromium.org/206036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26416 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid gyp_chromium duplicating an include that's already in the command line.mattm@chromium.org2009-09-161-9/+31
| | | | | | | | | | | Fixes automatic makefile regeneration from duplicating gcc flags and causing a full rebuild each time. BUG=none TEST=make && touch chrome/chrome.gyp && make Review URL: http://codereview.chromium.org/207004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26415 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash issue of AutocompleteEditViewTest.suzhe@chromium.org2009-09-161-3/+22
| | | | | | | | | | | This CL fixes a crash issue of AutocompleteEditViewTest, which is due to not waiting for bookmark model and history service being fully loaded. BUG=21971 TEST=none Review URL: http://codereview.chromium.org/201135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26413 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing lame bug in radiobutton. oshima@chromium.org2009-09-161-1/+1
| | | | | | | | | The UsesNativeRatioButtonGropu condition was inverse. RadioButton should use its own grouping logic when native grouping is not used. (on windows) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26411 0039d316-1c4b-4281-b951-d872f2087c98
* Oops, copy and paste error with the licenses for these files.jorlow@chromium.org2009-09-164-8/+8
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/194126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26410 0039d316-1c4b-4281-b951-d872f2087c98
* Windows: Warn about outdated plugins.agl@chromium.org2009-09-168-1/+302
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add the infrastructure for detecting out of date plugins and warning the user about them. Glen was ok with the infobar, although he notes that there will be a better 'notifications' UI for this sort of thing in the future. This UI will trigger at most once a day and only when we load the plugin information. This patch appears to duplicate some information from plugins2.xml, which is the plugins database that the default plugin uses to install missing plugins. I'm not reusing that information in this patch: * Note that the names of the plugins are different between the two. plugins2.xml uses a 'friendly' name, while this code needs to know the name that the plugin itself uses. * Also note that URLs are different. plugins2.xml wants a link to an exe for the installer, while we want a landing page. * The code for loading and parsing plugins2.xml is in the default plugin, and thus would require a lot of major refactoring to use here. Regarding the second point, above. One could imagine that we open a tab to "about:update-plugin#MAGICSTRING,application/x-shockwave". Javascript on that page notes the fragment in the URL and creates a plugin of the correct type on the page, passing MAGICSTRING to the plugin. The renderers are updated to know that all plugins on about pages should be directed to the default plugin. The default plugin notes the MAGICSTRING argument and uses a new NPAPI call to validate the string. MAGICSTRING will be a random string, created once per instance which is needed so that the default plugin can know that it's running on behalf of the browser, not some random webpage. When it validates, it doesn't wait for the user to click inside the plugin to trigger the download. It also doesn't trigger a page reload afterwards, instead draws text to the effect of "Successful install". This alternative design would remove the duplication, at the cost of a lot of work. Since it's a UI question, I asked Ben and Glen. However, they didn't get back to me so, for now at least, this simplier solution will suffice. BUG=21100 http://codereview.chromium.org/197053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26409 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor gyp_chromium so you don't have to execute it from the src/.. directory.sgk@google.com2009-09-161-16/+16
| | | | | | | | BUG=none TEST='python src/build/gyp_chromium; cd src; python build/gyp_chromium; cd build; python gyp_chromium' Review URL: http://codereview.chromium.org/195107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26408 0039d316-1c4b-4281-b951-d872f2087c98
* Handle some startup errors encountered by ModelAssociator (such as tim@chromium.org2009-09-1611-14/+55
| | | | | | | | | | | | unable to find tagged nodes) more gracefully by triggering the unrecoverable error handler. This was in response to a suggestion from chron, as we seem to hit this case a fair bit, and crashing is a pain. More importantly it's possible users are hitting it as well and having an explicit error case / message hidden on the options dialog is better than silently failing with no inkling as to what happened. It also just seems preferable to be in the PSS error state when this happens. Review URL: http://codereview.chromium.org/201119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26407 0039d316-1c4b-4281-b951-d872f2087c98
* Widen suppression for bug 22021 for macdkegel@google.com2009-09-161-1/+1
| | | | | | | | BUG=22021 Review URL: http://codereview.chromium.org/211001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26406 0039d316-1c4b-4281-b951-d872f2087c98
* Add another suppression for the memory leak resulting fromagl@chromium.org2009-09-161-0/+7
| | | | | | | today's WebKit roll. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26403 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix Linux Views build.pkasting@chromium.org2009-09-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26402 0039d316-1c4b-4281-b951-d872f2087c98
* Escape ampersands in web view text selection for right click context menu so ↵estade@chromium.org2009-09-162-8/+30
| | | | | | | | | | | | that they don't show up as mnemonics. Also escape underscores in gtk menus so they don't show up as mnemonics (we use ampersands to match windows). BUG=14587 Review URL: http://codereview.chromium.org/203078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26401 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Add a dialog for printing.estade@chromium.org2009-09-1610-13/+277
| | | | | | | | | | | | Add an infobar directing users to tell us if they have problems with printing. Hide printing behind --enable-printing flag on linux/gtk. BUG=9847 TEST=none Review URL: http://codereview.chromium.org/200138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26400 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts fix for the scons build and fixes it in a different way sogspencer@google.com2009-09-162-5/+18
| | | | | | | | that both the scons and gyp builds are functional. Review URL: http://codereview.chromium.org/204049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26399 0039d316-1c4b-4281-b951-d872f2087c98
* Gears File Drag Dropmichaeln@google.com2009-09-169-26/+36
| | | | | | | | | | | | | | | | | r24899 now keys the child security policy database based on renderer id, rather than renderer process id. Update gears drag drop to use the renderer id for the file policy access checks. This is a clone for submission of of noel's original CL http://codereview.chromium.org/195079 BUG=7995 Review URL: http://codereview.chromium.org/196145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26397 0039d316-1c4b-4281-b951-d872f2087c98
* Rename test_web_contents.* to test_tab_contents.*tony@chromium.org2009-09-167-12/+10
| | | | | | | | | Just a small cleanup. Review URL: http://codereview.chromium.org/206037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26396 0039d316-1c4b-4281-b951-d872f2087c98
* Convert InfoBubble to using BubbleBorder. This also replaces the border ↵pkasting@chromium.org2009-09-1623-446/+478
| | | | | | | | | | | | graphics with a slightly darker set from Nicholas. The downside here is that the Linux views code is definitely going to be broken by this. I'm not sure of the best design for Linux views, so I haven't implemented one. BUG=21028 TEST=Open info bubbles (click star button, hover lock icon) and observe they are rendered with an identical border/shadow to the Omnibox dropdown, and at the same vertical position. Review URL: http://codereview.chromium.org/195099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26394 0039d316-1c4b-4281-b951-d872f2087c98
* Roll deps to pick up newer GTM for sheet fix.thomasvl@chromium.org2009-09-161-1/+1
| | | | | | | | TEST=http auth works again BUG=22013 Review URL: http://codereview.chromium.org/206039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26393 0039d316-1c4b-4281-b951-d872f2087c98
* Add test for history HTML escaping issue.cevans@chromium.org2009-09-161-0/+17
| | | | | | | | | BUG=17892 TEST=SessionHistoryTest.HistorySearchXSS Review URL: http://codereview.chromium.org/206040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26392 0039d316-1c4b-4281-b951-d872f2087c98
* Roll gyp deps to delete old gyp_chromium from src/tools/gyp/.tony@chromium.org2009-09-161-1/+1
| | | | | | | | | TBR=evanm Review URL: http://codereview.chromium.org/204048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26391 0039d316-1c4b-4281-b951-d872f2087c98
* Disable FilePathTest.AppendRelativeTest from r26387.mark@chromium.org2009-09-161-1/+1
| | | | | | Review URL: http://codereview.chromium.org/194132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26390 0039d316-1c4b-4281-b951-d872f2087c98
* Make LeakTracker be enabled using ENABLE_LEAK_TRACKER, rather than NDEBUG.eroman@chromium.org2009-09-162-16/+20
| | | | | | | | This way it is easy to toggle it on in release builds. Review URL: http://codereview.chromium.org/196130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26389 0039d316-1c4b-4281-b951-d872f2087c98
* Set svn:eol-style = LF on some files in sqlite.mark@chromium.org2009-09-161-6294/+6294
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26388 0039d316-1c4b-4281-b951-d872f2087c98
* Set OS X cache directory to ~/Library/Caches/[app name]/[profile name] mark@chromium.org2009-09-168-15/+160
| | | | | | | | | | | | | - Added implementation of GetUserCacheDirectory() for OS X. - Added FilePath::GetRelativePath(). - Implemented per-profile cache directories for OS X. Patch by Fred Akalin <akalin@gmail.com> Code review URL: http://codereview.chromium.org/174053 Review URL: http://codereview.chromium.org/204043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26387 0039d316-1c4b-4281-b951-d872f2087c98
* Abort WebKit bisection and update suppressions for leak. Looksagl@chromium.org2009-09-163-5/+8
| | | | | | | like this is already being worked on in bug 22021. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26386 0039d316-1c4b-4281-b951-d872f2087c98
* Starting to bisect the WebKit merge: step 1agl@chromium.org2009-09-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26385 0039d316-1c4b-4281-b951-d872f2087c98
* play-state is failing in Release too.agl@chromium.org2009-09-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26384 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix: vim wrapped the lineagl@chromium.org2009-09-161-2/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26382 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r26376 "Expectations for 3 perf systems"chase@chromium.org2009-09-161-7/+3
| | | | | | | | BUG=18597 TBR=nsylvain Review URL: http://codereview.chromium.org/201138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26380 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 10:27:38 +0000