| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Fix GView interceptor unit tests to match what is supposed to happen in the presence of the PDF internal plug-in on ChromeOS.
BUG=51242
TEST=GViewRequestInterceptorTest.DoNotInterceptPdfWhenEnabled, GViewRequestInterceptorTest.InterceptPdfWhenDisabled
Review URL: http://codereview.chromium.org/3308016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54898
TEST=first run in Hebrew
Review URL: http://codereview.chromium.org/3369012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Differences from the above CL include the following:
- RendererPreferences settings for ExtensionHosts are now extracted from the associated_tab_contents(). This ensures that extension hosts will also forward top level navigation requests.
- Instead of explicitly setting the delegate on the TabContents in ExtensionHost::ShowCreatedWindow, instead I instruct the associated tab-contents to add the newly build tab-contents. Note that this is the exact same behaviour performed by TabContents when initiating a top-level navigation to the host browser.
Points of interest:
- See the TODO in navigation_controller.cc. This problem of an unrecognized navigation entry needs further investigation.
- Also, I found that if the ActiveX control is navigated to a chrome-extension URL, then the top-level-navigation will fail because of the format of the URL. The fix was to construct a temporary url in place of the chrome-extension url.
BUG=51091
TEST=None
Review URL: http://codereview.chromium.org/3357013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that some gpu_info will actually exist. It does this by refreshing the page every 5 seconds until a context does exist, if necessary.
We also looked into other methods:
- synchronous call to create context, but that will hang if there are issues creating a context
- a call back, but that will also hang until we have a gpu context
- display no data and rely on the user to refresh which is somewhat unintuitive to the user
The method in this CL seemed to be the least annoying method of doing this which didn't cause the browser to hang.
BUG=none
TEST=visual
Review URL: http://codereview.chromium.org/3348007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to read files when registering the blob data.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3326017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes a lot of duplication, locking, and thread jumping.
Most of the operations run on the FILE thread, and we do not duplicate
so much information. Each DownloadFile keeps track of its DownloadManager
(each Profile has its own DownloadManager). This allows us to remove
many maps from DownloadFileManager that were duplicating that information.
There is still SaveFileManager, but hopefully I will be able
to merge those two in small steps.
Hopefully, this is http://codereview.chromium.org/3245005 done right.
TEST=unit_tests, browser_tests, ui_tests
BUG=48913
Review URL: http://codereview.chromium.org/3347018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the return value
of the chrome extension API, since a false does not represent an error. Added
an optional callback to the API so that caller can determine if the ping was
sent or not.
This CL is to reapply change 58827, which was reverted due to a test break.
I found an uninitialized variable in the underlying RLZ code, see
http://code.google.com/p/rlz/source/detail?r=18 for the fix. This CL includes
a bump of the RLZ library to get this fix. The tests have been expanded a bit
too since 58827.
BUG=54294
TEST=n/a
Review URL: http://codereview.chromium.org/3350016
TBR=rogerta@google.com
Review URL: http://codereview.chromium.org/3330019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PyAuto import tests copy over saved firefox profiles from data dir to the
location where firefox stores it profile. If intermediate dirs are missing
(when firefox has never been launched on the target machine), the test
crashes. This fixes it by creating intermediate dirs.
BUG=
TEST=
Review URL: http://codereview.chromium.org/3348018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved XmppSocketAdapter and friends to remoting directory.
Removed some dead code in jingle/.
This is a relanding of 59012, which was mistakenly reverted at 59104.
BUG=54146,55116
TEST=none
TBR=willchan
Review URL: http://codereview.chromium.org/3300030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
provider to be specified via the constructor.
Subsequently we will be able to use these classes for Chrome Frame as well without adding Chrome Frame policy entries to Chrome's.
TEST=Run the policy tests. There should be no change since I'm mostly just shifting code around.
BUG=29349
Review URL: http://codereview.chromium.org/3298012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the code is IPv6-correct.
This is a follow-up to an earlier review.
BUG=none
TEST=ui_tests
Review URL: http://codereview.chromium.org/3372008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeFrame when we
update the navigation state. We now default to SECURELOCK_SET_UNSECURE in case of any auth
errors.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=53649
Bug=53649
Review URL: http://codereview.chromium.org/3345020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of the chrome extension API, since a false does not represent an error. Added
an optional callback to the API so that caller can determine if the ping was
sent or not.
This CL is to reapply change 58827, which was reverted due to a test break.
I found an uninitialized variable in the underlying RLZ code, see
http://code.google.com/p/rlz/source/detail?r=18 for the fix. This CL includes
a bump of the RLZ library to get this fix. The tests have been expanded a bit
too since 58827.
BUG=54294
TEST=n/a
Review URL: http://codereview.chromium.org/3350016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sets the initial allocation for a widget when a size is passed in to
WidgetGtk::Init(). The timing of the init call as part of creating a
new tab contents view means that the arrangment of the hierarchy isn't
complete yet, so incorrect contents get shown. This goes back to the original behavior which is to ignore the initial size request (it's now ignored at the TabContentsViewGtk::CreateView level instead of being implicitly ignored in the WidgetGtk::Init code).
BUG=53870
TEST=Create new tabs, no flash of old tabs seen.
Review URL: http://codereview.chromium.org/3290016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, get ride of the template on LoginLibrary::Delegate. Most of the files are here due to that.
BUG=chromium-os:4929
TEST=None
Review URL: http://codereview.chromium.org/3319018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
So that it does not introduce static initializers into including files.
TEST=try
BUG=54904
Review URL: http://codereview.chromium.org/3354018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
for Windows
BUG=54871
TEST=in the bug
Review URL: http://codereview.chromium.org/3375001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
changed prefix on all newly added
histograms over to "Cookie."; there are enough such (and
Net. is already big enough) that a new group seemed warranted.
BUG=None
TEST=Trybots only.
Review URL: http://codereview.chromium.org/3319019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is to give the renderer or plugin process an opportunity to recover.
TEST=try
BUG=none
Review URL: http://codereview.chromium.org/3305028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=52367
TEST=none
Review URL: http://codereview.chromium.org/3368010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
permission to use.
Landing: http://codereview.chromium.org/3329022/show for finnur who can't currently build extension docs.
TBR=finnur
BUG=43743
TEST=None (doc change)
Review URL: http://codereview.chromium.org/3367024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added private interface to access resources from pepper plugin.
Added example to PDF srting resource.
BUG=54322
TEST=none
Review URL: http://codereview.chromium.org/3305029
TBR=gene@chromium.org
Review URL: http://codereview.chromium.org/3304019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added private interface to access resources from pepper plugin.
Added example to PDF srting resource.
BUG=54322
TEST=none
Review URL: http://codereview.chromium.org/3305029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
menu, don't "open all".
BUG=http://crbug.com/52488
TEST=
1) Confirm command-click on a folder still does OpenAllInNewTab.
2) Open a folder than has subfolders with bookmarks in them.
Hold command and move mouse slowly across the folder.
Make sure an "open all" is NOT triggered.
Review URL: http://codereview.chromium.org/3329021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To do this, this CL generalize the TabContentsFileSelectHelper (renamed FileSelectHelper) so it is associated with a RenderViewHost rather than a TabContents.
This allows the extension popups which don't use a TabContents to use it.
As part of that, I also moved GetTopLevelNativeWindow() from TabContentsView to TabContent, as it can be implemented in a non-platform specific way.
BUG=28829
TEST=Make sure you can still open file on web pages (such as http://www.cs.tut.fi/~jkorpela/forms/file.html.
Create an extension with a popup that contains an input file tag. Make sure it does open a file dialog and lets you choose a file.
Review URL: http://codereview.chromium.org/3209002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This caused us to write to ChromeNetLog from the sync thread. ChromeNetLog is not thread safe, so this causes problems.
BUG=55116,54146
TEST=Start up chrome. Does not repeatedly hit DCHECKs on ChromeNetLog::AddEntry().
Review URL: http://codereview.chromium.org/3358028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
by wtc (but I excluded from cl so I could still use the try
servers for that cl).
TBR=wtc
BUG=http://crbug.com/52916
TEST=None
Review URL: http://codereview.chromium.org/3292017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HKLM too (not just success messages).
The toast text changes are listed in the bug; basically we
have 4 experiments that differ only in the text we display
as a headline.
I also fixed an issue raised by QA with error codes being
written to HKCU as opposed to HKLM. This should fix that
issue.
BUG=http://crbug.com/54835, http://crbug.com/44378
TEST=Requires manual testing by QA.
Review URL: http://codereview.chromium.org/3341026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome relaunch.
BUG=54620
TEST=PrefChangeRegistrarTest.*
Review URL: http://codereview.chromium.org/3316007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=54376
TEST=admx_writer_unittest.py
adml_writer_unittest.py
Review URL: http://codereview.chromium.org/3290018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
user level.
Review URL: http://codereview.chromium.org/3320018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3290020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3360019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SECURITY_STYLE_AUTHENTICATION_BROKEN, like the Omnibox does.
Started using...
a) the Info icon (blue i) for the first visit section and
b) the yellow exclamation point for http connections (instead of the skull and crossbones).
BUG=http://crbug.com/52916
TEST=None
Review URL: http://codereview.chromium.org/3367007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the Chrome tree.
BUG=chromium-os:6563
TEST=ran emerge, ran chrome on the device
Review URL: http://codereview.chromium.org/3340021
TBR=yusukes@chromium.org
Review URL: http://codereview.chromium.org/3358027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3331001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(1) it messes up with focus manager.
(2) it is redundant.
BUG=http://crosbug/6271
TEST=Manual
Review URL: http://codereview.chromium.org/3340019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The logic is identical to one in Chrome.
See http://src.chromium.org/viewvc/chrome?view=rev&revision=58913 for details.
Along the way, removed --logtostderr in candidate_window,
as we no longer use it
BUG=chromium-os:2723
TEST=Confirmed that IPAPGothic is used when UI language is set to Japanese, on the netbook. Also confirmed that Pinyin and Chewing input methods work with UI language set to Japanese (i.e. fallback fonts are properly used).
Review URL: http://codereview.chromium.org/3334014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=53406
Review URL: http://codereview.chromium.org/3305023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:6563
TEST=ran emerge, ran chrome on the device
Review URL: http://codereview.chromium.org/3340021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This enables us to run the device orientation layout tests.
BUG=54809
TEST=layout tests
Review URL: http://codereview.chromium.org/3298018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
screen locker.
BUG=chromium-os:6564
TEST=manually checked. see the bug.
Review URL: http://codereview.chromium.org/3358026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=43743
TEST=Two news tests: ExtensionTest.ApiPermissions (unit test), and ExtensionApiTest.AlwaysAllowed (browser test)
Review URL: http://codereview.chromium.org/3316009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
auto-config to the proxy extension API.
BUG=48930
TEST=covered by browser_tests ExtensionAPITest.Proxy*
Review URL: http://codereview.chromium.org/3348014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=https://bugs.webkit.org/show_bug.cgi?id=45513
TEST=win layout tests green up
R=none
Review URL: http://codereview.chromium.org/3334015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This generalizes the existing pattern matching code to support UTF8 strings.
BUG=53158
TEST=string_util_unittests.cc
Review URL: http://codereview.chromium.org/3295018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This version is basically tip-of-tree with r66992 (and r66997) rolled out,
under the theory that r66992 is causing the perf regression in
page_cycler_more_js.
BUG=https://bugs.webkit.org/show_bug.cgi?id=45524
R=tkent,ukai
TEST=page_cycler_more_js goes green
Review URL: http://codereview.chromium.org/3347021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=51906
TEST=none
Review URL: http://codereview.chromium.org/3363011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Along the way, add more comments, and rename functions
to be more descriptive.
TEST=manually on the netbook
BUG=none
Review URL: http://codereview.chromium.org/3343016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59068 0039d316-1c4b-4281-b951-d872f2087c98
|