| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Required going through and modifying some of the code to
solve name clashes.
Review URL: http://codereview.chromium.org/2945
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
webkit/glue/webpreferences.h:44: warning: 'WebPreferences::user_style_sheet_enabled' will be initialized after
webkit/glue/webpreferences.h:40: warning: 'bool WebPreferences::allow_scripts_to_close_windows'
webkit/glue/webpreferences.h:52: warning: when initialized here
Review URL: http://codereview.chromium.org/2947
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
We have been restructuring the message loop code lately and the MessageLoop on the file thread is not dispatching messages as it was before. I have changed the file thread to start with type MessageLoop::TYPE_IO, which pumps messages in such a way that Google Update can communicate back to us.
I'm not sure what the best way to test this is but I ran the UI tests and the unit tests and they all pass.
Review URL: http://codereview.chromium.org/2918
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
With this switch, window.close() will always be enabled.
Currently the switch is only available in test_shell.
Review URL: http://codereview.chromium.org/2915
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=rvargas
Review URL: http://codereview.chromium.org/2946
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
security error codes to our network error codes and
pass the certificate and its status up the stack.
There are still some rough edges and hardcoded
settings, but it is basically functional.
R=rvargas
BUG=b/1272567
Review URL: http://codereview.chromium.org/2898
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
computers have EnableLUA set to 2, which Vista treats as UAC 'on' but since our check checks for uac == 1 we think UAC is 'off'.
Changed the check to look for != 0 instead.
Review URL: http://codereview.chromium.org/3110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Add a scons/README.google file.
Review URL: http://codereview.chromium.org/2933
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
possible Windows race condition (file handles being held open an
indeterminate amount of time after being closed in other threads).
R: mpcomplete
Review URL: http://codereview.chromium.org/2940
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This way, if users clear their cookies and restart, they won't have to wonder why a Google cookie has suddenly mysteriously appeared.
BUG=1204
Review URL: http://codereview.chromium.org/2937
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2446
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
succeeds.
Review URL: http://codereview.chromium.org/2938
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=2335
Original patch by phajdan.jr@gmail.com in
http://codereview.chromium.org/2891
R=mark,sgk
Review URL: http://codereview.chromium.org/2939
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Hopefully this flag wont cause a performance regression.
Review URL: http://codereview.chromium.org/3109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In dns_host_info.cc there was probably a bug (hardcoded 1
instead of length.
BUG=2333
R=mark,sgk
Original patch by phajdan.jr@gmail.com at:
http://codereview.chromium.org/2890
Review URL: http://codereview.chromium.org/3108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
to-be-ported list.
Review URL: http://codereview.chromium.org/2934
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Committed: http://chrome-svn/viewvc/chrome?view=rev&revision=1553
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
entry committed notification.
I had to add some more stuff to the nav entry committed structure which now looks suspiciously like the provisional load details structure. I'll see how I can improve this in a future pass.
I used the new NotificationRegistrar to automatically unregister for notifications in the SSL manager, which reduces some code.
Review URL: http://codereview.chromium.org/3095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bookmarks is failing for some people. As a result of this I moved some
code from common/win_util to base/win_util so that file_util_win could
call it. The only changes to this code are formatting.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2931
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Patch from Pawel Hajdan Jr.
BUG=2410
Review URL: http://codereview.chromium.org/2929
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
navigation controller removing entries from the front of its list.
BUG=1324021
TEST=covered by unit tests, but make sure you don't see problems with
session restore.
Review URL: http://codereview.chromium.org/2906
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
we can pull this prototype upstream.
Review URL: http://codereview.chromium.org/2930
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
GetSystemMemory in net/disk_cache/cache_util is redundant.
Patch from Pawel Hajdan Jr.
Review URL: http://codereview.chromium.org/3103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Be more specific when using an overloaded operator since objective-c++ finds conflicts. Enable objective-C GC in our common config file for all projects.
Review URL: http://codereview.chromium.org/2912
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2927
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
processors.
Review URL: http://codereview.chromium.org/3084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
the base namespace. DCHECK the result to NSS_Shutdown. Remove the comment about nss.h and move to to it's appropiate place.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2922
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
text title bar... ie. don't load the font for the title bar for the main browser window since we won't use it - it's only used for app windows.
http://crbug.com/2369
Review URL: http://codereview.chromium.org/2919
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
optional, I needed to adjust the accessibility tests so that they use the right index.
Don't initialize the TabIconView if we don't need to. It's expensive to create.
http://crbug/2369
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
that says "Disable UAC". Possibly, this is governed by a policy setting on corporate networks.
In any case, this causes the About box to think we can't perform on-demand updates. We should never block on-demand updates on XP.
Review URL: http://codereview.chromium.org/2901
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/2369
Review URL: http://codereview.chromium.org/2917
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
SSL certificate error.
R=abarth,jcampan
BUG=2316
Review URL: http://codereview.chromium.org/3091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
folks are having problems.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2914
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the title would revert.
BUG=1353834
TEST=Create a bookmark, on the bubble type in a new name, click edit
and make sure the editor that pops up has the name you just typed in.
Review URL: http://codereview.chromium.org/3093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The build engine (library) is getting added in a scons-local subdirectory,
without version number, so we can track future changes, and more easily
merge any local mods we've had to make in a pinch.
Removing the old scons-local-0.98.3 directory will come seprately
to avoid Rietveld limitations.
Review URL: http://codereview.chromium.org/2902
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
was an issue
with Adobe reader retaining an open handle to the chrome application folder causing issues
with subsequent installs.
This was because we did not specify the current directory in the ShellExecute call. This resulted
in the chrome application folder becoming the current directory and hence the issue.
Bug=2321
Review URL: http://codereview.chromium.org/3092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
across this when tracking down previous fix. Allowing MAX_PATH + 1
causes a DCHECK to be hit when we read back from the clipboard.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
bitmaps until they're actually needed.
http://crbug.com/2369
Review URL: http://codereview.chromium.org/2907
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
order to fix release Mac builds
Review URL: http://codereview.chromium.org/2908
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
fall back to searching the original plugins/gears/gears.dll for existing users.
Review URL: http://codereview.chromium.org/2904
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2282 0039d316-1c4b-4281-b951-d872f2087c98
|