summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add protected destructors to interface types that should only be deleted via adarin@chromium.org2009-08-1116-23/+52
| | | | | | | | | | | | | subclass. There's no reason for these to be virtual since they can only be called by a subclass. R=jorlow BUG=none TEST=none Review URL: http://codereview.chromium.org/165312 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23100 0039d316-1c4b-4281-b951-d872f2087c98
* Download item gtk tidbits:estade@chromium.org2009-08-112-5/+28
| | | | | | | | | - Add histograms for clickjacking - Load correct icon for dangerous download items (credit to Nico Weber) Review URL: http://codereview.chromium.org/164337 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23099 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix assertion failure on pressing the fn-key (and increase robustness).avi@chromium.org2009-08-111-3/+20
| | | | | | | | | | | Patch by viettrungluu. BUG=http://crbug.com/18796 TEST=On a Mac with an fn key, give the web page keyboard focus and press the fn key. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23098 0039d316-1c4b-4281-b951-d872f2087c98
* valgrind: Remove a suppression for a test that has been removed.jhawkins@chromium.org2009-08-111-18/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/165329 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23096 0039d316-1c4b-4281-b951-d872f2087c98
* valgrind: Remove a suppression for a leak that has been fixed.jhawkins@chromium.org2009-08-111-18/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/165326 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23095 0039d316-1c4b-4281-b951-d872f2087c98
* Enforce maximum number of entries in FtpAuthCache.phajdan.jr@chromium.org2009-08-113-27/+83
| | | | | | | | | TEST=Covered by net_unittests. BUG=none Review URL: http://codereview.chromium.org/165167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23094 0039d316-1c4b-4281-b951-d872f2087c98
* Allow running the browser_tests in valgrind.jhawkins@chromium.org2009-08-111-0/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/165325 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23093 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for constrained windows on os x, based on Avi's ↵thakis@chromium.org2009-08-1121-42/+739
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | GTMWindowSheetController. Add carpet bombing dialog as first per-tab sheet. Depends http://codereview.appspot.com/105064 . The main issue with this patch is that GTMWindowSheetController doesn't provide an api to move sheets between windows, so this CL disables tab dragging for tabs with sheets, and fullscreen mode for windows with sheets. We can fix this later. Other stuff that should be done at some point, but not now: * Open/Save panels should be per-tab * Need an ui test that goes to page, then page with sheet, then hit back, forward, reload. * Bookmark sheets should not be sheets but in a separate window BUG=14666 TEST=Go to skypher.com/SkyLined/Repro/Chrome/carpet bombing/repro.html , a per-window sheet should appear. Things to test with this dialog: * Hitting cmd-q while a sheet is open in any tab should not quit but instead focus the sheet. * Hitting cmd-w while a sheet is open in any tab should not close the window but instead focus the sheet. * Dragging a tab with a sheet should move the window (and keep the tab visible), not detach the tab. * Going fullscreen should be disabled for windows with open tabs. * When a per-tab sheet is open in a non-active tab, it shouldn't steal the focus, i.e. going to the page above, then hitting cmd-t, and then hitting cmd-l should work. * Closing a non-frontmost tab with a per-tab sheet shouldn't crash. * Going to the url above and quickly opening a new tab, so that the sheet opens while its tab is not front-most should work (sheet should display only when you switch back to the tab with the sheet). * Go to google.com, then to skypher.com/SkyLined/Repro/Chrome/carpet bombing/repro.html , hit "backward" with open sheet, hit forward, focus location bar, hit enter. This shouldn't crash. * Hitting escape should dismiss the sheet * Hitting enter should confirm the sheet. Review URL: http://codereview.chromium.org/159780 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23091 0039d316-1c4b-4281-b951-d872f2087c98
* Disk Cache: cleanup of OpenBlockFile.rvargas@google.com2009-08-113-7/+31
| | | | | | | | | | | | Don't add the file to the list of open files until it passes all sanity checks. BUG=18174 TEST=unittest Review URL: http://codereview.chromium.org/164336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23090 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Use a consistent border color along all webcontent.erg@chromium.org2009-08-117-23/+71
| | | | | | | | | | The color used in the status bubble is now used in the top margin and in the download bar. This doesn't convert the popup notification, as that needs additional changes... Review URL: http://codereview.chromium.org/164345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23089 0039d316-1c4b-4281-b951-d872f2087c98
* Initial version of the Seccomp sandbox. Imported from ↵markus@chromium.org2009-08-1143-3/+11439
| | | | | | | | | | | http://code.google.com/p/seccompsandbox/ Make the seccomp sandbox dependant on the --enable-seccomp-sandbox flag Review URL: http://codereview.chromium.org/165310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23087 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Add CHECKs to track down source of history std::string out of range ↵willchan@chromium.org2009-08-111-0/+14
| | | | | | | | | | exceptions. BUG=http://crbug.com/15261 Review URL: http://codereview.chromium.org/164191 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23086 0039d316-1c4b-4281-b951-d872f2087c98
* Do not import homepage on First Run if a homepage is given in master ↵kuchhal@chromium.org2009-08-1113-28/+49
| | | | | | | | | | preferences. BUG=9048 Review URL: http://codereview.chromium.org/164291 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23085 0039d316-1c4b-4281-b951-d872f2087c98
* Add checks to DEBUG mode that no instance of URLRequest or URLFetcher ↵ericroman@google.com2009-08-119-11/+647
| | | | | | | | | | | | | | | | | | | | survives the destruction of the IO thread. This checking is done by introducing a new helper class to base called LeakTracker. Classes that you want to check for leaks just need to extend LeakTracker. The reason I am picking on URLFetcher / URLRequest, is I believe we have a bug that is making an instance of URLFetcher to outlive the IO thread. This causes various sorts of badness. For example: If URLFetcher survives the IO thread, then URLRequestContext remains referenced and therefore also survives IO thread. In turn HostResolverImpl survives the IO thread, so any outstanding resolve requests are NOT cancelled before the IO thread is decomissioned. So now, when the worker thread doing the DNS resolve finally finishes (assuming it finishes before the rogue URLRequest is destroyed), it post the result to a defunct message loop. KAB00m! (http://crbug.com/15513) Moreover, I believe we hit this same problem sporadically in AutomationProxyTest.AutocompleteGetSetText -- the test is flaky on the buildbots, and I've seen DCHECKs which suggest it is related to this issue. BUG=http://crbug.com/18372 Review URL: http://codereview.chromium.org/160447 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23084 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unreachable code from extension.cc.aa@chromium.org2009-08-111-1/+0
| | | | | | | BUG=17927 TBR=phajdan.jr@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23083 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors code to extract urls out of bookmark_utils and into GtkDndUtil.sky@chromium.org2009-08-113-25/+70
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/164322 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23082 0039d316-1c4b-4281-b951-d872f2087c98
* With the recent NNTP changes, we change the way themes work - they're now ↵glen@chromium.org2009-08-115-32/+64
| | | | | | | | | | | | | closer to NTP1 theming - ntp_section_* is used to control the display of the light blue sections, and we've added ntp_header that controls the dark blue hover color, ntp_header falls back to ntp_section if provided. Also fix a minor bug where the default theme was saving theme data - we were generating colors before saving the provided colors. BUG=18720,18722 TEST=Install a theme and verify that the recently closed section is themed correctly. Review URL: http://codereview.chromium.org/165192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23081 0039d316-1c4b-4281-b951-d872f2087c98
* First Run Import Progress UI.jeremy@chromium.org2009-08-1110-23/+1097
| | | | | | | | | | | First run code needed some reworking in order to get things in order for progress notification. BUG=18773 TEST=When importing another browser's settings, a progress dialog should be displayed. Review URL: http://codereview.chromium.org/164290 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23080 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Disconnect the accelerator group keys when closing the browser window.jhawkins@chromium.org2009-08-113-18/+23
| | | | | | | | BUG=10737 TEST=Watch the valgrind bot stay green. Review URL: http://codereview.chromium.org/164294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23078 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure we have a valid profile when usingavi@chromium.org2009-08-113-0/+69
| | | | | | | | | | | | | | BrowserInit::LaunchWithProfile::OpenURLsInBrowser() directly and the browser passed in is a popup window. Original Review URL: http://codereview.chromium.org/160331 BUG=http://crbug.com/17520 TEST=see bug. Review URL: http://codereview.chromium.org/164341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23077 0039d316-1c4b-4281-b951-d872f2087c98
* build-valgrind-for-chrome.sh: Don't install valgrind to /usr/bin anymoredkegel@google.com2009-08-112-18/+49
| | | | | | | | | | | | | | (wasn't useful on Goobuntu anyway, where some other valgrind came first in the PATH) Don't hardcode versions/dates. Add usage message. Remove URLs to some patches (they go stale fast) chrome_tests.sh: use the valgrind built by build-valgrind-for-chrome.sh by default, but provide way to override Review URL: http://codereview.chromium.org/165317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23076 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build/mac/tweak_app_infoplist build script for git users. Patch by Robertmark@chromium.org2009-08-111-15/+23
| | | | | | | | Sesek <rsesek@gmail.com>. Review URL: http://codereview.chromium.org/165314 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23075 0039d316-1c4b-4281-b951-d872f2087c98
* Use real creator code for Keychain items. Instead of hard-coding 'rimZ', usemark@chromium.org2009-08-116-47/+81
| | | | | | | | | | | the correct creator code for the application. This is 'rimZ' for branded Google Chrome, and 'Cr24' for Chromium. BUG=19000 TEST=No functional change in Google Chrome-branded builds Review URL: http://codereview.chromium.org/164332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23074 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 23064 - Ensure we don't load plugins on the IO threadsgk@google.com2009-08-1111-184/+78
| | | | | | | | | | | BUG=17938 TEST=added asserts which crash if plugins loaded on IO thread, current UI tests exercise them Review URL: http://codereview.chromium.org/164305 TBR=jam@chromium.org Review URL: http://codereview.chromium.org/165321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23073 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 23068.darin@chromium.org2009-08-1112-58/+62
| | | | | | Review URL: http://codereview.chromium.org/165316 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23071 0039d316-1c4b-4281-b951-d872f2087c98
* Add a first attempt at a compact location bar and a status bar. The status barbrettw@chromium.org2009-08-1122-112/+694
| | | | | | | | contains a clock, an application menu, and a non-working battery indicator. The compact location bar can be toggled by COMPACT_NAV_BAR in browser_window_gtk.cc Review URL: http://codereview.chromium.org/165272 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23070 0039d316-1c4b-4281-b951-d872f2087c98
* Add more window icons.estade@chromium.org2009-08-112-0/+3
| | | | | | | | BUG=19015,19016 Review URL: http://codereview.chromium.org/164331 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23069 0039d316-1c4b-4281-b951-d872f2087c98
* Remove WebView::SetDelegate because I'd like to avoid having a method like thisdarin@chromium.org2009-08-1112-62/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | in the WebKit API. The only consumer was TestShell. It was using this method to replace its TestWebViewDelegate instance. Instead, with this change, it has a manual Reset method. To avoid duplication with the constructor, Reset uses operator=(). This required a couple changes: 1- Remove DISALLOW_COPY_AND_ASSIGN from WebViewDelegate. Anyways, that didn't make sense since you cannot 'copy' a class with pure virtual methods. 2- Change scoped_ptr members of TestWebViewDelegate to linked_ptr. The extra overhead of the linked_ptr seems warranted in this case. I also changed TestWebViewDelegate to not be reference counted since it wasn't necessary. R=tony BUG=none TEST=none Review URL: http://codereview.chromium.org/164308 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23068 0039d316-1c4b-4281-b951-d872f2087c98
* media player cleanup of old unused menu itemsfbarchard@chromium.org2009-08-116-131/+9
| | | | | | | | | BUG=17415 TEST=options menu has no greyed out items in it. about box date updated. Review URL: http://codereview.chromium.org/164334 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23067 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit to 47041amanda@chromium.org2009-08-112-1/+5
| | | | | | | | | TBR=levin BUG=19064 TEST=none Review URL: http://codereview.chromium.org/165311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23066 0039d316-1c4b-4281-b951-d872f2087c98
* Bump to 4.0.x.xlaforge@chromium.org2009-08-111-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23065 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure we don't load plugins on the IO threadjam@chromium.org2009-08-1111-78/+184
| | | | | | | | BUG=17938 TEST=added asserts which crash if plugins loaded on IO thread, current UI tests exercise them Review URL: http://codereview.chromium.org/164305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23064 0039d316-1c4b-4281-b951-d872f2087c98
* Removes bogus comments in WidgetGtk::GetBounds.sky@chromium.org2009-08-111-9/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/165306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23062 0039d316-1c4b-4281-b951-d872f2087c98
* AudioRendererHost send ViewMsg_AudioStreamStatehclam@chromium.org2009-08-1111-115/+108
| | | | | | | | | | | | | AudioRendererHost should use ViewMsg_AudioStreamState to notify renderer of its state instead of AudioOutputStream::State. The enum of AudioOutputStream::State is not used anywhere, thus removed. TEST=unit_tests --gtest_filter=Audio* Review URL: http://codereview.chromium.org/165255 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23061 0039d316-1c4b-4281-b951-d872f2087c98
* Make double-clicking to select work correctly on Mac.tc@google.com2009-08-111-3/+8
| | | | | | | | | | | | | | | | | | | (I think that Linux uses an editor delegate -- see WebViewImpl::IsSelectTrailingWhitespaceEnabled() -- so it already works correctly; but if Linux ever stops, it'll now still work correctly also.) BUG=16624 TEST=Select some word on some web page by double-clicking on it; should select only the word and not any trailing space. Patch by Viet-Trung Luu <viettrungluu@gmail.com> in http://codereview.chromium.org/165309 Review URL: http://codereview.chromium.org/164333 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23060 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 201.0 to 202.0laforge@chromium.org2009-08-111-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23059 0039d316-1c4b-4281-b951-d872f2087c98
* Use $XDG_CACHE_HOME for the cache on Linux. This only works for the default ↵thestig@chromium.org2009-08-116-3/+40
| | | | | | | | | | profile. BUG=16976 TEST=Run Chromium, visit some webpages, make sure it's using the cache under $XDG_CACHE_HOME (~/.cache by default) Review URL: http://codereview.chromium.org/159028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23057 0039d316-1c4b-4281-b951-d872f2087c98
* Enable MediaLeakTest.VideoBearhclam@chromium.org2009-08-111-1/+1
| | | | | | | | | | | | | | BUG=18461 Enabling MediaLeakTest.VideoBear because it does similar things as ui_tests --gtest_filter=Media* and that test doesn't seem to be flaky. Still keep MediaLeakTest.ManyVideoBear disabled because that test starts too many intance of <video> and is very easy to crash. Review URL: http://codereview.chromium.org/165258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23056 0039d316-1c4b-4281-b951-d872f2087c98
* Make the theme install infobar have an 'undo' button insteadaa@chromium.org2009-08-115-19/+36
| | | | | | | | | | | of a 'back to default' button. BUG=18986 TEST=none Review URL: http://codereview.chromium.org/164312 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23055 0039d316-1c4b-4281-b951-d872f2087c98
* I think both of these issues have been fixed now.agl@chromium.org2009-08-111-4/+0
| | | | | | | BUG=18784 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23053 0039d316-1c4b-4281-b951-d872f2087c98
* Make app modal dialogs (from javascript) actually be app modal. Thistc@google.com2009-08-113-1/+32
| | | | | | | | | | | | is similar to the behavior on Windows, although they only fake app modality. BUG=18123 Review URL: http://codereview.chromium.org/164296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23052 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to Bitmap before exposing to JavaScriptgman@google.com2009-08-1139-1311/+1229
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL changes Bitmap to no longer be a cubemap. Instead there is a function, Pack::CreateBitmapsFromRawData that returns an array of bitmaps. For a 2D image 1 bitmap is returned For a cubemap 6 bitmaps are returned eventually for a volumemap N bitmaps will be returned. To distinguish between 6 bitmaps that are a cubemap and 6 bitmaps that are slices of a volumemap there is a Bitmap::semantic which tells what the bitmap is intended for. In a previous CL I had started to break Bitmap into classes like Bitmap8, BitmapFloat, BitmapDXT1. These were not intended to be exposed to JavaScript, only to make the internal code get rid of lots of if format == or case(format) stuff. But given that it's working as is and there are more pressing things I'm not planning to do that right now. I can delete the classes if you think I should. Note: This is still not 100% done. I still need to deal with the flipping issues or at least test. I probably need to add more tests as well. I also got rid of any mention of resize_to_pot in the command buffer version. Client side command buffer should not have to deal with POT/NPOT issues. I also moved the pot/npot stuff out of generic code and into the platform specific code. The generic code is not supposed to care. This is slower than the old way but it feels cleaner. A few issues I'm looking for input on. There's a function, Bitmap::GenerateMips(source_level, num_levels). It generates mips as long as they 8Bit textures. I can easily add half and float but not DXT. Right now if you call it on DXT in debug it prints a LOG message but otherwise it does nothing. Should I error for DXT? On the one hand it would be good to know that it failed so a user will not be wondering "I called it, why are there no mips?" On the otherhand, from JavaScript failing would mean you'd need to check the format before calling it which also seems less then ideal. The other is that currently it doesn't ADD mips, it just replaces the ones that are there. That means if you load a 2d image and want mips you have to allocate a new bitmap with the number of mips you want, copy level 0 from the old bitmap to the new bitmap and then generate mips Should I make generate mips effectively do that for you? Basically, if you call it to generate mips on levels that don't yet exist in the bitmap it would realloc itself and then generate them. Is that better? Also, I started down the path of taking out alpha_is_one. I'm trying to decide what to do with it. Part of me wants to take it out completely but since it's already there maybe I can't. If I leave it in I was thinking of making it check every time it's called. First I'd just make it slow. Then later if we want I could add a dirty flag and only recheck when it's dirty. That would be a lot of work though. It would mean wrapping Lock and SetRect and maybe a few other things so that we could catch any writes to the texture. It might also mean changing Lock to take read/write flags. I think those are good changes but again, it's not important right now. So, the question is what to do now. I can 1) Remove alpha_is_one. That might break something out there 2) Leave it in but just have it always false. 3) Make it check every time it's accessed. 4) Do the dirty flag thing. Preference? I'm for 2 or 3 I think. Review URL: http://codereview.chromium.org/164235 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23051 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Make SandboxIPCProcess not be a WebKitClientagl@chromium.org2009-08-114-121/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, SandboxIPCProcess had to be a full WebKitClient because of the following assertion failure: 0 0x08af0a77 in buildBaseTextCodecMaps () at third_party/WebKit/WebCore/platform/text/TextEncodingRegistry.cpp:176 1 0x08af0e73 in WebCore::atomicCanonicalTextEncodingName (name=0x985d665 "UTF-8") at third_party/WebKit/WebCore/platform/text/TextEncodingRegistry.cpp:241 2 0x08aee811 in TextEncoding (this=0xb876ef8, name=0x985d665 "UTF-8") at third_party/WebKit/WebCore/platform/text/TextEncoding.cpp:61 3 0x08aee88a in WebCore::UTF8Encoding () at third_party/WebKit/WebCore/platform/text/TextEncoding.cpp:266 4 0x08ae744c in WebCore::String::fromUTF8 (string=0x56d7a120 "�226\207�211�233正�221", size=15) at third_party/WebKit/WebCore/platform/text/String.cpp:674 5 0x0872a7c0 in WebKit::WebString::fromUTF8 (data=0x56d7a120 "�226\207�211�233正�221", length=15) at webkit/api/src/WebString.cpp:72 6 0x087245bd in WebKit::WebFontInfo::familyForChars (characters=0x56c11628, numCharacters=1) at webkit/api/src/gtk/WebFontInfo.cpp:98 7 0x0847599a in SandboxIPCProcess::HandleGetFontFamilyForChars (this=0xff869ba8, fd=29, pickle=@0xff86900c, iter=0xff869054, fds=@0xff86901c) at chrome/browser/renderer_host/render_sandbox_host_linux.cc:215 8 0x08475d70 in SandboxIPCProcess::HandleRequestFromRenderer (this=0xff869ba8, fd=29) at chrome/browser/renderer_host/render_sandbox_host_linux.cc:115 9 0x08475fea in SandboxIPCProcess::Run (this=0xff869ba8) at chrome/browser/renderer_host/render_sandbox_host_linux.cc:84 10 0x084747f9 in RenderSandboxHostLinux (this=0x56c10e78) at chrome/browser/renderer_host/render_sandbox_host_linux.cc:299 This this patch, we remove the need to use WebString and the codec translation (which was just a translation from UTF8 to UTF16 and back again anyway) and thus can remove all of the WebKitClient gubbins. BUG=17260 http://codereview.chromium.org/164112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23050 0039d316-1c4b-4281-b951-d872f2087c98
* Skia merge 310:313agl@chromium.org2009-08-111-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23049 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a spell check dictionary download bug, where killing the spell checker ↵sidchat@google.com2009-08-112-192/+72
| | | | | | | | | | while downloading the dictionary leads to a crash. This is happening for my auto-language detection feature, which sometimes kills a spellchecker while it is downloading a dictionary file. Hopefully, this is also a fix for BUG 18743. BUG=www.crbug.com/18743 TEST=none Review URL: http://codereview.chromium.org/165175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23048 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete and unused WebPreferences header.darin@chromium.org2009-08-111-94/+0
| | | | | | | | | | R=jorlow BUG=none TEST=none Review URL: http://codereview.chromium.org/165305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23047 0039d316-1c4b-4281-b951-d872f2087c98
* Fix failing startup test.mirandac@chromium.org2009-08-112-9/+9
| | | | | | Review URL: http://codereview.chromium.org/164328 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23046 0039d316-1c4b-4281-b951-d872f2087c98
* One more little fix for extension docs page flickering -- remove ↵rafaelw@chromium.org2009-08-1116-16/+16
| | | | | | | | | | class="hidden" on page_template.html TBR=aa Review URL: http://codereview.chromium.org/164327 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23045 0039d316-1c4b-4281-b951-d872f2087c98
* Change Force Software Render to also use environment variablegman@google.com2009-08-111-28/+3
| | | | | | | | | | so there's a hermetic option. Should I delete the registry stuff? It seems like it's not needed. Review URL: http://codereview.chromium.org/165221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23044 0039d316-1c4b-4281-b951-d872f2087c98
* Save debugging symbols for plugin_carbon_interpose.dylib.mark@chromium.org2009-08-111-7/+12
| | | | | | | | | BUG=18997 TEST=Release build produces plugin_carbon_interpose.dylib-*-i386.breakpad, and Google Chrome.dsym.tar.bz2 contains plugin_carbon_interpose.dylib.dSYM Review URL: http://codereview.chromium.org/164325 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23043 0039d316-1c4b-4281-b951-d872f2087c98