summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix color conversion. When I removed the dependency on skia_utils in this ↵brettw@google.com2008-12-031-1/+1
| | | | | | | | port file, I did the color conversion wrong. Review URL: http://codereview.chromium.org/13073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6256 0039d316-1c4b-4281-b951-d872f2087c98
* Add a note about a test that's expected to fail if you're not running ↵pkasting@chromium.org2008-12-033-5/+12
| | | | | | | | crash_service.exe. Review URL: http://codereview.chromium.org/12882 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6254 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused directories that I failed to clean uptc@google.com2008-12-030-0/+0
| | | | | | | | | earlier. TBR=deanm git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6253 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes context menu behavior of table view. In particular when runningsky@google.com2008-12-022-18/+43
| | | | | | | | | | | | | | in an RTL locale and right clicking on the icon some times the scrollbar context menu would appear. I've fixed it by subclassing the context menu handling and getting the location from the position of the mouse. BUG=4752 TEST=see bug, but also make sure this doesn't regress 4750 Review URL: http://codereview.chromium.org/13055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6252 0039d316-1c4b-4281-b951-d872f2087c98
* Redo fix from yesterday.mbelshe@google.com2008-12-022-6/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Post Mortem on why yesterday's fix was bogus: The motivation for this change was because a separate CL had a OneShotTimer<> as part of a Singleton class. The Singleton is cleaned up in the AtExit manager, which currently runs after the MessageLoop is destroyed. The following sequence left a dangling pointer: 1) Start a OneShotTimer - Creates a task and registers on the MessageLoop 2) Destroy MessageLoop (this deletes all Pending Tasks) 3) Destroy your OneShotTimer - Tries to reference a dangling pointer for the already-deleted task. The fix was to modify the Task such that at destruction it would zero-out the wrapper's pointer to the Task. Now step 3 would not reference a bogus pointer. Unfortunately, the fix is broken. The timers work by having a wrapper Timer class (BaseTimer_Helper) and a Task. The Task has a pointer back to its wrapper and the wrapper has a pointer to the task. For the case where a timer is re-started from within its Run() loop, things fail: 1) Start a RepeatingTimer 2) Timer fires via the MessageLoop MessageLoop calls Run() 3) Run() restarts the timer, which creates a new Task but reuses the same BaseTimer_Helper. BaseTimer_Helper's timer pointer now points to the NEW timer 4) The MessageLoop destroys the Task The new code zeroes out the task pointer in the BaseTimer_Helper, breaking the newly restarted timer. This fix is the same as yesterday's fix, except: 1) More comments 2) Added extra check at line 169. Don't reset the Task pointer when destroying the Task if the Timer does not point to the Task being destroyed. I'm confident, but not 100% positive that this fixes the problem. I did reproduce *something* using PageHeap which now seems to be gone, but I can't quite confirm. Review URL: http://codereview.chromium.org/13067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6251 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mac build bustage by syncing to new file locations.brettw@google.com2008-12-022-10/+12
| | | | | | Review URL: http://codereview.chromium.org/13068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6250 0039d316-1c4b-4281-b951-d872f2087c98
* Delete files from base unittests that I moved to skia.brettw@google.com2008-12-021-2/+0
| | | | | | Review URL: http://codereview.chromium.org/13066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6249 0039d316-1c4b-4281-b951-d872f2087c98
* Move convolver, image_operations, and skia_utils from base/gfx to skia/ext.brettw@google.com2008-12-0252-319/+289
| | | | | | | | | | | This changes the namespace in those files from "gfx" to "skia". I split skia_utils into two parts, the Windows specific part is now in a separate file called skia_utils_win. There were several obsolete includes of these headers which I removed. I also removed img_resize_perftest which isn't used and has bitrotted. Review URL: http://codereview.chromium.org/12842 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6248 0039d316-1c4b-4281-b951-d872f2087c98
* Change the map of accessibility id to IAccessible interface to holdananta@chromium.org2008-12-022-2/+4
| | | | | | | | | | | | | | a COMPtr<IAccessible> instead. This ensures that it is refcounted. I saw an instance while debugging bug 4582, where the map actually had a junk IAccessible pointer with a valid accessibility id. Bug=4582 R=jam Review URL: http://codereview.chromium.org/10980 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6246 0039d316-1c4b-4281-b951-d872f2087c98
* Allow PDF files to open in Acrobat Reader. ananta@chromium.org2008-12-026-19/+19
| | | | | | | | | | | | | | | | | | This fixes http://code.google.com/p/chromium/issues/detail?id=3977, which is an issue with Acrobat Reader internet preferences being set to always open PDF files in Reader. This operation when performed in chrome and Safari brings up an error message from the Acrobat Reader plugin that the file could not be found. The plugin in this case returns NP_ASFILE as the plugin mode from NPP_NewStream. The data is written accordingly to the temp file created. When we finish receiving the data we pass the file name in NPP_StreamAsFile to the plugin. The plugin does not open the file immediately as per our expectation. It opens the file after the stream has been destroyed which ends up deleting the temp file created above. Debugged Firefox and found that it never deletes these temp files and leaves them around in the cache. We can go one step forward and track all these files on a per instance basis. These are deleted when the plugin instance is destroyed. Bug=3977 R=jam Review URL: http://codereview.chromium.org/12875 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6245 0039d316-1c4b-4281-b951-d872f2087c98
* add more files to mac chrome project, build a few more tests. Fix typo in ↵pinkerton@google.com2008-12-023-25/+54
| | | | | | | | scons file for darwin. Use compiler define for MSVC pragma. Review URL: http://codereview.chromium.org/13060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6244 0039d316-1c4b-4281-b951-d872f2087c98
* Add launch_url to gears-scons build.mpcomplete@chromium.org2008-12-023-4/+20
| | | | | | Review URL: http://codereview.chromium.org/12879 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6243 0039d316-1c4b-4281-b951-d872f2087c98
* Remove empty "port/dom" directory and reference to non-existent ↵dglazkov@google.com2008-12-021-4/+0
| | | | | | | | ScriptController.h file. Review URL: http://codereview.chromium.org/13061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6242 0039d316-1c4b-4281-b951-d872f2087c98
* Change a DCHECK to CHECK to help debug a crash inwtc@google.com2008-12-021-1/+1
| | | | | | | | | | release builds. R=eroman BUG=4749 Review URL: http://codereview.chromium.org/12874 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6241 0039d316-1c4b-4281-b951-d872f2087c98
* Adding more space between dialog contents and the buttons. For XP Classic themeben@chromium.org2008-12-021-1/+1
| | | | | | | | | | | | | | there was close to no space between the tab control and the buttons. The space is aligned with default Windows look for dialogs. BUG=4402 TEST=Verify that all dialogs look good in any XP/Vista theme w.r. to space from dialog contents to buttons. Change by Sverrir Á. Berg <sverrir@google.com>, committing on his behalf. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6240 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a comment. This was brought up by Ojan in a review for my previous ↵brettw@google.com2008-12-021-2/+0
| | | | | | | | patch, but I forgot to fix it before checking in. Review URL: http://codereview.chromium.org/12877 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6239 0039d316-1c4b-4281-b951-d872f2087c98
* Quick touchup requested by revieweravi@google.com2008-12-021-2/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6238 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r6233, need to move the cert, there is a policy against dkegel@google.com2008-12-0210-436/+32
| | | | | | | | net depending on chrome Review URL: http://codereview.chromium.org/13059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6237 0039d316-1c4b-4281-b951-d872f2087c98
* LayoutTests/css1/box_properties/acid_test.html now runs on Linux.agl@chromium.org2008-12-021-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6236 0039d316-1c4b-4281-b951-d872f2087c98
* Add crash_sender and crash_inspector to Safari gears-scons build.mpcomplete@chromium.org2008-12-023-11/+36
| | | | | | Review URL: http://codereview.chromium.org/13037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6235 0039d316-1c4b-4281-b951-d872f2087c98
* Add Verdana to the list of loaded fonts.agl@chromium.org2008-12-021-0/+4
| | | | | | | This fixes, at least, LayoutTests/css1/box_properties/acid_test.html git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6234 0039d316-1c4b-4281-b951-d872f2087c98
* For http://code.google.com/p/chromium/issues/detail?id=4510dkegel@google.com2008-12-029-30/+436
| | | | | | | | | | | | | | | | | | | Extract some UI SSL test code into new class SSLTestUtil to avoid duplication. Point nss at root certs so test_shell can talk to mail.google.com without warnings. Support ciphers needed to talk to testserver.py. Load temporary testing cert needed to run unit tests. Implement part of GetSSLInfo. Change URL in developer error message to point to chromium.org. Re-enable url_request_unittest.cc, which seems to have been disabled by mistake. Later changesets will implement x509 certificates for nss, finish GetSSLInfo support, and update chrome/browser/ssl_uitest.cc to use SSLTestUtil. Earlier version was committed as r6063, but was rolled back. Review URL: http://codereview.chromium.org/11249 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6233 0039d316-1c4b-4281-b951-d872f2087c98
* Triage some layout tests. I filed bugs on 3 and rebaselined one.brettw@google.com2008-12-024-6/+5
| | | | | | Review URL: http://codereview.chromium.org/13054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6232 0039d316-1c4b-4281-b951-d872f2087c98
* Fix text selection for the Mac test_shell, for some value of "fix".paul@chromium.org2008-12-021-1/+1
| | | | | | Review URL: http://codereview.chromium.org/12853 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6230 0039d316-1c4b-4281-b951-d872f2087c98
* Add a note about why chrome/fonts/impact.html layout test is broken.agl@chromium.org2008-12-021-0/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6229 0039d316-1c4b-4281-b951-d872f2087c98
* * Cleanup: move base/platform_test.h -> testing/jeremy@chromium.org2008-12-0229-63/+36
| | | | | | | | * Add support for "Debug On Start" switch to MultiprocessTest::SpawnChild Review URL: http://codereview.chromium.org/13052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6227 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Add a tool to upgrade a set of cache files from one version torvargas@google.com2008-12-0211-54/+1550
| | | | | | | | | another. Also moves crash_cache project to the "tools folder" on the solution. Review URL: http://codereview.chromium.org/12851 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6226 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the URL and title from the state getting functions and IPC messages.brettw@google.com2008-12-0211-80/+31
| | | | | | | If the title or URL changes, we'll be updated in other ways, so this extra processing is wasted. Review URL: http://codereview.chromium.org/12859 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6225 0039d316-1c4b-4281-b951-d872f2087c98
* Add setStopProvisionalFrameLoads to the test shell layout test controller.tc@google.com2008-12-024-4/+25
| | | | | | | | | | This fixes a layout test. BUG=http://crbug.com/2980 Review URL: http://codereview.chromium.org/13038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6224 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix layout test crash for security/block-test.html.agl@chromium.org2008-12-021-0/+2
| | | | | | | | | | | | If a connection fails without EINPROGRESS then we don't close the socket right away, but wait until the destructor calls Disconnect(). However, Disconnect assumes that we managed to setup the libevent handle, which is that case we didn't, and crashes on an assert. Review URL: http://codereview.chromium.org/12648 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6223 0039d316-1c4b-4281-b951-d872f2087c98
* Try to reland the ipc code to see if the testsnsylvain@chromium.org2008-12-0210-71/+317
| | | | | | | | | are going to break again. TBR:jeremy Review URL: http://codereview.chromium.org/13053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6222 0039d316-1c4b-4281-b951-d872f2087c98
* Implement GetCPUUsage; it was causing link errors because of its absence on ↵avi@google.com2008-12-022-5/+53
| | | | | | | | the Mac, so we'll implement it for everyone. Review URL: http://codereview.chromium.org/12869 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6221 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the timer code again because even after relandingnsylvain@chromium.org2008-12-022-48/+6
| | | | | | | | | it on a clean and clobbered tree, it caused all the failures Review URL: http://codereview.chromium.org/12870 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6220 0039d316-1c4b-4281-b951-d872f2087c98
* Few minor updates to the linux expected results list.deanm@chromium.org2008-12-021-2/+1
| | | | | | Review URL: http://codereview.chromium.org/13051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6219 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 6190 now that the tree is green to see ifnsylvain@chromium.org2008-12-022-6/+48
| | | | | | | it's still breaking the tests Review URL: http://codereview.chromium.org/12868 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6218 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline deep-recursion, additional test cases were added upstream.deanm@chromium.org2008-12-024-7/+5
| | | | | | Review URL: http://codereview.chromium.org/13048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6217 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to get the linux expected results closer to reality.deanm@chromium.org2008-12-021-8/+305
| | | | | | Review URL: http://codereview.chromium.org/12867 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6215 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to make the linux test lists more accurate.deanm@chromium.org2008-12-022-682/+61
| | | | | | | | This will require a second pass after a few buildbot runs. Review URL: http://codereview.chromium.org/13049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6214 0039d316-1c4b-4281-b951-d872f2087c98
* Remove getallheader() compat shim after upstream changes to use $_SERVER.deanm@chromium.org2008-12-022-18/+0
| | | | | | Review URL: http://codereview.chromium.org/12862 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6213 0039d316-1c4b-4281-b951-d872f2087c98
* Local fix to SCons bug:sgk@google.com2008-12-021-0/+4
| | | | | | | | | | | If a Node exists explicitly in a repository directory but not in the local working directory, SCons would throw an exception when globbing the entry when it tried to extract the non-existent same-named entry from the local working directory's entries dictionary. Since we know we want to return local entry anyway, make sure it exists. Review URL: http://codereview.chromium.org/13044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6212 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce Extension class that can serializer and deserialize from Valueaa@chromium.org2008-12-027-0/+296
| | | | | | | instances. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6211 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes and enhancementssgk@google.com2008-12-029-37/+77
| | | | | | | | | | | | | | | | | | * Configurable CHROME_BUILD_TYPE command line or external environment variable for selecting appropriate release_impl*.scons settings (_checksenabled, _coverage, _dom_stats, _official, _purify). * Configurable CHROMIUM_BUILD command line or external environment variable for selecting appropriate chromium_build*.scons settings (_google_chrome). * Configurable /INCREMENTAL linking via command line or external environment variable ($INCREMENTAL), through appropriate setting of an internal $CHROMIUM_INCREMENTAL_FLAGS construction variable. * Full link of release builds by default. * Alphabetize *.scons files in the mac_env.FilterOut() list. * Explicitly set _checksenabled.scons link flags. Review URL: http://codereview.chromium.org/13039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6210 0039d316-1c4b-4281-b951-d872f2087c98
* I wanted env.subst() afterall, env.Dir is apparently incorrect.deanm@chromium.org2008-12-021-2/+1
| | | | | | Review URL: http://codereview.chromium.org/12860 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6209 0039d316-1c4b-4281-b951-d872f2087c98
* Minor refactorings:ericroman@google.com2008-12-024-6/+5
| | | | | | | | | | | | - Change scheme from a (const char*) to a (std::string). This is in response to an earlier comment. Background: It used to be a (const char*) to avoid allocating a string object since all the callers initialize it with a string literal. - Change the initial value of nonce_count_ from 1 to 0. This doesn't functionally change anything (we just change to a pre-increment rather than post-increment), but I prefer the the start-at-zero style. Review URL: http://codereview.chromium.org/12846 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6208 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring: replace some raw strings with GURL.ericroman@google.com2008-12-0210-44/+57
| | | | | | | | Also address a TODO about stripping references from proxy resolve requests. Review URL: http://codereview.chromium.org/13029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6207 0039d316-1c4b-4281-b951-d872f2087c98
* Pre-substitute webkit includes to avoid repeated subsitution. This causes ↵deanm@chromium.org2008-12-021-16/+19
| | | | | | | | my null build to go from 45s to 30s. Review URL: http://codereview.chromium.org/12828 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6206 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 6190 to see if it's the cause of the 100+ new regressionsnsylvain@chromium.org2008-12-022-48/+6
| | | | | | | | | on the distributed tests. TBR Review URL: http://codereview.chromium.org/13042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6205 0039d316-1c4b-4281-b951-d872f2087c98
* Oops, no pipe anymore.nsylvain@chromium.org2008-12-021-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6202 0039d316-1c4b-4281-b951-d872f2087c98
* A test was there twice in the tests_fixable.txtnsylvain@chromium.org2008-12-021-4/+1
| | | | | | | TBR:ojan Review URL: http://codereview.chromium.org/13041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6201 0039d316-1c4b-4281-b951-d872f2087c98
* We have a bunch of new ui_tests failures. I wantnsylvain@chromium.org2008-12-0210-317/+71
| | | | | | | | | | to check if this change (6181) was the cause. I'm reverting. TBR:jeremy Review URL: http://codereview.chromium.org/12856 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6199 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-18 12:16:48 +0000