summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Reupload of 12418glen@chromium.org2008-12-0734-230/+1850
| | | | | | Review URL: http://codereview.chromium.org/13183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6497 0039d316-1c4b-4281-b951-d872f2087c98
* Capitalize the 'Extensions' folder in the visual studio project for consistency.aa@chromium.org2008-12-071-1/+1
| | | | | | Review URL: http://codereview.chromium.org/13613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6496 0039d316-1c4b-4281-b951-d872f2087c98
* Third time's a charm?dkegel@google.com2008-12-0715-183/+557
| | | | | | | | | | | | | | | | | | | | | | | | | | | Fix part of http://code.google.com/p/chromium/issues/detail?id=4510 and improve https support in test shell on linux. This is the same as the earlier ssl cert cl (see http://codereview.chromium.org/11249), but with the certs moved so net can use them without reaching over into chrome's pants and causing test failure on the 'modules' Windows build server, which is set up to test net and base but not chrome. For this to pass, we will need to install the certs on the windows module and try servers. (And make sure tlslite is present.) (A later CL will finish implementing SSLInfo for Linux, and probably reference net/base/ssl_test_util.cc from all three vcproj files that need it, even though that's ugly, because that's less ugly that referencing it from net.lib's vcproj.) Review URL: http://codereview.chromium.org/12930 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6495 0039d316-1c4b-4281-b951-d872f2087c98
* Update themes since we merged webkit r38911.deanm@chromium.org2008-12-074-20/+24
| | | | | | | | | | | | - A blink value of 0 should no longer paint storm. Return a non-blinking caret in linux layout test mode again. - Update a mismerge from Chromium r6487. The virtual method was renamed to creatBlinkInterval, so now we are created an additional virtual method instead of overriding the theme's. Review URL: http://codereview.chromium.org/13611 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6494 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the tab restore service persist closed tabs/windows to disk andsky@google.com2008-12-0642-1213/+2192
| | | | | | | | | | | | | | | | | reload them when asked. Sorry for largish looking change. It's made big by refactoring common code between TabRestoreService and SessionService into a common superclass. At the same time I removed some dead code and shuffled the session related classes into a single directory for easier perusal. BUG=384 TEST=close the browser, start the browser and make sure the new tab page shows closed windows/tabs from the previous session. Review URL: http://codereview.chromium.org/13152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6490 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible flicker when tab finishes animating back to draggedsky@google.com2008-12-061-1/+5
| | | | | | | | | | | position. BUG=NONE TEST=none Review URL: http://codereview.chromium.org/13221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6489 0039d316-1c4b-4281-b951-d872f2087c98
* Add baselines for new tests in the last webkit merge.brettw@google.com2008-12-064-0/+29
| | | | | | Review URL: http://codereview.chromium.org/13604 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6488 0039d316-1c4b-4281-b951-d872f2087c98
* Pull new WebKit 38900:38950.brettw@google.com2008-12-066-21/+6
| | | | | | Review URL: http://codereview.chromium.org/13228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6487 0039d316-1c4b-4281-b951-d872f2087c98
* Improve PDF FastWebView performance. This occurs because the manual data ↵ananta@chromium.org2008-12-062-3/+19
| | | | | | | | | | | | | | | | stream load does not get cancelled correctly. This causes the IPC messages for the manual data stream to continue going back and forth. They are ignored by the plugin anyways. This fixes http://code.google.com/p/chromium/issues/detail?id=5196. Fix is to cancel the manual document load correctly. Bug=5196 Review URL: http://codereview.chromium.org/13198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6486 0039d316-1c4b-4281-b951-d872f2087c98
* Mark the test as failure in DEBUG mode.fqian@google.com2008-12-061-0/+1
| | | | | | Review URL: http://codereview.chromium.org/13232 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6484 0039d316-1c4b-4281-b951-d872f2087c98
* Change init() in GKURL to use the default UTF-8 converter when an encoding ↵jungshik@google.com2008-12-061-11/+17
| | | | | | | | | | | | | | | is one of Unicode encodings (UTF-8,7,16,32). HTML5 stipulates that it should use UTF-8 for UTF-16, which is extended in this change list to include UTF-32 and UTF-7 (Firefox made that change a long time ago). The corresponding webkit bug is http://bugs.webkit.org/show_bug.cgi?id=21635 (the patch was landed in r38755 in the webkit trunk and picked up in r6182 in our copy of Webkit). The layout tests for this was landed in the webkit in r38988 : http://bugs.webkit.org/show_bug.cgi?id=22492 ) and will be picked up in the next webkit merge. bug=3433 TEST=pass the layout tests http/tests/misc/{url,submit-get,submit-post}-in-utf{7,32be,32le,16le,16be}.html (not yet in our tree) Review URL: http://codereview.chromium.org/13186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6481 0039d316-1c4b-4281-b951-d872f2087c98
* Linux rebaseline: LayoutTests/css2.1/t1507-c526-font-sz-02-b-a.htmlagl@chromium.org2008-12-065-10/+10
| | | | | | | | | We actaully get this correct, the Windows baseline is wrong. Review URL: http://codereview.chromium.org/12951 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6480 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Round font heights.agl@chromium.org2008-12-061-1/+1
| | | | | | | | | | | | Outside the VDMX regions of fonts we can mismatch Windows. Specifically, with 2pt Times New Roman we are 1px off. This is needed to pass ACID 2 tests. Review URL: http://codereview.chromium.org/12959 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6478 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline output of some test because of hotmail fix.fqian@google.com2008-12-069-195/+195
| | | | | | | | All are different output of DOM constructor toString. It used to be 'function XXXDOMConstructorXXX() {native code}', and now it is [object Function]. Review URL: http://codereview.chromium.org/13226 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6477 0039d316-1c4b-4281-b951-d872f2087c98
* Allow specifying a wrapper command around test_shell in layout tests.evanm@google.com2008-12-062-11/+24
| | | | | | | | | This makes running with valgrind easy. Review URL: http://codereview.chromium.org/13189 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6476 0039d316-1c4b-4281-b951-d872f2087c98
* Handle destruction of test shell properly.evanm@google.com2008-12-063-29/+33
| | | | | | | | | | | | | | | | | When test shell's destructor runs, it tries to delete its child objects. But when the GTK widgets are destroyed, they also try to delete the associated objects. We don't want both to run. Also, there were a couple of incorrect uses of the GTK API (e.g. destroy-event instead of destroy) that were obfuscating the problem. This fixes a crash on shutdown, so I'm restoring the LoadURL() call in TestShell's destructor. Review URL: http://codereview.chromium.org/13214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6475 0039d316-1c4b-4281-b951-d872f2087c98
* Fuzzy matching: ignore scrollbars and add option to highlightagl@chromium.org2008-12-061-11/+62
| | | | | | | Review URL: http://codereview.chromium.org/13184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6474 0039d316-1c4b-4281-b951-d872f2087c98
* Incorporate Mads' comment, only comment style changes.fqian@google.com2008-12-063-3/+3
| | | | | | | | TBR=ager Review URL: http://codereview.chromium.org/12962 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6473 0039d316-1c4b-4281-b951-d872f2087c98
* This is a cleaned up fix of Christian's original patch in fqian@google.com2008-12-064-14/+93
| | | | | | | | | | | http://codereview.chromium.org/13176 I cleaned it a bit so it does not leak memory. There is a corner case that can crash a test, so I have to make a workaround. Review URL: http://codereview.chromium.org/13224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6472 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: checkin rebaselined images for LayoutTests/fast/*agl@chromium.org2008-12-061942-0/+971
| | | | | | | | | | | | This is the set of images and checksums for layout tests where we match the render tree exactly and the fuzzy image matcher believes that our image outputs are semantically the same as the Windows version. Since we don't want to be running the fuzzy matcher forever, we are checking in new baselines for the images only. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6471 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: FreeType doesn't scale OS/2 valuesagl@chromium.org2008-12-061-1/+2
| | | | | | | | | sxHeight values are in font units, not 26.6 fixed point as I assumed. Review URL: http://codereview.chromium.org/13195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6470 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Original CL: http://codereview.chromium.org/12831, fix the build errortc@google.com2008-12-063-15/+4
| | | | | | | | | | | for http://codereview.chromium.org/13181." This reverts commit r6463. Review URL: http://codereview.chromium.org/13225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6468 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux broken layout tests. They want the windows UA sheet.mpcomplete@google.com2008-12-052-0/+15
| | | | | | Review URL: http://codereview.chromium.org/13193 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6466 0039d316-1c4b-4281-b951-d872f2087c98
* Revert this file submitted by accidentnsylvain@chromium.org2008-12-051-11/+0
| | | | | | Review URL: http://codereview.chromium.org/13222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6465 0039d316-1c4b-4281-b951-d872f2087c98
* Original CL: http://codereview.chromium.org/12831, fix the build error for ↵hclam@chromium.org2008-12-053-4/+15
| | | | | | | | http://codereview.chromium.org/13181. Review URL: http://codereview.chromium.org/13217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6463 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an unused string (IDS_PAGE_MENU_REPORT_PHISHING_WEBSITE_URL)jungshik@google.com2008-12-0551-52/+1
| | | | | | | bug=4457 Review URL: http://codereview.chromium.org/13207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6462 0039d316-1c4b-4281-b951-d872f2087c98
* * Prevent early exit due to && operator.kuchhal@chromium.org2008-12-051-12/+14
| | | | | | | | BUG=5104 Review URL: http://codereview.chromium.org/13179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6461 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing build bustage. Adding files which were part of the original changeananta@chromium.org2008-12-055-0/+14
| | | | | | | | | | branch r6396, which was reverted partially. TBR=jam Review URL: http://codereview.chromium.org/13215 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6460 0039d316-1c4b-4281-b951-d872f2087c98
* Add error messages to JSONReader and friends. This required a bit of ↵aa@chromium.org2008-12-0518-111/+313
| | | | | | | | refactoring to do cleanly. This CL doesn't actually use this capability anywhere except for unit tests. I will add that in a future CL. Review URL: http://codereview.chromium.org/13169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6459 0039d316-1c4b-4281-b951-d872f2087c98
* Add a CHECK to assert that each invocation ofwtc@google.com2008-12-051-0/+5
| | | | | | | | | | | ResourceDispatcherHost::RemovePendingRequest removes exactly one URLRequest from pending_requests_. R=eroman BUG=4749 Review URL: http://codereview.chromium.org/12977 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6458 0039d316-1c4b-4281-b951-d872f2087c98
* changelist for estade readability review.estade@chromium.org2008-12-053-94/+105
| | | | | | | submitted changelist: http://codereview.chromium.org/9154 Review URL: http://codereview.chromium.org/12605 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6457 0039d316-1c4b-4281-b951-d872f2087c98
* Add using_wtl.scons to the chrome\test\automation SCons configuration,sgk@google.com2008-12-051-0/+1
| | | | | | | paralleling addition of using_wtl.vsprops to the VS configuration. Review URL: http://codereview.chromium.org/13401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6456 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline animation/keyframes.htmltc@google.com2008-12-053-4/+66
| | | | | | | | | | | | There's a one line difference where we fail because in V8 typeof(CSSStyleDeclaration) != typeof(rules2.item(0).style). BUG=13154 Review URL: http://codereview.chromium.org/13154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6455 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r6396 the PDF fix to not cancel the manual data streamananta@chromium.org2008-12-055-5/+29
| | | | | | | | | | | | load when the plugin calls NPN_RequestRead. I was looking at the wrong stream implementation in Firefox :( Bug=5009 TBR=jam Review URL: http://codereview.chromium.org/13212 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6454 0039d316-1c4b-4281-b951-d872f2087c98
* Fuzzy matching: remove stray debugging lineagl@chromium.org2008-12-051-1/+0
| | | | | | | | | | | This slipped in via a TBR build fix change (13209) TBR=tony Review URL: http://codereview.chromium.org/13185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6453 0039d316-1c4b-4281-b951-d872f2087c98
* Un-revert 6386 (my CSS change). Layout tests pass for me. I think thempcomplete@google.com2008-12-058-109/+30
| | | | | | | | | builders just need a clobber when this is checked in. I also fixed the SConscript and deleted the old CSS files. Review URL: http://codereview.chromium.org/13146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6452 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build: missed a fileagl@chromium.org2008-12-051-0/+48
| | | | | | | | | TBR=tony Review URL: http://codereview.chromium.org/13209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6449 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a race condition in the SyncChannel code.jam@chromium.org2008-12-052-61/+37
| | | | | | | | | | | The problem is that QueueMessage would be called with listener() on the IPC thread, and then the function would wait on message_lock_ before adding the message and its associated listener. However, in between the time that listener() was called and the lock was taken control of, the listener thread may be calling RemoveListener. The fix is to not send the listener, but instead just send a pointer to the context. It'll be used on the listener thread, at which point listener() can be called to check if the listener is available. BUG=1305036 Review URL: http://codereview.chromium.org/12952 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6448 0039d316-1c4b-4281-b951-d872f2087c98
* Remove LoadURL("about:blank") in the destructor, it crashes the test_shell ↵fqian@google.com2008-12-051-1/+0
| | | | | | | | | | on Linux. TBR = patrick Review URL: http://codereview.chromium.org/13208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6447 0039d316-1c4b-4281-b951-d872f2087c98
* fix chrome_paths to make some test dirs relative to base::DIR_SOURCE_ROOTerikkay@google.com2008-12-054-21/+30
| | | | | | | | | | | | | | rather than chrome::DIR_APP. DIR_APP is in different relative locations on different platforms while DIR_SOURCE_ROOT is the same, so this allows us to share code and be correct on all platforms. Also, enable extensions_service_unittest for Mac and Linux and add an NSAutoreleasePool to ChromeTestSuite (which is now being used by run_all_unittests on Mac and Linux per my earlier checkin). Review URL: http://codereview.chromium.org/13177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6445 0039d316-1c4b-4281-b951-d872f2087c98
* Add fuzzy image matching tool for Linux pixel testsagl@chromium.org2008-12-054-0/+113
| | | | | | | Review URL: http://codereview.chromium.org/13159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6444 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: remove passing tests from tests_fixableagl@chromium.org2008-12-051-80/+6
| | | | | | | | | | | | | | | | | | For each line in tests_fixable: if the platforms list is missing THEN ignore it if the platforms list is [LINUX] AND the test passed the most recent builder run THEN delete it if the platforms list includes LINUX AND the test passed the most recent builder run AND the platforms list does not include WIN THEN remove LINUX from the platforms list Review URL: http://codereview.chromium.org/13180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6443 0039d316-1c4b-4281-b951-d872f2087c98
* UserData Options tabmunjal@chromium.org2008-12-053-3/+44
| | | | | | | | | Plumbing for User Data tab in Options dialog. Review URL: http://codereview.chromium.org/13150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6442 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 6439.nsylvain@chromium.org2008-12-053-13/+4
| | | | | | | Revision 6439 broke the build. I'm reverting it. Please monitor the build after submitting code Review URL: http://codereview.chromium.org/13181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6441 0039d316-1c4b-4281-b951-d872f2087c98
* Change "client" parameter in RLZ ping to "referral" gwilson@google.com2008-12-055-11/+11
| | | | | | | | | | to match Omaha's changes. BUG=1520348 Review URL: http://codereview.chromium.org/12975 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6440 0039d316-1c4b-4281-b951-d872f2087c98
* Same as CL 12831, create a new one to get rid of the eol-style commit error.hclam@chromium.org2008-12-053-4/+13
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6439 0039d316-1c4b-4281-b951-d872f2087c98
* Change the accelerator key for Javascript debug to Ctrl-Shift-D from 'Alt-`'jungshik@google.com2008-12-051-1/+2
| | | | | | | | | BUG=3696,5087 TEST=Install non-en-US keyboard and switch keyboards to one of them (e.g. German, French, Russian) and make sure that shortcut keys for Javascript debug remains 'Ctrl-Shift-L'. Review URL: http://codereview.chromium.org/10652 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6438 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the layout of the Spell Check Options part, in the languages tab, in the ↵sidchat@google.com2008-12-051-18/+20
| | | | | | | | | Fonts and Languages Options Menu, to match with the Mock. Issue=4401 Review URL: http://codereview.chromium.org/12957 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6437 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a bogus initialization of string constants. The stack allocated ↵erikkay@google.com2008-12-051-12/+6
| | | | | | | | | | | string from StringPrintf gets destroyed right away, and c_str is just a pointer to its internal buffer, so the error constant was bogus memory. This showed up in the purify tests. Sorry I missed this in the initial code review. Review URL: http://codereview.chromium.org/13204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6436 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Merge 38850:38900, Part 3dglazkov@google.com2008-12-054-5/+14
| | | | | | Review URL: http://codereview.chromium.org/10425 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6435 0039d316-1c4b-4281-b951-d872f2087c98