| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13613
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix part of http://code.google.com/p/chromium/issues/detail?id=4510
and improve https support in test shell on linux.
This is the same as the earlier ssl cert cl
(see http://codereview.chromium.org/11249),
but with the certs moved so net can use them without
reaching over into chrome's pants and causing
test failure on the 'modules' Windows build server,
which is set up to test net and base but not chrome.
For this to pass, we will need to install
the certs on the windows module and try servers.
(And make sure tlslite is present.)
(A later CL will finish implementing SSLInfo for Linux,
and probably reference net/base/ssl_test_util.cc
from all three vcproj files that need it,
even though that's ugly, because that's less ugly
that referencing it from net.lib's vcproj.)
Review URL: http://codereview.chromium.org/12930
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- A blink value of 0 should no longer paint storm. Return
a non-blinking caret in linux layout test mode again.
- Update a mismerge from Chromium r6487. The virtual method
was renamed to creatBlinkInterval, so now we are created an
additional virtual method instead of overriding the theme's.
Review URL: http://codereview.chromium.org/13611
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reload them when asked.
Sorry for largish looking change. It's made big by refactoring common
code between TabRestoreService and SessionService into a common
superclass. At the same time I removed some dead code and shuffled the
session related classes into a single directory for easier perusal.
BUG=384
TEST=close the browser, start the browser and make sure the new tab
page shows closed windows/tabs from the previous session.
Review URL: http://codereview.chromium.org/13152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
position.
BUG=NONE
TEST=none
Review URL: http://codereview.chromium.org/13221
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13604
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13228
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
stream load does not get cancelled correctly. This causes the IPC messages for the manual data stream to continue going back and forth. They are ignored
by the plugin anyways.
This fixes http://code.google.com/p/chromium/issues/detail?id=5196.
Fix is to cancel the manual document load correctly.
Bug=5196
Review URL: http://codereview.chromium.org/13198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13232
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is one of Unicode encodings (UTF-8,7,16,32). HTML5 stipulates that it should use UTF-8 for UTF-16, which is extended in this change list to include UTF-32 and UTF-7 (Firefox made that change a long time ago).
The corresponding webkit bug is http://bugs.webkit.org/show_bug.cgi?id=21635 (the patch was landed in r38755 in the webkit trunk and picked up in r6182 in our copy of Webkit).
The layout tests for this was landed in the webkit in r38988 : http://bugs.webkit.org/show_bug.cgi?id=22492 ) and will be picked up in the next webkit merge.
bug=3433
TEST=pass the layout tests http/tests/misc/{url,submit-get,submit-post}-in-utf{7,32be,32le,16le,16be}.html (not yet in our tree)
Review URL: http://codereview.chromium.org/13186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
We actaully get this correct, the Windows baseline is wrong.
Review URL: http://codereview.chromium.org/12951
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Outside the VDMX regions of fonts we can mismatch Windows. Specifically,
with 2pt Times New Roman we are 1px off.
This is needed to pass ACID 2 tests.
Review URL: http://codereview.chromium.org/12959
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
All are different output of DOM constructor toString. It used to be 'function XXXDOMConstructorXXX() {native code}', and now it is [object Function].
Review URL: http://codereview.chromium.org/13226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This makes running with valgrind easy.
Review URL: http://codereview.chromium.org/13189
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When test shell's destructor runs, it tries to delete its child objects.
But when the GTK widgets are destroyed, they also try to delete the associated
objects. We don't want both to run.
Also, there were a couple of incorrect uses of the GTK API (e.g. destroy-event
instead of destroy) that were obfuscating the problem.
This fixes a crash on shutdown, so I'm restoring the LoadURL() call in
TestShell's destructor.
Review URL: http://codereview.chromium.org/13214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=ager
Review URL: http://codereview.chromium.org/12962
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/13176
I cleaned it a bit so it does not leak memory. There is a corner case that
can crash a test, so I have to make a workaround.
Review URL: http://codereview.chromium.org/13224
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the set of images and checksums for layout tests where we match
the render tree exactly and the fuzzy image matcher believes that our
image outputs are semantically the same as the Windows version.
Since we don't want to be running the fuzzy matcher forever, we are
checking in new baselines for the images only.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
sxHeight values are in font units, not 26.6 fixed point as I assumed.
Review URL: http://codereview.chromium.org/13195
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for http://codereview.chromium.org/13181."
This reverts commit r6463.
Review URL: http://codereview.chromium.org/13225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13193
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/13181.
Review URL: http://codereview.chromium.org/13217
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
bug=4457
Review URL: http://codereview.chromium.org/13207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=5104
Review URL: http://codereview.chromium.org/13179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
branch r6396, which was reverted partially.
TBR=jam
Review URL: http://codereview.chromium.org/13215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
refactoring to do cleanly. This CL doesn't actually use this capability anywhere except for unit tests. I will add that in a future CL.
Review URL: http://codereview.chromium.org/13169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ResourceDispatcherHost::RemovePendingRequest removes
exactly one URLRequest from pending_requests_.
R=eroman
BUG=4749
Review URL: http://codereview.chromium.org/12977
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
submitted changelist: http://codereview.chromium.org/9154
Review URL: http://codereview.chromium.org/12605
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
paralleling addition of using_wtl.vsprops to the VS configuration.
Review URL: http://codereview.chromium.org/13401
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's a one line difference where we fail because in V8
typeof(CSSStyleDeclaration) != typeof(rules2.item(0).style).
BUG=13154
Review URL: http://codereview.chromium.org/13154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
load when the plugin calls NPN_RequestRead. I was looking at the wrong
stream implementation in Firefox :(
Bug=5009
TBR=jam
Review URL: http://codereview.chromium.org/13212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This slipped in via a TBR build fix change (13209)
TBR=tony
Review URL: http://codereview.chromium.org/13185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
builders just need a clobber when this is checked in.
I also fixed the SConscript and deleted the old CSS files.
Review URL: http://codereview.chromium.org/13146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=tony
Review URL: http://codereview.chromium.org/13209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The problem is that QueueMessage would be called with listener() on the IPC thread, and then the function would wait on message_lock_ before adding the message and its associated listener. However, in between the time that listener() was called and the lock was taken control of, the listener thread may be calling RemoveListener.
The fix is to not send the listener, but instead just send a pointer to the context. It'll be used on the listener thread, at which point listener() can be called to check if the listener is available.
BUG=1305036
Review URL: http://codereview.chromium.org/12952
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
on Linux.
TBR = patrick
Review URL: http://codereview.chromium.org/13208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rather than chrome::DIR_APP. DIR_APP is in different relative locations on
different platforms while DIR_SOURCE_ROOT is the same, so this allows us to
share code and be correct on all platforms.
Also, enable extensions_service_unittest for Mac and Linux and add an
NSAutoreleasePool to ChromeTestSuite (which is now being used by
run_all_unittests on Mac and Linux per my earlier checkin).
Review URL: http://codereview.chromium.org/13177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For each line in tests_fixable:
if the platforms list is missing THEN
ignore it
if the platforms list is [LINUX] AND
the test passed the most recent builder run THEN
delete it
if the platforms list includes LINUX AND
the test passed the most recent builder run AND
the platforms list does not include WIN THEN
remove LINUX from the platforms list
Review URL: http://codereview.chromium.org/13180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Plumbing for User Data tab in Options dialog.
Review URL: http://codereview.chromium.org/13150
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Revision 6439 broke the build. I'm reverting it. Please monitor the build after submitting code
Review URL: http://codereview.chromium.org/13181
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to match Omaha's changes.
BUG=1520348
Review URL: http://codereview.chromium.org/12975
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=3696,5087
TEST=Install non-en-US keyboard and switch keyboards to one of them (e.g. German, French, Russian) and make sure that shortcut keys for Javascript debug remains 'Ctrl-Shift-L'.
Review URL: http://codereview.chromium.org/10652
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Fonts and Languages Options Menu, to match with the Mock.
Issue=4401
Review URL: http://codereview.chromium.org/12957
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
string from StringPrintf gets destroyed right away, and c_str is just a pointer to its internal buffer, so the error constant was bogus memory. This showed up in the purify tests.
Sorry I missed this in the initial code review.
Review URL: http://codereview.chromium.org/13204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10425
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6435 0039d316-1c4b-4281-b951-d872f2087c98
|