| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
when OnUnrecoverableError() is called after Start().
BUG=41438
TEST=unittests
Review URL: http://codereview.chromium.org/1630021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
framebuffer objects. Conditionalized allocation of FBO in
AcceleratedSurface class, and changed SwapBuffers to optionally copy from
the current context's back buffer. Changed GPUProcessor on Mac to always
use PbufferGLContext, and hooked in optional call to AcceleratedSurface's
SwapBufers before calling user's callback. Completely disabled
ViewGLContext on Mac OS X. This causes Pepper 3D applications to use the
GGL default back buffer on Mac, which is the desired behavior.
Ideally the FBO allocation would be factored out of the AcceleratedSurface
class, and ideally the pbuffer setup code would not be duplicated between
this class and PbufferGLContext. However, these cleanups are being deferred
because they require substantial refactorings.
Removed accelerated_surface_stub.cc, which isn't needed any more since
AcceleratedSurface moved to app/.
Tested:
- Pepper 3D plugin with glBindFramebuffer(GL_FRAMEBUFFER, 0) in place with
both IOSurface and TransportDIB code paths
- Unity 3D with IOSurface / Core Animation code path
BUG=41004
TEST=none (ran above tests)
Review URL: http://codereview.chromium.org/1637007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=41361
Review URL: http://codereview.chromium.org/1513034
TBR=skrul@chromium.org
Review URL: http://codereview.chromium.org/1564032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
context menus. Eliminate bifurcated 'parentController_' data member (leaving this common behavior to the BookmarkFolderTarget class). Provide context menus (one for button and another for folder) for the folder controller thus allowing far easier identification of the target of the action.
BookmarkBar.xib changes: Added Cut and Paste menu items to the button and folder contextual menus. Reconfigured the menus with separators and some rearranging to match Windows.
BookmarkBarFolderWindow.xib changes: Copied the button and folder contextual menus from the BookmarkBar.xib and wired them up to the folder controller instead.
BUG=23541
TEST=Present context menu for bookmark bar and verify the presence of Cut/Copy/Paste/Delete. Verify proper enabling (i.e. Paste should not be enabled until a bookmark or folder has been Cut or Copied). Perform each action Cut, Copy, Delete and Paste. Perform these tests for the contents of a folder coming off of the bookmark bar and for subfolders, too. Insure that pasting can be performed from the bar to a folder, a folder to the bar, bar to bar, folder to folder, at the beginning and at the end of each.
Review URL: http://codereview.chromium.org/1611027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=41361
Review URL: http://codereview.chromium.org/1513034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36799
TEST=mac 10.6 tests are green
Review URL: http://codereview.chromium.org/1613017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fixed the looping problem with audio / video.
BUG=39478
TEST=audio plays with looping
Review URL: http://codereview.chromium.org/1620010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=41349
TEST=Visit a page in a language different than the Chrome UI language.
Disconnect the network cable. Click Translate in the infobar.
After some time an error infobar should be shown.
Review URL: http://codereview.chromium.org/1602024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Fixes Linux official build:
chrome/app/breakpad_linux.cc:184: error: ‘PRODUCT_VERSION’ was not declared in this scope
Review URL: http://codereview.chromium.org/1630022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=compiles
Patch from Thiago Farina <thiago.farina@gmail.com>
Review URL: http://codereview.chromium.org/1547020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1648004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
window. Used to lock bar visibility when dragging.
BUG=40740
TEST=Go Fullscreen. Drag a bookmark button that is inside a folder. When the folder disappears, the overlay bar should stay visible.
Review URL: http://codereview.chromium.org/1610023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40278
TEST=As per adhoc method in the bug. Open infobar & bubble, check they show URL in arabic
Review URL: http://codereview.chromium.org/1612017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
test to get it to work on IE6. It appears that on IE6
we don't receive the BeforeNavigate notifications for the anchor URLs.
Review URL: http://codereview.chromium.org/1568032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=41485
TEST=linux startup perf is green
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/1525033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
host.
BUG=37153
Review URL: http://codereview.chromium.org/1286004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The search icon (magnifying glass) in the keyword-search bubble was
inverted. The icon was shared with other code which called
|-setFlipped:| incompatibly.
Also line up the icon above the popup icons, and match the text baseline with the field's baseline.
BUG=41012
TEST=Type "google.com" then TAB. Mag glass is upright (like in popup).
Review URL: http://codereview.chromium.org/1574026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1540037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes a few changes:
- Switch to memcpy instead of CG drawing to copy pixels from the transport bitmap to the backing bitmap (this is a substantial perf win).
- Send transparancy information to the WebPluginDelegate, since it's no longer equivalent to not having a background DIB on the Mac (and likely on the other platforms in the future).
- Don't clear the transport DIB for non-transparent plugins, since they will be drawing over whatever is there anyway.
BUG=41340
TEST=Both transparent and non-transparent plugins should continue to draw correctly. Framerates for large CG plugins (e.g., in-window Netflix streaming) should be higher.
Review URL: http://codereview.chromium.org/1629017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
linux/views gets created bigger than max size."
This is not right fix.
This reverts commit ef67a340932fffa116b72413c7e5e425019f32a1.
BUG=none
TEST=none
TBR=johnnyg@chromium.org
Review URL: http://codereview.chromium.org/1618016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
single words from causing ugly notifications."
This reverts commit 0f42cfcc13c6d060fe8e43f6d8b5f069849f08f0.
This change makes the balloon's intial size bigger.
Review URL: http://codereview.chromium.org/1629015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=41011
TEST=none
TBR=davemoore@chromium.org
Review URL: http://codereview.chromium.org/1637010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1627017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1582029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gtk_drag_set_icon_pixbuf converts pixbuf with alpha into a pixmap and mask.
It uses the pixmap as window back pixmap and shape the window with the mask.
This should work theoretically. However, the underlying window's content
get mixed into the drag icon and make it un-usable. So changing to use a
drag icon widget of our own which would render everything correctly.
BUG=none.
TEST=Verify the drag-n-drop works correct without a messed up drag icon on bookmark bar and omnibox.
Review URL: http://codereview.chromium.org/1630017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This prevents GTK theme colors from bleeding into the omnibox.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1605026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure a repost form warning is closed properly even when the constrained window is closed from underneath us.
To do this, its controller now calls |Cancel| in its destructor.
We now have a potential cycle of methods calling each other:
* |RepostFormWarningController::CloseDialog| closes the |ConstrainedWindow|.
* This eventually calls |RepostFormWarningWin::DeleteDelegate|, which destroys |RepostFormWarningWin| and |RepostFormWarningController|.
* In its destructor, |RepostFormWarningController| calls |Cancel|, which calls |CloseDialog|.
Therefore, there are some checks in place to make sure we do everything during the teardown exactly once:
* After calling |NavigationController::CancelPendingReload|, we set |tab_contents| to null to make sure we don't call it again.
* During destruction, we set |window_| to null to make sure we don't call |CloseConstrainedWindow| again.
BUG=41367
TEST=RepostFormWarningTest.*
Review URL: http://codereview.chromium.org/1530032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This has happened to enough plugins now that it seems better to just make it a blanket policy on the Mac. We don't gain anything by unloading them at shutdown.
BUG=41431
TEST=Internal Flash shouldn't crash on unload.
Review URL: http://codereview.chromium.org/1652003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
protocol is already getting registered by url_util.cc super early in the
process, so this extra registration is redundant. Re-adding the protocol later
apparently modifies the set that url_util uses, and when this happens there
could be other threads reading it.
BUG=41150
TEST=none
Review URL: http://codereview.chromium.org/1545029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
NOTREACHED in the profile initialization when the password store fails to
initialize correctly.
BUG=35038
TEST=PasswordStoreMacTest.*
Review URL: http://codereview.chromium.org/1528036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome Frame such that CF will scan for older versions on load and delegate to them. This is to support clean upgrade scenarios whereby a new version is registered while IE is running.
BUG=40117
TEST=Register a new CF version while an old one is loaded in IE. Open a few new tabs and observe nothing bad happening.
Review URL: http://codereview.chromium.org/1562018
TBR=robertshield@chromium.org
Review URL: http://codereview.chromium.org/1604035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
older versions on load and delegate to them. This is to support clean upgrade scenarios whereby a new version is registered while IE is running.
BUG=40117
TEST=Register a new CF version while an old one is loaded in IE. Open a few new tabs and observe nothing bad happening.
Review URL: http://codereview.chromium.org/1562018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
that the buttons work.
BUG=crbug.com/41403
TEST=See bug report for repro steps.
Review URL: http://codereview.chromium.org/1595024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=manually
BUG=crosbug.com/2137
Review URL: http://codereview.chromium.org/1640010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
based on host permissions
BUG=38398
TEST=none
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/1528038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Along the way, refactor some related code.
BUG=now
TEST=manually
Review URL: http://codereview.chromium.org/1605029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use ISO 639-1 language code for input method indicator.
- Do not use raw language codes in the drop-down menu.
BUG=crosbug.com/2428
BUG=crosbug.com/2564
TEST=manual
Review URL: http://codereview.chromium.org/1622025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
document or query params.
We should only remove the icon when visiting a new origin or the underlying setting has changed.
BUG=40742
Review URL: http://codereview.chromium.org/1640004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
At this moment, this requires a browser restart, thus shows
a dialog about it.
DPENDS_ON http://codereview.chromium.org/1595026/show
BUG=crosbug.com/2336
TEST=manually
Review URL: http://codereview.chromium.org/1645007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the UI by Options->Change AutoFill settings->click on an
address->click on "Make this my default profile" flag.
( Original patch by raz@chromium.org )
BUG=41247
TEST=Set this pref in one browser, sync it in the other
Review URL: http://codereview.chromium.org/1612019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=confirmed it worked on linux and didn't break the windows build by trybots
BUG=none
Review URL: http://codereview.chromium.org/1595026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Recently the tarball got approx. 2x bigger because of that.
TBR=nsylvain
TEST=none
BUG=29044
Review URL: http://codereview.chromium.org/1545036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Startup perf was not impacted in an earlier test run, so this should be safe.
BUG=38182
Review URL: http://codereview.chromium.org/1530031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19113
TEST=Right border has correct color
Review URL: http://codereview.chromium.org/1518027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed Control+space since it's just for testing. Added Alt+~ which is popular for Japanese IME users on Windows.
We will add more hot-keys like 'Right-Alt+Right-Shift' and 'Zenkaku_Hankaku' later (in a separate CL).
BUG=crosbug/492
TEST=manual
Review URL: http://codereview.chromium.org/1593026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I added this method to webkit_glue in r44435, but forgot to
add it to this file.
Review URL: http://codereview.chromium.org/1566042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Along the way, remove "Cance" button. If really needed,
we could adding support for canceling in the future.
BUG=crosbug.com/2074
TEST=manually
Review URL: http://codereview.chromium.org/1612018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44452 0039d316-1c4b-4281-b951-d872f2087c98
|