| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
+ Remove the NativeMetafileFactory since we can't just use preview flag.
+ Update each Metafile constructor site to use PreviewMetafile or NativeMetafileImpl.
+ Fix misc. problems blocking pdf generation on Windows.
+ Rename the metafile interface.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/6826027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
file_manager.css:
* Smaller margin in header to account for buttons.
* No padding on sort image for the 'icon type' column.
* Add icon for folders
file_manager.js:
* Cache data for the sort column *just* before sorting.
* Scan DOM for 'visibleif' attributes to control visibility of DialogType specific elements.
* Add 'New Folder' functionality.
* Add new 'Icon Type' column so that files can be sorted by type. This column is a slightly special case because it has no label.
* Scroll selected items back into view after a sort.
* Remove leading '/' in virtual path passed in to selectFile(s).
mock_chrome.js:
* Remove unused strings.
* Add new strings.
util.js:
* Refactor FileError.p.toString code so that callers can get a error mnemonic without the surrounding '[object ...]' string.
main.html:
* Add 'New folder' button.
* Switch filename label/input to use visibleif attribute.
generated_resources.grd:
* Update strings
extension_file_browser_private_api.cc:
* Update strings.
* Add local macro to reduce copy-pasta overload.
BUG=chromium-os:14011
TEST=manual testing in harness and chromeos-chrome build
Review URL: http://codereview.chromium.org/6827001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/6820046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
b.ViewHostMsg_UpdateFaviconURL can update multiple icon urls
BUG=71571
TEST=Tested with existing unit test and add 2 new unit tests
Review URL: http://codereview.chromium.org/6672065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6823052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
R=mark@chromium.org
Review URL: http://codereview.chromium.org/6813083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I have been having issues with clicking the targets on this page during development do to other issues. Since this is not intended to be the final screen I just increased the size of the text so I don't accidentally click the wrong link. This caused it to be obvious that one of my divs wasn't closed correctly, so I fixed that also.
Patch from Ryan Harrison <rharrison@chromium.org>
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/6801048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=caseq
Review URL: http://codereview.chromium.org/6826039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- testMultiplePopups - verify that multiple popups are blocked.
- testPopupBlockedEverySec - Verify that popups launched are blocked every second.
- testPopupsLaunchWhenBrowserBackButton - Verify that popups are launched when the browser back button is pressed.
- testBlockPopupsFromExternalSite - Verify popups are blocked from an external site.
- testPopupsLaunchWhenTabIsClosed - Verify that popups are launched when leaving a page.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/6820006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use InvalidationClient's session state to determine whether notifications
are on/off, instead of just the XMPP connection state.
Combine ChromeInvalidationClient::Listener's invalidation methods into one.
Push the cached registered types state from InvalidationNotifier into
ChromeInvaildationClient.
BUG=
TEST=
Review URL: http://codereview.chromium.org/6820022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reason for crash appears to be because we can't find the WindowWin for
an hwnd.
I'm also removing a comment that is no longer relevant, and nuking a
call in window_win to ui::SetWindowUserData that is already done in
WindowImpl.
BUG=77651
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/6825045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Remove that test and replace it with cwnd10, which fixes the cwnd at 10.
BUG=none
TEST=this is the test
Review URL: http://codereview.chromium.org/6792026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows a base::WeakPtr to be deleted on a different thread, which will modify the refcount on Flag.
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81142
Review URL: http://codereview.chromium.org/6826034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed to fix a timing issue in browser_tests
OmniboxApiTest.Basic on the new Lucid builders. The browser window's
configure events are coming in at an unpredictable rate, causing the
debounce timer to expire prematurely, which results in an apparent
window resize/move, which causes the omnibox autocomplete popup to
close, which makes the test think there are no autocomplete results,
giving an error like:
chrome/browser/extensions/extension_omnibox_apitest.cc:129: Failure
Value of: result.size()
Actual: 0
Expected: 5U
BUG=
TEST=browser_tests succeeds on Lucid builders
Review URL: http://codereview.chromium.org/6825010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The pyauto test sync.SyncTest.testRestartBrowser was flaky because, on
browser restart, the ProfileSyncService was sometimes in the middle of
being initialized when the test began its wait for sync completion.
This patch adds a check to make sure the sync service is initialized,
that will also wait for initialization. It also adds an extra check to
the sync.SyncTest.testRestartBrowser test case to make sure that
updates_received is 0 if a browser is restarted and nothing has changed
at the server end.
BUG=78677, 78548, 78863
TEST=pyauto test sync.SyncTest.testRestartBrowser
Review URL: http://codereview.chromium.org/6825023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=75048
TEST=Use Natty. Open Window. Isn't ugly orange box in lower right corner.
Review URL: http://codereview.chromium.org/6826006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
RefCountedThreadSafe.This allows a base::WeakPtr to be deleted on a different thread, which will modify the refcount on Flag.BUG=noneTEST=noneReview URL: http://codereview.chromium.org/6826034
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/6821053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
through a layer iterator. This device is neither SkCanvas::getDevice() or SkCanvas::getTopDevice(). We changed it to do native painting on SkCanvas::getDevice() in r80955 which resulted in numerous regressions. This patch reverts to using the same device used pre r80955.
BUG=78891
Review URL: http://codereview.chromium.org/6826040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows a base::WeakPtr to be deleted on a different thread, which will modify the refcount on Flag.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6826034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=rjkroege@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Executing this hook has the same effect as clicking on the "Update
extensions now" button under "Developer tools" on Chrome's extensions
page. This hook is especially useful for testing the promo apps, because
the promo apps won't be installed until after the extensions are
updated.
BUG=75202
TEST=None
Review URL: http://codereview.chromium.org/6713104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=rogerta@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=78825
TEST=N/A
TBR=dmichael@chromium.org
Review URL: http://codereview.chromium.org/6813086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=79081
TEST=N/A
TBR=dmichael@chromium.org
Review URL: http://codereview.chromium.org/6821051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
prior to placing it in a scoped_nsobject<NSBundle>, otherwise the NSBundle
might be released prematurely. This should fix FutureCat zombie crashes.
BUG=78652
TEST=No more NSBundle zombie crashes should show up on the crash server.
Review URL: http://codereview.chromium.org/6813085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- generate WebInputEvent::ContextMenu events.
- calculate the context menu position correctly.
- monitor mouse down events on fullscreen render widget, so that we can pass correct timestamp to gtk_menu_popup.
BUG=None.
TEST=Open a fullscreen Youtube video, and right click on it to see whether context menu shows up or not.
Review URL: http://codereview.chromium.org/6760019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
converting to a std::string for serialization (the backend treats empty string
the same as NULL).
Review URL: http://codereview.chromium.org/6824045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This implementation is based on the existing AudioDevice client.
Patch by henrika@chromium.org:
http://codereview.chromium.org/6724022/
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6812042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=N/A
BUG=79074
TBR=dmichael@chromium.org
Review URL: http://codereview.chromium.org/6823050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
apache2.2-bin where available.
TEST=http layout tests pass even after uninstalling apache2
Review URL: http://codereview.chromium.org/6822031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
using PyAuto.
GetUpdateInfo() returns information about the updater, including what track (channel) the updater is on and what state the updater is in.
UpdateCheck() will initiate a check for updates and attempt to install one if there is one. It is a blocking call.
SetReleaseTrack() will set the release track to either "beta-channel" or "dev-channel".
BUG=chromium-os:12524
TEST=testSetReleaseTrack and testGetUpdateInfo included in chromeos_basic.py. UpdateCheck() tested manually, since an AU server or devserver is needed to test it.
Review URL: http://codereview.chromium.org/6813006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- clang build requires destructor in complex classes
- chromeos build requires newline at end of files
Adding a native theme painter, to allow Views to use NativeTheme to draw
their background. Added example code to show it in use. I still have not
hooked this into any existing View-based controls.
BUG=None
TEST=None
R=ben@chromium.org
Review URL: http://codereview.chromium.org/6820007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:13257, chromium-os:4413
TEST=NONE
Review URL: http://codereview.chromium.org/6809001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6825044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/6813081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This matches the behavior on Windows and also prevents visual confusion that
suggests you can drag a folder into itself (by drag it into its own menu).
BUG=53570
TEST=Open a bookmark menu from the bookmark bar. Start dragging the folder
button that was opened. The bookmark menu should get closed.
Review URL: http://codereview.chromium.org/6816017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a real fix for 13750. When the entire area of a WidgetGtk is covered by another GdkWindow,
the WidgetGtk doesn't get expose event, which was causnig 13750. This fixes this issue by listening
child widget's expose event and remove the FREEZE_UPDATE property.
BUG=chromium-os:11514, chromium-os:13750
TEST=see bug for repro steps
R=sky@chromium.org
Review URL: http://codereview.chromium.org/6823017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a test that verifies that we can still execute scripts after a frame has
loaded, even when that frame loaded after the main document has completed.
R=aa@chromium.org
BUG=78854
TEST=ExecuteScriptApiTest.ExecuteScriptFrameAfterLoad
Review URL: http://codereview.chromium.org/6813064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Drawing from the lists of preferences in user_cros_settings_provider.cc, this adds the remaining boolean prefs
to our device policy protobuf definition.
BUG=13230
TEST=build chrome
R=jkummerow@chromium.org
Review URL: http://codereview.chromium.org/6821049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=51317
Review URL: http://codereview.chromium.org/6825024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
table.css: Use unicode characters rather than images, looks the same and doesn't require wiring up a content handler.
table.js: Add forwarded method scrollIndexIntoView
table_data_model.js: Add prepareSort hook so client code can fetch data required for the sort.
table_header.js: Add column specific class name to headers so that clients can apply column-number specific header styles.
table_selection_model.js: Adjust leadIndex after a sort.
table_single_selection_model.js: Adjust leadIndex after a sort.
BUG=none
TEST=manual testing of cros file dialogs
Review URL: http://codereview.chromium.org/6825029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6822023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6824042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Removes the guesswork when this dcheck shows up.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/6824030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6823025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=58235
TEST=none
Review URL: http://codereview.chromium.org/6826028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=bradnelson
Review URL: http://codereview.chromium.org/6824044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While I'm here add On prefix, renaming it to OnSourceProfilesLoaded(),
to make it clear this is an event, and to differentiate it from other method
also called SourceProfilesLoaded().
Some unrelated changes in testing_automation_provider.h:
- Move BrowserList::Observer implementation to private section.
- Reorder the definition in the source file to match with the header order.
BUG=None
TEST=None
R=avi@chromium.org
Review URL: http://codereview.chromium.org/6821034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=77914
TEST=none, trybots remain green
Review URL: http://codereview.chromium.org/6813074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81108 0039d316-1c4b-4281-b951-d872f2087c98
|