| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=none
TEST=|'localStorage' in window| should only be true iff --enable-local-storage is specified
Review URL: http://codereview.chromium.org/335034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hack for making them work in test shell and single process mode.
This replaces http://codereview.chromium.org/335034/show
TEST=none
BUG=24581
Review URL: http://codereview.chromium.org/363014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit 31077.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/fast/events/drag-and-drop-dataTransfer-types-nocrash.html was fixed in WebKit r50532 <http://trac.webkit.org/changeset/50532>.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/355038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26555
TEST=run valgrind or let build bot do it and if it runs faster than you can go make a coffee and get back, then its good.
Review URL: http://codereview.chromium.org/366023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Refactored WebWorkerClientProxy into two classes - WebWorkerDispatcher which dispatches incoming IPCs for the worker, and WebWorkerClientProxy, which handles outgoing API calls from WebWorkerImpl. This allows WebWorkerClientProxy to be reused by WebSharedWorkerDispatcher.
BUG=26233
TEST=none (will enable layout tests when basic functionality available)
Review URL: http://codereview.chromium.org/351004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is so that when unattended, typically the first run dialog is not shown
(when using automation proxy) and the user does not get a chance to consent
to sending stats. This gives an opportunity to force enable breakpad.
BUG=24960,25271
TEST=Breakpad should be initialized if --enable-crash-reporter flag has been specified
Review URL: http://codereview.chromium.org/282011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
compile-time differences between Chrome Frame and Chrome.
Review URL: http://codereview.chromium.org/361023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Wrote unit tests for the entire class and fixed some other bugs that cropped up.
BUG=25075
TEST=unit_tests, also closing tabs/browser shouldn't try to use dead IO loop
Review URL: http://codereview.chromium.org/363007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
database. This allows us to modify Browser::Type without invalidating databases from older versions.
http://crbug.com/26500
TEST=see bug
Review URL: http://codereview.chromium.org/361016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26756
Review URL: http://codereview.chromium.org/361024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
- Less file IO on the UI thread
Review URL: http://codereview.chromium.org/354013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
checked into platform/chromium-win
R=victorw@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/360046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/360045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
blocks the connection) to ERR_ACCESS_DENIED. We are already
mapping EACCES to ERR_ACCESS_DENIED on Linux and Mac.
Use ERR_CONNECTION_FAILED instead of ERR_FAILED as the default
error code for Connect.
Create the ShouldTryNextAddress function for Windows to match
the Linux and Mac code.
WSAGetLastError returns int rather than DWORD.
R=eroman
BUG=21548
TEST=none
Review URL: http://codereview.chromium.org/361015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25945
TEST=similar to media_bench you should be able to valgrind on the tool and not see memory leaks.
Review URL: http://codereview.chromium.org/363021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
almost identical app menu.
This CL will toggle app menu depending on the status of toolbar.
- This is only for toolkit views build as gtk version does not toggle toolbar.
- The menu contnets are not fully sync'ed. We need some refactoring, when
we fully migrate to views.
Review URL: http://codereview.chromium.org/366010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
TEST=tree stays green
Review URL: http://codereview.chromium.org/361019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24701
TEST=ran chrome and looked at the strings
Review URL: http://codereview.chromium.org/366016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=22962
TEST=Install an extension. Install dialog warning should not include any warnings about autoupdating.
Review URL: http://codereview.chromium.org/362002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=14751,14752,14767
Review URL: http://codereview.chromium.org/363020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=7228-7241
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/360037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25945
TEST=valgrind --tool=memcheck --num-callers=30 --leak-check=full --gen-suppressions=all --demangle=no out/Debug/media_bench --stream=video ~/media/color2.mp4
Review URL: http://codereview.chromium.org/363016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also correct some long line violations.
Review URL: http://codereview.chromium.org/355034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
expected leak in CheckOpString
Review URL: http://codereview.chromium.org/361021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/360036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
bookmarks bar during an animation. What we want is the "extra"
height provided by the bookmarks bar. Since we always show at
least 4px, we don't count that as extra height.
Review URL: http://codereview.chromium.org/366019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26509
TEST=none
Review URL: http://codereview.chromium.org/340072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
TEST=tree stays green
Also add a fail expectation for a new test so we can capture it's
baseline later.
Review URL: http://codereview.chromium.org/363013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
keep alignment correct in both cases. Also strip out newlines from bookmark titles.
[Patch by feldstein.]
BUG=26353
TEST=Add and remove titles from bookmarks in the bookmark bar and verify that they look correct, and icons are centered when there is no text.
Review URL: http://codereview.chromium.org/353024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=26614
Review URL: http://codereview.chromium.org/360035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
on shutdown when extensions were running.
BUG=15708
BUG=26652
Review URL: http://codereview.chromium.org/355032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/355033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= 20036
TEST= install glossy blue theme. See curved corner (overlay) in upper left hand corner.
Note that it does not appear in the incognito version of the theme (now it appears in the jarringly wrong color).
Review URL: http://codereview.chromium.org/361018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=20786
BUG=20886
BUG=24167
TEST=i can has green?
Review URL: http://codereview.chromium.org/367004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Test were added in http://trac.webkit.org/changeset/50495.
R=hamaji
TEST=none
BUG=20206
Review URL: http://codereview.chromium.org/366018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
declaration order.
This is strictly a no-op refactor, it does not change any code (just re-orders it within the file).
This addresses a TODO to tidy the code.
TBR=darin
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/360030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=japhet
TEST=none
BUG=10442
Review URL: http://codereview.chromium.org/360032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
therefore asserting in debug mode.
Review URL: http://codereview.chromium.org/360033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/361012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG= 26704
TEST= change themes. browser does not crash.
Review URL: http://codereview.chromium.org/366015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=amit
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
locatio instead of its old location.
Review URL: http://codereview.chromium.org/360020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Skia correctly depends on Harfbuzz so we don't need to depend on it
from the top-level gyp file.
TEST=compiles
Review URL: http://codereview.chromium.org/355031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now this test is dumpAsText test.
Upstream change: https://bugs.webkit.org/show_bug.cgi?id=30931
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/340053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TCV's size allocate message. This avoids a spurious size-allocate
being sent to the renderers when creating a new tab. The extra
size-allocate is called by the build-in GtkFixed's size allocate
method.
Another way to think of this is that we only size our RWH directly
and decouple it's sizing from the GTK+ widget's sizing.
BUG=26495
Review URL: http://codereview.chromium.org/363012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG= 26689
TEST= none
Review URL: http://codereview.chromium.org/362012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=rafaelw
BUG=None
TEST=This is fixing a test.
Review URL: http://codereview.chromium.org/367006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=17585
TBR=japhet
Review URL: http://codereview.chromium.org/363015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31027 0039d316-1c4b-4281-b951-d872f2087c98
|