| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before:
current_locale->default_locale
Now:
current_locale->chain_of_parent_locales->default_locale
If default_locale is de, and current locale en_US, we follow:
en_US -> en -> de
en is not a Chrome locale (only en_US, en_GB are), but we fake it to allow this kind of fallback.
Developers can implement common locale root with most of the messages (like en) and put locale specifics in en_GB (color->colour) or en_US. You can even symlink en and en_US and save on work.
I am planning on fixing loading local resources too, to use this child->parent fallback.
BUG=12131
Review URL: http://codereview.chromium.org/293037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The test was still failing
Review URL: http://codereview.chromium.org/314001
TBR=yurys@google.com
Review URL: http://codereview.chromium.org/292051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/303018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
functions that are now public. Fix a few style errors. Make some functions shorter. Remove "using" directives since most of the file ignored them anyways. Remove unneeded #includes.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/292041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This hasn't reproduced in the past bunch of runs of net_unittests; I believe it was fixed by r26611.
BUG=15147
Review URL: http://codereview.chromium.org/294034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=13907
TEST=n/a
Review URL: http://codereview.chromium.org/295040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Windows only change.
This is basically landing jschuh change http://codereview.chromium.org/293040
TEST=none
BUG=25366
Review URL: http://codereview.chromium.org/313009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/307021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
test and for permitting the tests to be run regardless of underlying platform. Also some minor fixes and cleanup.
BUG=none
TEST=none
REVIEW=http://codereview.chromium.org/269016/
TBR=kkania@chromium.org
Review URL: http://codereview.chromium.org/293054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix canvas text drawing bugs for certain vertical alignments.
BUG=25267
TEST=about:crash
Review URL: http://codereview.chromium.org/307015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/292038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and allow remembering the "Do Nothing" choice.
BUG=none
TEST=Verify that "Do Nothing" is the left button, and that clicking the "Remember" checkbox remembers the "Do Nothing" state.
Review URL: http://codereview.chromium.org/314003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* classes AppCacheResponseReader and AppCacheResponseWriter
* also implements AppCacheStorage.LoadResponseInfo()
* using a memory-backed disk_cache for now, so not really on disk yet
TEST=appcache_response_unittest.cc
BUG=none
Review URL: http://codereview.chromium.org/269062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
RenderViewHostDelegate::FormFieldHistory to better reflect the purpose of the interface.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/294030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
permitting the tests to be run regardless of underlying platform. Also some minor fixes and cleanup.
BUG=none
TEST=none
REVIEW=http://codereview.chromium.org/269016/
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/295039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
otherwise the profile pointer may go stale if it was opened from an Incognito
window.
Simplify the check that already does this on Mac. GetOriginalProfile() returns
the profile it's called on, if it isn't incognito.
BUG=23359
TEST=open Incognito window, right-click in omnibox, Edit Search Engines,
close Incog window, edit an engine
Review URL: http://codereview.chromium.org/307010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The extension team's plan is to get rid of extension shelf entirely.
This is also going to fix a crash.
TEST=none
BUG=25106
Review URL: http://codereview.chromium.org/313006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Covered by net_unittests.
BUG=25316
Review URL: http://codereview.chromium.org/293049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=aa
Review URL: http://codereview.chromium.org/313008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This surfaced because I moved global shortcut handling before menu dispatch recently, and global keyboard handling didn't look at the opt button, so it thought cmd-opt-left meant cmd-left and swallowed the event.
BUG=25396
TEST=Focus text box in web. cmd-opt-left/right should switch tabs, cmd-left/right should move cursor in text box. Focus web background. cmd-opt-left/right should switch tabs, cmd-left/right should do history navigation. Focus omnibox. cmd-opt-left/right should still switch tabs, cmd-left/right should move cursor. cmd-1/2 should switch tabs in all three places, cmd-opt-1/2 should not do anything.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29646
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=29648
Review URL: http://codereview.chromium.org/313004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/313007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We expand it to $HOME or the appropriate /home/foobar.
BUG=18200
TEST=Extended the unit test with test cases.
Review URL: http://codereview.chromium.org/300026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/293050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
running wine.
BUG=valgrind_210481, valgrind_205541
TEST=valgrind net_unittests --gtest_filter=ProxyResolverV8Test.LoadLog ; valgrind wine's unit tests and see no HEAP_CreateSubHeap valgrind warnings
Review URL: http://codereview.chromium.org/306020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
running, the Chrome window was not activated.
BUG=19373
TEST=See bug
Review URL: http://codereview.chromium.org/308008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
the main.py selenium test runner.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(r29315 was http://codereview.chromium.org/273063.) r29315 incorrectly changed the code for the Text Encoding menu entry to IDC_ENCODING_AUTO_DETECT (from IDC_ENCODING_MENU), which caused it to be incorrectly recognized as the auto detect menu item....
BUG=25397
TEST=Check the View->Text Encoding menu under various circumstances.
Review URL: http://codereview.chromium.org/292047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that they can be highlighted / depressed independently.
Got alignment of buttons right.
Support hover and pushed in StatusAreaButton.
Share status area button code.
New icons for battery and wifi.
New images.
Review URL: http://codereview.chromium.org/300018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/fast/xmlhttprequest/xmlhttprequest-html-response-encoding.html = CRASH
BUG:25399
Review URL: http://codereview.chromium.org/303020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG:19546
Review URL: http://codereview.chromium.org/300038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This surfaced because I moved global shortcut handling before menu dispatch recently, and global keyboard handling didn't look at the opt button, so it thought cmdoptleft meant cmdleft and swallowed the event.
BUG=25396
TEST=Focus text box in web. cmdoptleft/right should switch tabs, cmdleft/right should move cursor in text box. Focus web background. cmdoptleft/right should switch tabs, cmdleft/right should do history navigation. Focus omnibox. cmdoptleft/right should still switch tabs, cmdleft/right should move cursor. cmd1/2 should switch tabs in all three places, cmdopt1/2 should not do anything.
Review URL: http://codereview.chromium.org/313004
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/306025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG:25399
Review URL: http://codereview.chromium.org/293047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This surfaced because I moved global shortcut handling before menu dispatch recently, and global keyboard handling didn't look at the opt button, so it thought cmd-opt-left meant cmd-left and swallowed the event.
BUG=25396
TEST=Focus text box in web. cmd-opt-left/right should switch tabs, cmd-left/right should move cursor in text box. Focus web background. cmd-opt-left/right should switch tabs, cmd-left/right should do history navigation. Focus omnibox. cmd-opt-left/right should still switch tabs, cmd-left/right should move cursor. cmd-1/2 should switch tabs in all three places, cmd-opt-1/2 should not do anything.
Review URL: http://codereview.chromium.org/313004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG:None, since there is already multiple similar stacks in this file.
TBR
Review URL: http://codereview.chromium.org/307019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change effectively reverts http://src.chromium.org/viewvc/chrome?view=rev&revision=25491 and fixes http://crbug.com/16018 in a different way.
BUG=http://crbug.com/16018
BUG=http://crbug.com/21738
TEST=layout tests should still pass
Review URL: http://codereview.chromium.org/258035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25392
TBR=dank
Review URL: http://codereview.chromium.org/293046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move security related methods out of WebKit.h into its own class WebSecurityPolicy. This involves these functions:
- registerURLSchemeAsLocal
- registerURLSchemeAsNoAccess
- whiteListAccessFromOrigin
- resetOriginAccessWhiteLists
BUG=24601
TEST=Compiled locally, try bot'ed.
Review URL: http://codereview.chromium.org/293021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/295019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/314001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25385
TBR=dank
Review URL: http://codereview.chromium.org/306024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(see third_party/icu/source/common/umutex.c)
When two concurrent threads try to call umtx_lock(mutex) for an uninitialized mutex simultaneously, *mutex is read without taking any lock.
However, if *mutex is NULL, a DCLP inside umtx_init(mutex) guarantees that *mutex is initialized exactly once. Otherwise, if *mutex is already a valid pthread_mutex_t, the behavior of the program is not affected.
This patch was prepared by Alexander Potapenko (cc'ed)
TBR=dank
Review URL: http://codereview.chromium.org/303019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
unnecessary UTF-8 conversion when converting C strings to WebKit
Strings. Re-enabled WebGL in Dev Channel builds.
BUG=http://crbug.com/21852
TEST=none (runs existing WebGL tests; more coming)
Review URL: http://codereview.chromium.org/308006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=12881
TEST=none
Review URL: http://codereview.chromium.org/307017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=apavlov
Review URL: http://codereview.chromium.org/313002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12497,24756
TEST=LayoutTests/fast/websockets success
Review URL: http://codereview.chromium.org/243108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The heap checker will be linked with libtcmalloc by default.
This patch was prepared by Alexander Potapenko (cc'ed) and originally reviewed as http://codereview.chromium.org/307005
TBR=evan,bradn (already LGTMed at http://codereview.chromium.org/307005)
Review URL: http://codereview.chromium.org/292043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29625 0039d316-1c4b-4281-b951-d872f2087c98
|