| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rid of jankyness on 10.6. It really shouldn't have worked right on 10.5 either.
The layer needed to be hosted in a view. Views should not overlap.
The only ways to do this correctly are:
a) Turn on setWantsLayer for the browser view and make a subview to host our
animation.
b) An overlay window
Went with 'b', because 'a' may be a big memory hit, and I'm not sure how
webkit works in a layered environment.
BUG=23500
TEST=see bug
Review URL: http://codereview.chromium.org/385053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
codereview.chromium.org/293019
TEST=BUG=none
Review URL: http://codereview.chromium.org/389016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- don't reload tabs to ensure that a page loaded (it's handled in
waiting for completion of IDC_NEW_TAB)
- simplify the code, making it shorter and issuing less automation calls
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/385066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
rather than the "origin".
BUG=26961
TEST=test extension linked in the bug
Review URL: http://codereview.chromium.org/385058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I've chosen to use a union here instead of restoring the original memcpy code.
Errors were as follows:
cc1plus: warnings being treated as errors
chrome/browser/safe_browsing/safe_browsing_database_bloom.cc: In member function ‘virtual bool SafeBrowsingDatabaseBloom::ContainsUrl(const GURL&, std::string*, std::vector<int, std::allocator<int> >*, std::vector<SBFullHashResult, std::allocator<SBFullHashResult> >*, base::Time)’:
chrome/browser/safe_browsing/safe_browsing_database_bloom.cc:274: error: dereferencing pointer ‘full_hash.207’ does break strict-aliasing rules
chrome/browser/safe_browsing/safe_browsing_database_bloom.cc:274: note: initialized from here
chrome/browser/safe_browsing/safe_browsing_database_bloom.cc: In member function ‘void SafeBrowsingDatabaseBloom::InsertSub(int, SBPrefix, SBEntry*)’:
chrome/browser/safe_browsing/safe_browsing_database_bloom.cc:478: error: dereferencing pointer ‘full_hash.258’ does break strict-aliasing rules
chrome/browser/safe_browsing/safe_browsing_database_bloom.cc:478: note: initialized from here
chrome/browser/safe_browsing/safe_browsing_database_bloom.cc: In member function ‘void SafeBrowsingDatabaseBloom::InsertAdd(SBPrefix, SBEntry*)’:
chrome/browser/safe_browsing/safe_browsing_database_bloom.cc:402: error: dereferencing pointer ‘full_hash.237’ does break strict-aliasing rules
chrome/browser/safe_browsing/safe_browsing_database_bloom.cc:402: note: initialized from here
make: *** [out/Release/obj.target/browser/chrome/browser/safe_browsing/safe_browsing_database_bloom.o] Error 1
Review URL: http://codereview.chromium.org/389021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=26155
TEST=Install a chrome theme; the default gradient shouldn't be shown on the
popup notification.
Review URL: http://codereview.chromium.org/384063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
implements the PluginRequestHandler
interface which is maintained by individual requests which can outlive the active document/activex instances.
I ran into a crash where UrlmonUrlRequest was calling into an invalid PluginRequestHandler pointer which
had been destroyed just before.
We also need to ensure that UrlmonUrlRequest and ChromeFrameActiveXBase select the multi threaded model as
AddRef/Release can be invoked from multiple threads.
I also removed the CleanupAsyncRequests function in ChromeFrameAutomationClient and moved all the code to CleanupRequests, which ensures that we treat synchronous
and asynchronous requests similarly.
There are instances where an automation client instance is created and destroyed without being initialized which causes a spurious assert to fire in the Uninitialize function. I added a check in the Uninitialize function to return if the state is uninitialized.
Bug=none
Review URL: http://codereview.chromium.org/386014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
window.close().
BUG=26277
TEST=none
Review URL: http://codereview.chromium.org/385056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/385057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added ProfileSyncService::IsSyncEnabled().
BUG=23073
TEST=manually (OS X),trybot
Review URL: http://codereview.chromium.org/389019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
set. At the same time, allow it in release mode as well.
BUG=27252
Review URL: http://codereview.chromium.org/384084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Menu item is right above "Preferences..." (with an extra separator). Menu item and separator is hidden if sync is not enabled.
BUG=23073
TEST=manually
Review URL: http://codereview.chromium.org/386020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* test for ViewID util that is not used in linux views
BUG=None
TEST=Run browser_tests --gtest_filter=ViewIDTest.* and make sure no test runs.
Review URL: http://codereview.chromium.org/388014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/18084
TEST=You should be able to undo and redo typing and pasting in the omnibox, unless autocomplete has kicked in or you selected/highlighted an entry in the popup.
Review URL: http://codereview.chromium.org/246009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
inspector.js in WebKit)
To use old-style unconcatenated sources, set 'debug_devtools' variable.
BUG=26911
TEST=none
Review URL: http://codereview.chromium.org/376022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add DCHECKs for main thread in all the places we use animation contexts.
Added a stack based class that takes an animate flag to enable/disable animation operations (grouping, durations) to clean up the code that does optional animation.
This might help the crashes in the bug because before we created animation context groups when we didn't need them and those empty groups could be tripping up something in the system frameworks (I some something similar in nib loading on 10.6).
BUG=26979
TEST=like we have a repeat fail case...
Review URL: http://codereview.chromium.org/390014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Tha panel allows inspecting cookies and local/session storage which are enabled by default.
TEST=DevToolsSanityTest.TestShowStoragePanel
Review URL: http://codereview.chromium.org/391032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
already been rolled
BUG=27366,27321
TEST=DevToolsSanityTest.TestPauseWhenLoadingDevTools
TBR=pfeldman
Review URL: http://codereview.chromium.org/389018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Don't run experiment task if there are not request context ready yet.
BUG=27491
TEST=none
Review URL: http://codereview.chromium.org/384076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These controls are only visible when sync is enabled. This isn't finished,
but it is enough to be usable.
Made RemoveViewFromView() handle top-most views. Also added
RemoveGroupFromView().
BUG=23073
TEST=manual testing, trybots
Review URL: http://codereview.chromium.org/380006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
by really making the alarm instantly go off.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/377029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Use assignment/casting in place of memcpy() where possible
* Avoid some unnecessary size_t->int casts by just using size_t
* Be more consistent about usage of SBPrefix type
* Write shorter statements/blocks if possible, e.g. "a -= (b + c);" instead of "a = a - b; a = a - c;"
* Update copyrights
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/386009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Involved some refactoring of FlipStreamParser/FlipStream/FlipSession.
I now want to merge FlipStream and FlipStreamParser.
In this CL:
* Update the FlipDelegate to remove unused methods and add the
OnWriteCompleted() method.
* Add a full state machine to the FlipStreamParser. This is the same
state machine which is used by the HttpStreamParser, with only
small changes. The FLIP side of this only needs the write-state
right now, and as we merge the FlipStream and FlipStreamParser,
I think we'll get the full state machine hashed out.
* POST now works (minimally). I need more testing for large posts.
But the unittests are updated (using the new delayed async mock
socket work).
BUG=none
TEST=flip_network_transaction_unittest.cc
Review URL: http://codereview.chromium.org/390016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=scherkus
Review URL: http://codereview.chromium.org/385063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Base class of using a OMX component for video decoding.
This class defines the specific behavior of using an OMX
component for video decoding. It tries not to be hardware
specific as much as possible.
Review URL: http://codereview.chromium.org/372037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Will revert after looking at the Linux memory bot and perf cycler.
TBR=willchan
Review URL: http://codereview.chromium.org/386016
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/384074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
been fixed and it looks arial to me now.
BUG=10277
TEST=none
Patch by kinuko@g
Original review: http://codereview.chromium.org/384043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Will revert after looking at the Linux memory bot and perf cycler.
TBR=willchan
Review URL: http://codereview.chromium.org/386016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
reusable.
o Adds the ability to position the arrow of the bubble on the top right as well as the top left (default).
BUG=none
TEST=Nothing should change visually. This is prep for use by browser action popups and the first run UI.
Review URL: http://codereview.chromium.org/385060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and go back to the default behavior which treats BEGIN as BEGIN
DEFERRED.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/387030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also added basic tests for these functions.
BUG=21732
Review URL: http://codereview.chromium.org/384070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r31736 due to valgrind errors.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
No functional change, just cleanup.
Review URL: http://codereview.chromium.org/384069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=new cases in mock_appcache_storage_unittest.cc and appcache_unittest.cc
BUG=none
Review URL: http://codereview.chromium.org/372070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26713
TEST=still compiles
Review URL: http://codereview.chromium.org/387031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/27301
TEST=new profile with no bookmarks. Shrink horiz width so "bookmarks
go here" text overlaps with "Other bookmarks". Make sure they line up
vertically. Now go to NTP and detach bookmark bar (cmd-shift-b).
Make sure text still lines up.
Review URL: http://codereview.chromium.org/385055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Check the output of localtime() before using it.
BUG=none
TEST=memory_test on 64bit Linux
Review URL: http://codereview.chromium.org/386012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/384067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
method in Chromium's custom Posix VFS implementation to correctly
implement the 'unused file descriptors' logic.
TEST=none
BUG=26041
Review URL: http://codereview.chromium.org/377039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This mega patch contains a few simple but tightly dependent changes:
1. Deletion of webkit/api/WebKit.gyp. The file now lives in webkit.org.
2. Rename of webkit/webkit.gyp to webkit/webkit_glue.gyp. Having two webkit.gyp was a source of developer confusion.
3. Gyp dependencies are updated across chromium to point at the upstream WebKit.gyp and the renamed webkit_glue.gyp.
4. Some 200+ files include paths fixed to point to third_party/WebKit/WebKit/chromium instead of webkit/api. The later will be deleted in a subsequent patch.
Review URL: http://codereview.chromium.org/387020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All In New Window" and "Open All In Incognito Window" (17616).
Bookmark Folders have the bar context menu, not the bookmark context
menu (26748).
Disable bookmark manager item on bookmark contextual menus (26944).
BUG=http://crbug.com/17616, http://crbug.com/26748, http://crbug.com/26944
TEST=Add some bookmarks.
Make sure "Open All In New Window" and "Open All In Incognito Window" work from the bar context menu.
Add a bookmark folder.
Make sure the context menu of the folder is the bar conetxt menu, not the 'mark context menu.
Make sure Bookmark Manager item is DISabled in both context menus.
nib change: hook up actions in the "Open All Blah" items just like the normal "Open All".
Review URL: http://codereview.chromium.org/373022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The RWH_TabSwitchPaintDuration histogram calculates
the amount of time it took after a particular view was
selected for it to be fully painted.
Previous versions of this patch included modifications
to the tab switching test. Those are blocked on setting
up a new builder for accurate measurement and are now
removed from this CL.
BUG=4104
TEST=none
Commit: http://src.chromium.org/viewvc/chrome?view=rev&revision=31632
Revert: http://src.chromium.org/viewvc/chrome?view=rev&revision=31645
Commit: http://src.chromium.org/viewvc/chrome?view=rev&revision=31679
Revert: http://src.chromium.org/viewvc/chrome?view=rev&revision=31683
Review URL: http://codereview.chromium.org/378038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=erikkay
Review URL: http://codereview.chromium.org/386011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also makes the SetUserText behavior similar to the Windows/Linux versions (by calling SetWindowTextAndCaretPos() that also deals with the selection).
R=shess
BUG=None
TEST=Make sure the location bar still works as expected on Mac.
Review URL: http://codereview.chromium.org/329024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=27436
Review URL: http://codereview.chromium.org/391023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
using GTK theme or Classic theme.
BUG=27075
Review URL: http://codereview.chromium.org/384060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26106
TEST=none
TBR=finnur
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
At this point it does not support grouping or sorting.
Mostly refactoring things from TableView to TableView2 and NativeTableWin.
BUG=None
TEST=Unit-tests and view examples for now.
R=sky
Review URL: http://codereview.chromium.org/387021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31741 0039d316-1c4b-4281-b951-d872f2087c98
|