| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3692008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a RequestSockets() API to ClientSocketPool interface.
- no RequestPriority param, all requests default to LOWEST.
- adds a |num_sockets| param to control how many sockets to try to ensure are connected.
Adds an implementation for said function in ClientSocketPoolBaseHelper.
Adds a new ClientSocketPoolBaseHelper::Flag type to modify socket request behavior. In this case, we bypass idle sockets.
Adds a preconnect concept to ConnectJob. This lets normal requests hijack preconnect jobs.
Modifies all ClientSocketPool subclasses to support new RequestSockets API().
Adds new tests.
No client actually uses this API yet. We need to plumb it up to the preconnect system.
BUG=54450
TEST=new tests in ClientSocketPoolBaseTest
Review URL: http://codereview.chromium.org/3689004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This disables all enabled labs, but doesn't disable about:labs. If a lab crashes chrome on startup, one can temporarily start chrome with --no-labs, go to about:labs, disable the lab, and then restart chrome.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3720002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- hook up desktop notification exceptions map to the view.
- fix the notification system for desktop notifications and geolocation so that the views update in real time
- disable double-click editing of desktop/location exceptions
BUG=57457
TEST=manual
Review URL: http://codereview.chromium.org/3709006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58973
TEST=None
Review URL: http://codereview.chromium.org/3698006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
since it's disabled in released builds.
Review URL: http://codereview.chromium.org/3742001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Rename chrome_thread.cc to browser_thread.cc
- Rename chrome_thread_unittest.cc to browser_thread_unittest.cc
- Include browser_thread.h instead of chrome_thread.h where needed.
- Fix gyp files according.
BUG=56926
TEST=trybots and compiled locally
Review URL: http://codereview.chromium.org/3643005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Call OnMenuOpened when the window is mapped.
This is necessary as DOMUI menu doesn't show the popup window until page is renderred.
* Moved listners to Menu2 as Menu2 manages MenuListeners.
BUG=chromium-os:7642
TEST=TestMenuKeyboardAccess,TestAltMenuKeyboardAccess passes with this fix.
Review URL: http://codereview.chromium.org/3678005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I was worried about this problem, and realized I didn't
have a unit test to ensure the correctness in this
case. This just adds a unit test.
r=rvargas
Review URL: http://codereview.chromium.org/3535009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=33185
r=kmixter
Review URL: http://codereview.chromium.org/3702005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/3729003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Happy trybots.
Review URL: http://codereview.chromium.org/3697009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
First step to allowing the session manager to handle whitelisting the owner.
BUG=chromium-os:7511
TEST=unit tests, install on device with ToT session_manager
Review URL: http://codereview.chromium.org/3671005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
removing
unneeded files in WebKit API.
BUG=none
TEST=none
TBR=darin
Review URL: http://codereview.chromium.org/3727004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Minor cleanup of CertificateManagerModel by removing some wrappers of CertDatabase readonly functions.
BUG=19991
TEST=manual
Review URL: http://codereview.chromium.org/3516023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
from being shown on ChromeOS.
BUG=54145
TEST=none
Review URL: http://codereview.chromium.org/3731004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19991
TEST=manual
Review URL: http://codereview.chromium.org/3661003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
is needed because pdf documents might disallow copying/printing and it's confusing to have an enabled menu item which does nothing.
BUG=47364
Review URL: http://codereview.chromium.org/3692007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome.dll and chrome.exe both had incremental linking turned on,
which means they were both trying to use chrome.ilk for the
incremental linking storage, causing incremental linking to always
fail for both. Chrome.exe is small and doesn't benefit much from
incremental linking, so turn it off there and let chrome.dll have the
playground.
BUG=21266
TEST=gyp the projects, load them up, and check incremental linking for the chrome project with a debug target, should be off. Check the chrome_dll target, should be on.
Review URL: http://codereview.chromium.org/3673001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=green
TBR=apavlov
Review URL: http://codereview.chromium.org/3691010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This outputs an HTML report of symbols that the linker claimed
were not used. It includes instructions on how to get the linker
to emit that.
Review URL: http://codereview.chromium.org/3739002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
change to return
true from the AutomationResourceMessageFilter::OnMessageReceived for network request IPCs. ChromeFrame
net tests also have a AutomationResourceMessageFilter instance which is not registered as a
real message filter and is instead invoked from the TestAutomationProvider.
Fix is to remove the dummy AutomationResourceMessageFilter instance and instead register the
filter as a real message filter. To achieve this the automation_resource_message_filter_
member in the AutomationProvider class is now protected.
TBR=tommi
Review URL: http://codereview.chromium.org/3741001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Accoring to the flakiness dashboard, this hasn't failed in a while so it may
have been failing due to some underlying bug in the browser or test harness
that's been fixed.
BUG=57378
TEST=none
TBR=skerner@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ServiceProcessControlBrowserTest.
BUG=None
TEST=browser_tests.
Review URL: http://codereview.chromium.org/3653005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
expiration details.
BUG=52316
TEST=FormStructureTest.HeuristicsInfernoCC
Review URL: http://codereview.chromium.org/3736003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(First reverted in r61175, landed in r61243.)
My valgrind build was broken and didn't report memory leaks :( That's
why I mistakenly reverted the first time. The leak has been correctly
fixed by r62323 now.
BUG=57456
TEST=valgrind net_unittests
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
changing GetCredHandle to return 'int' (the error code).
Add ERR_SSL_CLIENT_AUTH_PRIVATE_KEY_ACCESS_DENIED and
ERR_SSL_CLIENT_AUTH_CERT_NO_PRIVATE_KEY.
R=eroman
BUG=55678
TEST=none
Review URL: http://codereview.chromium.org/3696006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58522
TEST=sync_integration_tests on OS X
Review URL: http://codereview.chromium.org/3671004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Will look at it again tomorrow.
BUG=http://crbug.com/57694
TEST=None
TBR=aa
Review URL: http://codereview.chromium.org/3664009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when the requested byte range looks wrong.
We postpone the decision about what to do with a cached
entry until we receive confirmation from the server, so
we cannot skip asking the server about it!.
This CL also makes it so that if the server returns 304
(so that our cached copy is curent), we don't destroy the
entry, and we return 416 (bad range request) to the caller.
BUG=58047
TEST=net_unittests
Review URL: http://codereview.chromium.org/3722001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also includes freebsd changes from evan and some
msvs changes from erikwright and cbentzel.
Review URL: http://codereview.chromium.org/3692006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=56579
TEST=sync_unit_tests
Review URL: http://codereview.chromium.org/3544012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I had originally disabled this when setting up the upstream
webkit.org build. At the time we didn't compile any of src/gpu,
but now we do, so it's safe to enable this.
If we don't compile this, shared library (.so) builds in a
webkit only tree fail to link because of missing symbols.
Review URL: http://codereview.chromium.org/3722002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
net-internals tab, with links to the corresponding sources on
the events tab.
Includes a minor cleanup or two relating to unneeded/unused code/headers for the rendering of SocketPools.
BUG=58034
TEST=manual
Review URL: http://codereview.chromium.org/3565015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This correctly exits the loop, then destroy menu2 instance
when the browser is closed while the menu is open.
BUG=chromium-os:7642
TEST=CloseWithAppMenuOpen browser test should pass.
Review URL: http://codereview.chromium.org/3643004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=gene
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=53967
TEST=ogv videos still play but more efficiently
Review URL: http://codereview.chromium.org/3723004
TBR=fbarchard@chromium.org
Review URL: http://codereview.chromium.org/3737002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- definition of new access point for Chrome Frame
- new unit test for machine id
TEST=This is the first step of the change for bug 58076.
no user visible changes until the work for this bug is
complete.
BUG=58076
Review URL: http://codereview.chromium.org/3735004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The actual changes are in
http://codereview.chromium.org/3536010/show
R=agl
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3733001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=57456
TEST=valgrind net_unittests
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
template_url_fetcher_unittest
BUG=None
TEST=None
TBR=levin
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53967
TEST=ogv videos still play but more efficiently
Review URL: http://codereview.chromium.org/3723004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=clang builds everything in Release
Review URL: http://codereview.chromium.org/3727003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58269
TEST=ExtensionApiTest.Tabs
Review URL: http://codereview.chromium.org/3686002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
times. This would
occur in the following scenario.
1. Chrome would issue a GET request to download the data.
2. The server would respond with data.
3. Chrome would terminate the request. In this context we send over an IPC to ChromeFrame
requesting that the request be terminated.
4. Before ChromeFrame receives the above IPC it sends over more data packets to Chrome
which would result in the automation resource message filter not finding the request
id in the map. The request would then percolate up to the automation provider which does
not handle these requests and would break the connection.
Fix is to trace the offending request id in the automation resource filter and return true
indicating that we handled the request.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=58049
Bug=58049
Review URL: http://codereview.chromium.org/3683006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
startup time is used as a timestamp to discover new crashes (determined by
entries in crash dir since the recorded startup time) in the ui_test
framework. Initialing it in the constructor is problematic for PyAuto since
python unittest initialzes testcase objects for all tests together, so all
instances will have about the same startup time, and this leads to crashes
from one test being mismatched to the error reporting in another.
This CL fixes it by moving startup time initialization to SetUp, which is
closer to the time the browser actually gets launched.
Consciously, Not moving to LaunchBrowserAndServer.
BUG=51463
TEST=
Review URL: http://codereview.chromium.org/3670004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3732001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Include browser_thread instead of chrome_thread in more 97 files.
Now the remaining files that are including chrome_thread.h are:
chrome_thread.cc and browser_thread.h.
They will be fixed next.
BUG=56926
TEST=trybots
Review URL: http://codereview.chromium.org/3717004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=56385,58882
TEST=Instant should be in labs. After enabling, Instant should work without needing to put --enable-match-preview on the commandline.
Review URL: http://codereview.chromium.org/3689005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62311 0039d316-1c4b-4281-b951-d872f2087c98
|