summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* add a comment to the test file as to why these tests are failingtc@google.com2009-03-051-0/+1
| | | | | | Review URL: http://codereview.chromium.org/40152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10963 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash in chrome.exe caused by the external tab container instance ↵ananta@chromium.org2009-03-052-7/+18
| | | | | | | | | | | | | | getting destroyed without going through the proper window shutdown sequence when the external host crashes. The fix is to ensure that we clean up correctly when the external tab instance goes away. Will add a unit test in a subsequent CB. Bug=1688967 Review URL: http://codereview.chromium.org/39086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10962 0039d316-1c4b-4281-b951-d872f2087c98
* Mark some layout tests as no longer flaky on windows, since they've beenmpcomplete@google.com2009-03-051-7/+3
| | | | | | | | | | | | | | passing consistently for the past 2 weeks. Tests are: LayoutTests/http/tests/navigation/redirect302-subframeload.html LayoutTests/http/tests/navigation/success200-frames-loadsame.html LayoutTests/http/tests/navigation/timerredirect-subframeload.html LayoutTests/http/tests/navigation/success200-subframeload.html LayoutTests/http/tests/navigation/redirect302-frames.html LayoutTests/http/tests/navigation/timerredirect-frames.html LayoutTests/http/tests/navigation/metaredirect-subframeload.html Review URL: http://codereview.chromium.org/39171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10961 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that we display a sad face for a windowed plugin when the plugin ↵ananta@chromium.org2009-03-052-21/+45
| | | | | | | | | | | | | | | process crashes. This was a regression introduced by creating the plugin parent on the browser UI thread, which remains valid when the plugin process crashes. The fix is to track plugin wrapper windows in the PluginProcessHost class and destroy any remaining windows in the destructor. Removed the DestroyWindowTask which destroys the windows on the UI thread. We can achieve the same result by posting WM_CLOSE messages to these windows. This fixes http://code.google.com/p/chromium/issues/detail?id=7673 Bug=7673 Review URL: http://codereview.chromium.org/40120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10960 0039d316-1c4b-4281-b951-d872f2087c98
* Various fixes to mouse wheel scrolling:pkasting@chromium.org2009-03-055-125/+97
| | | | | | | | | | | | | * Now that WebCore uses floating-point scroll deltas, eliminate complicated carryover code and just use simple floating-point arithmetic when calculating scroll delta. * Now that WebCore supports scrolling by page, plumb this instead of using a hacky "10 times the normal scroll amount" constant. * Don't pretend shift was down when it wasn't (e.g. WM_MOUSEHWHEEL). * Use SPI_GETWHEELSCROLLCHARS for horizontal scrolling, per MSDN. * Fix horizontal scrolling to be "scroll down to go right" as the comment said (behavior was backwards) * Clean up code. * Reorder Mac/Linux code to match Windows code ordering. Review URL: http://codereview.chromium.org/40135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10959 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: don't build gtk2drawing.c any more.agl@chromium.org2009-03-051-1/+0
| | | | | | | We don't use GTK for drawing in WebKit any more, so we don't need it. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10958 0039d316-1c4b-4281-b951-d872f2087c98
* Replace a notimplemented with a bug about full screen mode.tc@google.com2009-03-051-2/+4
| | | | | | | Review URL: http://codereview.chromium.org/40142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10956 0039d316-1c4b-4281-b951-d872f2087c98
* Use grit to generate locale rc files and remove the old locale rc files from ↵tc@google.com2009-03-05156-4074/+3493
| | | | | | | | | | | | | | the tree. I made a small change to grit so we can use our resource ID as the translation ID making it a bit easier to read. The old locale_settings*.rc files would #include the google_strings.rc or chromium_strings.rc. Instead, I added it to the vcproj file using $(CHROMIUM_BUILD) to grab the right file. This required changing the output names in the grd files. TBR=deanm Review URL: http://codereview.chromium.org/39152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10955 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a toolbar width TODO.evan@chromium.org2009-03-051-4/+3
| | | | | | Review URL: http://codereview.chromium.org/39168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10954 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Rolls DEPS to pickup Linux rendering fixes.agl@chromium.org2009-03-051-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10952 0039d316-1c4b-4281-b951-d872f2087c98
* Changes spellcheck_unittest to read dictionaries directly from the src tree. ↵shess@chromium.org2009-03-056-75/+20
| | | | | | | | | Removes the build rules to copy test dictionaries to Dictionaries/. Review URL: http://codereview.chromium.org/40082 Patch from rohitrao. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10951 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: don't call gtk_init in the renderer process.agl@chromium.org2009-03-051-8/+5
| | | | | | | | | | | | | Previously, our command line objects were created /after/ gtk_init had processed |argc| and |argv|. With this patch, it's created before hand and main's |argc| and |argv| are now kept pristine. Thus our command line will now reflect GTK arguments that previously it wouldn't have seen. This should be harmless. Review URL: http://codereview.chromium.org/39172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10950 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaselines the testsky@google.com2009-03-054-59/+60
| | | | | | | | | | | | LayoutTests/fast/replaced/width100percent-textarea.html . The old output was wrong because it had our old fonts. BUG=none TEST=none Review URL: http://codereview.chromium.org/40140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10946 0039d316-1c4b-4281-b951-d872f2087c98
* Turns our moving the scroll methods onto RenderTextControlSingleLineojan@google.com2009-03-051-2/+0
| | | | | | | fixed a couple layout tests. Review URL: http://codereview.chromium.org/39153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10945 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression where bookmark manager would show black backgroundsky@google.com2009-03-051-3/+6
| | | | | | | | | | | | when not results are found for a search string. Using your halo methods does the trick. BUG=8367 TEST=see bug Review URL: http://codereview.chromium.org/39165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10944 0039d316-1c4b-4281-b951-d872f2087c98
* Two layout tests are failing consistently on Windows infinnur@chromium.org2009-03-051-0/+2
| | | | | | | | | | debug mode only. Adding them back to tests_fixable in their original spot. Review URL: http://codereview.chromium.org/37009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10943 0039d316-1c4b-4281-b951-d872f2087c98
* Make file_version_info work even without including windows.hbrettw@chromium.org2009-03-051-1/+4
| | | | | | Review URL: http://codereview.chromium.org/39166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10942 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up the browser about URL handler to not derive from WebContents. It isbrettw@chromium.org2009-03-0410-353/+355
| | | | | | | | | | | | | | | | | | | | instead integrated in the BrowserURLHandler for special schemes. This solves a number of problems and cleans things up nicely. Most of the functions were not necessary to have in the header file of the browser about handler, so I made them local to the .cc file. I moved everything around, but there was no change to any of the About...() functions. This improves the about:memory page to not include the memory of the new tab page it replaced. The entry for itself also has the proper title. This works by using a meta refresh to the actual page, the the process transition no longer happens at the same time as the about:memory page computation. This also fixes problems with the about:network and about:ipc dialogs opening blank pages and also re-opening the dialog when you close the browser. Review URL: http://codereview.chromium.org/27238 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10941 0039d316-1c4b-4281-b951-d872f2087c98
* Changed several references from "char" to "uint8" which is the appropriate ↵ralphl@chromium.org2009-03-048-63/+107
| | | | | | | | | | | | | | | | definition for byte data buffers. This change is small, but modifies the data source interface Read() method, and the VideoSurface data structure. Mocks and tests all have very small changes. There are some changes in the mock_media_filters.h file that go beyond the scope of just changing char to uint8. These changes are required for future tests, and simply fill in parts of mocks that previously were NOTIMPLEMENTED(). The MockVideoFrame was modified to allow other tests to create a video frame directly without using the MockFilterConfiguration data structure. Also, it is now possible to construct a mock pipeline that has no audio. The currently checked-in pipeline will NOT work if you don't have audio. In a 2nd changelist, I will submit a new Pipeline_Impl and unit test that DOES support video without audio. Review URL: http://codereview.chromium.org/40059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10940 0039d316-1c4b-4281-b951-d872f2087c98
* Remove abandoned NSS/NSPR import.mmoss@chromium.org2009-03-042788-1074158/+0
| | | | | | | | | We're opting to use pre-built 32-bit libs (from distro packages) rather than building locally to satisfy 64-bit dependencies. Review URL: http://codereview.chromium.org/40064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10939 0039d316-1c4b-4281-b951-d872f2087c98
* Some cleanup of backing_store_win.cccpu@google.com2009-03-042-60/+42
| | | | | | | | | | | | | | | | | | - Fix a small leak (solved by re-selecting the initial bitmap into the dc at dtor time) - Remove one set of GetDC(NULL) + GetDeviceCaps() + ReleaseDC() - Remove some dead code The removal of GetDC(NULL) might speed up Vista drawing a little bit, as is rummored that this operation is expensive when DWM + Aero is enabled. The integer overflow check is no longer possible. I'll file a bug so it is not lost. TEST= existing test suffice Review URL: http://codereview.chromium.org/21516 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10938 0039d316-1c4b-4281-b951-d872f2087c98
* Take two at hooking up title bar on linux.tc@google.com2009-03-042-24/+24
| | | | | | | | | | | | The only change from before is moving a method from a windows #ifdef section to outside it. TBR=evan Review URL: http://codereview.chromium.org/39158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10937 0039d316-1c4b-4281-b951-d872f2087c98
* Minor changes to valgrind test scripts to add running on additional unitnirnimesh@chromium.org2009-03-042-4/+21
| | | | | | | | | | | tests. LGTM-ed here: http://codereview.chromium.org/27306/show (I didn't have my @chromium.org account then) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10936 0039d316-1c4b-4281-b951-d872f2087c98
* Add download items to the download shelf in linux.estade@chromium.org2009-03-046-5/+182
| | | | | | Review URL: http://codereview.chromium.org/40136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10935 0039d316-1c4b-4281-b951-d872f2087c98
* Fix transparency for dragged downloads and links by using the halo textbrettw@chromium.org2009-03-042-62/+9
| | | | | | | routines. This also removes CreateDragImageForLink which is never called. Review URL: http://codereview.chromium.org/39082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10934 0039d316-1c4b-4281-b951-d872f2087c98
* One of the renderer unit tests is flaky so I have disabled it and put a TODO ↵ralphl@chromium.org2009-03-041-1/+3
| | | | | | | | | | to investigate it. Entered bug # 8379 and assigned it to ralphl (me). Actually, the test is not flaky, the renderer is not working right, so the test is right, but there is a bug that it uncovers. Review URL: http://codereview.chromium.org/40074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10933 0039d316-1c4b-4281-b951-d872f2087c98
* Revert to V8 revision 1370 due to performance regressions.darin@chromium.org2009-03-041-1/+1
| | | | | | | | R=nsylvain Review URL: http://codereview.chromium.org/39160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10931 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: rebaselining layout testsagl@chromium.org2009-03-047767-3884/+3884
| | | | | | | | I removed GTK from our WebKit port and this is one of the patches to fix the resulting destruction of the layout tests. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10930 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r9953 since it caused regressions like: ben@chromium.org2009-03-048-56/+26
| | | | | | | | | http://crbug.com/8287 Eyeballing the code in RootView, this change seems wrong. Review URL: http://codereview.chromium.org/40124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10929 0039d316-1c4b-4281-b951-d872f2087c98
* Fix potential crash if the saved options tab is ever out of bounds.ben@chromium.org2009-03-041-1/+4
| | | | | | | | http://crbug.com/8342 Review URL: http://codereview.chromium.org/40090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10928 0039d316-1c4b-4281-b951-d872f2087c98
* Basic download shelf implementation on linux.estade@chromium.org2009-03-049-47/+200
| | | | | | | | | | It shows and hides at appropriate times, and that's about it. TEST=navigate to a savable page and select "save page as" from the page menu. Click the x. Save the page again. The shelf should pop up, go away, pop up again. Review URL: http://codereview.chromium.org/38004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10927 0039d316-1c4b-4281-b951-d872f2087c98
* Expose the iostream (logging) interfaces of some gfx:: classes.evan@chromium.org2009-03-043-17/+3
| | | | | | | | | This is useful when developing anyway, and the compiler ought to be able to eliminate any dead code if we don't use it. Review URL: http://codereview.chromium.org/39089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10926 0039d316-1c4b-4281-b951-d872f2087c98
* Log an error message if the auth scheme is connection-basedwtc@chromium.org2009-03-041-0/+30
| | | | | | | | | | but the connection is not marked as keep-alive. R=eroman BUG=8325 Review URL: http://codereview.chromium.org/40093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10925 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Hook up the app title to the page title."tc@google.com2009-03-042-9/+9
| | | | | | | | | This reverts commit 10923. Review URL: http://codereview.chromium.org/40130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10924 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up the app title to the page title.tc@google.com2009-03-042-9/+9
| | | | | | | Review URL: http://codereview.chromium.org/39114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10923 0039d316-1c4b-4281-b951-d872f2087c98
* fix python2.6 warnings in grittc@google.com2009-03-044-7/+9
| | | | | | | | | | | remove one assert as it's not correct BUG=8298,8299 Review URL: http://codereview.chromium.org/40073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10922 0039d316-1c4b-4281-b951-d872f2087c98
* Move files instead of copying them.kuchhal@chromium.org2009-03-0410-7/+562
| | | | | | | | | BUG=1184319,8218 Review URL: http://codereview.chromium.org/39048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10921 0039d316-1c4b-4281-b951-d872f2087c98
* Branding of Chrome.app.jrg@chromium.org2009-03-043-6/+45
| | | | | | | | | To brand, do a "src/tools/gyp/gyp_dogfood -Dbranding=Chrome src/build/all.gyp" (Then build, of course.) Review URL: http://codereview.chromium.org/40066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10920 0039d316-1c4b-4281-b951-d872f2087c98
* Missing util filesavi@chromium.org2009-03-042-0/+138
| | | | | | Review URL: http://codereview.chromium.org/39156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10919 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing WebKeyboardEvent.avi@chromium.org2009-03-0421-334/+280
| | | | | | Review URL: http://codereview.chromium.org/39075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10918 0039d316-1c4b-4281-b951-d872f2087c98
* Make UITest::CrashAwareSleep portable.phajdan.jr@chromium.org2009-03-044-5/+30
| | | | | | Review URL: http://codereview.chromium.org/40119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10916 0039d316-1c4b-4281-b951-d872f2087c98
* Add trivial theming support in extensions.erikkay@google.com2009-03-045-13/+103
| | | | | | | NOTE: This is not final API. It *will* change. It's purely for testing purposes. Review URL: http://codereview.chromium.org/40042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10913 0039d316-1c4b-4281-b951-d872f2087c98
* Fix stupid mistake of forgetting negation in if condition.kuchhal@chromium.org2009-03-041-1/+1
| | | | | | | | | BUG=8371 Review URL: http://codereview.chromium.org/39149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10912 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome side of WebKit merge 41402:41420brettw@chromium.org2009-03-043-3/+3
| | | | | | Review URL: http://codereview.chromium.org/39139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10911 0039d316-1c4b-4281-b951-d872f2087c98
* Rebase button tests whose output is now correct.ojan@google.com2009-03-045-53/+51
| | | | | | Review URL: http://codereview.chromium.org/40121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10910 0039d316-1c4b-4281-b951-d872f2087c98
* Roll deps to pull in webkit with textarea fixes. TBR.ojan@google.com2009-03-041-1/+1
| | | | | | Review URL: http://codereview.chromium.org/39146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10909 0039d316-1c4b-4281-b951-d872f2087c98
* Two fast/form Layout tests.finnur@chromium.org2009-03-047-126/+129
| | | | | | | | | | | | | | | | | | | | | | Looking through the history for these two tests (both locally and upstream) it seems these two tests stayed the same upstream but started failing locally and got rebaselined. Now, they've failed again in such a way that they've gone back to the way they were before the rebaseline. I asked Ojan and he thinks we weren't sure why they changed locally, which makes me want to rebaseline again to get to back to where we were. Especially since the buttons in button-default-title look more natural this way (the label doesn't looks one pixel too high). Review URL: http://codereview.chromium.org/39083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10908 0039d316-1c4b-4281-b951-d872f2087c98
* Fix another regression. Coordinate calculation in the ↵ben@chromium.org2009-03-041-1/+5
| | | | | | | | | | OpaqueBrowserFrameView::HitTest method was wrong. http://crbug.com/8365 Review URL: http://codereview.chromium.org/37008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10907 0039d316-1c4b-4281-b951-d872f2087c98
* add the webkit resources/strings to the combined pak files for mac/linux.thomasvl@chromium.org2009-03-041-0/+2
| | | | | | Review URL: http://codereview.chromium.org/39145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10904 0039d316-1c4b-4281-b951-d872f2087c98
* Register SSLManager preferences on linux and mac.evan@chromium.org2009-03-041-3/+3
| | | | | | | | | This should fix the following error: FATAL:common/pref_service.cc(314)] Check failed: false. Trying to read an unregistered pref: security.mixed_content_filtering Review URL: http://codereview.chromium.org/39006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10903 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 15:48:51 +0000