| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- reduce the number of different classes
- clean up the internal code
- modify the interface to expose less internal details
(this will allow more flexibility with port numbers)
TEST=many
BUG=49680
Review URL: http://codereview.chromium.org/3080029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of filtering over all certificates and then picking the ones suitable
for client auth, NSS provides a function that does this in one go. In addition,
delay checking for the private key until we actually send the certificate.
While this means we may potentially offer a client certificate with no matching
private key, such a store should not exist. This avoids requiring us
authenticate to every certificate offered. In addition, it delays the password
dialog, when we implement it, until after the user has designated that they are
interested in a certificate.
This mirrors Firefox's use of NSS.
R=wtc
BUG=none
TEST=linux ssl client auth works
Review URL: http://codereview.chromium.org/3177018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The constructor of syncable::ScopedDirLookup takes the username of the
account being synced. There are times when the username is blank,
resulting in a DCHECK being fired for the value of good() within the method
SyncManager::SyncInternal::InitialSyncEndedForAllEnabledTypes().
This patch makes sure that a ScopedDirLookup with a blank username is
never created by adding a check in the method
SyncManager::SyncInternal::HandleDirectoryManagerEvent().
BUG=51820
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/3184009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Two threads are currently allowed to attempt
to define the same histogram at the same time.
A factory class sorts out which one was first,
and ensures that only the winner remains
registered. An old DCHECK used to assert
that only one caller (constructor) could
register a given histogram. This CL
removes that DCHECK, and leaves the
first to register as the winner.
BUG=52394
r=eroman
Review URL: http://codereview.chromium.org/3107018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46374
TEST=opengl demos work on Pepper2
Review URL: http://codereview.chromium.org/3020049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=manual
BUG=none
Review URL: http://codereview.chromium.org/3131018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
.cc file.
Cleanup in base. This moves the implementation (and a bunch of header file
dependencies) from the multiprocess test and the test_suite headers to .cc
files. Moves multiprocess_test to the test directory, and all of this stuff to
the existing base_test_support project. I also used the base namespace.
Previously other projects included this functionality just by #include because
it was all inline, so I had to add dependencies on base_test_support in a few
places.
Moves and renames the command line switch this was using to base_switches. Move
the base switch for process type to chrome switches.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3026055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
request is [application/xhtml+xml, image/svg, image/svg+xml, video/ogg, video/webm,video/mp4] or text/html
BUG=51982
Review URL: http://codereview.chromium.org/3107019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use ScopedTempDir, and don't CHECK in tests.
BUG=none
TEST=waterfall.
Review URL: http://codereview.chromium.org/3127007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=28294
Review URL: http://codereview.chromium.org/3145014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on failure within
Chromium. It is a network level implementation and should constitute a good
enough bottleneck to manage every outgoing http request.
Committing for malavv@google.com.
Original review: http://codereview.chromium.org/2487001/show
R=phajdan-jr
BUG=none
TEST=unit tests
Review URL: http://codereview.chromium.org/3005049
TBR=joi@chromium.org
Review URL: http://codereview.chromium.org/3165029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR: satish@chromium.org
BUG=none
TEST=check perms builder goes green
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
That patch wasn't what caused the regression in the page cycler.
BUG=51411,52103
TEST=still compiles
Review URL: http://codereview.chromium.org/3106018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50699
TEST=First three (or two in Vietnam and Iran) search engine logos always available on import in --organic Chrome (not Chromium).
Review URL: http://codereview.chromium.org/3189004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For each resolution request this checks to see if this 'host' is a literal ip address. If so, it synthesises a struct addrinfo and returns it without adding it to the cache.
BUG=39830
TEST=unit tests, new and old
Review URL: http://codereview.chromium.org/3023048
TBR=vandebo@chromium.org
Review URL: http://codereview.chromium.org/3115014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
For each resolution request this checks to see if this 'host' is a literal ip address. If so, it synthesises a struct addrinfo and returns it without adding it to the cache.
BUG=39830
TEST=unit tests, new and old
Review URL: http://codereview.chromium.org/3023048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
follow up to http://codereview.chromium.org/3170023/show
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3193003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
not look broken.
TBR=ben
BUG=none
TEST=Run in Aero with --lang=he, hit ctrl-shift-n, Incognito image should not be broken in two
Review URL: http://codereview.chromium.org/3117016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TabStrip::SetBackgroundOffset() into a single call in a different place.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3107012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium. It is a network level implementation and should constitute a good
enough bottleneck to manage every outgoing http request.
Committing for malavv@google.com.
Original review: http://codereview.chromium.org/2487001/show
BUG=none
TEST=unit tests
Review URL: http://codereview.chromium.org/3005049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
a bug in tabapplescript. Added more examples.
patch from (v.a.shreyas@gmail.com)
BUG=none
TEST=run tests included in CL.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Thumbnails file is renamed to Favicons.
The new "Top Sites" DB file is added.
TEST=about:histograms
BUG=none
Review URL: http://codereview.chromium.org/3113002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
selecting/focusing elements. Change context menu tests to use this approach.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3115002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Follow up to http://src.chromium.org/viewvc/chrome?view=rev&revision=56299
BUG=22109,16096
Review URL: http://codereview.chromium.org/3170023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
list.
I have also set the svn:ignore property for the 'speex' subdir under third_party directory, though I guess it can't be seen in the review.
BUG=none
TEST=none yet
Review URL: http://codereview.chromium.org/3143022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(http://code.google.com/p/chromium-os/issues/detail?id=4448)
Moved PopupNonClientFrameView to its own file and moved FrameView initialization logic to BrowserFrameChromeos::Init.
TEST=See issue. Additionally, ensure that non-chromeos Chrome popup window behavior is unaffected, and that the address bar is still visible for popup windows not generated by apps (e.g popped out google chat windows), on chromeos and non-chromeos.
Review URL: http://codereview.chromium.org/3133001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Apply 10% white to selected menu button;
- Remove the menu offset so that the menu is top aligned with toolbar;
- Make all status area buttons derive from StatusAreaButton;
- Move ClockMenuButton's text size logic into StatusAreaButton to share the
logic with LanguageMenuButton;
- Strip unused space from LanguageMenuButton so that it looks good with 10%
white highlight;
- Make LanguageMenuButton and ClockMenuButton center aligned;
- Add 1-pixel padding at top when the vertical space is odd number so that text
looks properly aligned with the icons;
BUG=chromium-os:5517
TEST=Verify fix for chromium-os:5517.
Review URL: http://codereview.chromium.org/3141019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
translate" infobar when in Incognito mode.
BUG=52305
TEST=See bug.
Review URL: http://codereview.chromium.org/3164016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3109025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This happens mainly in chrome frame where password manager
or the web data service could be invalid due to failed sqllite
initialization. The failure is due to chrome.exe running in low
integrity mode while deleting browser history. This a temporary
fix to avoid crash the right fix is to run chrome.exe at medium
integrity and that involves some investigation.
Now why chrome.exe runs in the low integrity mode is a long
story. Chrome Frame implements IDeleteBrowsingHistory to
participate in history/user data deletion. IE8 tries to be
smart and invokes IDeleteBrowsingHistory methods in by
launching a separate process, rundll32.exe. However, when
npchrome_frame.dll's implementation is invoked the container
rundll32.exe is in low integrity. IE's elevation policy does
not work for us to elevate chrome_launcher.exe to medium in
this case (since this is not IE). so we end up launching
chrome.exe in low integrity.
BUG=51949
TEST=load gcf:about:version in Chrome Frame with IE8 on Win7
and delete browsing history.
Review URL: http://codereview.chromium.org/3133019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The itteration is performed in the browser process
when the list of field-trial settings is passed to
the renderer. I failed to acquire the lock prior
to the itteration, and it appears that some code
is deciding on a field trial VERY late in browser
startup and racing against this render-spawn
operation. The code in FieldTrial is wrong
(but fixed here), but I'll still need to
track down the racing thread that is performing
such a late FieldTrial definition (the results
of which will not be passed to some renderers).
BUG=49409
R=huanr
Review URL: http://codereview.chromium.org/3134015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
some logics are moved into system memory path only. ( such as allocation of output buffer, and usage of FTBDoneACK messages.
Review URL: http://codereview.chromium.org/3141014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
reduce the amount of false positive crash reports - when exception is swallowed
and is almost always not a problem due ChromeFrame code.
BUG=51830
TBR=amit@chromium.org
Review URL: http://codereview.chromium.org/3148015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Part of http://codereview.chromium.org/3191002 missed during checkin.
BUG=49091
TEST=None
Review URL: http://codereview.chromium.org/3149018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48100
TEST=net_unittests
Review URL: http://codereview.chromium.org/3048058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
on NDEBUG builds too.
TBR: zelidrag
BUG=48920
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Spotted in previous review.
BUG=23581
Review URL: http://codereview.chromium.org/3152019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=51449
TEST=JsonSchemaTest.TestNumber
Review URL: http://codereview.chromium.org/3158015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Unit tests in file_watcher_unittest.cc.
Review URL: http://codereview.chromium.org/3149004
TBR=mnissler@chromium.org
Review URL: http://codereview.chromium.org/3165027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
as navigation state.
Review URL: http://codereview.chromium.org/3110018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
layout tests
BUG=45080,46299
Review URL: http://codereview.chromium.org/3116015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49091
TEST=Open DOMUI prefs, and click the "Manage..." button for search engines. Search engines should be listed, the default should be changeable, and entries should be removable.
Review URL: http://codereview.chromium.org/3191002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This has reappeared on TSan UI FYI bot between r56211 and r56252
http://build.chromium.org/buildbot/waterfall.fyi/builders/Linux%20Tests%20(tsan%20ui)/builds/1796
Sample "getenv" callstack:
Concurrent read(s) happened at (OR AFTER) these points:
T0 (WR-L{L144}/RD-L{L1, L36, L144}):
#0 getenv /lib/tls/i686/cmov/libc-2.7.so
#1 __dcigettext /lib/tls/i686/cmov/libc-2.7.so
#2 dcgettext /lib/tls/i686/cmov/libc-2.7.so
#3 gdk_pango_renderer_class_intern_init /build/buildd/gtk+2.0-2.12.9/gdk/gdkpango.c:487
#4 g_type_class_ref /build/buildd/glib2.0-2.16.6/gobject/gtype.c:1880
#5 g_type_class_ref /build/buildd/glib2.0-2.16.6/gobject/gtype.c:2400
#6 g_object_new_valist /build/buildd/glib2.0-2.16.6/gobject/gobject.c:988
#7 g_object_new /build/buildd/glib2.0-2.16.6/gobject/gobject.c:795
#8 gtk_text_layout_draw /build/buildd/gtk+2.0-2.12.9/gtk/gtktextdisplay.c:731
#9 gtk_text_view_expose_event /build/buildd/gtk+2.0-2.12.9/gtk/gtktextview.c:4462
TBR=glider
TEST=TSan/UI should become greener
BUG=41314
Review URL: http://codereview.chromium.org/3191005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
(Everything goes to hell when the try servers don't work.)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
content_setting_bubble_contents.[cc/h]
(Note: that was a TODO for bulach).
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3177016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change moves the Response class to the top level to save other
files from having to #include the header in order to get a pointer to
a Response object.
This change also modifies the semantics of resolution: the callback
will now be made of the origin MessageLoop, rather than a random
thread.
TEST=net_unittests
BUG=none
http://codereview.chromium.org/3110015/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Unit tests in file_watcher_unittest.cc.
Review URL: http://codereview.chromium.org/3149004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and margin.
BUG=51124
TEST=none
Review URL: http://codereview.chromium.org/3184008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crosbug.com/5376
TEST=Manual
Review URL: http://codereview.chromium.org/3114011/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=51729
TEST=see bug
Review URL: http://codereview.chromium.org/3145016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56338 0039d316-1c4b-4281-b951-d872f2087c98
|