summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* net: Remove typedef net::URLRequestJob URLRequestJob;tfarina@chromium.org2010-12-1176-220/+231
| | | | | | | | | BUG=64263 TEST=compiled locally, trybots Review URL: http://codereview.chromium.org/5607004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68935 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux] Fix base_unittests for GCC 4.5.1phajdan.jr@chromium.org2010-12-111-1/+1
| | | | | | | | | | | | | This is upstreaming a Gentoo Linux patch. I have encountered this tiny compile issue when using a more recent GCC. TEST=none BUG=none Review URL: http://codereview.chromium.org/5791001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68933 0039d316-1c4b-4281-b951-d872f2087c98
* Make members of Singleton<T> private and only visible to the singleton type. ↵satish@chromium.org2010-12-1156-335/+493
| | | | | | | | | | | | | | | This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness. As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file. There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5682008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68932 0039d316-1c4b-4281-b951-d872f2087c98
* Silence another failurepkasting@chromium.org2010-12-111-1/+2
| | | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68931 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid inserting a redundant separator in status icon menu.tfarina@chromium.org2010-12-111-1/+2
| | | | | | | | | | | | When there is no application installed on chrome we are showing two separators instead of one in the menu. BUG=65648 TEST=see bug Review URL: http://codereview.chromium.org/5513008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68928 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily silence a failurepkasting@chromium.org2010-12-111-0/+1
| | | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68926 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Temporarily strip trailing colons from section titles until the stringsjhawkins@chromium.org2010-12-116-17/+83
| | | | | | | | | | | can be changed. BUG=62875 TEST=none Review URL: http://codereview.chromium.org/5799001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68923 0039d316-1c4b-4281-b951-d872f2087c98
* Update WebKit to r73822.pkasting@chromium.org2010-12-111-1/+1
| | | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68922 0039d316-1c4b-4281-b951-d872f2087c98
* Enable popup blocker tests.nirnimesh@chromium.org2010-12-111-1/+1
| | | | | | | | | | Seems to have cured itself. BUG=59208 Review URL: http://codereview.chromium.org/5713003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68921 0039d316-1c4b-4281-b951-d872f2087c98
* Fix flaky BrowserKeyEventsTest.ReservedAccelerators on Windows (hopefully)suzhe@chromium.org2010-12-111-28/+22
| | | | | | | | | | | According to the log, the flakiness may be caused by http://crbug.com/65375. But I can't reproduce it manually on my local Windows 7 workstation. This CL just uses the same test flow as Mac port to try to avoid flakiness. The FLAKY label is not removed in case the test will still be flaky. BUG=65847 TEST=The test should not flaky on Windows. Review URL: http://codereview.chromium.org/5746002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68920 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the 'restart required' alert when enabling the metrics reporting ↵csilv@chromium.org2010-12-115-48/+6
| | | | | | | | | | option, the alert is obsolete. BUG=none TEST=Green tree and no 'restart required' alerts when enabling metrics in Chrome builds. Review URL: http://codereview.chromium.org/4778002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68919 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Remove the sync settings overlay.jhawkins@chromium.org2010-12-1114-223/+213
| | | | | | | | | | | | | * Move the sync settings into the Personal Stuff page. * Fix disabling input elements from JS. * Fix handling of boolean prefs in select controls. BUG=59279 TEST=none Review URL: http://codereview.chromium.org/5779001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68918 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68893 - Consider PlatformThread::Join() to be blocking IO.csilv@chromium.org2010-12-115-25/+0
| | | | | | | | | | | | | | | | | Marks PlatformThread::Join() as blocking IO using ThreadRestrictions. Whitelists existing spots where we join on the UI/IO threads. Also noteworthy is I allow blocking IO on shutdown. BUG=65530,66077,66082 TEST=none Review URL: http://codereview.chromium.org/5693003 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/5743005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68915 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Move the 'Get themes' link below the 'Reset' button.jhawkins@chromium.org2010-12-111-3/+5
| | | | | | | | | BUG=63830 TEST=none Review URL: http://codereview.chromium.org/5721003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68912 0039d316-1c4b-4281-b951-d872f2087c98
* views: Include base/win/scope_comptr.h instead of base/scoped_comptr_win.htfarina@chromium.org2010-12-106-15/+15
| | | | | | | | | | | Also add base::win:: to ScopedComPtr where necessary. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/5625006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68910 0039d316-1c4b-4281-b951-d872f2087c98
* Adding pyauto tests to passwords.pynirnimesh@chromium.org2010-12-102-22/+87
| | | | | | | | | | | | | | | | | | | Added tests 1. testRemovePasswords 2. testFetchAnotherUser 3. testNeverSavePasswords Added a method for constructing password dictionary Modified testSavePassword in passwords.py MOdified GoogleAccountsLogin and VerifyGoogleAccountCredsFilled in test_utils.py to take window index and tab index BUG=none TEST=none Review URL: http://codereview.chromium.org/5379007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68909 0039d316-1c4b-4281-b951-d872f2087c98
* A small wstring -> string16 cleanup in PlatformFont.tony@chromium.org2010-12-108-15/+14
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/5794001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68908 0039d316-1c4b-4281-b951-d872f2087c98
* Include auxiliary profiles when crowdsourcing autofill data.isherman@chromium.org2010-12-101-3/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5784001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68906 0039d316-1c4b-4281-b951-d872f2087c98
* Pull in a named constant from WebKitisherman@chromium.org2010-12-102-196/+200
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5770002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68905 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the bug in Linux in the case of moving the window.isherman@chromium.org2010-12-101-0/+4
| | | | | | | | | BUG=25232 TEST=1, Input text to show popup with autofill. 2. Once autofill pops up drag the browser with mouse. 4, Confirm the popup window is closes. Review URL: http://codereview.chromium.org/5544011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68904 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68899 - Disk cache: Remove the request throttling experiment.rvargas@google.com2010-12-101-1/+10
| | | | | | | | | | | | | | This is intended for the beta/stable branch. BUG=none TEST=none Review URL: http://codereview.chromium.org/5628006 TBR=rvargas@google.com Review URL: http://codereview.chromium.org/5700005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68900 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Remove the request throttling experiment.rvargas@google.com2010-12-101-10/+1
| | | | | | | | | | | This is intended for the beta/stable branch. BUG=none TEST=none Review URL: http://codereview.chromium.org/5628006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68899 0039d316-1c4b-4281-b951-d872f2087c98
* Changed the partial url search term to avoid the crash on windowsnirnimesh@chromium.org2010-12-102-4/+1
| | | | | | | | BUG=66448 Review URL: http://codereview.chromium.org/5697004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68898 0039d316-1c4b-4281-b951-d872f2087c98
* Hard code number of auto generated command buffer unitgman@chromium.org2010-12-101-3/+3
| | | | | | | | | | | | | | | | | | tests per file so that tests do not move from file to file. The problem is gles2_cmd_decoder_n_unittest_autogen.h is dependent on gles2_cmd_decoder_n_unittest.cc So if a test moves to another generated file then the things it depends on do not move withit. TEST=none BUG=65400 Review URL: http://codereview.chromium.org/5686003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68897 0039d316-1c4b-4281-b951-d872f2087c98
* Verify enabeling and disable javascript prefs worksnirnimesh@chromium.org2010-12-102-0/+26
| | | | | | | | | | ( Note: Data file related to the same test is submitted in a different CL) Verify prefs to enabled/disables omnibox suggestions Review URL: http://codereview.chromium.org/5556010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68896 0039d316-1c4b-4281-b951-d872f2087c98
* Release notes for M9.kathyw@chromium.org2010-12-106-41/+115
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/5748001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68895 0039d316-1c4b-4281-b951-d872f2087c98
* Consider PlatformThread::Join() to be blocking IO.willchan@chromium.org2010-12-105-0/+25
| | | | | | | | | | | | | | Marks PlatformThread::Join() as blocking IO using ThreadRestrictions. Whitelists existing spots where we join on the UI/IO threads. Also noteworthy is I allow blocking IO on shutdown. BUG=65530,66077,66082 TEST=none Review URL: http://codereview.chromium.org/5693003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68893 0039d316-1c4b-4281-b951-d872f2087c98
* Load external extensions even when --disable-extensions is used. We do this ↵jstritar@chromium.org2010-12-103-13/+71
| | | | | | | | | | | since different environments may require users to have certain external policy extensions installed. This patch also fixes a crash when --disable-extensions is used with external extensions installed. BUG=66070 TEST=ExtensionsServiceTest.ExternalUninstall Review URL: http://codereview.chromium.org/5695004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68892 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Fixed sync crash regression in ServerNotifierThreadakalin@chromium.org2010-12-107-13/+159
| | | | | | | | | | | | | Added unit tests for ServerNotifierThread. Put DISABLE_RUNNABLE_METHOD_REFCOUNT() call for MediatorThreadImpl in the right place. BUG=57898 TEST=New unittests Review URL: http://codereview.chromium.org/5722002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68891 0039d316-1c4b-4281-b951-d872f2087c98
* Nuke the about:flag for Mac Instant now that there is a real pref.maf@chromium.org2010-12-101-7/+0
| | | | | | | | Fixes bug where Instant is on even when checkbox in prefs is cleared. BUG=66089 Review URL: http://codereview.chromium.org/5745004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68890 0039d316-1c4b-4281-b951-d872f2087c98
* Verify Translate Info bar should not stay on the page after opting "Never ↵nirnimesh@chromium.org2010-12-101-0/+7
| | | | | | | | | | translate the page" TEST=47250 Review URL: http://codereview.chromium.org/5557005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68889 0039d316-1c4b-4281-b951-d872f2087c98
* emacs: use UTF-8 and DOS encoding when reading filesevan@chromium.org2010-12-102-8/+18
| | | | | | | | | | | | | This fixes: - Linux output has UTF-8 quotes in it. - Mac/Windows have DOS-style CRLF (and reading Linux with that coding system is ok). TEST=new trybot-test-linux Review URL: http://codereview.chromium.org/5778003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68888 0039d316-1c4b-4281-b951-d872f2087c98
* Commit the data file I missed in r68886nirnimesh@chromium.org2010-12-101-0/+15
| | | | | | TBR= git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68887 0039d316-1c4b-4281-b951-d872f2087c98
* Two Testcases on verifying the content of pages.nirnimesh@chromium.org2010-12-101-0/+23
| | | | | | | | | | | | | | | | TEST=None Bug=None 1. Verify content on https page - https://www.google.com. Verify in regular, incognito window 2. Verify that chrome works with some top websites. Browse a list of urls, each time verify some key strings. This test will verify that chrome is not getting blocked by user-agent test by those websites. Review URL: http://codereview.chromium.org/5726001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68886 0039d316-1c4b-4281-b951-d872f2087c98
* Marking ExtensionApiTest, Infobars as DISABLED on everything but Windows.gman@chromium.org2010-12-101-1/+1
| | | | | | | | | TEST=none BUG=66461 TBR=asargent@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68885 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove needed #includes for profile.h.thestig@chromium.org2010-12-1027-35/+11
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5682007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68884 0039d316-1c4b-4281-b951-d872f2087c98
* C++ readability change for kmadhusu.kmadhusu@chromium.org2010-12-102-88/+88
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5054003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68883 0039d316-1c4b-4281-b951-d872f2087c98
* Disable omnibox.OmniboxTest.testBookmarkResultInNewTabAndWindow on winnirnimesh@chromium.org2010-12-101-0/+2
| | | | | | | | BUG=66448 Review URL: http://codereview.chromium.org/5725004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68882 0039d316-1c4b-4281-b951-d872f2087c98
* Rolled cacheinvalidation to @67.akalin@chromium.org2010-12-102-1/+2
| | | | | | | | | | | This includes a crash fix (see bugs). BUG=65945,chromium-os:5014 TEST=Manual Review URL: http://codereview.chromium.org/5782001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68881 0039d316-1c4b-4281-b951-d872f2087c98
* Mark NamedInterfaceTest.BasicNamedInterface as flaky.csilv@chromium.org2010-12-101-1/+8
| | | | | | | | BUG=66414 TEST=none Review URL: http://codereview.chromium.org/5728003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68880 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Show onscreen bubble when brightness changes.derat@chromium.org2010-12-1015-2/+275
| | | | | | | | | | | | | | | | | | | | This adds a BrightnessLibrary class that registers to receive notification of brightness changes from the libcros code that I added in http://codereview.chromium.org/5640003/, a BrightnessBubble class to control an onscreen indicator of the current brightness level, and a BrightnessObserver class that wires up the two. This change depends on http://codereview.chromium.org/5603012/, which pulls the updated version of libcros into Chrome. BUG=chromium-os:8473,chromium-os:4816 TEST=built and tried it Review URL: http://codereview.chromium.org/5620004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68879 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leaks in RtpVideoReaderTest.sergeyu@chromium.org2010-12-103-20/+4
| | | | | | | | | BUG=65988 TEST=unittests under heapcheck Review URL: http://codereview.chromium.org/5777001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68878 0039d316-1c4b-4281-b951-d872f2087c98
* Create a new container to own downloads in DownloadManager.rdsmith@google.com2010-12-103-122/+109
| | | | | | | | | | | | | Shifts destructor to use new container, and removes no longer needed containers. Part of the downloads refactor effort. dangerous_finished_ was only used for finding downloads that needed to be removed on disk, which can be determined more cleanly from the DownloadItem state. This does mean two passes through downloads_ (one to find the downloads that require special handling, and one to delete everything) but a) it's worth it for code clarity, and b) when we cleanup the semantics of DownloadItem::Remove, we can drop it to a single pass. BUG=63493 TEST=All known not-always failing download tests pass. Review URL: http://codereview.chromium.org/5636003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68877 0039d316-1c4b-4281-b951-d872f2087c98
* Update WebKit to r73742.pkasting@chromium.org2010-12-101-1/+1
| | | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68876 0039d316-1c4b-4281-b951-d872f2087c98
* wstrings: make l10n_util::TruncateString use string16evan@chromium.org2010-12-109-40/+38
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/5742006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68875 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in PrerenderInterceptorTestcbentzel@chromium.org2010-12-102-14/+10
| | | | | | | | BUG=65993 TEST=unit_tests --gtest_filter="*Prerender*" Review URL: http://codereview.chromium.org/5693001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68874 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up third_party/libpng/pngusr.h and update it for libpng-1.2.44.thakis@chromium.org2010-12-101-332/+381
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Defined PNG_NO_READ_SWAP, PNG_NO_WRITE_SWAP, PNG_NO_READ_oFFs, PNG_NO_WRITE_oFFs, PNG_NO_USER_LIMITS, PNG_NO_SET_USER_LIMITS, PNG_NO_TIME_RFC1123. Clarified that PNG_NO_INFO_IMAGE, PNG_NO_PROGRESSIVE_READ are undefined. Used PNG_NO_SEQUENTIAL_READ instead of PNG_NO_SEQUENTIAL_READ_SUPPORTED. Defined PNG_NO_WRITE_gAMA, PNG_NO_WRITE_sRGB. Clarified that PNG_NO_READ_gAMA and PNG_NO_READ_sRGB are undefined (i.e. gAMA and sRGB are retrieved by libpng, along with iCCP). Fixed typo in the mangling of png_set_text_2. Renamed the prefix webkit_ to wk_ in mangled names. Restored the full function name in mangling; e.g., png_create_read_struct is mangled as wk_png_create_read_struct instead of wk_png_cr_read_str. Added mangling for all symbols with external linkage that are never macros. Added explicit #undef for symbols that may sometimes be macros in png.h: png_benign_error, png_chunk_benign_error, png_get_int_32, png_get_uint_16, png_get_uint_32, png_info_init, png_read_init, png_write_init. BUG=none TEST=none Review URL: http://codereview.chromium.org/5689001 Patch from Cosmin Truta <ctruta@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68873 0039d316-1c4b-4281-b951-d872f2087c98
* Fix sync in Chromium-os by not allowing CanShowPromo to initialize the sync ↵mirandac@chromium.org2010-12-101-3/+7
| | | | | | | | | | | system. BUG=http://code.google.com/p/chromium-os/issues/detail?id=10031 TEST=cros sync works Review URL: http://codereview.chromium.org/5685004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68872 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make profile-locking error the same as failing to lock.shess@chromium.org2010-12-101-8/+4
| | | | | | | | | | | | | Previously, the profile-locking code was conservative in the face of errors. Histograms indicate that the error rate is acceptable (no errors seen), so flip locking errors to me failure-to-lock. BUG=58986 TEST=none Review URL: http://codereview.chromium.org/5717002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68871 0039d316-1c4b-4281-b951-d872f2087c98
* Make BrowserMessageFilter support dispatching messages on different threads.jam@chromium.org2010-12-1010-106/+173
| | | | | | Review URL: http://codereview.chromium.org/5541005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68870 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-18 00:12:14 +0000