| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
initialized in the constructor.
Also, when a manual callback was executed, if a regular fluch happened to come
in the intervening time, we would cause an assertion failure because it would
always try to paint. Now when we get the callback, we can ignore it if there is
already a flush pending.
Original review=http://codereview.chromium.org/4886004/
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
that it can be reused for this code.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
non-joinable threads.
Fix all known instances or explicitly allow them. Usually the fix involves switching from Default traits to Lazy traits.
BUG=61753
TEST=none
Review URL: http://codereview.chromium.org/4635012
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/4980001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/4976001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
When porting this test to NaCl, I discovered that it didn't build! This patch
makes it build and adds it to our test suite.
Review URL: http://codereview.chromium.org/4966001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I hit this DCHECK and didn't know if it was telling me that initialization
failed or that initialization had already happened.
TEST=compiles
Review URL: http://codereview.chromium.org/4882005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This regressed in r59021. I think I can fix it in a cleaner way
with some refactoring, but for now since I want to cherry-pick this
onto older branches let's revert some of r59021 to fix this in
the simplest way possible.
BUG=59824
TEST=manual (will write a test in my followup that refactors it)
Review URL: http://codereview.chromium.org/4911002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Fix our heuristics to not be terribly wrong, while discouraging their use. If the theme author doesn't specify colors in the form of ChromeGtkFrame::frame-color, use the old MetaFrames/selection color fallback (tinting slightly darker).
2) Give the ChromeGtkFrame several optional widget style properties allowing theme authors to explicitly specify colors for the frame and scrollbars, and control the gradient on top of the chrome frame.
TODO: Do we want to let theme authors override the close/min/max button images?
BUG=62377, 35317
TEST=for now, compiles, as the needed data hasn't been added by theme authors.
Review URL: http://codereview.chromium.org/4715005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glider
Review URL: http://codereview.chromium.org/4970001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Welcome screen uses different style of buttons.
BUG=chromium-os:8468
TEST=none
Review URL: http://codereview.chromium.org/4402001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implemented left margin. Also implemented fade out in the end of the
label.
BUG=chromeos:7896
TEST=Compare with the mocks from the issue.
Review URL: http://codereview.chromium.org/4708010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Employ BubbleWindow with throbber for proxy settings dialog.
BUG=http://crosbug.com/7322
TEST=Manual
Review URL: http://codereview.chromium.org/4841005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use 'Sing in' label instead of the long one.
BUG=chromium-os:9084
TEST=manual
Review URL: http://codereview.chromium.org/4817002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
demonstating the feature.
Also fixed some lint issues.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/4855004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=62341
TEST=None
Review URL: http://codereview.chromium.org/4898001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=32-bit official linux build goes green.
TBR=abarth
Review URL: http://codereview.chromium.org/4965001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=63045
TEST=none
TBR=darin
Review URL: http://codereview.chromium.org/4964001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=62943
TEST=Heapchecker goes green?
TBR=noelutz
Review URL: http://codereview.chromium.org/4963001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46161
TEST=none
TBR=timurrrr
Review URL: http://codereview.chromium.org/4962001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
mocks.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4943001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61347
TEST=http://upload.wikimedia.org/wikipedia/commons/7/79/Big_Buck_Bunny_small.ogv
Review URL: http://codereview.chromium.org/4957001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to properly
redirect to partner payment portal when we run out of plan. Changed usage notification
to display "More info..." instead of "Buy plan".
BUG=chromium-os:8745, chromium-os:8724, chromium-os:8853, chromium-os:8685
TEST=see listed bugs for details
Review URL: http://codereview.chromium.org/4699004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=darin
Review URL: http://codereview.chromium.org/4951001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=darin
Review URL: http://codereview.chromium.org/4949002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise they hit a base::ThreadRestrictions::AssertIOAllowed() assertion.
Introduced MimeRegistryDispatcherHost for code sharing among renderer_host and worker_host.
BUG=62601
TEST=none
Review URL: http://codereview.chromium.org/4857001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=57053
TEST=None.
TBR=nrettw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60632
TEST=trybots
Review URL: http://codereview.chromium.org/4893001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Need to fix RequestPause/RequestResume before turning this back on, else we
run into data races checking the model type information.
BUG=62880
TEST=none
TBR=tim
Review URL: http://codereview.chromium.org/4810003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Forgot to add an enum
TEST=another opengl es 2.0 conformance test passes
BUG=none
Review URL: http://codereview.chromium.org/4867001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the screen locker window to its own window group,
preventing GTK widgets from other windows from grabbing the
focus from it. (Otherwise, we intentionally crash when we
see the focus get stolen to prevent Chrome from accepting
input into other windows while the screen is locked.)
BUG=chromium-os:8999
TEST=ran "setTimeout(function() { alert(); }, 2000)" in a JS console, locked the screen, and checked that we no longer crash
Review URL: http://codereview.chromium.org/4908001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37891
TEST=trybots
Review URL: http://codereview.chromium.org/4825002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
button.
BUG=61500
TEST=none
Review URL: http://codereview.chromium.org/4922001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
immediately after creating a new window need to wait for it to be "ready" on
linux.
**remake of issue4838001 (nuked client, long story)
BUG=62783,44203
Review URL: http://codereview.chromium.org/4931001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to not crash anymore.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4869001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It requires flash 10.1.103.19 or better, the current
flash in trunk is 10.1.103.20 so we are fine.
BUG=50796
TEST=see bug
Review URL: http://codereview.chromium.org/4870001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=63024
TEST=none
Review URL: http://codereview.chromium.org/4890003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4884003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4923001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4900003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
resubmit
Revert 66002 - Change the FF CEEE to create its chrome frame instance initially hidden, and
make it visible only once the content is done loading. This avoids any flicker
at startup, and fixes a bug where the chrome frame instance is removed after
a print preview.
Also added support to chrome frame to send an uninitialized ready state
when its being torn down.
BUG=62979
TEST=Make sure that there is no UI flicker on chrome frame startup, and make
sure that the extenions works correct after showing print preview and closing
it.
Review URL: http://codereview.chromium.org/4882004
TBR=rogerta@chromium.org
Review URL: http://codereview.chromium.org/4855005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=FullTabNavigationTest.TypeAnchorUrl
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/4807004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=another opengl es 2.0 conformance test passes
BUG=none
Review URL: http://codereview.chromium.org/4862001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Creates an enumeration histogram called Extensions.AppsPromo with the following buckets:
0: launched an application from the promo
1: launched the web store from the promo
2: manually closed the promo (and uninstalled the applications)
3: promo expired
BUG=61017
TEST=
Review URL: http://codereview.chromium.org/4708002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We don't rely on samples identifying themselves as discontinuous and instead have the pipeline force a flush as part of a seek.
BUG=54110
TEST=media_unittests and layout tests
Review URL: http://codereview.chromium.org/4878001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* CopyBackground that copies the background from other view.
* Updated NewUserView to use CopyBackground.
I couldn't use this for existing_user_view as surrounding area is rendered by another window.
BUG=chromium-os:8101
TEST=Check username/password fields on new user pods and password field on screen locker have the same background as surrounding area.
Review URL: http://codereview.chromium.org/4882003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Remove the hack we used for checking that plugins didn't
regress, as this is a generalization of that idea.
Review URL: http://codereview.chromium.org/4161004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66003 0039d316-1c4b-4281-b951-d872f2087c98
|