| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/21044
TEST= try installing a theme with a corrupt image. note that loading bubble disappears.
Review URL: http://codereview.chromium.org/196016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=japhet
BUG=8630
TEST=none
Review URL: http://codereview.chromium.org/196017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=19049
TEST=https sites perform identically under Mac OS X <= 10.5.6 and Mac OS X >= 10.5.7 (in particular, https://test-ssev.verisign.com/ and the three pages linked from there)
Review URL: http://codereview.chromium.org/177014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/201010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Good news: these were discovered by testing the repaint functionality.
R=japhet
TEST=none
BUG=8630
Review URL: http://codereview.chromium.org/196011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
and Reenable.
BUG=20828
Review URL: http://codereview.chromium.org/193013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* linkify the subsection's URL rather than just displaying the URL
* also changed the URL scheme of the text from about:net-internal to view-net-internal
BUG=http://crbug.com/14478
Review URL: http://codereview.chromium.org/196013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
It's not useful to warn the user about broken symlinks when iterating
a directory tree.
Review URL: http://codereview.chromium.org/197017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There seems to be no other reliable way to do that due to Windows file semantics.
This should decrease the flakiness.
TEST=Covered by ui_tests.
http://crbug.com/20809
Review URL: http://codereview.chromium.org/192010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Focus the location bar, deactive/reactivate the browser window with
Alt-Tab, the focus should still be on the location bar.
Click few links on a page to have a history navigation. Focus the location
bar, use backspace to delete some text. Focus a text area in a web page,
make sure backspace works as expected (deletes text). Now click on a non
text area, press backspace. You should trigger a navigate back.
Review URL: http://codereview.chromium.org/185014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(I had them incorrectly formatted before)
BUG=http://crbug.com/20703
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests\editing\pasteboard\5027857.html for Linux.
Windows rebaselines were done in http://src.chromium.org/viewvc/chrome?view=rev&revision=15515, but Linux baselines were not updated at that time. These correspond to upstream rebaselines in http://trac.webkit.org/changeset/43243.
TEST=layout test try bots
BUG=none
Review URL: http://codereview.chromium.org/195011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/195006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/17696
TEST= Install a theme. Note that a "loading" message appears to notify you that a theme is loading.
Review URL: http://codereview.chromium.org/191011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this patch, we'll persist ForceTLS state to disk. It's saved as a
JSON file (ForceTLSState) in the user data directory for the moment.
You still need the --force-https flag in order to trigger any ForceTLS
behaviour, however.
For the moment, this state isn't cleared when the rest of the browser
state it. That's ok because it's still behind a flag.
http://codereview.chromium.org/186014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=japhet
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/197015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=19951,20552
TEST=compare pages rendered in Chromium and Safari. They should appear the same.
mark: review
jrg/brettw: FYI
Review URL: http://codereview.chromium.org/194013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=maruel
Review URL: http://codereview.chromium.org/198012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=12347
Review URL: http://codereview.chromium.org/192011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20709
TEST=use ffmpeg to dump raw yuv and compare to media_bench output.
Review URL: http://codereview.chromium.org/171113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This exposes a bug where \n in a string resource is rendered literally when it is displayed. I don't know at what point on Windows the '\' + 'n' is translated to a line return, I have filed crbug.com/20943
BUG=20731
Review URL: http://codereview.chromium.org/194002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/195009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The browser process launches children with fork && exec. On the Mac, this
results in a child that has its exception ports set the same as the parent.
When Breakpad is enabled, this means that a child such as a renderer process
begins its life with its exception port pointing to a Breakpad instance
running inside the browser. This is not intended. Even if the child installs
its own Breakpad handler (which a renderer would), the previous handler would
be pointing to the instance inside the browser, and if the child's Breakpad
is misconfigured to pass exceptions to the previous handler it will wind up
being passed back to the parent. The misconfiguration was corrected in r25311.
This change restores the default exception handler port, which should be
Apple Crash Reporter/ReportCrash, in the child process immediately after it
it has been forked.
BUG=20371
TEST=None, because r25311 fixed the visible aspect of this bug
Review URL: http://codereview.chromium.org/200007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
NO CODE CHANGE.
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jcampan
BUG=None
TEST=Release build should work now.
Review URL: http://codereview.chromium.org/196008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
windows already and just have slight pixel differences from windows results.
BUG=11123
TEST=layout test try bots
Review URL: http://codereview.chromium.org/200008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bar should not change the focus.
Add param const Event& event to ButtonPressed, so that recipients can find out more about the event that generated the ButtonPress message.
BUG=9687
TEST=Open www.google.com and open Find-in-page, search for 'e'. Press FindNext button with mouse and note that the focus should be on the textfield. Now press Tab twice to put focus on the FindNext button and press SpaceBar a few times. Note that the focus should stay on the FindNext button.
Review URL: http://codereview.chromium.org/188016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch submitted by Thiago Farina:
http://codereview.chromium.org/188017
BUG= http://crbug.com/2185
TEST=None
Review URL: http://codereview.chromium.org/199009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also makes the buttons drag-able -- you can drag or click and wait to
open their menu. Lucky for me, I wrote reusable code.
To do (not now): The "off-the-end" button on the bookmark bar needs the
same fix.
Bug (not to be fixed now): The menu doesn't do the right thing when the
window is moved off the left edge to the screen -- it doesn't open to
the right in the correct fashion. Nor does it do the proper thing when
you move the window off the bottom edge of the screen -- it doesn't open
upwards entirely correctly. <shrug>
BUG=18572
TEST=Click on the Page and Wrench menu buttons and observe. Also test \
dragging to open.
Review URL: http://codereview.chromium.org/174556
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/20957
TEST= Install many themes quickly, with many windows open. Close browser and reopen. Theme should not be corrupted.
Review URL: http://codereview.chromium.org/197010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
net-internals page.
BUG=http://crbug.com/14478
Review URL: http://codereview.chromium.org/184008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/18734
TEST=Launch Chrome. Add some bookmarks then open the bookmark menu.
You should see all "bookmark bar" bookmarks, followed by a separator
line, followed by an "Other bookmarks" submenu at the end.
Go to a bookmark then click on STAR. Change folder to "other bookmarks".
Now open bookmark menu; see item moved from "main page" to the
"other bookmarks" folder at the end.
Undo that change by clicking on STAR, changing parent.
Make sure back to normal.
Review URL: http://codereview.chromium.org/195001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
needed.
BUG=http://crbug.com/17852
TEST=delete all bookmarks. No chevron.
Add one bookmark to bookmark bar. No chevron.
Make window real wide.
Add some more bookmarks (but not enough that it spills over). No chevron.
Make window thinner. Chevron appears!
Widen window until chevron hides.
Add more bookmarks until it appears again.
Review URL: http://codereview.chromium.org/201005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Do not add unnecessary baselines
Check whether a baseline is duplicate and can fallback to
same baseline for another platform. For example, if a test
has same baseline on linux and windows, then we only store
windows baseline and linux baseline will fallback to the
windows version.
- Set new baseline svn property.
TEST=rebaseline tool
BUG=18906
Review URL: http://codereview.chromium.org/174567
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also use it if present. Especially use its new xml suppression record
if present, which is more correct than the one we synthesize.
Also fix a warning about global use before declare in memcheck_analyze.py.
Review URL: http://codereview.chromium.org/191006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=21010
TEST=Happier valgrind bots
Review URL: http://codereview.chromium.org/201006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/20243
TEST=Go to www.popuptest.com. Select test #2, allow one of the popups
through. Try to edit in the omnibox. Should be able to select and
copy, but not enter text.
Review URL: http://codereview.chromium.org/183043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This should never have been checked-in as-is.
TEST=still compiles
BUG=none
Review URL: http://codereview.chromium.org/193007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/200005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
is what has changed).
Review URL: http://codereview.chromium.org/196005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Due to our tweaking of the text area, the I-beam cursor was sometimes
janky.
http://crbug.com/20238
TEST=I don't even know how to really test this.
Review URL: http://codereview.chromium.org/181011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
in 'script-tests' directories.
TBR=hamaji
BUG=20908
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20908
TEST=none
Review URL: http://codereview.chromium.org/187017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
when running the RenderView unit tests. The tests create a RenderView object using the default constructor of RendererPreferences. The uninitialized values are then passed through to WebKit to set the focus ring color.
BUG=20964
TEST=Covered by valgrinding unit tests.
Review URL: http://codereview.chromium.org/194009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16106
TEST=none
Review URL: http://codereview.chromium.org/176016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
colors. These will be used to make the UI more readable on non-default themes.
Also removes a function that no one was calling.
BUG=92, 18367
TEST=none
Review URL: http://codereview.chromium.org/190001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
bundle) to O3D, not o3d.
This matches the name it gets in the GYP build and enabled them to share an Info.plist file (also changed in this CL in the same way).
Add include dir for the Breakpad header to scons, so it can cope with us #including "Breakpad.h" as required by the GYP build, rather than <Breakpad/Breakpad.h>.
Review URL: http://codereview.chromium.org/200002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
about some awful behavior that dates back to the earliest days.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/185002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25338 0039d316-1c4b-4281-b951-d872f2087c98
|