summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Rebuild app menu in ToolbarView::RunAppMenuxiyuan@chromium.org2010-02-065-18/+62
| | | | | | | | | | | | When "enable-udd-profiles" switch is set, update profile submenu and rebuild app menu if necessary. BUG=30417 TEST=Verify that comment 5 in issue 30417 is fixed. Review URL: http://codereview.chromium.org/571015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38281 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Don't let omnibox popup text tighten while resizing.shess@chromium.org2010-02-051-0/+1
| | | | | | | | | | | | | | | Sets the tightening factor to 0.0 so that the popup text doesn't tighten then rebound after being elided. BUG=24296 TEST=Get the omnibox popup up, resize the window smaller, all the left-hand-side text which stays should be rendered in a stable position (right-hand-side text may shift as LHS text is elided, but the spacing between characters should stay the same). Review URL: http://codereview.chromium.org/577029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38280 0039d316-1c4b-4281-b951-d872f2087c98
* Revert debugging crud I added while trying to track down bug 31719.erg@chromium.org2010-02-053-105/+16
| | | | | | | | | | | | Revert "Speculative fix for the windows theme crasher." (r36036) Revert "More debugging statements to try to track down BrowserThemePack crash." (r37259). BUG=31719 TEST=none Review URL: http://codereview.chromium.org/573036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38279 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] o Adds a slight drop shadow to the drawn images within Browser Action ↵andybons@chromium.org2010-02-059-119/+820
| | | | | | | | | | | | | buttons. o Adds initial BrowserActionsContainerView class that simply draws a right border at this time but will be used for more complex UI later. o Alters Toolbar.xib to use the new view class instead of a plain NSView. TEST=none BUG=none Review URL: http://codereview.chromium.org/565048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38278 0039d316-1c4b-4281-b951-d872f2087c98
* Force Java version to 1.6.0 on Mac OS X because apparently latestkbr@chromium.org2010-02-051-1/+10
| | | | | | | | | JSCompiler binaries require this version. Verified this fix on 10.5 and tested on 10.6 as well. Review URL: http://codereview.chromium.org/578022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38275 0039d316-1c4b-4281-b951-d872f2087c98
* Added Star button to compact navigation mode.avayvod@chromium.org2010-02-0512-197/+202
| | | | | | | | | | BUG=32326 TEST=Switch Chrome to compact mode by pressing Ctrl-Shift-C. Test that Star icon works. Review URL: http://codereview.chromium.org/577026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38273 0039d316-1c4b-4281-b951-d872f2087c98
* Added needed dependency on npo3dautoplugin because otherwise thekbr@chromium.org2010-02-051-0/+3
| | | | | | | | unpack_firefox target can run before the plugin has been built. Review URL: http://codereview.chromium.org/574019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38272 0039d316-1c4b-4281-b951-d872f2087c98
* Roll Skia to 488 to pick up some new needed entry points.kbr@chromium.org2010-02-051-1/+1
| | | | | | Review URL: http://codereview.chromium.org/577031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38271 0039d316-1c4b-4281-b951-d872f2087c98
* Addsgman@chromium.org2010-02-0516-507/+1359
| | | | | | | | | | | | | | | | | glGetActiveAttrib glGetActiveUniform glGetAttachedShaders glGetShaderPrecision TEST=none BUG=none Review URL: http://codereview.chromium.org/577017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38270 0039d316-1c4b-4281-b951-d872f2087c98
* Check for the existance of a profile manager. Might not exist during early ↵jochen@chromium.org2010-02-051-0/+7
| | | | | | | | | | | shutdown. BUG=34652 TEST=Execute chrome. Run chrome --uninstall. Should not crash. Review URL: http://codereview.chromium.org/572043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38269 0039d316-1c4b-4281-b951-d872f2087c98
* Refactored out JS specific part of modal dialog stack into its own class, ↵zelidrag@chromium.org2010-02-0528-715/+1194
| | | | | | | | | | | exposed cookie/storage prompt as a modal dialog. BUG=32719 TEST=none, requires Darin to hook this with his code. Review URL: http://codereview.chromium.org/560030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38268 0039d316-1c4b-4281-b951-d872f2087c98
* linux: build with -Wextraevan@chromium.org2010-02-0544-89/+125
| | | | | | | | | | | | 95% of this is removing "const" from return types, but turning this on found one bug! (A "for" loop that expected its iterator to go negative but which was using an unsigned type.) BUG=34160 Review URL: http://codereview.chromium.org/570012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38266 0039d316-1c4b-4281-b951-d872f2087c98
* Arne's examples of two approaches to showing a page action:kathyw@chromium.org2010-02-0511-0/+106
| | | | | | | | | | | | * for particular URLs (chrome.tabs.onUpdated) * for particular page content (content script) TEST=none BUG=34694 Review URL: http://codereview.chromium.org/561087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38264 0039d316-1c4b-4281-b951-d872f2087c98
* Make open tab items check item.oshima@chromium.org2010-02-052-7/+7
| | | | | | | | | | | and fixed comment in simple_menu_model.h BUG=chromium-os:1217 TEST=none Review URL: http://codereview.chromium.org/575012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38263 0039d316-1c4b-4281-b951-d872f2087c98
* The FullTabModeIE_ReferrerTest has been marked FLAKY. It appears to be a ↵ananta@chromium.org2010-02-051-1/+3
| | | | | | | | | | | recent regression. Bug=34812 TBR=tommi Review URL: http://codereview.chromium.org/573033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38262 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix tab strip width calculation for RTLestade@chromium.org2010-02-051-1/+4
| | | | | | | | | BUG=34763 TEST=see bug Review URL: http://codereview.chromium.org/579006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38258 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Toggle set-above property on bookmark bar event box when showing it.estade@chromium.org2010-02-051-9/+16
| | | | | | | | | | | BUG=34564 TEST=In both normal theme mode and gtk theme mode, a) doesn't regress 33220 b) floating bookmark bar accepts input Review URL: http://codereview.chromium.org/577005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38257 0039d316-1c4b-4281-b951-d872f2087c98
* 1st step to implement notification panel for chromeososhima@chromium.org2010-02-058-2/+557
| | | | | | | | | | | | | | - re-using views implementation, but removed layout related code - add NotificationPanel - added SetSize in BalloonViewHost. I needed this because I removed animation code and NativeViewHostGtk doesn't know about render view. I need to think a bit more to find out how to deal wit this. It's using existing balloon collection, but we may need one for chromeos (or may not). BUG=33306 TEST=none Review URL: http://codereview.chromium.org/572018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38255 0039d316-1c4b-4281-b951-d872f2087c98
* Add placeholder for histogramming non-speculative resolve jobs duration.eroman@chromium.org2010-02-051-5/+40
| | | | | | Review URL: http://codereview.chromium.org/573021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38254 0039d316-1c4b-4281-b951-d872f2087c98
* The RemoveChars utility function requires a NULL-terminated input string, so ↵jhawkins@chromium.org2010-02-051-1/+1
| | | | | | | | | | | fix the test accordingly. TBR=joth BUG=34731 TEST=StringUtilTest.RemoveChars Review URL: http://codereview.chromium.org/578018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38252 0039d316-1c4b-4281-b951-d872f2087c98
* Page Info dialog button HIG fixes.mattm@chromium.org2010-02-052-12/+14
| | | | | | | | | | | | | | All: Remove ellipses from IDS_PAGEINFO_CERT_INFO_BUTTON, as it does not require further action to display the info. Add use_titlecase version. Linux: Place button in the primary area instead of secondary to match HIG (I guess). BUG=34425 TEST=read Gnome HIG (and MSDN "Command Buttons" guidelines), open Page Info for some page, compare Review URL: http://codereview.chromium.org/561079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38251 0039d316-1c4b-4281-b951-d872f2087c98
* roll deps to pick up nacl changes for armpiman@google.com2010-02-051-1/+1
| | | | | | Review URL: http://codereview.chromium.org/575020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38249 0039d316-1c4b-4281-b951-d872f2087c98
* When clearing browsing data modified since a certain time, do not delete ↵jochen@chromium.org2010-02-055-15/+30
| | | | | | | | | | | | | extension data. You can use the cookie tree model to really delete all data. BUG=34598 TEST=install an extension that uses local storage, delete browsing data, check that the extension data still exist. Review URL: http://codereview.chromium.org/573030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38248 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor media::InputBuffer to consolidate it with media::Bufferhclam@chromium.org2010-02-058-46/+49
| | | | | | | | | | | | Rename media::InputBuffer to media::OmxInputBuffer and inherit from media::Buffer. Also provide the timestamp to media::OmxCodec. TEST=omx_test BUG=32753 Review URL: http://codereview.chromium.org/577012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38247 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Implement the new content blocking address bar bubbles on Linux.erg@chromium.org2010-02-057-3/+500
| | | | | | | | | BUG=33314 TEST=none Review URL: http://codereview.chromium.org/573023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38246 0039d316-1c4b-4281-b951-d872f2087c98
* Added validation for non-emptiness of the label.georgey@chromium.org2010-02-052-1/+55
| | | | | | | | TEST=If any label (in address or credit card) is empty, the save button is disabled. Otherwise it is enabled. BUG=33026 Review URL: http://codereview.chromium.org/575027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38245 0039d316-1c4b-4281-b951-d872f2087c98
* Minor unittest cleanup.eroman@chromium.org2010-02-051-24/+21
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/561082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38244 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the HostResolver::Shutdown() method.eroman@chromium.org2010-02-057-17/+9
| | | | | | | | | | | While this doesn't entirely remove the hack, it limits the scope of it to HostResolverImpl. Hopefully in the future HostResolver will not be refcounted so this can go away altogether. BUG=18373 Review URL: http://codereview.chromium.org/569035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38243 0039d316-1c4b-4281-b951-d872f2087c98
* Don't crash when a theme specifies a non-existant image.erg@chromium.org2010-02-054-6/+31
| | | | | | | | | | | Fixes the current TopCrasher. BUG=31719 TEST=BrowserThemePackTest.TestNonExistantImages Review URL: http://codereview.chromium.org/572039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38242 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed the following issues with SPDY server push.cbentzel@chromium.org2010-02-054-15/+48
| | | | | | | | | | | | | * A NULL stream was added to pushed_streams_ * FlipStream had a NULL HttpResponseInfo pointer. In non-server-push paths, this pointer references a member of the associated FlipNetworkTransaction. In this case, I just leak memory - needs a better solution. * io_state_ was set to NONE on a server push, which DCHECK'ed in the first state machine loop. Changed it to jump to READ_HEADERS state. BUG=NONE TEST=Manual Review URL: http://codereview.chromium.org/551006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38241 0039d316-1c4b-4281-b951-d872f2087c98
* skia is absolute coords for rectsdavemoore@chromium.org2010-02-054-126/+236
| | | | | | Review URL: http://codereview.chromium.org/575017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38240 0039d316-1c4b-4281-b951-d872f2087c98
* Add an extension API test to catch cookie regressions.mpcomplete@chromium.org2010-02-054-0/+49
| | | | | | | | BUG=34649 Review URL: http://codereview.chromium.org/573032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38239 0039d316-1c4b-4281-b951-d872f2087c98
* Add a test executable to allow verifying which minidump flag configurations ↵siggi@chromium.org2010-02-052-0/+444
| | | | | | | | | | | work on which OSen. BUG=32441 TEST=none Review URL: http://codereview.chromium.org/578003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38238 0039d316-1c4b-4281-b951-d872f2087c98
* Yet more tab strip model changes. I'm hoping this is the last ofsky@chromium.org2010-02-058-79/+287
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | it. I'm now going with: // . Mini-tab. Mini tabs are locked to the left side of the tab strip and // rendered differently (small tabs with only a favicon). The model makes // sure all mini-tabs are at the beginning of the tab strip. For example, // if a non-mini tab is added it is forced to be with non-mini tabs. Requests // to move tabs outside the range of the tab type are ignored. For example, // a request to move a mini-tab after non-mini-tabs is ignored. // You'll notice there is no explcit api for making a tab a mini-tab, rather // there are two tab types that are implicitly mini-tabs: // . App. Corresponds to an extension that wants an app tab. App tabs are // identified by TabContents::is_app(). // . Pinned. Any tab can be pinned. A pinned tab is made phantom when closed. // Non-app tabs whose pinned state is changed are moved to be with other // mini-tabs or non-mini tabs. I'm going with a more neutral name like mini-tabs so that we can change the meaning if we need to without changing around all the UI code. I'll convert the UI code next. BUG=32845 TEST=none Review URL: http://codereview.chromium.org/570043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38237 0039d316-1c4b-4281-b951-d872f2087c98
* Worked around bug in 32-bit Safari 4 on Mac OS X 10.6 where thekbr@chromium.org2010-02-051-0/+6
| | | | | | | | | | browser sends O3D a spurious NPP_SetWindow with an invalid window after first sending it a valid one. Tested this on both 10.6 and 10.5; no ill effects on 10.5, including in multiple tab case. Review URL: http://codereview.chromium.org/572027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38236 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed build problem on Mac OS X 10.6. precompile.h is inferred by namekbr@chromium.org2010-02-051-0/+2
| | | | | | | | | | | | to be a C file, but it includes C++ headers like <vector> and <algorithm>. In order for the compiler to find these headers it was necessary to force it to treat this as a C++ header. This fix was determined to be necessary on multiple machines running Xcode 3.2.1. It has also been tested on 10.5 with no ill effects. Review URL: http://codereview.chromium.org/572026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38235 0039d316-1c4b-4281-b951-d872f2087c98
* Tab strip model: Fix an off by one error where we do not check the first tab.thestig@chromium.org2010-02-051-15/+10
| | | | | | | | BUG=33323 TEST=see bug Review URL: http://codereview.chromium.org/561066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38234 0039d316-1c4b-4281-b951-d872f2087c98
* Enable onhttpequiv again. The difference this time around is that wetommi@chromium.org2010-02-053-136/+83
| | | | | | | | | | | | | perform the switch in onhttpequiv when done==false. Also, we don't rely on having access to the already existing moniker but instead create our own and DCHECK that it is IsRunning() (see comments). TEST=The double loading effect we were seeing before should be gone. BUG=33332 Review URL: http://codereview.chromium.org/576017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38232 0039d316-1c4b-4281-b951-d872f2087c98
* Don't call View::DidChangeBounds() when the bounds didn't changedavemoore@chromium.org2010-02-051-6/+7
| | | | | | | | | Bug: None Test: Views based UI should still layout correctly Review URL: http://codereview.chromium.org/574013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38231 0039d316-1c4b-4281-b951-d872f2087c98
* Adding the URLRequestTest.CookiePolicy_ForceSession test to the list of ↵ananta@chromium.org2010-02-051-0/+1
| | | | | | | | | | | | disabled tests as it does not apply to the host network stack. TBR=amit Review URL: http://codereview.chromium.org/572040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38230 0039d316-1c4b-4281-b951-d872f2087c98
* Don't need ipc_message.h any morecmasone@google.com2010-02-052-16/+0
| | | | | | Review URL: http://codereview.chromium.org/577025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38229 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds support for displaying Chrome InfoBars in pages rendered via ↵ananta@chromium.org2010-02-056-26/+88
| | | | | | | | | | | | | | | | | | ChromeFrame. To achieve this the ExternalTabContainer now creates a view which comprises of the InfoBarContainer and the TabContentsContainer view. It uses the GridLayout manager to layout this view. The InfoBarContainer no longer depends on the BrowserView. It now passes notifications to the InfoBarContainerDelegate interface which is implemented by the BrowserView and the ExternalTabContainer. Fixes bug http://code.google.com/p/chromium/issues/detail?id=24051 Bug=24051 Review URL: http://codereview.chromium.org/573022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38228 0039d316-1c4b-4281-b951-d872f2087c98
* Add Single Sign On support to HTTP Authentication handlers.cbentzel@chromium.org2010-02-0521-185/+457
| | | | | | | | | | | | | | | Currently this is implemented on Windows for the NTLM and Negotiate schemes. This CL does not introduce the hooks to actually use Single Sign On in response to a 401/407 request - that will come in a later CL. This behavior is disabled for now as well. BUG=29862 TEST=Ran unittests, and Chrome against a server with authentication challenges. Review URL: http://codereview.chromium.org/555174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38227 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crasher in LocationBarView when browser is closed with page action ↵mirandac@chromium.org2010-02-054-19/+31
| | | | | | | | | | install bubble showing. BUG= 34282 TEST= in release version, create a page action. close browser window while page action install bubble is showing. no crash, ever. Review URL: http://codereview.chromium.org/561028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38225 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak the crash dump flags to make sure we get PEB/TEB and the unloaded ↵siggi@chromium.org2010-02-051-1/+20
| | | | | | module list where available. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38224 0039d316-1c4b-4281-b951-d872f2087c98
* Show the filebrowse ui rather than the download shelf in chromeos.xiyuan@chromium.org2010-02-058-26/+95
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This cl displays the filebrowse ui rather than download shelf for downloads in chrom(e|ium) os. It conditionally replaces (with preprocessor macros) the Browser::OnStartDownload method to do this. The cl adds a static FileBrowseUI::OpenPopup(profile, hashArgument), which opens the file browse ui and passes it the provided hash argument. This is invoked directly from Browser::OnStartDownload. The USBMountObserver code was changed to call this static method, rather than open the popup by hand as it had been doing. I'm not sure about ownership of the Browser* returned by OpenPopup, but based on other code in the tree I assume chrome will deal with freeing it when appropriate. Before this change, USBMountObserver would add the window to registrar_ *before* showing it. Now that FileBrowseUI::OpenPopup returns a which which is already visible, this is no longer the case. I assume this won't be a problem. Commit this for rginda. Original review: http://codereview.chromium.org/555167 BUG=none TEST=none Review URL: http://codereview.chromium.org/564022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38222 0039d316-1c4b-4281-b951-d872f2087c98
* Prepare for running nacl_ui_test on Mac and Linux.gregoryd@google.com2010-02-051-0/+6
| | | | | | | | This is the NaCl-Chrome integration test that runs in Chrome waterfall, currently on Windows only. I am working on starting new bots that will run it on Mac and Linux. Review URL: http://codereview.chromium.org/563021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38218 0039d316-1c4b-4281-b951-d872f2087c98
* Update my watchlist.finnur@chromium.org2010-02-051-0/+9
| | | | | | | | | BUG=None TEST=None (no code change) Review URL: http://codereview.chromium.org/577023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38217 0039d316-1c4b-4281-b951-d872f2087c98
* Make Carbon plugin idle event source robust against changes during iterationstuartmorgan@chromium.org2010-02-051-57/+62
| | | | | | | | | | | | | Ensure that removing any plugin from the idle event source during iteration is safe (not just the currently-firing plugin). Also bullet-proofs against the possibility of nested iteration. Refactors the idle event source to use a helper class, to reduce duplicate code. BUG=33467 TEST=Scroll rapidly on a page with multiple instances of a Cabon plugin. Review URL: http://codereview.chromium.org/575023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38216 0039d316-1c4b-4281-b951-d872f2087c98
* Makes example.com resolve to localhost for test.sky@chromium.org2010-02-051-0/+2
| | | | | | | | | | BUG=32845 TEST=none TBR=erikkay Review URL: http://codereview.chromium.org/573029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38215 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 11:20:14 +0000