| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=23536
TEST=Open Chrome Linux w/a theme and no bookmarks, verify instructional text in bookmarks bar has correct color.
Review URL: http://codereview.chromium.org/274034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I still don't know why it failed, but the only difference
that I could see in this test between xp and vista is that
xp accepts a lot of small IOs before returning pending, so
this change results in similar behavior in both platforms
and a faster run on xp.
BUG=23862
TEST=none
Review URL: http://codereview.chromium.org/273024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
until they are fixed.
BUG:24769
Review URL: http://codereview.chromium.org/274037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/271076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Adds unmonitoring of network status changes.
Fixed a few edge case bugs.
BUG=23923
TEST=none
Review URL: http://codereview.chromium.org/272019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
widget_gtk when building chromeos build. We need a #ifdef for
CHROMEOS but not using TOOLKIT_VIEWs for the browser window. I'm
temporarily adding this one.
This bug is the result of Oshima making TOOLKIT_VIEWS set OS_CHROMEOS.
Review URL: http://codereview.chromium.org/270092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/270094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(Long term intention is to add a subset of cpplint.py to the presubmit script.)
Review URL: http://codereview.chromium.org/276008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=domincc
Original review: http://codereview.chromium.org/271069
Enables use-machine-stack.html worker test.
As of WebKit revision 49427 Workers now set an appropriate stack
limit on OS X, so this test can be enabled.
Submitt this patch for Dominic Cooney <dominicc@google.com>
Review URL: http://codereview.chromium.org/271082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Preserves backwards compatability with the old manifest format.
BUG=24635
Review URL: http://codereview.chromium.org/275007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also add some FilePath methods in disk_cache_util.h and obsolete
the old.
BUG=24444
Review URL: http://codereview.chromium.org/266069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24672
TEST=still compiles
Review URL: http://codereview.chromium.org/270077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Main entry point
- sqlite error handler
BUG=none
TEST=none
TBR=huanr
Review URL: http://codereview.chromium.org/274033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Get the printing support class stack building and hooked up on the Mac.
Add support for creating NativeMetafile objects with PDF print data on the renderer side, and passing them to the browser via the existing printing IPC system.
Flip on the simpler printing unit tests (those that don't require PDF -> bitmap conversion).
BUG=13158
TEST=Print on the Mac--it should work!
Review URL: http://codereview.chromium.org/276004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
setting, ignoring the CRL setting. Not a problem at the moment since revocation isn't hooked up at the lower level, but it would have been a problem in due time.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/215014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
always there but it only became an issue when accessibility changes
landed.
BUG=http://crbug.com/24758
TEST=Open menu. See "add page" sheet show up.
Review URL: http://codereview.chromium.org/270096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
not deleting the blocked popup container view views,
which resulted in a reliability crash. This differs from the first patch in that BlockedPopupContainerViewViews::Destroy now does
a delete this.
From the original patch:
I had to fix a couple of additional things here:
. Avoid doing anything in OnSizeAllocation if the size hasn't
changed. Because of how gtk works I was getting stuck in a loop if I
OnSizeAllocate did anything if the size hadn't changed.
. Applied similar shortcut to TabContentsViewGtk.
. Made SimpleMenuModel only ask delegate for checked state if the item
is a check.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/274019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Adds accelerator to list of files compiled on views/gtk.
. Adds function to Screen to get monitor bounds from a window.
. Adds BrowserFrameGtk::GetAccelerator to match windows.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/275005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/271043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
description:
Numerous fixes to get parts of Chrome Sync to compile on OS X.
Fixes include:
- Added missing definitions for some static const class variables.
- Added some missing dependencies.
- Marked some Windows-only dependencies as such.
- Added stub files for some platform-specific classes.
BUG=none
TEST=Put through trybots.
Review URL: http://codereview.chromium.org/266065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23536
TEST=With an empty bookmark bar and any theme, the helper text color should match the "other bookmarks" color.
Review URL: http://codereview.chromium.org/276005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Chromium changes that correspond to this WebKit change:
https://bugs.webkit.org/show_bug.cgi?id=30135
Review URL: http://codereview.chromium.org/274024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/274029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"stats for nerds" screen.
TEST=none
BUG=http://code.google.com/p/nativeclient/issues/detail?id=108
Review URL: http://codereview.chromium.org/267043
TBR=gregoryd@google.com
Review URL: http://codereview.chromium.org/266067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
segment_usage"""
startup_tests are failing.
This reverts commit r28870.
TBR=finnur
Review URL: http://codereview.chromium.org/274026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23569
TEST=https://rbacpro.sftcomp.ru/ should report "invalid certificate" rather than crash
Review URL: http://codereview.chromium.org/270034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
have the full certificate chain.
BUG=23122
TEST=https://www.paypal.com should have "This certificate is valid" in View Page Info->View Certificate Information
Review URL: http://codereview.chromium.org/256064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=24337
Review URL: http://codereview.chromium.org/269065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
process count change.
BUG=22608
Review URL: http://codereview.chromium.org/261056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/270090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is the last piece needed before I can clean up all the callers.
BUG=24672
TEST=compiles
Review URL: http://codereview.chromium.org/274022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
nerds" screen.
TEST=none
BUG=http://code.google.com/p/nativeclient/issues/detail?id=108
Review URL: http://codereview.chromium.org/267043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
"SkColorSetARGB(0, 0, 0, 0)" in place of "NULL" since it's not obvious what the latter means as a color.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/273042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24444
Review URL: http://codereview.chromium.org/274012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary for AccessibilityController, which has non-trivial
property accessors.
R=darin
BUG=10322
TEST=CppBoundClassTest.SetAndGetPropertiesWithCallbacks
Review URL: http://codereview.chromium.org/243064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
.app bundle, and make them available to the packaging system. This ensures
that the packager uses the correct logic to sign a bundle, and places the
correct Keystone auto-update script into the package. Because things may
move around in the bundle and the proper codesign invocation may change
between versions, it is correct to store the codesign logic with the package
being signed. Similarly, because the correct way to perform an client-side
auto-update may change between versions, it is correct to store the
auto-update script with the code.
BUG=14610 (in support of unbreaking auto-update)
TEST=none
Review URL: http://codereview.chromium.org/261048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
segment_usage""
This re-lands commit r28844 with a fix to make sure the History database
exists before trying to update the dates.
TBR=brettw
Review URL: http://codereview.chromium.org/266066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We don't have html popups yet but clicking should work (e.g. print button works).
TODO: port browser_action in proc browser test.
TODO: badges
BUG=23882
TEST=loaded gmail browser action extension, loaded print bookmark bar extension, loaded them both, unloaded, disabled, enabled, etc.
Review URL: http://codereview.chromium.org/273025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/266037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/266063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Although turning back on the browser focus tests that had been turned off last week because of my previous attempt at performing this refactoring (that change was reverted).
BUG=None
TEST=Build and run the interactive ui tests on Windows and Linux.
Review URL: http://codereview.chromium.org/273029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2. Reduce the timeout for Release builds to 6 seconds.
3. Double the timeout for Debug builds (i.e. 12 seconds).
4. Make SLOW mean 5x the regular timeout (used to mean 10x).
Looking at the flakiness dashboard. There's ~50-100 tests that very
rarely take 4-5 seconds to run. If we really cared we should look into
why, but just to be safe, we set the timeout to 6 seconds.
Review URL: http://codereview.chromium.org/271074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Blindly dereferencing NULL pointers in a unittest causes the test harness to crash.
BUG=none
TEST=none
TBR=jcampan
Review URL: http://codereview.chromium.org/270088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/276003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
A check is failing during page cycler tests so the test is going red.
This reverts commit r28844.
TBR=chase
Review URL: http://codereview.chromium.org/264049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
GPUPluginObject.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/264041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Part two of printing implementation on the Mac. This adds a Mac implementation of PrintSettings to get page setup and printer information, basic PDF->context rendering in PrintedDocument, and most of PrintingContext to allow getting print settings (both default and interactive).
Reworks the message flow a bit when asking for print settings on the Mac, since it can only be done from the UI thread. Uses a modal dialog for now, but will later be modified further to allow for a sheet.
BUG=13158
TEST=None; no user-visible effect yet.
Review URL: http://codereview.chromium.org/268036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28857 0039d316-1c4b-4281-b951-d872f2087c98
|