summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Change from CHECK to DCHECK and attempt to handle NULL values, in ↵joi@chromium.org2011-03-052-24/+17
| | | | | | | | | | | | | | | preparation for M11 branch point. Add boolean to iteration history for whether item was removed from map, to verify something I saw in 11.0.690.0 crash dumps. Remove copy of command-line as we have seen there is no correlation between command line and these crashes. BUG=71721 TEST=net_unittests Review URL: http://codereview.chromium.org/6624028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77043 0039d316-1c4b-4281-b951-d872f2087c98
* Quick-fix the suppression - accidentally replaced "4" with "}"timurrrr@chromium.org2011-03-051-1/+1
| | | | | | | | | Blame vim on OS X for that =\ TBR=glider Review URL: http://codereview.chromium.org/6625041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77041 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress many Valgrind reports on the memory waterfalltimurrrr@chromium.org2011-03-051-2/+77
| | | | | | | | | TBR=glider BUG=75019,75020,75021,75023 TEST=Memory waterfall goes green Review URL: http://codereview.chromium.org/6627037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77040 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress uninit conds in fileapi::FileSystemUsageCache::Read (issue 75018)glider@chromium.org2011-03-051-0/+28
| | | | | | | | | BUG=75018 TBR=kinuko Review URL: http://codereview.chromium.org/6623035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77039 0039d316-1c4b-4281-b951-d872f2087c98
* Check that uncompressed data passed to zlib is defined, and mark compressionglider@chromium.org2011-03-051-0/+12
| | | | | | | | | | | | | | result as defined. This way, we suppress benign reports from zlib (see http://www.zlib.net/zlib_faq.html#faq36), without losing coverage of spdy code. This patch was originally prepared by eugenis@chromium.org (doesn't have a committer access yet) and reviewed at http://codereview.chromium.org/6591101/ TBR=wtc Review URL: http://codereview.chromium.org/6286146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77036 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 692.0 to 693.0chrome-release@google.com2011-03-051-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77035 0039d316-1c4b-4281-b951-d872f2087c98
* Reland code to detect corruption of histogram rangesjar@chromium.org2011-03-056-73/+206
| | | | | | | | | | | | | | | | | | | | | | | | | | | This code was reverted because it caused, or exposed flakiness in sync unit test code (mostly on the Mac). We need to monitor that closely as we re-land. See the reviews and history in CLs: http://codereview.chromium.org/6577013 and http://codereview.chromium.org/6591052 This code generates CRC checksums for the histogram bucket-range vectors, and guarantees they remain intact when the histogram data is about to be uploaded to UMA. If the data is corrupted, then we will fail on a CHECK(). r=mbelshe,rvargas bug=73939 Review URL: http://codereview.chromium.org/6627011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77033 0039d316-1c4b-4281-b951-d872f2087c98
* Yet another clang roll attempt.thakis@chromium.org2011-03-052-1/+5
| | | | | | | | | | | | | | To r126754 To handle clang making -fno-exceptions disabling ObjC exceptions, add -fobjc-exceptions for all files for now. This is a band-aid, see the bug below. BUG=75001 TEST=none TBR=hans Review URL: http://codereview.chromium.org/6628002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77032 0039d316-1c4b-4281-b951-d872f2087c98
* autofill: Rename AutoFillManager to AutofillManager.tfarina@chromium.org2011-03-0524-200/+200
| | | | | | | | | BUG=72758 TEST=existing unit_tests Review URL: http://codereview.chromium.org/6625033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77031 0039d316-1c4b-4281-b951-d872f2087c98
* Marking sync test SinkBMs10LevelDown as a failure due to r76700.rsimha@chromium.org2011-03-051-1/+3
| | | | | | | | | | | | | | | | | | | Ever since http://src.chromium.org/viewvc/chrome?view=rev&revision=76700 was landed, the sync integration test TwoClientLiveBookmarksSyncTest.SC_SinkBMs10LevelDown has become mildly flaky with a bookmark model mismatch. It used to pass all the time before this patch. See logs at http://build.chromium.org/p/chromium/builders/Mac10.6%20Sync/builds/2006/steps/sync_integration_tests/logs/SC_SinkBMs10LevelDown. Marking the test as failed until the root cause is investigated. BUG=74853, 60236, chromium-os:11226 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/6628033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77027 0039d316-1c4b-4281-b951-d872f2087c98
* importer: Tweak ImportLockDialog comments.tfarina@chromium.org2011-03-053-7/+11
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6627020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77026 0039d316-1c4b-4281-b951-d872f2087c98
* Disable verbose logging for sync integration tests.rsimha@chromium.org2011-03-051-4/+0
| | | | | | | | | | | | | | | | | | | The chromium buildbots were showing an increasing number of browser crashes while running the sync integration tests. These crashes were fixed by reverting r76345 and r76239, and by the new patch in r76989. This patch disables verbose logging, now that the root cause of the crashes were identified. BUG=74467 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/6588068 TBR=rsimha@chromium.org Review URL: http://codereview.chromium.org/6624038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77025 0039d316-1c4b-4281-b951-d872f2087c98
* NSS: Unlock crypto devices when populating cert manager.mattm@chromium.org2011-03-0511-43/+130
| | | | | | | | | BUG=42073 TEST=try to use cert manager with "unfriendly" device. Review URL: http://codereview.chromium.org/6580058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77024 0039d316-1c4b-4281-b951-d872f2087c98
* Remove prototype of a function that was removed a while ago.thakis@chromium.org2011-03-051-2/+0
| | | | | | | | | | BUG=70465,72205 TEST=none TBR=sky Review URL: http://codereview.chromium.org/6633012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77023 0039d316-1c4b-4281-b951-d872f2087c98
* Major rewrite of BookmarkButton event-handling to support proper menu maf@chromium.org2011-03-0511-32/+327
| | | | | | | | | | | | | | tracking on mousedown, sticky and non-sticky menus, drag-down to get menu on draggable folders, etc. Also contains first half of animation support for these UI items. Note that a forthcoming checkin will add live animation during the drag, but that's not covered by this checkin, which adds animation support for the bookmark toolbar buttons, but only in response to completed actions. BUG=72011,70002,72012 Review URL: http://codereview.chromium.org/6594065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77022 0039d316-1c4b-4281-b951-d872f2087c98
* Cros: Check PCM after opening Alsa mixerdavej@chromium.org2011-03-051-15/+13
| | | | | | | | | | | | Alsa is logging numerous messages in the buildbot Linux Builder (Chromium OS) logs when trying to open a PCM stream after CL 6591095. This block of code was moved down to run only after successfully attaching to the Alsa mixer. BUG=chromium-os:12151 TEST=none Review URL: http://codereview.chromium.org/6621026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77021 0039d316-1c4b-4281-b951-d872f2087c98
* Don't try to convert text/html URLs ending in .user.js.aa@chromium.org2011-03-056-17/+15
| | | | | | | | | | | | This doesn't solve the problem with view-source://, that is a separate issue. BUG=35795 TEST=manual, see bug. Review URL: http://codereview.chromium.org/6574033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77020 0039d316-1c4b-4281-b951-d872f2087c98
* Move socket stream messages to content, in preparation for moving its ↵jam@chromium.org2011-03-0532-209/+307
| | | | | | | | dispatcher. In this change I also converted p2p_messages to use the new automated way of serializing structs. Review URL: http://codereview.chromium.org/6621025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77019 0039d316-1c4b-4281-b951-d872f2087c98
* Add vpn networks to network_librarystevenjb@google.com2011-03-055-74/+196
| | | | | | | | | | | First part of adding UI support for VPN BUG=chromium-os:2665 TEST=Ensure existing network functionality works, particularly network menu icon Review URL: http://codereview.chromium.org/6627022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77018 0039d316-1c4b-4281-b951-d872f2087c98
* Service process crash on Windows.scottbyer@chromium.org2011-03-051-4/+4
| | | | | | | | | | | | A crash not caught by the service process browser tests, revert the timeline of creating the proxy service on Windows to what it was previously. BUG=74992 TEST=enable cloud print proxy on Windows, service doesn't crash withing 5 minutes. Review URL: http://codereview.chromium.org/6626038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77017 0039d316-1c4b-4281-b951-d872f2087c98
* LOG(INFO)->VLOG(1)estade@chromium.org2011-03-051-4/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6627033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77016 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Paint() to PaintForDrag() in two cases.thakis@chromium.org2011-03-0512-25/+31
| | | | | | | | | | | | | | | | | | | | | | Both TextButton and MenuItemView called the method that implements their painting Paint(), which is also the name of the superclass's Paint() method. The painting stack currently looks: TextButton::Paint() TextButton::OnPaint() View::Paint() which is confusing. MenuButton overrides the method from TextButton, so rename it there, too. Also convert the 2nd parameter of this function from a bool to an enum. BUG=70465,72205 TEST=none TBR=sky Review URL: http://codereview.chromium.org/6625023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77015 0039d316-1c4b-4281-b951-d872f2087c98
* Make IndexedDB obey the SpecialStoragePolicy.jorlow@chromium.org2011-03-056-23/+58
| | | | | | | | | TEST=none BUG=60579 Review URL: http://codereview.chromium.org/6588110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77014 0039d316-1c4b-4281-b951-d872f2087c98
* importer: Some more cleanups.tfarina@chromium.org2011-03-0512-128/+89
| | | | | | | | | | | | | - Eliminate using declarations to importer::ImportItem constants. - Add OVERRIDE to StartImport implementations. - Sort #include declarations. BUG=None TEST=existing unit_tests Review URL: http://codereview.chromium.org/6625007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77013 0039d316-1c4b-4281-b951-d872f2087c98
* Add 64-bit Windows tokens to the UA string. This parallels ↵pkasting@chromium.org2011-03-051-2/+21
| | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=55226 as well as Firefox and IE. BUG=none TEST=none Review URL: http://codereview.chromium.org/6627019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77012 0039d316-1c4b-4281-b951-d872f2087c98
* Just return, don't use temps.pkasting@chromium.org2011-03-051-13/+9
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6611033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77011 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding this.ananta@chromium.org2011-03-052-5/+15
| | | | | | | | | | | | | | | | | | | Enable ChromeFrame net tests. These tests regressed with the change in the chunked upload code in net to move the formatting of individual chunks to the http network stack. This caused the URLRequestTestHTTP.TestPostChunkedDataBeforeStart test to hang in ChromeFrame. Fix is to ensure that the individual chunks are properly formatted while marshaling them over IPC. BUG=none TEST=chrome frame net tests should pass. TBR=amit Review URL: http://codereview.chromium.org/6621024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77010 0039d316-1c4b-4281-b951-d872f2087c98
* Remove note about flakiness from a test that is no longer flaky. asargent@chromium.org2011-03-051-1/+0
| | | | | | | | | | | | | | I checked the flakiness dashboard and this test hasn't failed in quite a while (other than due to times where some bad CL went into the tree that broke huge swaths of browser tests for a cycle or two before it was reverted). BUG=57378 TEST=none TBR=skerner@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77009 0039d316-1c4b-4281-b951-d872f2087c98
* fix display of filenames in file:/// URLsevan@chromium.org2011-03-053-11/+13
| | | | | | | | | | | | | | | | | | | | | | | | | (retry of previous code with tests fixed) The code attempted to shorten file:/// URLs to just the filename when displayed as the title of a page. But that appears to have regressed sometime in the past. This shortening is consistent with how we display the title of images (which are like "foo.png (123x456)".) Chrome does a poor job of displaying longer titles (most of the tab title ends up being "file:///C:/" anyway). In any case, using a FilePath to get the filename from a URL may not have even worked on Windows, where the path separator is a backslash. It appears Glen wrote the original code, Brett may be the one to have regressed it in a refactor, and I probably broke it worse in a FilePath refactor. BUG=69467 TEST=load a text file via a file: URL; tab title is just the file name Review URL: http://codereview.chromium.org/6591127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77008 0039d316-1c4b-4281-b951-d872f2087c98
* An attempt to fix the flakiness in a few UI tests.zmo@google.com2011-03-051-1/+5
| | | | | | | | | | BUG=none TEST=hope these flaky tests pass TBR=vangelis@chromium.org Review URL: http://codereview.chromium.org/6621023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77007 0039d316-1c4b-4281-b951-d872f2087c98
* Make Window class concrete (mostly).ben@chromium.org2011-03-0510-40/+261
| | | | | | | | | | | | Create NativeWindow/NativeWindowDelegate interfaces. BUG=72040 TEST=none TBR=sky Review URL: http://codereview.chromium.org/6626036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77006 0039d316-1c4b-4281-b951-d872f2087c98
* Mac print proxy out from flag.scottbyer@chromium.org2011-03-053-6/+12
| | | | | | | | | | | | | We found the issue with control of the service process, and with that fix the proxy is stable enough to be exposed. The fix also improves the Linux proxy control, but an autostarted service process on Linux still has an issue, so that remains behind the flag. BUG=74223 TEST=See that cloud print proxy is not in about:flags on the Mac, and the sign in is availble in Under the Hood. Signing in, restarting Chromium, and disabling the proxy works (removes the autostart file is the quickest visible way to verify). Review URL: http://codereview.chromium.org/6633004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77005 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 77002 - Enable ChromeFrame net tests. These tests regressed with the ↵ananta@chromium.org2011-03-052-14/+5
| | | | | | | | | | | | | | | | | | | | | change in the chunked upload code in net to move the formatting of individual chunks to the http network stack. This caused the URLRequestTestHTTP.TestPostChunkedDataBeforeStart test to hang in ChromeFrame. Fix is to ensure that the individual chunks are properly formatted while marshaling them over IPC. BUG=none TEST=chrome frame net tests should pass. Review URL: http://codereview.chromium.org/6626035 TBR=ananta@chromium.org Review URL: http://codereview.chromium.org/6628029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77004 0039d316-1c4b-4281-b951-d872f2087c98
* (1) Hook up the print button to send the pages to the default printer for ↵kmadhusu@chromium.org2011-03-0522-49/+353
| | | | | | | | | | | | | printing without displaying a native dialog. (2) Made code changes to accept a print page range from the user and to print only those specified pages. BUG=none TEST=Enable print preview on mac, provide a valid page range and make sure print button in print preview works. Review URL: http://codereview.chromium.org/6533006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77003 0039d316-1c4b-4281-b951-d872f2087c98
* Enable ChromeFrame net tests. These tests regressed with the change in the ↵ananta@chromium.org2011-03-052-5/+14
| | | | | | | | | | | | | | | | | | chunked upload code in net to move the formatting of individual chunks to the http network stack. This caused the URLRequestTestHTTP.TestPostChunkedDataBeforeStart test to hang in ChromeFrame. Fix is to ensure that the individual chunks are properly formatted while marshaling them over IPC. BUG=none TEST=chrome frame net tests should pass. Review URL: http://codereview.chromium.org/6626035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77002 0039d316-1c4b-4281-b951-d872f2087c98
* Update translations using strings from launchpad.net r141tony@chromium.org2011-03-0529-238/+1059
| | | | | | Review URL: http://codereview.chromium.org/6625029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77001 0039d316-1c4b-4281-b951-d872f2087c98
* Add a declared destructor as suggested by Clang builder.satish@chromium.org2011-03-042-0/+4
| | | | | | | | BUG=none TEST=none TBR=erg@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77000 0039d316-1c4b-4281-b951-d872f2087c98
* Hover/selection of username dropdown items should do nothingdhollowa@chromium.org2011-03-044-27/+77
| | | | | | | | | | | This changes the password autofill interaction between mouse-hover and menu item selection's interaction with the contents of the <input> text. This restores the original behavior of only modifying the <input> text when the user has explicity "accepted" the selection in the menu, as opposed to hovering over the selection or key-down/up'ing to the selection. BUG=74868 TEST=PasswordAutoFillManagerTest.SuggestionAccept Review URL: http://codereview.chromium.org/6623005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76999 0039d316-1c4b-4281-b951-d872f2087c98
* New assets for PDF progress control. Added asset for drop shadow.gene@chromium.org2011-03-0414-0/+3
| | | | | | | | | | BUG=71506 TEST=none Review URL: http://codereview.chromium.org/6626030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76998 0039d316-1c4b-4281-b951-d872f2087c98
* Make more methods on Widget non-virtual and move to NativeWidgetben@chromium.org2011-03-047-293/+331
| | | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6623025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76997 0039d316-1c4b-4281-b951-d872f2087c98
* Move infobar_delegate.[cc,h] back to chrome/browser/tab_contents.tfarina@chromium.org2011-03-0411-14/+14
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6621009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76996 0039d316-1c4b-4281-b951-d872f2087c98
* WebUI Prefs: Remove trailing colon from 'Home page'stuartmorgan@chromium.org2011-03-041-1/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6613030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76995 0039d316-1c4b-4281-b951-d872f2087c98
* Stream speech audio to server as it gets recorded, instead of waiting until ↵satish@chromium.org2011-03-0410-44/+91
| | | | | | | | | | | | | end of recording. This CL depends on http://codereview.chromium.org/6292013/ which is in review. BUG=61677 TEST=manual, invoke speech input and verify that recognition results appear as expected. Review URL: http://codereview.chromium.org/6615020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76993 0039d316-1c4b-4281-b951-d872f2087c98
* Do all OOLing in the views code. linux_views now builds clean with the clang ↵erg@google.com2011-03-0488-313/+721
| | | | | | | | | | | plugin. BUG=carnitas TEST=compiles Review URL: http://codereview.chromium.org/6622002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76992 0039d316-1c4b-4281-b951-d872f2087c98
* Register "filesystem:" as a "WebSafeScheme" to let ResourceDispatcherHost ↵adamk@chromium.org2011-03-042-0/+5
| | | | | | | | | | | service requests. BUG=74858 TEST=run test case attached to bug Review URL: http://codereview.chromium.org/6625019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76991 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanuposhima@google.com2011-03-041-25/+0
| | | | | | | | | | | | Removing outdated commented out code. TBR=anicolao@chromium.org BUG=13389 TEST=see bug. Review URL: http://codereview.chromium.org/6596082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76990 0039d316-1c4b-4281-b951-d872f2087c98
* Skip generation of stats, since code is now shared across threadsjar@chromium.org2011-03-041-0/+6
| | | | | | | | | | | | | The stats function was not written to be shared across threads, and recent use by sync on a second thread is causing it to malfunction (because it uses function level statics). r=wtc bug=74467 Review URL: http://codereview.chromium.org/6624023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76989 0039d316-1c4b-4281-b951-d872f2087c98
* Use string for hash in callbacks from safebrowsing. This makes the API more ↵lzheng@chromium.org2011-03-043-4/+5
| | | | | | | | | | | | | consistent since we pass in string in checkdownloadhash. Also DCHECK empty hashes and handle it nicely when it happens. TEST=safebrowsing related tests stays green. BUG=none Review URL: http://codereview.chromium.org/6627017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76988 0039d316-1c4b-4281-b951-d872f2087c98
* Add O2D rendering with cairo into Windows build.gangji@google.com2011-03-045-5/+49
| | | | | | Review URL: http://codereview.chromium.org/6628015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76986 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb through NetworkChangeNotifier::IsOffline() to WebKit, enablingadamk@chromium.org2011-03-0427-57/+154
| | | | | | | | | | | | | navigator.onLine and online/offline events. Only works on Windows at the moment, as IsCurrentlyOffline() is supported only by NetworkChangeNotifierWin. Most of the changes are due to the need to support two different kinds of NetworkChangeNotifier observers. Both observers currently happen to trigger on the same event, but that could change, e.g., if we store the previous online state and only notify on a change. Thus the need for two different observer interfaces, and associated Add/Remove methods. BUG=7469 TEST=Load https://bug336359.bugzilla.mozilla.org/attachment.cgi?id=220609, unplug network cable, reload, see that page changes to note offline status Review URL: http://codereview.chromium.org/6526059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76985 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 20:40:30 +0000