| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Nothing in base/ uses it, and I'm going to make some non-trivial changes to it.
TEST=none
http://crbug.com/19202
Review URL: http://codereview.chromium.org/164428
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165410
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test was checking that the system host resolver maintains an internal cache, by doing actual DNS resolves (which introduces a network dependency in the unit tests). This could be flaky on linux, which doesn't cache resolves.
As of r18236 however, chromium maintains its own host cache. So the DNS prefetcher does not need to rely on the OS caching DNS resolves in order to be a win.
BUG=http://crbug.com/18766
Review URL: http://codereview.chromium.org/164350
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Send crashes to Apple Crash Reporters so we get a nice UI to restart the Browser process if it crashes.
BUG=9231
TEST=Induce a browser crash in a Chrome build, Apple Crash reporter UI should appear aftera few seconds. Induce a renderer crash, no UI should be displayed.
Review URL: http://codereview.chromium.org/164433
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165405
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://www.google.com/codesearch/p?hl=en&sa=N&cd=2&ct=rc#eSCqYNcHl48/gtk%2B-2.4.10/gdk/gdkevents.c&q=gdk_event_get_time
Review URL: http://codereview.chromium.org/164429
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
requests through automation to receive persistent cookies from the automation client. These cookies are passed in when the automation client notifies Chrome that a HTTP request was started.
The URLRequestAutomationJob object now informs Chrome whether an automation URL request was redirected.
The ExternalTabContainer now handles the NEW_FOREGROUND_TAB and displays a popup window in response. This gets around an ASSERT.
This fixes bug http://b/issue?id=2048046
Bug=2048046
Review URL: http://codereview.chromium.org/165350
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164401
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
tests.
BUG=12140
Review URL: http://codereview.chromium.org/164335
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Reported by Julien Tinnes)
Because the chroot helper process and the zygote share a FILES
structure, the latter can race the former and change the value of cwd
before it does chroot("."). Because of this, the zygote could chroot
into a directory of its choosing. Once there, it could setup hardlinks
to SUID binaries and possibly make them misbehave if they weren't
sufficiently paranoid.
This possibility should have been migigated by the removal of
dangerous environment variables. However, we had to reinstate them in
order to pass LD_LIBRARY_PATH because some setups don't have ld.so
setup to use /usr/lib32 and also for ffmpeg.
http://codereview.chromium.org/164427
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Location").
Patch by viettrungluu.
BUG=http://crbug.com/19172
TEST=Go to File menu and look.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Create a working desktop shortcut. For now it displays no UI, but the backend works.
TEST=none
http://crbug.com/17251
Review URL: http://codereview.chromium.org/164280
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/17402
TEST=Enter text in the omnibox and resize the window. Popup size should follow.
Review URL: http://codereview.chromium.org/165332
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/17569
TEST=none
TBR=agl
Review URL: http://codereview.chromium.org/164422
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and Chromium's definitions of LOG. This is necessary after WebKit r47092
exposed its LOG in a few more places.
BUG=0
TEST=WebKit Canaries come back to life
Review URL: http://codereview.chromium.org/164421
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
v8::RegisterExtension()
BUG=19191,19196
TEST=valgrind ui bot 1 of 3 green more often
Review URL: http://codereview.chromium.org/165401
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is enabled, but the run-time flag is disabled.
1) Added a new class WebApplicationCacheHost and a factory method on WebKitClient.
2) Provide an implementation of WebCore's ApplicationCachHost class that calls out to chrome thru the new WebKit API.
3) Added new files to gyp and turned on the compile-time ENABLE(OFFLINE_WEB_APPLICATIONS) flag.
4) Turned on the compile-time flag for v8 bindings in build-generated-files.sh
4) Disabled the run-time appliation_cache_enabled settings in the test shell for now.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bar.
It turns out that the frame is in the DelayedMenuButton's coordinate
system, but a fudge is needed to make things line up. (I don't
understand these fudges, especially vertically.)
Patch by viettrungluu.
BUG=http://crbug.com/19174
TEST=Surf a bit, check back menu with and without bookmark bar.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Localize the menu bar titles.
Have the browser platform delegate startup the resource bundle system so we can fetch localization data.
Make l10n_util::GetApplicationLocale return what cocoa says for the language so we match what the UI is using.
TEST=everything still works.
BUG=17380
Review URL: http://codereview.chromium.org/164413
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New fork and possible patches from Timur.
Accept new xml output format.
Use --xml-file option if present.
Drop two patches already in trunk.
Remove obsolete --generate_suppressions code.
Accept but ignore --generate_dsym option on non-darwin platforms, so scripts don't need conditionals
Switch to using svn revision numbers rather than dates,
because svn uses the local timezone to interpret the dates,
and this caused patches to fail. Feh.
Check to make sure a good copy of valgrind was found before trying to
use valgrind.
Review URL: http://codereview.chromium.org/160392
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=cmp
BUG=19002
Review URL: http://codereview.chromium.org/165400
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165398
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164412
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Partially based on patch by Dan Kegel.
Review URL: http://codereview.chromium.org/164371
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This feature is better implemented as an extension rather than being put into
the absolute-core UI.
Review URL: http://codereview.chromium.org/164301
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
not doing the cleanup that happens in real life.
BUG=19002
TEST=SyncSetupWizardTest
Review URL: http://codereview.chromium.org/164370
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=sgk
Review URL: http://codereview.chromium.org/164406
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/18471
TEST= Open new tab page in any theme, click "Change page layout" dropdown menu, note that text is always blue on white.
Review URL: http://codereview.chromium.org/165389
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=dglazkov@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/164384
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164404
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Constness of return values and paramaters were causing compiler errors.
BUG=19120
ISSUE=164373
Review URL: http://codereview.chromium.org/164414
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Covered by net_unittests.
http://crbug.com/19095
Review URL: http://codereview.chromium.org/164354
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This required making it so that extension_api.json definitions defer to existing bindings so that the chrome.extension object can remain setup in renderer_extension_bindings.js.
Also fixed a minor bug with error handling in the api_generator.js
Moved "Port" type to the new extension module.
Removed a bunch of trailing whitespace from the extension_api.json.
Review URL: http://codereview.chromium.org/165323
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
cross-platform file that is not used for CG.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164411
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
is gone.
BUG=8044
TEST=Dock icon still works properly
Review URL: http://codereview.chromium.org/165384
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also clean up the Tree is closed presubmit check (CheckTreeIsOpen).
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/165251
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=wtc
http://crbug.com/18697
Review URL: http://codereview.chromium.org/164410
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=wtc
http://crbug.com/18697
Review URL: http://codereview.chromium.org/165391
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=2047272
TEST=none
Review URL: http://codereview.chromium.org/164353
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=See bug.
http://crbug.com/18697
Review URL: http://codereview.chromium.org/165386
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also uses the new consistent border color in GTK theme mode.
Review URL: http://codereview.chromium.org/165356
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium:
* First run no longer displays every time you launch Chromium.
* Enable Stats checkbox hidden (it doesn't do anything anyway in Chromium).
General:
* Import popup menu disables with checkbox.
BUG=19163,19171
Review URL: http://codereview.chromium.org/165387
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the following error when building for x64 targets:
base/third_party/nspr/prtime.cc: In function 'PRTime PR_ImplodeTime(const
PRExplodedTime*)':
base/third_party/nspr/prtime.cc:173: error: integer overflow in expression
base/third_party/nspr/prtime.cc:176: error: integer overflow in expression
PRTime is long long (8 bytes) on ia32, and long (8 bytes) on x64. On ia32,
LONG_MAX (4 bytes) converted to microseconds fits in the PRTime type, but
on x64 LONG_MAX is 8 bytes and so overflows the PRTime type on conversion.
Avoid these issues by only returning INT_MAX. On ia32 this is the correct
value, and does not change behaviour. On x64 the call to timegm() will always
succeed due to the increased range of time_t, so the error condition of -1
should never be reached.
Fix a bug in the conditional expression for 1 second before epoch.
Patch by Joel Stanley
Original review URL: http://codereview.chromium.org/160511
R=dean,wtc
BUG=18231
TEST=new unit test
Review URL: http://codereview.chromium.org/164366
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
initialized data even if the system is totally unable to service the request.
BUG=19000
Review URL: http://codereview.chromium.org/164388
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL improves key event handling of AutocompleteEditViewGtk class, following changes have been made:
1. Avoid accessing private data member of GtkTextView object, including im_context, need_im_reset etc.
2. Always send key events to the default handler of GtkTextView before handling them by ourselves, to make sure the behavior of IME and GtkTextView are always correct. This fixes the issue of moving focus from omnibox to webpage by pressing Tab key when using XIM im module.
3. Intercept "insert-text" signal of GtkTextBuffer object to prevent any unwanted characters from being inserted into omnibox.
4. Intercept "backspace" signal of GtkTextView object to fix issue 19068: [Linux] Search keywords: Backspace should exit out of search mode
BUG=18393: AutocompleteEditViewGtk should not access private members of GtkTextView
BUG=19068: [Linux] Search keywords: Backspace should exit out of search mode
TEST=Starts a XIM input method, such as scim then open chrome with GTK_IM_MODULE=xim. Opens a webpage and press tab and shift-tab in omnibox to see if focus can be moved to/from webpage correctly.
TEST=Copy & paste some text with new line characters to omnibox to see if new line characters are filtered.
TEST=Turn on keyword search mode, press backspace to see if it can exit keyword search mode.
TEST= Turn on keyword search mode, input some text then press backspace to delete a character, to see if it still in keyword search mode. Then move the cursor to the beginning of the text and press backspace, to see if it exits keyword search mode correctly.
Review URL: http://codereview.chromium.org/164142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=19086,...
Review URL: http://codereview.chromium.org/164398
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165379
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=17400
Review URL: http://codereview.chromium.org/164318
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23181 0039d316-1c4b-4281-b951-d872f2087c98
|