summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Follow up to my previous CL for adding IDS_UI_FONT resources to ↵cira@chromium.org2009-06-1950-225/+0
| | | | | | | | | | | | | app_locale_settings. Removing duplicate IDS_UI_FONT_ from locale_settings (already present in app_locale_settings). There are no code changes. BUG=http://crbug.com/7319 TEST=No test case, since we are removing dupes. The only check is to make sure code compiles (and it does). Review URL: http://codereview.chromium.org/131060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18838 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: Fix Toolstrips sometimes show scrollbars as renderingaa@chromium.org2009-06-1910-11/+45
| | | | | | | See: http://codereview.chromium.org/126098 Patch from Jerry Tang <tangjie@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18837 0039d316-1c4b-4281-b951-d872f2087c98
* Disable flaky UI test.jparent@chromium.org2009-06-191-1/+2
| | | | | | | BUG=14731 Review URL: http://codereview.chromium.org/138001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18836 0039d316-1c4b-4281-b951-d872f2087c98
* Comments added to SSL unit tests.jrg@chromium.org2009-06-192-0/+35
| | | | | | Review URL: http://codereview.chromium.org/132081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18835 0039d316-1c4b-4281-b951-d872f2087c98
* linux: make extensions service test pass in Debug.evan@chromium.org2009-06-192-5/+3
| | | | | | | | | | | It only passes on the build bots because they still have old directories, I think? AbsolutePath() on POSIX will fail if the path doesn't exist. We let the program march on in that case and the normal error handling (that would handle the non-existent path) make the tests continue to pass. Review URL: http://codereview.chromium.org/132054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18834 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor FFmpegDemuxerTest to use gmock and eliminate flakiness.scherkus@chromium.org2009-06-195-438/+569
| | | | | | | | | | | | | | | This eliminates all final traces of the old global-functions-and-variables style of mocking, which was a massive headache to maintain and verify correctness. No new tests have been added, however gmock creates much stronger assertions for the tests themselves. I also made FFmpegDemuxerTest a friend of FFmpegDemuxer to let tests verify that all tasks on the internal demuxing thread have completed. BUG=13933 TEST=FFmpegDemuxerTest should more awesome and less flaky Review URL: http://codereview.chromium.org/126306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18833 0039d316-1c4b-4281-b951-d872f2087c98
* Only select scalable fonts. Fixed-size fonts don't work with ↵thestig@chromium.org2009-06-191-0/+10
| | | | | | | | | | FT_Set_Char_Size in SkFontHost_FreeType.cpp. BUG=13007 TEST=On Linux, visit url with { font-family: fixed; } on a computer with pcf fonts. Review URL: http://codereview.chromium.org/131096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18832 0039d316-1c4b-4281-b951-d872f2087c98
* Add "Show all downloads" link to download shelf.thakis@chromium.org2009-06-193-6/+341
| | | | | | | | | | | BUG=14665 TEST=Download something, check that "show all downloads" text is on shelf, click it, check that the downloads tab opens. Review URL: http://codereview.chromium.org/132073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18831 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Fallback to SSL if server closes early during TLS handshake.willchan@chromium.org2009-06-191-1/+8
| | | | | | | | | BUG=http://crbug.com/14092 TEST=See bug for example TLS-intolerant server. Review URL: http://codereview.chromium.org/131085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18830 0039d316-1c4b-4281-b951-d872f2087c98
* Use correct calling convention for intercepted callcpu@google.com2009-06-191-2/+4
| | | | | | | | | | | - Thanks to zhu.she.pi@gmail.com for finding the bug BUG=14631 TEST=no test Review URL: http://codereview.chromium.org/131066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18827 0039d316-1c4b-4281-b951-d872f2087c98
* Add to watchlist.kuchhal@chromium.org2009-06-191-0/+8
| | | | | | Review URL: http://codereview.chromium.org/132076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18826 0039d316-1c4b-4281-b951-d872f2087c98
* Add merging algorithm for keychain and metadata db PasswordForms, and unit ↵stuartmorgan@chromium.org2009-06-193-0/+440
| | | | | | | | | | | | tests for it. Not used quite yet, since the metadata database still needs to be integrated into PasswordStoreMac. BUG=none TEST=none Review URL: http://codereview.chromium.org/131076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18825 0039d316-1c4b-4281-b951-d872f2087c98
* Add a suppression for couple of valgrind warnings in OpenGL.framework ↵stuartmorgan@chromium.org2009-06-191-0/+7
| | | | | | | | | | initialization. BUG=none TEST=Run ui_tests under valgrind; see fewer warning that we can't fix. Review URL: http://codereview.chromium.org/131081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18824 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak when we bail out early because of the wrong bpp.jhawkins@chromium.org2009-06-191-1/+3
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/131118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18823 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile error.pinkerton@chromium.org2009-06-191-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18822 0039d316-1c4b-4281-b951-d872f2087c98
* Make escape close the prefs window.pinkerton@chromium.org2009-06-191-0/+7
| | | | | | | | BUG=none TEST=fields in the middle of being editing should not save the value. Review URL: http://codereview.chromium.org/131113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18821 0039d316-1c4b-4281-b951-d872f2087c98
* Add a temporary command-line switch --auto-ssl-client-auth forwtc@chromium.org2009-06-194-4/+34
| | | | | | | | | | | | | | | | | automatically selecting a client certificate when an SSL server requests client authentication. This switch will be removed when we implement client certificate selection UI. Also fix some cpplint.py nits. R=jcampan BUG=http://crbug.com/318 TEST=none Review URL: http://codereview.chromium.org/131090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18819 0039d316-1c4b-4281-b951-d872f2087c98
* DEPS roll to revert gyp change that broke Chromium Linux builder.sgk@google.com2009-06-191-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/131117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18818 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Enable 'Inspect element' on chromeui content while in debug mode.pfeldman@chromium.org2009-06-191-1/+6
| | | | | | Review URL: http://codereview.chromium.org/132071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18817 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: make import warning dialog modal.kuchhal@chromium.org2009-06-194-3/+14
| | | | | | | | | | | | Make ImporterHost aware of the current parent window and use that as parent for the warning dialog. BUG=13481 TEST=Start Firefox, try to import profile in Chrome and make sure the warning dialog is modal. Review URL: http://codereview.chromium.org/131080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18816 0039d316-1c4b-4281-b951-d872f2087c98
* Add Print Selection support to Chrome. This change is fairly involved since ↵sverrir@google.com2009-06-1920-128/+162
| | | | | | | | | | | | | | | | this means that the printing is done async instead of the fully synchronous mode the normal full page printing is. This means we create an in memory copy of the selected text for printing. This is the next step to move to fully async printing with print frame support. This change also removes the print on demand functionality that was no longer used. BUG=http://crbug.com/1682 TEST=The print dialog on Windows now contains an option to print selection only. Test that with various pages and various selections. Review URL: http://codereview.chromium.org/125082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18815 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the mode we pull events in, so we don't fire off timers and ↵avi@google.com2009-06-191-3/+5
| | | | | | | | | | | notifications. BUG=http://crbug.com/14609 TEST=No immediate test; see that the specified crash in the bug report stops happening. Review URL: http://codereview.chromium.org/132070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18814 0039d316-1c4b-4281-b951-d872f2087c98
* Add 'theme_dll' as a dependency of 'chrome_dll'.sgk@google.com2009-06-192-4/+2
| | | | | | | | | gyp DEPS roll so loadable_module targets ignore import libraries. BUG=none TEST=none Review URL: http://codereview.chromium.org/131109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18813 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the redness on the new Google Chrome continuous builder by notnsylvain@chromium.org2009-06-191-1/+3
| | | | | | | | running the mini_installer_tests that need to access the previous installers, since they are not accessible from this buildbot. Review URL: http://codereview.chromium.org/131070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18812 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline some Linux specific layout test differences from r18803.deanm@chromium.org2009-06-1912-6/+6
| | | | | | | | | | | | Skia's gradient drawing has changed a slight bit. None of the differences are noticable visually. These changes were specific to Linux and didn't happen on Windows since we use Skia gradients for drawing our form buttons on Linux. Inspected each difference manually, and they look ok. Review URL: http://codereview.chromium.org/131111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18811 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: add fake callframe for live object expansion in console.pfeldman@chromium.org2009-06-191-1/+7
| | | | | | Review URL: http://codereview.chromium.org/132068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18810 0039d316-1c4b-4281-b951-d872f2087c98
* Display an infobar alert when extension process crashes.phajdan.jr@chromium.org2009-06-199-32/+190
| | | | | | | | | | | | Also correctly handle crashes in task manager. The infobar allows user to restart the extension process. TEST=Install buildbot extension, see its content in the shelf. Open task manager, kill extension process. Click "restart" in the infobar that should appear. The extension content in the shelf should re-appear after the crash. http://crbug.com/14111 Review URL: http://codereview.chromium.org/126289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18809 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline Linux layout tests for the Skia roll in r18803.deanm@chromium.org2009-06-1952-26/+26
| | | | | | | Review URL: http://codereview.chromium.org/131110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18808 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: remove dock/undock buttonpfeldman@chromium.org2009-06-191-1/+5
| | | | | | | BUG=25 Review URL: http://codereview.chromium.org/131108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18807 0039d316-1c4b-4281-b951-d872f2087c98
* Implement restoring closed tab menu item. Reworked cross-platform code to ↵pinkerton@chromium.org2009-06-1910-80/+181
| | | | | | | | | | handle the case of restoring when there are no browsers open by making window restore re-use a given browser if it has no tabs. Removed unit test that assumes it can pass a NULL Browser. Wrote a new UI test to cover the same area, but it's disabled until another bug is fixed, and I didn't want to hold up landing this feature. Added key shortcut for "open window in incognito mode". BUG=13758 TEST=restoring closed tabs with visible windows and with no windows remaining open. Review URL: http://codereview.chromium.org/125257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18806 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: fix crash when inspect element invoked on the root element.pfeldman@chromium.org2009-06-191-4/+4
| | | | | | Review URL: http://codereview.chromium.org/131106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18805 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary devtool_sanity_unittest.cc entries from 'unit_tests'.sgk@chromium.org2009-06-191-4/+0
| | | | | | | | BUG=14639 TEST=none Review URL: http://codereview.chromium.org/132067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18804 0039d316-1c4b-4281-b951-d872f2087c98
* Roll Skia up to r224, for a few bug fixes.deanm@chromium.org2009-06-1983-42/+42
| | | | | | | | | | | | | | | Most importantly this fixes a spline drawing error and a possible Linux crash when failing to load a font. The rebaselines are mostly due to minor gradient changes (Skia changes r212 and r213). There was one layout test that was hitting the spline drawing bug, and the results now look correct (svg-as-background-5.html). BUG=13007,14536 Review URL: http://codereview.chromium.org/131105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18803 0039d316-1c4b-4281-b951-d872f2087c98
* Don't grant unnecessary handle privileges in OpenProcessHandle.phajdan.jr@chromium.org2009-06-194-9/+8
| | | | | | | | | This patch makes it harder for process handles with more privileges to leak to untrusted places. Review URL: http://codereview.chromium.org/125260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18802 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a valgrind error related to Zygote's CommandLine usage.craig.schlenter@chromium.org2009-06-193-5/+12
| | | | | | | | Also touch up some include guards and a comment. Review URL: http://codereview.chromium.org/131054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18801 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: add devtools.css to webkit.gyp. It should have been added as part ↵yurys@google.com2009-06-193-3/+4
| | | | | | | | of http://codereview.chromium.org/125116 Review URL: http://codereview.chromium.org/131103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18800 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools Profiler: Fix parsing of duplicate function names.mnaganov@chromium.org2009-06-191-1/+5
| | | | | | | | | | | If there are several functions with the same name, their names are suffixed with "{<counter>}". I forgot about this, and it resulted in emitting wrong URLs for them. BUG=none TEST=none Review URL: http://codereview.chromium.org/132065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18799 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 1.2.8.2.sgjesse@chromium.org2009-06-191-1/+1
| | | | | | Review URL: http://codereview.chromium.org/131098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18798 0039d316-1c4b-4281-b951-d872f2087c98
* Test expectation update due to the WebKit merge 44805:44837.levin@chromium.org2009-06-191-2/+1
| | | | | | | | | | TBR=paul@chromium.org BUG=None TEST=None Review URL: http://codereview.chromium.org/132064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18797 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline tests due to the merge 44805:44837. levin@chromium.org2009-06-193-2/+6
| | | | | | | | | | | | The rebaseline is due to http://trac.webkit.org/changeset/44806 which did a vertical alignment change. TBR=paulg BUG=None TEST=None Review URL: http://codereview.chromium.org/132062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18796 0039d316-1c4b-4281-b951-d872f2087c98
* Fix: New window appears to the left/up if the taskbar is on left/top.yuzo@chromium.org2009-06-193-8/+25
| | | | | | | | | | | | | | | | | Currently, the Windows taskbar (put differently, work area) is not considered in getting the last window bounds (while it is for the saved window bounds). This causes new windows (CTRL-N) appear to the left/up of the existing window instead of right/down, if the taskbar is on left or top. TESTED=gcl try, manually TEST=Place the taskbar on left or top of the screen and create new Chrome windows by CTRL-N and observe. BUG=14131 Review URL: http://codereview.chromium.org/125179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18795 0039d316-1c4b-4281-b951-d872f2087c98
* When we upgrade, discard all uploadable stats, including old logsjar@chromium.org2009-06-191-0/+8
| | | | | | | | | | | | | | We already discard all stability info when we do an upgrade to a new version, as there is less concern about stats from old versions. This change just adds the list of "old logs" (gathered in previous sessions, presumably with an old version) to the list of data that is discarded. BUG=14657 r=evanm Review URL: http://codereview.chromium.org/131089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18794 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: when script has URL all breakpoints are set using that URL and ↵yurys@google.com2009-06-191-26/+65
| | | | | | | | | line number, otherwise breakpoint is set using script id and line number. Breakpoints set using URL will survive page reload. BUG=13675 Review URL: http://codereview.chromium.org/131036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18793 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline tests due to the merge 44805:44837.levin@chromium.org2009-06-1923-58/+249
| | | | | | | | | | | | | | | | The majority of these have to do http://trac.webkit.org/changeset/44806 which did a vertical alignment change. become-overlay-composited-layer is a new result due to a new test added by http://trac.webkit.org/changeset/44817. BUG=None TEST=None TBR=paulg Review URL: http://codereview.chromium.org/132061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18792 0039d316-1c4b-4281-b951-d872f2087c98
* This is a fix for a memory leak.jcampan@chromium.org2009-06-192-2/+4
| | | | | | | | | | AutocompletePopupWin would be leaked when the browser view is closed. BUG=None TEST=Make sure Chrome can be opened/closed without crasher. Review URL: http://codereview.chromium.org/132050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18791 0039d316-1c4b-4281-b951-d872f2087c98
* Change URL back to the previous one if the typed URL causes file download.yuzo@chromium.org2009-06-191-0/+7
| | | | | | | | | | | | | | | | | | This is the successor to http://codereview.chromium.org/115704 TESTED=manually TEST=Type any URL that causes download, e.g., ftp://ftp.vim.org/pub/vim/pc/gvim72.zip into the omnibox. Without this change the URL remains there. With this change, the URL is changed back to the original one. BUG=1904 Review URL: http://codereview.chromium.org/126266 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18790 0039d316-1c4b-4281-b951-d872f2087c98
* Convert unit_tests.exe, with additional dependency on ffmpegsgk@google.com2009-06-191-2/+13
| | | | | | | | | | | | | | | (for dependencies on avcode-52.lib et al.). Adds additional system libraries (urlmon.lib and winmm.lib). Disables (excludes from the build) four modules with build or runtime errors: browser/debugger/devtools_sanity_unittest.cc browser/extensions/extensions_service_unittest.cc browser/password_manager/login_database_unittest.cc common/extensions/extension_unittest.cc BUG=none TEST=none Review URL: http://codereview.chromium.org/126180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18789 0039d316-1c4b-4281-b951-d872f2087c98
* A crasher from the field seems to indicate that the page render widget host ↵jcampan@chromium.org2009-06-191-1/+2
| | | | | | | | | | view win can get the focus after the TabContents delegate has been NULLed. BUG=http://crbug.com/14599 TEST=Exercise closing tabs with on-unload handlers. Review URL: http://codereview.chromium.org/132052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18788 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 44805:44837levin@chromium.org2009-06-1958-381/+11
| | | | | | | | | | | | The deletions of results are due to conversions of test to be dumpAsText tests. TBR=paulg BUG=none TEST=none Review URL: http://codereview.chromium.org/132057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18787 0039d316-1c4b-4281-b951-d872f2087c98
* Implement window open disposition for (some) navigation buttons.estade@chromium.org2009-06-196-5/+92
| | | | | | | | | | still need to do similar for link buttons and such. BUG=14518 Review URL: http://codereview.chromium.org/131071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18786 0039d316-1c4b-4281-b951-d872f2087c98