summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Document how we avoid running leaky tests under Purify and Valgrind,dkegel@google.com2009-03-183-0/+20
| | | | | | | | and copy Purify's list of leaky net tests for Valgrind's benefit. Review URL: http://codereview.chromium.org/42309 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12042 0039d316-1c4b-4281-b951-d872f2087c98
* Fix single-process ui test failures from my previous change. The problem ↵jam@chromium.org2009-03-186-12/+13
| | | | | | | | | was that the wrong pid was being sent to RDH from RMF. It needs to be the fake pid for the in-process renderer. BUG=8890 Review URL: http://codereview.chromium.org/42366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12040 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor sandboxing code so that it can be used by worker processes.jam@chromium.org2009-03-189-244/+216
| | | | | | Review URL: http://codereview.chromium.org/42311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12038 0039d316-1c4b-4281-b951-d872f2087c98
* Added a debug method AssertAcquired() that compiles to nothing in non-debug ↵ralphl@chromium.org2009-03-183-28/+49
| | | | | | | | | | | | | | | | | builds. In debug builds, the method will DCHECK if the current thread does not hold the lock. I also removed a class that was not being used (AutoLockImpl) which seems like someone just copied the Lock.h file and blindly added an Impl for the AutoLock class. Thre are places in my code where I want to use the AutoUnlock class. I can't see why it was restricted to use by the condition variable class only, so I just made it into a regular class with no restrictions. I noticed that JamesR posted a CL about a month ago that made AutoUnlock a public class, but it was never committed, so I added him to this CL for review too. Review URL: http://codereview.chromium.org/48109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12037 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing 'return true' to stop switch fall though.agl@chromium.org2009-03-181-0/+1
| | | | | | | | | (found by Coverity) Review URL: http://codereview.chromium.org/42370 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12035 0039d316-1c4b-4281-b951-d872f2087c98
* Navigating to about:memory page from Task manager should bring up thetc@google.com2009-03-181-0/+2
| | | | | | | | | | | | | | | minimized browser window. BUG=4557 ( http://crbug.com/4557 ) Original patch by Mohamed Mansour <m0.interactive@gmail.com> in http://codereview.chromium.org/42208/show Review URL: http://codereview.chromium.org/48167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12034 0039d316-1c4b-4281-b951-d872f2087c98
* This is a follow-up for enabling workers in Win build.dimich@google.com2009-03-181-1/+1
| | | | | | Review URL: http://codereview.chromium.org/42344 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12033 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix crash when renderer asks for the location of a NULL windowagl@chromium.org2009-03-181-0/+5
| | | | | | | | | | | There are cases where the renderer asks for the root rectangle of its window before we have a window for it. Since we still have the NativeViewId hack in place, this previously caused a crash. Review URL: http://codereview.chromium.org/42356 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12032 0039d316-1c4b-4281-b951-d872f2087c98
* DEFERs the testsky@google.com2009-03-181-3/+2
| | | | | | | | | | | | | | | LayoutTests/http/tests/xmlhttprequest/web-apps/013.html. We're now failing this because of differences in how lighthttpd behaves vs apache. I'ved filed http://code.google.com/p/chromium/issues/detail?id=8941 to track it. BUG=none TEST=none TBR=finnur Review URL: http://codereview.chromium.org/48159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12031 0039d316-1c4b-4281-b951-d872f2087c98
* Check return values for ReadInt in SSL manageragl@chromium.org2009-03-181-4/+3
| | | | | | | | | (found by Coverity) Review URL: http://codereview.chromium.org/42369 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12030 0039d316-1c4b-4281-b951-d872f2087c98
* Fix no-op DCHECKagl@chromium.org2009-03-181-1/+1
| | | | | | | | | | | new_name_count_ is unsigned, so checking for >= 0 is useless. (Found by Coverity) Review URL: http://codereview.chromium.org/48152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12029 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: A few minor fixes to make coverity happy.rvargas@google.com2009-03-184-4/+8
| | | | | | Review URL: http://codereview.chromium.org/48155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12028 0039d316-1c4b-4281-b951-d872f2087c98
* Check return value of SharedMemory::Createagl@chromium.org2009-03-181-3/+3
| | | | | | | | | (found by Coverity) Review URL: http://codereview.chromium.org/42367 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12027 0039d316-1c4b-4281-b951-d872f2087c98
* Mark more tests as passing based on Anders' flips document.pkasting@chromium.org2009-03-181-12/+2
| | | | | | Review URL: http://codereview.chromium.org/48154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12026 0039d316-1c4b-4281-b951-d872f2087c98
* Fix possible memory leak.agl@chromium.org2009-03-181-3/+4
| | | | | | | | | (Coverity discovered it.) Review URL: http://codereview.chromium.org/49002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12025 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: build fix for systems without inotify headersagl@chromium.org2009-03-182-0/+31
| | | | | | | Review URL: http://codereview.chromium.org/42363 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12024 0039d316-1c4b-4281-b951-d872f2087c98
* Update Mac layout failures list.dglazkov@google.com2009-03-181-2/+10
| | | | | | | | TBR=jeremy Review URL: http://codereview.chromium.org/48165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12023 0039d316-1c4b-4281-b951-d872f2087c98
* CreateResourceRequest() inhclam@chromium.org2009-03-181-0/+1
| | | | | | | | | | | | | | | chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc is not updated when |request_context| is added to ViewHostMsg_Resource_Request. In r11816 CreateResourceRequest() is used to prepare ViewHostMsg_Resource_Request with |request_context| uninitialized, giving the purify bot red. Initializing the variable should fix the UMR error. Review URL: http://codereview.chromium.org/42360 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12021 0039d316-1c4b-4281-b951-d872f2087c98
* Update LINUX/MAC expectations.dglazkov@google.com2009-03-181-2/+10
| | | | | | | | TBR=ojan Review URL: http://codereview.chromium.org/48158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12019 0039d316-1c4b-4281-b951-d872f2087c98
* Update my so-called fix by including expectation.dglazkov@google.com2009-03-181-1/+1
| | | | | | | | TBR=ojan Review URL: http://codereview.chromium.org/42365 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12018 0039d316-1c4b-4281-b951-d872f2087c98
* Yet another test list update, skipping font-specific test.dglazkov@google.com2009-03-181-0/+3
| | | | | | | | TBR=ojan Review URL: http://codereview.chromium.org/42364 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12017 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/42288georged@chromium.org2009-03-1820-214/+548
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12016 0039d316-1c4b-4281-b951-d872f2087c98
* Fix test list.dglazkov@google.com2009-03-181-3/+3
| | | | | | | | TBR=finnur Review URL: http://codereview.chromium.org/48153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12015 0039d316-1c4b-4281-b951-d872f2087c98
* Bug 4688: First run bubble ignores user's keyboard attemptfinnur@chromium.org2009-03-182-10/+43
| | | | | | | | | | | | | | | | (tab) to change Search Engine. Not a good first impression. BUG=4688 TEST=Open Chrome using --first-run, press Cancel on the import dialog and watch the First Run bubble come up. Use Tab and then Enter and the Change Search Engine should appear. Then try it again, but this time click outside the bubble to dismiss it (corner case that could lead to a crash). Review URL: http://codereview.chromium.org/48138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12014 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Merge 41768:41807, Chromium Sidedglazkov@google.com2009-03-1890-648/+759
| | | | | | | | R=ojan Review URL: http://codereview.chromium.org/42352 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12013 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix scrollingagl@chromium.org2009-03-181-6/+18
| | | | | | | | | | | I had assuming that we always scroll the whole window; I was wrong. This patch fixes issues with 'ghost' scrollbars appearing when the window looses focus and with huge misrendering when scrolling iframes. Review URL: http://codereview.chromium.org/42357 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12012 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline the passing test.amit@chromium.org2009-03-182-1/+11
| | | | | | | | | | The test fails in webkit and the expected.txt contains failure output. We work fine so just rebaseline till it is fixed upstream. Review URL: http://codereview.chromium.org/42353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12010 0039d316-1c4b-4281-b951-d872f2087c98
* Ports all of the chrome/browser/history code to use FilePath, exceptestade@chromium.org2009-03-1825-168/+172
| | | | | | | | | | | | | for DownloadDatabase, InMemoryDatabase, and RedirectUiTest. Except for in those files, we now only use std::wstring for text strings. This CL also enables two more unittests on Mac. patch by Rohit Rao. http://codereview.chromium.org/48018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12009 0039d316-1c4b-4281-b951-d872f2087c98
* New native control helpers. Built but not run by anyone just yet. See design docben@chromium.org2009-03-187-0/+794
| | | | | | | | http://dev.chromium.org/developers/design-documents/native-controls Review URL: http://codereview.chromium.org/48094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12008 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup in DirectoryWatcher:phajdan.jr@chromium.org2009-03-183-68/+63
| | | | | | | | | | | - share more code between different platforms - put more code inside anonymous namespace - add more DISALLOW_COPY_AND_ASSIGNs - small #include cleanup Review URL: http://codereview.chromium.org/42343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12007 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing chrome/fast/dom/java-applet-calls.htmlfinnur@chromium.org2009-03-182-9/+7
| | | | | | | | | | | | | | | I don't understand how the test could have worked because if you don't specify a CODEBASE for the Java Applet the default is the url. In the Java console I was seeing it try to load the class by appending the TestApplet to the path to the html file (the layout test file). By specifying "." as the CODEBASE it is able to find and load the class that resides in the same directory and all is well. Review URL: http://codereview.chromium.org/48148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12005 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline test for aa. Was incorrectly rebased last time around.ojan@google.com2009-03-181-7/+7
| | | | | | Review URL: http://codereview.chromium.org/48146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12004 0039d316-1c4b-4281-b951-d872f2087c98
* Allow Skia to build on case-sensitive filesystemsmark@chromium.org2009-03-181-1/+1
| | | | | | Review URL: http://codereview.chromium.org/42350 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12003 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more generic pattern for the `anonymous namespace'::PureCall crash.patrick@chromium.org2009-03-181-1/+1
| | | | | | Review URL: http://codereview.chromium.org/42338 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12002 0039d316-1c4b-4281-b951-d872f2087c98
* A few updates to the valgrind runner script.deanm@chromium.org2009-03-181-1/+3
| | | | | | | | | | | - Add G_DEBUG=fatal_warnings to abort on GTK assertions. - Find the suppressions file no matter where you run the script from. - Add +x on the script. Review URL: http://codereview.chromium.org/45011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12001 0039d316-1c4b-4281-b951-d872f2087c98
* DEFER a test that is broken upstream.tc@google.com2009-03-185-9/+3
| | | | | | | | | | | | | The test tries to load a file:/// URL from a data: URL. This isn't allowed in Chromium but it is in Safari. The test really doesn't have anything to do with security checks so we should fix the test upstream instead. I'm deleting the existing pixel baseline because they're wrong (missing the image because of the security check mentioned above). Review URL: http://codereview.chromium.org/42349 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12000 0039d316-1c4b-4281-b951-d872f2087c98
* The test suite commandline leak is easy to plug, so we may as well.dkegel@google.com2009-03-181-1/+3
| | | | | | | | | | | | | | | | | Fixes 244 bytes in 5 blocks are possibly lost in loss record 57 of 97 at operator new(unsigned int) m_replacemalloc/vg_replace_malloc.c:230 by std::string::_Rep::_S_create(unsigned int, unsigned int, std::allocator<char> const&) (in libstdc++.so.6.0.9) by (within libstdc++.so.6.0.9) by std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(char const*, std::allocator<char> const&) (in libstdc++.so.6.0.9) by CommandLine::CommandLine(int, char const* const*) src/base/command_line.cc:96 by CommandLine::Init(int, char const* const*) src/base/command_line.cc:177 by TestSuite::TestSuite(int, char**) src/base/test_suite.h:34 Review URL: http://codereview.chromium.org/42341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11999 0039d316-1c4b-4281-b951-d872f2087c98
* Make startup_tests build and work on Mac.phajdan.jr@chromium.org2009-03-189-47/+80
| | | | | | | | | | Also ensure that Chromium.app quits properly between the tests. http://crbug.com/8391 Review URL: http://codereview.chromium.org/42306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11998 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: First implementation of TrimDeleted() and a fewrvargas@google.com2009-03-185-10/+70
| | | | | | | | | | other fixes related to the new eviction code. As before, almost everything is disabled by default. Review URL: http://codereview.chromium.org/48112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11995 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 1.1.1.2.ager@chromium.org2009-03-187-3/+298
| | | | | | | This contains the new compiler infrastructure which gives a nice performance improvement on the V8 benchmark suite. Review URL: http://codereview.chromium.org/48143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11994 0039d316-1c4b-4281-b951-d872f2087c98
* This test seems to have never failed on win/mac according to thetc@google.com2009-03-183-6/+1
| | | | | | | | | | flips page. Rebaseline on linux which matches win in metrics but the image differs due to anti-aliased fonts and the scrollbar. Review URL: http://codereview.chromium.org/48145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11993 0039d316-1c4b-4281-b951-d872f2087c98
* Green the layout test bots by marking some new failures.estade@chromium.org2009-03-181-0/+3
| | | | | | | | TBR=jkhawkins Review URL: http://codereview.chromium.org/42347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11992 0039d316-1c4b-4281-b951-d872f2087c98
* Implement GTK dropdown menus.estade@chromium.org2009-03-184-23/+108
| | | | | | | | These are used for <select> html items, for example. Review URL: http://codereview.chromium.org/48054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11991 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mac build break.estade@chromium.org2009-03-181-1/+0
| | | | | | | | tbr=avi Review URL: http://codereview.chromium.org/48139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11988 0039d316-1c4b-4281-b951-d872f2087c98
* Autocomplete now uses the input field id when no name is available to ↵jcampan@chromium.org2009-03-183-9/+31
| | | | | | | | | | | | perform autocomplete. This matches FF behavior. BUG=6310 TEST=See bug. Review URL: http://codereview.chromium.org/48033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11987 0039d316-1c4b-4281-b951-d872f2087c98
* Let checkdeps ignore #if 0 blocks. Also strip lines of leading/trailing ↵thestig@chromium.org2009-03-182-4/+14
| | | | | | | | whitespaces before checking. Review URL: http://codereview.chromium.org/42316 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11986 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling forward cygwin version to include hermetic python when including ↵bradnelson@google.com2009-03-181-1/+1
| | | | | | | | hermetic cygwin in setup_env.bat Review URL: http://codereview.chromium.org/48137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11985 0039d316-1c4b-4281-b951-d872f2087c98
* Removes LayoutTests/fast/events/click-count.html from the flakey winsky@google.com2009-03-181-1/+1
| | | | | | | | | | | | list. This test hasn't failed in a long time. BUG=none TEST=none TBR=tc Review URL: http://codereview.chromium.org/42342 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11984 0039d316-1c4b-4281-b951-d872f2087c98
* Fix underflow that would cause either an access violation or an infinite ↵robertshield@google.com2009-03-181-2/+3
| | | | | | | | loop if we were ever to get a "chrome_config" node back in metrics response data. Review URL: http://codereview.chromium.org/42335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11983 0039d316-1c4b-4281-b951-d872f2087c98
* Remove BrowserWindow::Init().estade@chromium.org2009-03-187-111/+99
| | | | | | | | This belongs as a private method of BrowserView. Neither mac nor linux uses it. Review URL: http://codereview.chromium.org/42298 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11982 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 23:44:04 +0000