| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
since different environments may require users to have certain external policy extensions installed. This patch also fixes a crash when --disable-extensions is used with external extensions installed.
BUG=66070
TEST=ExtensionsServiceTest.ExternalUninstall
Review URL: http://codereview.chromium.org/5695004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added unit tests for ServerNotifierThread.
Put DISABLE_RUNNABLE_METHOD_REFCOUNT() call for MediatorThreadImpl in the right place.
BUG=57898
TEST=New unittests
Review URL: http://codereview.chromium.org/5722002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Fixes bug where Instant is on even when checkbox in prefs is cleared.
BUG=66089
Review URL: http://codereview.chromium.org/5745004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
translate the page"
TEST=47250
Review URL: http://codereview.chromium.org/5557005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes:
- Linux output has UTF-8 quotes in it.
- Mac/Windows have DOS-style CRLF (and reading Linux with that
coding system is ok).
TEST=new trybot-test-linux
Review URL: http://codereview.chromium.org/5778003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=None
Bug=None
1. Verify content on https page - https://www.google.com. Verify in regular,
incognito window
2. Verify that chrome works with some top websites. Browse a list of urls, each
time verify some key strings. This test will verify that chrome is not getting
blocked by user-agent test by those websites.
Review URL: http://codereview.chromium.org/5726001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=66461
TBR=asargent@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5682007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5054003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=66448
Review URL: http://codereview.chromium.org/5725004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This includes a crash fix (see bugs).
BUG=65945,chromium-os:5014
TEST=Manual
Review URL: http://codereview.chromium.org/5782001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=66414
TEST=none
Review URL: http://codereview.chromium.org/5728003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a BrightnessLibrary class that registers to receive
notification of brightness changes from the libcros code
that I added in http://codereview.chromium.org/5640003/,
a BrightnessBubble class to control an onscreen indicator of
the current brightness level, and a BrightnessObserver class
that wires up the two.
This change depends on
http://codereview.chromium.org/5603012/, which pulls the
updated version of libcros into Chrome.
BUG=chromium-os:8473,chromium-os:4816
TEST=built and tried it
Review URL: http://codereview.chromium.org/5620004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=65988
TEST=unittests under heapcheck
Review URL: http://codereview.chromium.org/5777001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Shifts destructor to use new container, and removes no longer needed containers. Part of the downloads refactor effort.
dangerous_finished_ was only used for finding downloads that needed to be removed on disk, which can be determined more cleanly from the DownloadItem state. This does mean two passes through downloads_ (one to find the downloads that require special handling, and one to delete everything) but a) it's worth it for code clarity, and b) when we cleanup the semantics of DownloadItem::Remove, we can drop it to a single pass.
BUG=63493
TEST=All known not-always failing download tests pass.
Review URL: http://codereview.chromium.org/5636003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23581
Review URL: http://codereview.chromium.org/5742006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=65993
TEST=unit_tests --gtest_filter="*Prerender*"
Review URL: http://codereview.chromium.org/5693001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Defined PNG_NO_READ_SWAP, PNG_NO_WRITE_SWAP, PNG_NO_READ_oFFs, PNG_NO_WRITE_oFFs,
PNG_NO_USER_LIMITS, PNG_NO_SET_USER_LIMITS, PNG_NO_TIME_RFC1123.
Clarified that PNG_NO_INFO_IMAGE, PNG_NO_PROGRESSIVE_READ are undefined.
Used PNG_NO_SEQUENTIAL_READ instead of PNG_NO_SEQUENTIAL_READ_SUPPORTED.
Defined PNG_NO_WRITE_gAMA, PNG_NO_WRITE_sRGB.
Clarified that PNG_NO_READ_gAMA and PNG_NO_READ_sRGB are undefined
(i.e. gAMA and sRGB are retrieved by libpng, along with iCCP).
Fixed typo in the mangling of png_set_text_2.
Renamed the prefix webkit_ to wk_ in mangled names.
Restored the full function name in mangling; e.g., png_create_read_struct
is mangled as wk_png_create_read_struct instead of wk_png_cr_read_str.
Added mangling for all symbols with external linkage that are never macros.
Added explicit #undef for symbols that may sometimes be macros in png.h:
png_benign_error, png_chunk_benign_error, png_get_int_32, png_get_uint_16,
png_get_uint_32, png_info_init, png_read_init, png_write_init.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5689001
Patch from Cosmin Truta <ctruta@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
system.
BUG=http://code.google.com/p/chromium-os/issues/detail?id=10031
TEST=cros sync works
Review URL: http://codereview.chromium.org/5685004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, the profile-locking code was conservative in the face of
errors. Histograms indicate that the error rate is acceptable (no
errors seen), so flip locking errors to me failure-to-lock.
BUG=58986
TEST=none
Review URL: http://codereview.chromium.org/5717002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/5541005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=65395
Review URL: http://codereview.chromium.org/5774001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Committing for tsepez. Original code review is here http://codereview.chromium.org/5682002/
BUG=49747
TEST=WordIteratorTest.*
Review URL: http://codereview.chromium.org/5718003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Finish taking new SignedSettings::ReturnCode values all the way out to consumers of the SignedSettingsHelper API
BUG=chromium-os:9666
TEST=unit tests, install on device, ensure that Guest mode setting can be updated and is honored.
Review URL: http://codereview.chromium.org/5671003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=bulach
BUG=66400
TEST=browser_tests
Review URL: http://codereview.chromium.org/5739002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=jorlow
BUG=66394
TEST=browser_tests
Review URL: http://codereview.chromium.org/5730002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=64089
TEST=none
Review URL: http://codereview.chromium.org/5750001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some FTP servers send MLSD listings with no facts, just
the file names. This is a valid RFC-3659 listing, but
is useless for web browsers.
In theory we could check whether a server advertises
MLSD support in FEAT response, or use LIST when MLSD
only returns file names, but the extra complexity
is not worth it.
All servers supporting MLSD must also support LIST,
so this should not regress compatibility.
This change also removes the "HPRC" directory listing parser.
Actually, it was just MLSD listing with no facts.
BUG=65328, 65584
TEST=net_unittests, also see the bugs
Review URL: http://codereview.chromium.org/5669001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24255
TEST=none
Review URL: http://codereview.chromium.org/5695006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=65859
TEST=yes please
Review URL: http://codereview.chromium.org/5519015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=66102
TEST=None
TBR=danno@chromium.org
Review URL: http://codereview.chromium.org/5731004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on WebKit r73697.
BUG=65619
TEST=browser_tests
Review URL: http://codereview.chromium.org/5695002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=66227
TEST=None
TBR=panayiotis@google.com
Review URL: http://codereview.chromium.org/5771002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=66102, 66054
TEST=valgrind on linux and mac
Review URL: http://codereview.chromium.org/5748002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=66277
TEST=less redness on memory bots
Review URL: http://codereview.chromium.org/5704002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Do not fade out the background and text at the same time.
2. Fixed username shape on the screen lock.
3. Fixed corners drawing for the user image.
4. Do not use rounded corners for 'add user' pod (it cased the white frame blinking)
5. Do not use rounded corners for the unselected label, since the user image is scaled and the frame almost disappears.
BUG=chromium-os:9721
TEST=manual
Review URL: http://codereview.chromium.org/5552003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- this allows keygen created keys to be stored in a platform specific way, and looked up in client auth
- still needs additional work in CertDatabase to fully implement client auth
BUG=64917
TEST=Keygen unittest
Review URL: http://codereview.chromium.org/5594009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebIDBKey::number() will be changed to return a double.
Cast this to int explicitly to avoid warnings in the mean time (esp. on Visual
Studio).
BUG=65619
TEST=none
Review URL: http://codereview.chromium.org/5727002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64753
TEST=*ContentSettings*.*
Review URL: http://codereview.chromium.org/5528010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5740003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It seems these leaks are caused by a reference-count mismatch for a ChannelProxy::Context object. (This class expects to increase its reference count in OnChannelOpened() and to decrease it in OnChannelClosed(). On the other hand, we cannot call OnChannelClosed() after calling ClearIPCMessageLoop() because it detaches the message loop of a ChannelProxy::Context object. That is, calling ChannelProxy::Close() in ChannelProxy::~ChannelProxy() cannot decrease the reference count to its context.) This change just explicitly calls ChannelProxy::Close() before calling ChannelProxy::ClearIPCMessageLoop().
BUG=65940
TEST=make the valgrind bot green without suppressions.
Review URL: http://codereview.chromium.org/5706001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=65963
TEST=manual (see bug)
Review URL: http://codereview.chromium.org/5760001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Certificate/CertificateVerify messages unless the peer sends a CertificateRequest, requesting client auth.
This would happen if the following conditions were true:
- In the initial/previous handshake, the peer requests client authentication.
- The client chooses a certificate, versus declining to provide one.
- A (EC-)DHE cipher suite is negotiated.
- The peer requests (secure) renegotiation.
- The peer does NOT request a client certificate during the renegotiated handshake.
R=wtc
BUG=62027
TEST=none
Review URL: http://codereview.chromium.org/5611005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
page. In this first iteration, the reports are minimal, but I created a new class because I would like to expand them.
Workflow: A SafeBrowsingBlockingPage is shown. A new MalwareReport object is created. The blocking page goes away, either when the user clicks proceed, go back or closed the tab. We read the user's preference, and if we have a pending report, we pass it on to the SafeBrowsingService so it can send it.
Depends on: http://codereview.chromium.org/4827001/
Also relevant: http://codereview.chromium.org/5102001/
Design doc: https://docs.google.com/document/edit?id=1s-7qMjm23onV68SyqO6yi-xsfFzz4OBSOyHoV3cY8mQ&authkey=CMCF-MID
BUG=60831
TEST=unit_tests,relevant browser_test
Review URL: http://codereview.chromium.org/4822002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68828 0039d316-1c4b-4281-b951-d872f2087c98
|