summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Load external extensions even when --disable-extensions is used. We do this ↵jstritar@chromium.org2010-12-103-13/+71
| | | | | | | | | | | since different environments may require users to have certain external policy extensions installed. This patch also fixes a crash when --disable-extensions is used with external extensions installed. BUG=66070 TEST=ExtensionsServiceTest.ExternalUninstall Review URL: http://codereview.chromium.org/5695004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68892 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Fixed sync crash regression in ServerNotifierThreadakalin@chromium.org2010-12-107-13/+159
| | | | | | | | | | | | | Added unit tests for ServerNotifierThread. Put DISABLE_RUNNABLE_METHOD_REFCOUNT() call for MediatorThreadImpl in the right place. BUG=57898 TEST=New unittests Review URL: http://codereview.chromium.org/5722002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68891 0039d316-1c4b-4281-b951-d872f2087c98
* Nuke the about:flag for Mac Instant now that there is a real pref.maf@chromium.org2010-12-101-7/+0
| | | | | | | | Fixes bug where Instant is on even when checkbox in prefs is cleared. BUG=66089 Review URL: http://codereview.chromium.org/5745004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68890 0039d316-1c4b-4281-b951-d872f2087c98
* Verify Translate Info bar should not stay on the page after opting "Never ↵nirnimesh@chromium.org2010-12-101-0/+7
| | | | | | | | | | translate the page" TEST=47250 Review URL: http://codereview.chromium.org/5557005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68889 0039d316-1c4b-4281-b951-d872f2087c98
* emacs: use UTF-8 and DOS encoding when reading filesevan@chromium.org2010-12-102-8/+18
| | | | | | | | | | | | | This fixes: - Linux output has UTF-8 quotes in it. - Mac/Windows have DOS-style CRLF (and reading Linux with that coding system is ok). TEST=new trybot-test-linux Review URL: http://codereview.chromium.org/5778003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68888 0039d316-1c4b-4281-b951-d872f2087c98
* Commit the data file I missed in r68886nirnimesh@chromium.org2010-12-101-0/+15
| | | | | | TBR= git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68887 0039d316-1c4b-4281-b951-d872f2087c98
* Two Testcases on verifying the content of pages.nirnimesh@chromium.org2010-12-101-0/+23
| | | | | | | | | | | | | | | | TEST=None Bug=None 1. Verify content on https page - https://www.google.com. Verify in regular, incognito window 2. Verify that chrome works with some top websites. Browse a list of urls, each time verify some key strings. This test will verify that chrome is not getting blocked by user-agent test by those websites. Review URL: http://codereview.chromium.org/5726001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68886 0039d316-1c4b-4281-b951-d872f2087c98
* Marking ExtensionApiTest, Infobars as DISABLED on everything but Windows.gman@chromium.org2010-12-101-1/+1
| | | | | | | | | TEST=none BUG=66461 TBR=asargent@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68885 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove needed #includes for profile.h.thestig@chromium.org2010-12-1027-35/+11
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5682007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68884 0039d316-1c4b-4281-b951-d872f2087c98
* C++ readability change for kmadhusu.kmadhusu@chromium.org2010-12-102-88/+88
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5054003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68883 0039d316-1c4b-4281-b951-d872f2087c98
* Disable omnibox.OmniboxTest.testBookmarkResultInNewTabAndWindow on winnirnimesh@chromium.org2010-12-101-0/+2
| | | | | | | | BUG=66448 Review URL: http://codereview.chromium.org/5725004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68882 0039d316-1c4b-4281-b951-d872f2087c98
* Rolled cacheinvalidation to @67.akalin@chromium.org2010-12-102-1/+2
| | | | | | | | | | | This includes a crash fix (see bugs). BUG=65945,chromium-os:5014 TEST=Manual Review URL: http://codereview.chromium.org/5782001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68881 0039d316-1c4b-4281-b951-d872f2087c98
* Mark NamedInterfaceTest.BasicNamedInterface as flaky.csilv@chromium.org2010-12-101-1/+8
| | | | | | | | BUG=66414 TEST=none Review URL: http://codereview.chromium.org/5728003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68880 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Show onscreen bubble when brightness changes.derat@chromium.org2010-12-1015-2/+275
| | | | | | | | | | | | | | | | | | | | This adds a BrightnessLibrary class that registers to receive notification of brightness changes from the libcros code that I added in http://codereview.chromium.org/5640003/, a BrightnessBubble class to control an onscreen indicator of the current brightness level, and a BrightnessObserver class that wires up the two. This change depends on http://codereview.chromium.org/5603012/, which pulls the updated version of libcros into Chrome. BUG=chromium-os:8473,chromium-os:4816 TEST=built and tried it Review URL: http://codereview.chromium.org/5620004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68879 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leaks in RtpVideoReaderTest.sergeyu@chromium.org2010-12-103-20/+4
| | | | | | | | | BUG=65988 TEST=unittests under heapcheck Review URL: http://codereview.chromium.org/5777001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68878 0039d316-1c4b-4281-b951-d872f2087c98
* Create a new container to own downloads in DownloadManager.rdsmith@google.com2010-12-103-122/+109
| | | | | | | | | | | | | Shifts destructor to use new container, and removes no longer needed containers. Part of the downloads refactor effort. dangerous_finished_ was only used for finding downloads that needed to be removed on disk, which can be determined more cleanly from the DownloadItem state. This does mean two passes through downloads_ (one to find the downloads that require special handling, and one to delete everything) but a) it's worth it for code clarity, and b) when we cleanup the semantics of DownloadItem::Remove, we can drop it to a single pass. BUG=63493 TEST=All known not-always failing download tests pass. Review URL: http://codereview.chromium.org/5636003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68877 0039d316-1c4b-4281-b951-d872f2087c98
* Update WebKit to r73742.pkasting@chromium.org2010-12-101-1/+1
| | | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68876 0039d316-1c4b-4281-b951-d872f2087c98
* wstrings: make l10n_util::TruncateString use string16evan@chromium.org2010-12-109-40/+38
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/5742006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68875 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in PrerenderInterceptorTestcbentzel@chromium.org2010-12-102-14/+10
| | | | | | | | BUG=65993 TEST=unit_tests --gtest_filter="*Prerender*" Review URL: http://codereview.chromium.org/5693001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68874 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up third_party/libpng/pngusr.h and update it for libpng-1.2.44.thakis@chromium.org2010-12-101-332/+381
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Defined PNG_NO_READ_SWAP, PNG_NO_WRITE_SWAP, PNG_NO_READ_oFFs, PNG_NO_WRITE_oFFs, PNG_NO_USER_LIMITS, PNG_NO_SET_USER_LIMITS, PNG_NO_TIME_RFC1123. Clarified that PNG_NO_INFO_IMAGE, PNG_NO_PROGRESSIVE_READ are undefined. Used PNG_NO_SEQUENTIAL_READ instead of PNG_NO_SEQUENTIAL_READ_SUPPORTED. Defined PNG_NO_WRITE_gAMA, PNG_NO_WRITE_sRGB. Clarified that PNG_NO_READ_gAMA and PNG_NO_READ_sRGB are undefined (i.e. gAMA and sRGB are retrieved by libpng, along with iCCP). Fixed typo in the mangling of png_set_text_2. Renamed the prefix webkit_ to wk_ in mangled names. Restored the full function name in mangling; e.g., png_create_read_struct is mangled as wk_png_create_read_struct instead of wk_png_cr_read_str. Added mangling for all symbols with external linkage that are never macros. Added explicit #undef for symbols that may sometimes be macros in png.h: png_benign_error, png_chunk_benign_error, png_get_int_32, png_get_uint_16, png_get_uint_32, png_info_init, png_read_init, png_write_init. BUG=none TEST=none Review URL: http://codereview.chromium.org/5689001 Patch from Cosmin Truta <ctruta@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68873 0039d316-1c4b-4281-b951-d872f2087c98
* Fix sync in Chromium-os by not allowing CanShowPromo to initialize the sync ↵mirandac@chromium.org2010-12-101-3/+7
| | | | | | | | | | | system. BUG=http://code.google.com/p/chromium-os/issues/detail?id=10031 TEST=cros sync works Review URL: http://codereview.chromium.org/5685004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68872 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make profile-locking error the same as failing to lock.shess@chromium.org2010-12-101-8/+4
| | | | | | | | | | | | | Previously, the profile-locking code was conservative in the face of errors. Histograms indicate that the error rate is acceptable (no errors seen), so flip locking errors to me failure-to-lock. BUG=58986 TEST=none Review URL: http://codereview.chromium.org/5717002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68871 0039d316-1c4b-4281-b951-d872f2087c98
* Make BrowserMessageFilter support dispatching messages on different threads.jam@chromium.org2010-12-1010-106/+173
| | | | | | Review URL: http://codereview.chromium.org/5541005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68870 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a plugin taking a whole iframe from messing with the page's zoom level.jam@chromium.org2010-12-101-0/+7
| | | | | | | BUG=65395 Review URL: http://codereview.chromium.org/5774001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68868 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ICU header dependencies outside of /i18n directory.cdn@chromium.org2010-12-103-12/+23
| | | | | | | | | | Committing for tsepez. Original code review is here http://codereview.chromium.org/5682002/ BUG=49747 TEST=WordIteratorTest.* Review URL: http://codereview.chromium.org/5718003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68867 0039d316-1c4b-4281-b951-d872f2087c98
* [Chrome OS] Plumb new error codes from SignedSettings to consumers of the APIcmasone@chromium.org2010-12-1011-153/+119
| | | | | | | | | | | Finish taking new SignedSettings::ReturnCode values all the way out to consumers of the SignedSettingsHelper API BUG=chromium-os:9666 TEST=unit tests, install on device, ensure that Guest mode setting can be updated and is honored. Review URL: http://codereview.chromium.org/5671003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68866 0039d316-1c4b-4281-b951-d872f2087c98
* Disable crashy GeolocationBrowserTest.NoInfoBarBeforeStartphajdan.jr@chromium.org2010-12-101-1/+2
| | | | | | | | | | | TBR=bulach BUG=66400 TEST=browser_tests Review URL: http://codereview.chromium.org/5739002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68863 0039d316-1c4b-4281-b951-d872f2087c98
* Disable crashy IndexedDBBrowserTest.DoesntHangTestphajdan.jr@chromium.org2010-12-101-1/+2
| | | | | | | | | | | TBR=jorlow BUG=66394 TEST=browser_tests Review URL: http://codereview.chromium.org/5730002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68862 0039d316-1c4b-4281-b951-d872f2087c98
* Add safe browsing tests to dbg mac valgrind build.lzheng@chromium.org2010-12-101-0/+1
| | | | | | | | BUG=64089 TEST=none Review URL: http://codereview.chromium.org/5750001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68861 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: fix compatibility problems with MLSD by removing MLSD support.phajdan.jr@chromium.org2010-12-1023-637/+6
| | | | | | | | | | | | | | | | | | | | | | | | Some FTP servers send MLSD listings with no facts, just the file names. This is a valid RFC-3659 listing, but is useless for web browsers. In theory we could check whether a server advertises MLSD support in FEAT response, or use LIST when MLSD only returns file names, but the extra complexity is not worth it. All servers supporting MLSD must also support LIST, so this should not regress compatibility. This change also removes the "HPRC" directory listing parser. Actually, it was just MLSD listing with no facts. BUG=65328, 65584 TEST=net_unittests, also see the bugs Review URL: http://codereview.chromium.org/5669001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68859 0039d316-1c4b-4281-b951-d872f2087c98
* Audit some Mac TODOs.rsesek@chromium.org2010-12-105-9/+3
| | | | | | | | | BUG=24255 TEST=none Review URL: http://codereview.chromium.org/5695006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68858 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 73714:73720pfeldman@chromium.org2010-12-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68854 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly whitelist the test server port.bauerb@chromium.org2010-12-106-9/+39
| | | | | | | | | BUG=65859 TEST=yes please Review URL: http://codereview.chromium.org/5519015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68853 0039d316-1c4b-4281-b951-d872f2087c98
* Re-add suppression for PrefValueStorePolicyRefreshTest.TestPolicyRefreshcbentzel@chromium.org2010-12-101-0/+10
| | | | | | | | | BUG=66102 TEST=None TBR=danno@chromium.org Review URL: http://codereview.chromium.org/5731004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68852 0039d316-1c4b-4281-b951-d872f2087c98
* IndexedDB: Numeric keys are floating point.hans@chromium.org2010-12-104-10/+9
| | | | | | | | | | | Depends on WebKit r73697. BUG=65619 TEST=browser_tests Review URL: http://codereview.chromium.org/5695002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68851 0039d316-1c4b-4281-b951-d872f2087c98
* heapcheck suppressions for MalwareDetailsTest's.cbentzel@chromium.org2010-12-101-0/+6
| | | | | | | | | | BUG=66227 TEST=None TBR=panayiotis@google.com Review URL: http://codereview.chromium.org/5771002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68850 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 73684:73714pfeldman@chromium.org2010-12-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68845 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leaks in AsynchronousPolicyProvider.danno@chromium.org2010-12-104-39/+11
| | | | | | | | | BUG=66102, 66054 TEST=valgrind on linux and mac Review URL: http://codereview.chromium.org/5748002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68844 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress memory leaks in MalwareDetailsTest introduced in r68828jochen@chromium.org2010-12-101-0/+6
| | | | | | | | | BUG=66277 TEST=less redness on memory bots Review URL: http://codereview.chromium.org/5704002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68843 0039d316-1c4b-4281-b951-d872f2087c98
* Login pod visual enhancements.altimofeev@chromium.org2010-12-106-85/+178
| | | | | | | | | | | | | | | 1. Do not fade out the background and text at the same time. 2. Fixed username shape on the screen lock. 3. Fixed corners drawing for the user image. 4. Do not use rounded corners for 'add user' pod (it cased the white frame blinking) 5. Do not use rounded corners for the unselected label, since the user image is scaled and the frame almost disappears. BUG=chromium-os:9721 TEST=manual Review URL: http://codereview.chromium.org/5552003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68842 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 607.0 to 608.0chrome-release@google.com2010-12-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68838 0039d316-1c4b-4281-b951-d872f2087c98
* Adds first cut implementation of a private key store abstraction for openssljoth@chromium.org2010-12-107-14/+152
| | | | | | | | | | | | - this allows keygen created keys to be stored in a platform specific way, and looked up in client auth - still needs additional work in CertDatabase to fully implement client auth BUG=64917 TEST=Keygen unittest Review URL: http://codereview.chromium.org/5594009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68836 0039d316-1c4b-4281-b951-d872f2087c98
* IndexedDB: Preparatory patch for https://bugs.webkit.org/show_bug.cgi?id=50674hans@chromium.org2010-12-101-1/+2
| | | | | | | | | | | | | WebIDBKey::number() will be changed to return a double. Cast this to int explicitly to avoid warnings in the mean time (esp. on Visual Studio). BUG=65619 TEST=none Review URL: http://codereview.chromium.org/5727002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68835 0039d316-1c4b-4281-b951-d872f2087c98
* Implement preference and policy based content settings providers.jochen@chromium.org2010-12-1017-369/+1006
| | | | | | | | | BUG=64753 TEST=*ContentSettings*.* Review URL: http://codereview.chromium.org/5528010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68834 0039d316-1c4b-4281-b951-d872f2087c98
* Add isherman@chromium.org to autofill watchlistisherman@chromium.org2010-12-101-1/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5740003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68833 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 73655:73684.pfeldman@chromium.org2010-12-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68832 0039d316-1c4b-4281-b951-d872f2087c98
* An exprimental fix for Bug 65940.hbono@chromium.org2010-12-102-19/+5
| | | | | | | | | | It seems these leaks are caused by a reference-count mismatch for a ChannelProxy::Context object. (This class expects to increase its reference count in OnChannelOpened() and to decrease it in OnChannelClosed(). On the other hand, we cannot call OnChannelClosed() after calling ClearIPCMessageLoop() because it detaches the message loop of a ChannelProxy::Context object. That is, calling ChannelProxy::Close() in ChannelProxy::~ChannelProxy() cannot decrease the reference count to its context.) This change just explicitly calls ChannelProxy::Close() before calling ChannelProxy::ClearIPCMessageLoop(). BUG=65940 TEST=make the valgrind bot green without suppressions. Review URL: http://codereview.chromium.org/5706001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68831 0039d316-1c4b-4281-b951-d872f2087c98
* [gtk] fix line wrap issue on app shortcut dialogestade@chromium.org2010-12-101-9/+14
| | | | | | | | | BUG=65963 TEST=manual (see bug) Review URL: http://codereview.chromium.org/5760001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68830 0039d316-1c4b-4281-b951-d872f2087c98
* When performing a SSL renegotiation handshake, do not send ↵rsleevi@chromium.org2010-12-103-31/+134
| | | | | | | | | | | | | | | | | | | Certificate/CertificateVerify messages unless the peer sends a CertificateRequest, requesting client auth. This would happen if the following conditions were true: - In the initial/previous handshake, the peer requests client authentication. - The client chooses a certificate, versus declining to provide one. - A (EC-)DHE cipher suite is negotiated. - The peer requests (secure) renegotiation. - The peer does NOT request a client certificate during the renegotiated handshake. R=wtc BUG=62027 TEST=none Review URL: http://codereview.chromium.org/5611005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68829 0039d316-1c4b-4281-b951-d872f2087c98
* Send malware reports when a user opts-in from the safe browsing interstitial ↵panayiotis@google.com2010-12-1015-35/+835
| | | | | | | | | | | | | | | | | page. In this first iteration, the reports are minimal, but I created a new class because I would like to expand them. Workflow: A SafeBrowsingBlockingPage is shown. A new MalwareReport object is created. The blocking page goes away, either when the user clicks proceed, go back or closed the tab. We read the user's preference, and if we have a pending report, we pass it on to the SafeBrowsingService so it can send it. Depends on: http://codereview.chromium.org/4827001/ Also relevant: http://codereview.chromium.org/5102001/ Design doc: https://docs.google.com/document/edit?id=1s-7qMjm23onV68SyqO6yi-xsfFzz4OBSOyHoV3cY8mQ&authkey=CMCF-MID BUG=60831 TEST=unit_tests,relevant browser_test Review URL: http://codereview.chromium.org/4822002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68828 0039d316-1c4b-4281-b951-d872f2087c98