| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of the command buffer. This brought out the fact that
there were lots of places in the code mixing size in bytes
with num command buffer entries.
This fixes most of those issues. No public interface
uses num command buffer entries except
gpu::CommandBuffer::State where it makes sense.
TEST=relying on unit tests, conformance tests and chrome
BUG=none
Review URL: http://codereview.chromium.org/2008014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
enabled vertex attribs are valid, not just the ones
the current program is using.
TEST=unit tests
BUG=none
Review URL: http://codereview.chromium.org/2021007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows machine.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1995012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
StringTokenizer. What used to take 10ms to parse now takes 6ms.
- Profiling showed that doing the additional work to work with quotes added a bit of runtime, but most users don't use the optional quotes functionality. This speed parsing up by 20% by switching to a fast-path implementation, reverting to the slower path when necessary.
- Eliminate temporary copies of tokens. This speeds up GetWorkingSetKBytes by another 20%.
BUG=40033
TEST=Existing StringTokenizerTests.
Review URL: http://codereview.chromium.org/1997017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The first CL was getting too large, and was being held back by
some platform specific changes. I pulled out the problems into
this CL to make it easier ot focus on getting them all right.
BUG=14193
r=eroman
Review URL: http://codereview.chromium.org/2033005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
a related crash.
BUG=31737,32906
TEST=none
Review URL: http://codereview.chromium.org/2018006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
authenticate_result_ flag.
added #include for gtest.h as it uses has EXPECT_EQ.
BUG=none
TEST=login_manager_view_browsertest should pass.
Review URL: http://codereview.chromium.org/2002016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=jhawkins
Review URL: http://codereview.chromium.org/2055014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
actual gallery downloads.
BUG=None
TEST=Pass in a gallery url through the command line and make sure the dangerous download warning does not show when downloading from that gallery.
Review URL: http://codereview.chromium.org/1997019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extensions are unpacked by a sandboxed utility process. The sandbox forbids file access outside the directory the extension will be unpacked in. If the path to that directory contains a symbolic link, then unpacking will fail because following the link will cause file system access outside the sandbox path. Use realpath() to get a symlink free path to the directory where the extension will be unpacked.
A similar issue exists on windows, with junctions instead of symlinks. This will be fixed in another change.
BUG=13044,35198
TEST=FileUtilTest.RealPath
Review URL: http://codereview.chromium.org/2001013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pulls in:
commit 191e7d263be5da30e07e5c7d44d144c8ecb941e0
Author: agl@chromium.org <agl@chromium.org@107f31f1-e31d-0410-a17c-a9b5b17689e2>
Date: Mon May 10 14:15:50 2010 +0000
[FreeType] Always use MONO hinting when hinting in monochrome.
This matches the behaviour of Cairo. It appears to be an undocumented
trick of font rendering on Linux that, in monochrome, all the hinting
modes expect no-hinting are mapped to FreeType's MONO hinting.
http://code.google.com/p/chromium/issues/detail?id=43252
http://codereview.appspot.com/1162041/show
git-svn-id: https://skia.googlecode.com/svn/trunk@562 107f31f1-e31d-0410-a17c-a9b5b17689e2
BUG=43252
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is preparation work for implementing platform-specific policy.
BUG=none
TEST=--gtest_filter=ConfigurationPolicyPrefStoreTest*
Review URL: http://codereview.chromium.org/1692011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Broke Chromium Linux Builder (dbg-shlib)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pulls in these two commits:
commit 1bb588523bf74ea4e0f71fc01180c21902ee577e
Author: agl@chromium.org <agl@chromium.org@107f31f1-e31d-0410-a17c-a9b5b17689e2>
Date: Mon May 10 21:20:58 2010 +0000
Minor fixes to build under Clang:
- Remove an unused ctor that was wrong anyway.
- Add magic angle brackets to a template declaration.
Patch-by: Evan Martin
git-svn-id: https://skia.googlecode.com/svn/trunk@563 107f31f1-e31d-0410-a17c-a9b5b17689e2
commit 191e7d263be5da30e07e5c7d44d144c8ecb941e0
Author: agl@chromium.org <agl@chromium.org@107f31f1-e31d-0410-a17c-a9b5b17689e2>
Date: Mon May 10 14:15:50 2010 +0000
[FreeType] Always use MONO hinting when hinting in monochrome.
This matches the behaviour of Cairo. It appears to be an undocumented
trick of font rendering on Linux that, in monochrome, all the hinting
modes expect no-hinting are mapped to FreeType's MONO hinting.
http://code.google.com/p/chromium/issues/detail?id=43252
http://codereview.appspot.com/1162041/show
git-svn-id: https://skia.googlecode.com/svn/trunk@562 107f31f1-e31d-0410-a17c-a9b5b17689e2
BUG=43252
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=satorux
Review URL: http://codereview.chromium.org/2044009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=satorux
Review URL: http://codereview.chromium.org/2007011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Make sure that libcupsys2-dev package get installed.
Review URL: http://codereview.chromium.org/2038011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Put a per-origin quota on session storage since it is using memory in the browser process, and should not be allowed to grow arbitrarily large.
Landing on behalf of hans@chromium.org from http://codereview.chromium.org/1998003/show
BUG=42740
TEST=none
Review URL: http://codereview.chromium.org/1995014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35027
TEST=None
TBR=antonm@chromium.org
Review URL: http://codereview.chromium.org/2015016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Vista (dbg) not crashing
BUG=22248
Review URL: http://codereview.chromium.org/2018008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
on Valgrind bots.
TBR=glider,thestig
Review URL: http://codereview.chromium.org/2051010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=glider,thestig
BUG=43972
Review URL: http://codereview.chromium.org/2013018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem was the circular gyp dependency between webkit.gyp
and WebKit.gyp:
webkit.gyp:pull_in_webkit_unit_tests -> WebKit.gyp -> webkit.gyp:webkit_support.
The fix is to move webkit_support into its own gyp file (like we do
in an webkit only checkout). We can't use the same gyp file for in-
chromium and in-webkit because we need to change the include path for
features.gypi. In gyp, variable expansion happens after includes
(otherwise you'd have to expand variables twice and they could change
values), so we can't use a single gyp file for this.
Review URL: http://codereview.chromium.org/1995013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After this change, the meaning of the prefixes is as follows:
- DISABLED_: the test is not run unless --gtest_also_run_disabled_tests
flag is used; should be used for tests that crash or exceed the time limit
- FLAKY_: for tests that behave intermittently, and don't crash nor time out
- FAILS_: for tests that fail consistently, but don't crash nor time out
The Testing Task Force aims to run as much tests as possible, to keep
the coverage high.
The Green Tree Task Force aims to fix the flaky tests because they are
unpredictable.
To satisfy both goals, we should differentiate between the two cases,
and that's why we have both the FLAKY_ and FAILS_ prefixes.
When a test crashes or exceeds time limit (even intermittently),
we have no choice other than disable it, and that's why we have DISABLED_
(and it's built-in the gtest framework anyway).
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2015013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
WebPluginImpl. We don't need most of that NPAPI cruft and can remove this extra
layer of abstraction to keep our code simpler.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2001014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
doesn't need it.
BUG=43489
TEST=none
Review URL: http://codereview.chromium.org/2055009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/fast/workers/storage/open-database-sync-inputs.html.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2045003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=estade
Review URL: http://codereview.chromium.org/2047013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=jam
Review URL: http://codereview.chromium.org/2003013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2008008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=sky
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
into view.
BUG=39368
TEST=n/a
Review URL: http://codereview.chromium.org/2021008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/2008015
TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/1979011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/2008015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=43891
TEST=Trigger toast scenario, it should only appear if user data dir is 3000 days old.
R=cpu
Review URL: http://codereview.chromium.org/2016009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the Gtk UI.
BUG=43802
TEST=manual
Review URL: http://codereview.chromium.org/2061003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=antonm
Review URL: http://codereview.chromium.org/2001015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the JS exception causes the test to crash.
TBR=mpcomplete
BUG=22248
TEST=none
Review URL: http://codereview.chromium.org/1993012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2052007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Benefits:
- less code
- more straightforward code
- more shared code
unresolved issues:
- RenderViewContextMenu{Gtk,Mac,Views} should not be a subclass of RenderViewContextMenu
- On Linux, IMEs are added in the wrong place (not near the other editable stuff)
BUG=31365
TEST=manual + trybots
Review URL: http://codereview.chromium.org/2017001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
window. This matches other options sub-dialogs.
BUG=41196
TEST=none
Review URL: http://codereview.chromium.org/2012010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2037007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
background.
Make window popup to avoid animation and keep it on top of the window stack.
BUG=http://crosbug.com/2914
TEST=none
Review URL: http://codereview.chromium.org/2032012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=With --enable-extension-apps, make sure you don't get the bookmark bar.
Review URL: http://codereview.chromium.org/1990015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=41275
Review URL: http://codereview.chromium.org/2013015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1999005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If it is, it must be an orphaned lock file that just happens to have an unfortunate pid, since we haven't tried to create a lockfile ourselves yet.
Also, don't allow kill with pid 0, which would be another way to theoretically kill ourselves.
BUG=42568,43594
TEST=ui_tests, manual testing
Review URL: http://codereview.chromium.org/1981009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46977 0039d316-1c4b-4281-b951-d872f2087c98
|