| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
bubbles when running OTR.
BUG=37525
TEST=Manual, check cookie prompt and bubbles in OTR session
Review URL: http://codereview.chromium.org/1629011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=40932
TEST=none
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/1605020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the failing tests caused by r44036 (cf. http://codereview.chromium.org/1589026).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1594024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=browser_tests
BUG=none
Review URL: http://codereview.chromium.org/1549028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- old prefs
- one source lang could be auto-translated to several target langs
- storage: list of target langs
- new prefs
- one source lang can only be auto-translated to one target lang, the latest option overwriting previous one
- storage: a single string value of target lang
- besides using new format, also migrate old to new format when registering user prefs
BUG=37313
TEST=verify per bug report.
Review URL: http://codereview.chromium.org/1551021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=manual
BUG=38362
Review URL: http://codereview.chromium.org/1600002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
in our GRD files.
BUG=23550
TEST=none
Review URL: http://codereview.chromium.org/1631003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is partial revert of r44072.
TBR=satorux
Review URL: http://codereview.chromium.org/1619009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dialog on all platforms into a delegate.
The platform-dependent ConstrainedWindow{Gtk,Mac,Win} classes each have their own platform-dependent |ConstrainedWindowDelegate| to inherit from, so instead of a common superclass they now have a RepostFormWarningDelegate.
Also, change the RELOADING notification to REPOST_WARNING_SHOWN to avoid trying to close the dialog while it's already in the process of being closed.
BUG=none
TEST=RepostFormWarningTest.*
Review URL: http://codereview.chromium.org/1520023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
UI thread, so no need for it to cache a copy of the prefs values
BUG=none
TEST=GeolocationContentSettingsMapTests.*
Review URL: http://codereview.chromium.org/1525018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change also disables the latter hot-key so that users can't disable IBus. This is preferable since "current input method is xkb:us::eng (for example) and it is enabled" and "current one is xkb:us::eng but it's disabled" are almost indistinguishable.
This change depends on http://codereview.chromium.org/1528023 and http://codereview.chromium.org/1610013.
BUG=none
TEST=boot chrome os, activate English and Chinese, click omnibox, press lang menu, press English to enable "xkb:us::eng", press omnibox, press ctrl+space, verify that the menu shows "Chi" (not "Eng").
Review URL: http://codereview.chromium.org/1553018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1595014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
There's no longer a use case for multiple radio groups (was originally planned for Geolocation), simplify the model and its views.
BUG=39073
TEST=content_setting_bubble_model_unittest
Review URL: http://codereview.chromium.org/1575022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(landing http://codereview.chromium.org/1595016/show for satish@chromium.org)
Review URL: http://codereview.chromium.org/1542023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The conversion is necessary so we can show language names properly in UI.
TEST=unit_tests
BUG=none
Review URL: http://codereview.chromium.org/1607010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/1600019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
text/text/plain;charset=utf-8.
BUG=crosbug.com/2178
TEST=See http://code.google.com/p/chromium-os/issues/detail?id=2178
Review URL: http://codereview.chromium.org/1599023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
than max size.
BUG=none
TEST=manual: run linux/view build or chromeos build and create a web notification. The size of balloon should be same as one in Windows.
Review URL: http://codereview.chromium.org/1631007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40893
TBR=creis
Review URL: http://codereview.chromium.org/1520029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
My build output is now beautiful and clean.
Review URL: http://codereview.chromium.org/1633004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This replaces calls to |innnerText()| with calls to |nodeValue()| for performance
gains.
BUG=40306
TEST=FormManagerTest
Review URL: http://codereview.chromium.org/1620007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=40893,40575
TBR=creis
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=37421
Review URL: http://codereview.chromium.org/1556018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1560023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
they're needed.
BUG=40306
TEST=none
Review URL: http://codereview.chromium.org/1626009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
correct roles.
Allow views to contain multiple accessibility states since states are not mutually exclusive, we treat them as an uint32. Add missing roles to couple of views.
BUG=None
TEST=Run unit tests, and check accessibility tree.
Review URL: http://codereview.chromium.org/1527019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke dom_checker_tests on Chromium Linux and Chromium Linux x64.
BUG=9394
Test=DomCheckerTest
Review URL: http://codereview.chromium.org/1609015
TBR=inferno@chromium.org
Review URL: http://codereview.chromium.org/1627013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=40674,40720,40744
TEST=In the bugs.
Review URL: http://codereview.chromium.org/1594021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
call OnUnrecoverableError on errors and rather just return "false". However, we seem to have regressed and this makes bad stuff happen when there are errors when starting sync.
BUG=40867
Review URL: http://codereview.chromium.org/1558034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
which causes many crashes on Linux debug layout tests (mostly svg).
Review URL: http://codereview.chromium.org/1553021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=9394
Test=DomCheckerTest
Review URL: http://codereview.chromium.org/1609015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
would
not get persisted. The problem was ImportFormData was assigning ID, which was causing
SetProfile to think it was an update, rather than an Add, and the update would then fail.
BUG=40297
TEST=PersonalDataManagerTest.ImportFormData (added)
Review URL: http://codereview.chromium.org/1589025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a case issue when matching names.
BUG=40299
TEST=none
Review URL: http://codereview.chromium.org/1575023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I have to rewrite those tests anyway.
TBR=ananta
Review URL: http://codereview.chromium.org/1626008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Rebased to a never Git revision to make things easier to land.
2. Chrome will now preserve the command line switches except for those that are
blacklisted.
3. Fixed a race condition that would cause the browser to think it didn't exit
cleanly after it's been restarted.
4. Fixed minor nits and omissions (indentation, etc).
This patch adds a timer which fires every 6 hours and checks whether the
browser is in the "persistent" (background) mode, and whether there's an
update pending restart. If both conditions are true, the browser is
restarted with blacklisted command line keys and all loose values stripped. In order to
restart the browser in the background mode, the longlivedextensions
key is also added to the command line.
This change is Windowsonly, and it won't become fully functional until
Drew (atwilson) checks in his work that enables Chrome to go into background.
Review URL: http://codereview.chromium.org/1617001
TBR=atwilson@chromium.org
Review URL: http://codereview.chromium.org/1517027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1540028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
preferences can be updated by the sync backend,
make sure HostContentSettingsMap correctly fires off notifications whenever
it modifies them, and reloads them when they are modified.
BUG=none
TEST=HostContentSettingsMapTest.*
Review URL: http://codereview.chromium.org/1540026
TBR=albertb@chromium.org
Review URL: http://codereview.chromium.org/1589026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Step one of the changes. Inspect data and cause a switch
in the moniker patch.
Review URL: http://codereview.chromium.org/1589013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
make sure HostContentSettingsMap correctly fires off notifications whenever
it modifies them, and re-loads them when they are modified.
BUG=none
TEST=HostContentSettingsMapTest.*
Review URL: http://codereview.chromium.org/1540026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
types, so it will download updates.
BUG=40555
TEST= Set up sync with some data types. Then customize sync to add or subtract some. Chrome should not crash or display command-line errors.
Review URL: http://codereview.chromium.org/1566032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This replaces calls to |innnerText()| with calls to |nodeValue()| for performance
gains.
BUG=40306
TEST=FormManagerTest.Label
Review URL: http://codereview.chromium.org/1622013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36180
TEST=unittest
Review URL: http://codereview.chromium.org/1591026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/o3d/issues/detail?id=215 /
http://codereview.chromium.org/669220 because of a last minute change
to the NPN_InvalidateRect call.
Internal bug ID: http://b/issue?id=2582040
BUG=none
TEST=none (ran O3D samples)
Review URL: http://codereview.chromium.org/1553020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Windows, the OS does not appear to properly support the
call to list interfaces. As a result, it is only returning
IPv4 interfaces, even if there are valid IPv6 interfaces.
This in turned caused IPv6 to be disabled on windows.
This patch tentatively allows IPv6 rather than performing
probe.
BUG=40851
r=wtc
Review URL: http://codereview.chromium.org/1564020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=40879
TEST=greener Mac UI Valgrind
TBR=viettrungluu@chromium.org, stuartmorgan@chromium.org
Review URL: http://codereview.chromium.org/1612012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the client area in fullscreen mode even though there are no non-client edges in fullscreen mode. This involves:
1. adding a check for IsFullscreen to the BrowserFrameWin code that calculates the client area insets for fullscreen state, just as it currently checks for maximized state.
2. bypass the WindowWin's sanity check for default insets in the Fullscreen case - in fullscreen mode the window should have zero non-client, not default restored non-client.
http://crbug.com/37588
http://crbug.com/39076
Review URL: http://codereview.chromium.org/1618009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Not deleting them was causing assertion failure. See the bug description for details.
* Added TestCleanExit
* Removed empty test that was checked in by my mistake.
BUG=40810
TEST=Added NotificationTest.TestCleanExit
Review URL: http://codereview.chromium.org/1600018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It was likely fixed by fixing worker process termination issues. Enabling it after running it 100 times on Linux try bot.
BUG=30353
TEST=ui_test WorkerTests.MultipleWorkers
Review URL: http://codereview.chromium.org/1607009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1619007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44026 0039d316-1c4b-4281-b951-d872f2087c98
|