| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sockets in the Mac
renderer sandbox to support running Native Client.
2. Put the Native Client sel_ldr (which contains the user's untrusted code
into a new Mac sandbox type.
3. Open /dev/random in SandboxWarmup().
4. Remove the "nosandbox" flag when running Mac tests.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=327
TEST=nacl_ui_tests still pass while running in the sandbox.
Review URL: http://codereview.chromium.org/1234003
TBR=msneck@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
considering the alternatives, I've decided that it's not terrible. This code
does not make it into the Chrome build, it's only used for the symbol dumper.
BUG=none
TEST=Mac official build
Review URL: http://codereview.chromium.org/1535005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=10.6 SDK build
Review URL: http://codereview.chromium.org/1552004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1587004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/668085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
landing WebKit side.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1516004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1582001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
renderer sandbox to support running Native Client.
2. Put the Native Client sel_ldr (which contains the user's untrusted code
into a new Mac sandbox type.
3. Open /dev/random in SandboxWarmup().
4. Remove the "--nosandbox" flag when running Mac tests.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=327
TEST=nacl_ui_tests still pass while running in the sandbox.
Review URL: http://codereview.chromium.org/1234003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
window exists.
BUG=None.
TEST=Run in process browser test that doesn't create browser window: it
should quit without timeout error.
Review URL: http://codereview.chromium.org/1508007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
or crashes, the popup should close for that extension.
BUG=35940
TEST=See bug for repro steps.
Review URL: http://codereview.chromium.org/1528006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutocompleteTextFieldEditor* requires its delegate to be an
AutocompleteTextField*. Override the return type of -delegate and the
parameter type of -setDelegate:. This is safe because NSTextView,
AutocompleteTextFieldEditor's superclass, uses id<NSTextViewDelegate> as the
delegate type (as of the 10.6 SDK, and just id prior), and
AutocompleteTextField* implements NSTextViewDelegate (and of course is
descended from id).
This change allows some casts and scattered type checks in this file to be
removed in favor of the cast and type check in one central location. It also
fixes another 10.6 SDK build error caused because -delegate is more specific
than just id in that SDK. It provides future-proofing against further errors
of this sort.
BUG=none
TEST=10.6 SDK build
Review URL: http://codereview.chromium.org/1550002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CRT reports are generated to allow sorting those dumps by stack signature.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1418001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=dpolukhin
Review URL: http://codereview.chromium.org/1588002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1508009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Conditionalizes a SetWindow call that was added to fix a crash in QuickDraw mode, but isn't necessary (and causes QuickTime not to draw) in other drawing modes.
BUG=38336,36896,35081
TEST=Play QuickTime movies on 10.6. The ones with floating controllers (36896) should draw again, and the other should not only work, but have smoother playback and use less CPU. The test case for bug 35081 should still not crash.
Review URL: http://codereview.chromium.org/1569005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
on Linux/shlib
BUG=38562
TBR=amit
Review URL: http://codereview.chromium.org/1593001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=28363
Review URL: http://codereview.chromium.org/1377003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Here's an example output of the failure:
[----------] 1 test from UnloadTest
[ RUN ] UnloadTest.CrossSiteInfiniteUnloadSync
[5442:5442:0330/051539:6569997191168:INFO:chrome/test/ui/ui_test.cc(1199)] BROWSER_WRAPPER was set, prefixing command_line with /b/slave/chromium-rel-linux-tsan-ui/build/valgrind.tmp/browser_wrapper.KXl4L_
Extracting ThreadSanitizer to /tmp/valgrind.de5700
chrome/test/ui/ui_test.cc:595: Failure
Value of: tab_proxy->NavigateToURLBlockUntilNavigationsComplete( url, number_of_navigations)
Actual: 0
Expected: AUTOMATION_MSG_NAVIGATION_SUCCESS
Which is: 1
http://mock.http/title2.html
chrome/browser/unload_uitest.cc:127: Failure
Value of: GetActiveTabTitle()
Actual: L""
Expected: expected_title
Which is: L"Title Of Awesomeness"
[ FAILED ] UnloadTest.CrossSiteInfiniteUnloadSync (556591 ms)
[----------] 1 test from UnloadTest (556591 ms total)
BUG=32529
TBR=glider
Review URL: http://codereview.chromium.org/1547007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Linux
TBR=amit
BUG=38562
Review URL: http://codereview.chromium.org/1592002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=TSan/UI should become greener
TBR=glider
Review URL: http://codereview.chromium.org/1552003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- use built-in timeouts instead of "inventing" them in each test case
- avoid unneeded checks and operations
- use automation calls more effectively
- use FLAKY mark instead of DISABLED to maintain test coverage
- split some tests to make the above possible
TEST=UI test based
BUG=39785
Review URL: http://codereview.chromium.org/1547003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a bug in String.prototype.replace.
BUG=v8:667 (http://code.google.com/p/v8/issues/detail?id=667)
TEST=none
Review URL: http://codereview.chromium.org/1529003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
has been annotated.
BUG=32892
Review URL: http://codereview.chromium.org/1276002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
xib changes:
- Added a new NSView for showing detailed information about appcaches in the cookie tree. The new view uses the same pattern as the existing views.
- Added bindings for the new view to control its visibility and the values displayed, also using the same style as the existing detail information subviews.
BUG=37459
TEST=new unit test and manual tests
Review URL: http://codereview.chromium.org/1555001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to FLAKY on Windows and Linux (required infrastructure is still not
available on Mac).
There is a slight possiblity that the flakiness has disappeared,
but I don't think so. We're going to get more accurate data
from the flakiness report.
TEST=AutomationProxyVisibleTest.AutocompleteMatchesTest
BUG=19876
Review URL: http://codereview.chromium.org/1530004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in the UI test framework:
- WaitUntilCookieValue
- WaitUntilCookieNonEmpty
- WaitUntilJavaScriptCondition
This helps reduce number of arbitrary "magic timeouts" which are different
in each test.
We don't remove the test timeout parameter, because it varies depending on test case,
and for now we don't have a better solution. Trying a "naive" way leads to hangs
on flaky tests.
TEST=UI-based tests
BUG=none
Review URL: http://codereview.chromium.org/1557001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
language is removed.
BUG=crosbug.com/2297
TEST=manually
Review URL: http://codereview.chromium.org/1585002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=hclam@chromium.org
Review URL: http://codereview.chromium.org/1545005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Along the way, refactor the code by adding SetLanguageActivated(),
This is simpler than having ActivateLanguage() and DeactivateLanguage().
The idea comes from View::SetEnabled(bool enabled).
BUG=crosbug.com/2001
TEST=manually
Review URL: http://codereview.chromium.org/1546002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Select a site in a language different than the Chrome
language, select never translate this site/language.
Visit that site again, use the context menu to translate.
The site and language should not be blacklisted for translation
anymore.
Review URL: http://codereview.chromium.org/1551001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
templating the AutofillModelAssociator code so we can use it for both formfill (what I'm calling autofillV1 in this patch), and "profiles". Since the diffs didn't line up so well from having to move some implementation to the .h (template), I'm breaking up the review here with just the formfill code rearranged and no autofill++ impl.
Review URL: http://codereview.chromium.org/1521002
TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/1559005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=WebSocketJob::SimpleHandshakeDraft76 passes
Review URL: http://codereview.chromium.org/1256001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1483001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=asargent
TEST=None
BUG=None
Review URL: http://codereview.chromium.org/1547006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
closure. The dismissal notification is sent asynchronously, after which the pop-up is entirely destructed. The ExtensionPopupHost now holds a reference to the pop-up, so that it can safely make use of it during ExtensionPopupHost::DispatchPopupClosedEvent.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/1512002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1578003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the Infobar is not set as the Container when the Infobar dies or
its delegate dies (so that we don't get calls from the
ExtensionView after our destruction).
Some background:
Our ExtensionInfobarDelegate owns the Infobar state, including the
ExtensionView/Host. This is because Infobars in Chrome are deleted
and recreated when you switch away from the tab and come back (and
we don't want to lose state doing so).
We also have an ExtensionInfobar object, which is set as a
"Container" for the ExtensionView, so that it can responds to
resize events from the ExtensionView.
The problem is that once chrome.tabs.create is called, a new tab
is created, which deletes the Infobar object that has yet to
receive an OnMouseLeave message from the View. Hence the crash.
We therefore null the Container in the destructor for the
ExtensionInfobar, to make sure the ExtensionView doesn't report
more events to us after we are deleted.
The only problem with this is that using the delegate_ pointer
in the destructor for ExtensionInfobar is not safe, because the
delegate may be deleted before us. Therefore, we also now observe
when the delegate is destroyed, so we can null the Container
through it.
BUG=http://crbug.com/39755
TEST=Using tabs.create should not crash the extension. Also,
opening two tabs, both with an infobar should not crash if you
switch to the first tab and close it.
Review URL: http://codereview.chromium.org/1583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
have state visible if they are not rendered on screen.
Add the ROLE_PANE role to viewsaccessibility types.
Provide accessible role and name for BrowserActionsContainer, InfoBarContainer, and InfoBar.
Set BrowserActionsContainer view visibility to true only when it contains browser actions.
Set ExtensionShelf vew visibility to true only when it has non-zero height.
BUG=36224
TEST=Verify extension toolbar and infobar container accessibility info within AccExplore32.exe
Review URL: http://codereview.chromium.org/669275
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
red when the URL is not properly formed.
BUG=17612
TEST=Type an unacceptable character in the URL field or leave the URL field blank and observe a red background.
Review URL: http://codereview.chromium.org/837010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1581001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
items, and no longer needed calls.
BUG=39428
TEST=Pop up a folder menu and insure that the background does not adopt any theme settings.
Review URL: http://codereview.chromium.org/1548003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in favor of a gyp variable.
Not sure how this managed to stick around this long.
BUG=39744
TEST=None
Review URL: http://codereview.chromium.org/1567002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
control.
BUG=9614
TEST=open AccExplorer, open Report broken website dialog, point AccExplorer to the combobox, see if the string value contained in the 'Bug type'combobox is the currently selected on it.
Patch from Thiago Farina <thiago.farina@gmail.com>
Review URL: http://codereview.chromium.org/1521001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
video frames.
In conjunction with a log parser we can detect dropped frames and our display jitter.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1398001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
changes changed how things get focus, so it's not clear to me what the desired behavior here is. I'll get this worked out tomorrow.
TBR=sky
BUG=none
TEST=Unittests don't fail
Review URL: http://codereview.chromium.org/1587001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=inferno
Review URL: http://codereview.chromium.org/1568006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
DownloadRequestManagerTest.Allow test
TBR=inferno
Review URL: http://codereview.chromium.org/1545004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To make use_system_ffmpeg work more correctly, we now use the system include path for headers and make use of the version number macros to determine the shared library names.
Also removed a bunch of cruft without breaking anything on Windows, Mac or Linux.
BUG=23602, 39430
TEST=ffmpeg should still work both with and without use_system_ffmpeg
Review URL: http://codereview.chromium.org/1503002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
thread, and GpuProcessHost, which now runs on the IO thread and
derives from ChildProcessHost. This split was necessary in order to
service synchronous messages from the renderer process. Moved message
handlers for GPU messages from renderer to browser from
BrowserRenderProcessHost to ResourceMessageFilter.
Stopped sending multiple ViewHostMsg_EstablishGpuChannel messages from
the same renderer if the connection was already established. Resetting
the channel was causing failures in Send, and every other page reload
containing WebGL content to fail. This cleanup will allow further
simplification in the GPU process, but this is being left for a
subsequent CL.
Fixed bug in sandboxing of GPU process. Fixed latent bugs in cleanup
code in GpuChannel and GpuChannelHost. Fixed crashes in
ChildProcessHost if resource_dispatcher_host_ was NULL. Fixed apparent
latent race conditions in creation of BackingStoreProxy and
VideoLayerProxy.
With these changes, WebGL content is running in the sandbox on both
Mac and Windows. Linux support will be added in a following CL.
BUG=29120
TEST=ran WebGL demos on Mac and Windows
Review URL: http://codereview.chromium.org/1546001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43029 0039d316-1c4b-4281-b951-d872f2087c98
|