summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Make the default launch container always be a tab. I think thisaa@chromium.org2010-05-053-6/+2
| | | | | | | | | is less confusing for users and the app tab is currently better, anyway. Review URL: http://codereview.chromium.org/1914001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46497 0039d316-1c4b-4281-b951-d872f2087c98
* Fix popups from onunload handlers.erg@chromium.org2010-05-051-3/+12
| | | | | | | | | | | | These popups should be checked against the page that created them and not the page that we're currently navigating to. BUG=40718 TEST=none Review URL: http://codereview.chromium.org/1906007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46496 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break.pkasting@chromium.org2010-05-051-0/+1
| | | | | | | | BUG=38717 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46494 0039d316-1c4b-4281-b951-d872f2087c98
* Make Font::GetStringWidth() a shortcut for gfx::Canvas::SizeStringInt() on ↵pkasting@chromium.org2010-05-055-27/+22
| | | | | | | | | | | | Windows. These two functions already did the same thing on Mac and Linux. If they ever returned different results on Windows, it would lead to subtle bugs, since measurement and drawing would slightly disagree. Clean up a few other things so that all three implementations of GetStringWidth() are identical. BUG=38717 TEST=none Review URL: http://codereview.chromium.org/1928003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46492 0039d316-1c4b-4281-b951-d872f2087c98
* Fix RTL-mode display of table of URLs to load on startup. The table itself ↵pkasting@chromium.org2010-05-051-5/+4
| | | | | | | | | | should still be mirrored (items are laid out right-to-left), we just want to mark the text contents as LTR (since they're URLs). BUG=7215 TEST=In Hebrew UI, go to first page of options and add URLs to table of URLs to load on startup. Check that they're laid out right-to-left with favicon first, but actual URLs are still drawn LTR. Review URL: http://codereview.chromium.org/1962004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46491 0039d316-1c4b-4281-b951-d872f2087c98
* STS: add elanex.biz to the preloaded list.agl@chromium.org2010-05-052-0/+8
| | | | | | | | Confirmed by asking the requestor to add STS headers to the website. http://codereview.chromium.org/1973003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46490 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll to r58838.dpranke@chromium.org2010-05-052-3/+1
| | | | | | | | | | BUG=none TEST=none R=none Review URL: http://codereview.chromium.org/1979001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46489 0039d316-1c4b-4281-b951-d872f2087c98
* Only define the ChangeResolution target on Windows. This fixes a problem ↵tschmelcher@chromium.org2010-05-051-8/+16
| | | | | | | | | | | | where the make generator on the buildbots was trying to build the target on Linux. Committing without code review because the code review server is down. TEST=built all targets on Linux BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46488 0039d316-1c4b-4281-b951-d872f2087c98
* Change the V8 proxy resolver bindings so that dnsResolve(XXX) returns null ↵eroman@chromium.org2010-05-053-39/+32
| | | | | | | | | | | | | when XXX is not a string. (The current behavior is to stringize XXX). This is consistent with other browsers. BUG=42646 TEST=ProxyResolverV8Test.V8indings Review URL: http://codereview.chromium.org/1954004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46487 0039d316-1c4b-4281-b951-d872f2087c98
* Added unit tests for URLSecurityManager.ahendrickson@chromium.org2010-05-052-0/+89
| | | | | | | | | BUG=29596 TEST=Pass in --gtest_filter=URLSecurityManager.* Review URL: http://codereview.chromium.org/1695008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46486 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the mini tab title animation.sky@chromium.org2010-05-057-31/+250
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1902005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46485 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 41985 - The focus frames are out of range on the Options ↵xji@chromium.org2010-05-053-14/+329
| | | | | | | | | | | | | | | | | | | | : RTL. Previously, Label::CalculateDrawStringParams() computes the text boundary for signle-line and multi-line texts differently, so the boundary of focus rectangle is computed differently too inside Label::Paint(). Now, Label::CalculateDrawStringParams() computes text boundary without differentiate single-line and multi-line text, the boundary itself always takes mirror into consideration. So, the boundary of focus rectangle no longer need mirroring for both cases. BUG=http://crbug.com/41985 TEST= 1. Launch Chrome with RTL languages UI (ex: chrome.exe --lang=he) 2. click Wrench => Options Under the Hood 3. click or press tab to focus any string there. 4. the focus should be around the text, not out of the text range. Review URL: http://codereview.chromium.org/1694012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46484 0039d316-1c4b-4281-b951-d872f2087c98
* Make the app launcher bubble fit its contents.jcivelli@google.com2010-05-0517-130/+235
| | | | | | | | | | | | | | It remains at least as wide as the browser location bar (that way it can always point at the + button). InfoBubble was modified so it can be resized. BUG=42260 TEST=Open the app launcher multiple-times. The app launcher should fit its contents nicely. Review URL: http://codereview.chromium.org/1739020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46482 0039d316-1c4b-4281-b951-d872f2087c98
* Update expectations temporarily.dpranke@chromium.org2010-05-051-0/+2
| | | | | | | | | | | | | Expect svg/custom/mask-changes.svg and http/tests/loading/bad-scheme-subframe.html to fail. BUG=none TEST=none TBR=none Review URL: http://codereview.chromium.org/1937009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46481 0039d316-1c4b-4281-b951-d872f2087c98
* Remove NOTIMPLEMENTED log spew for BrowserWindowCocoa::ShelfVisibilityChanged().mark@chromium.org2010-05-051-1/+1
| | | | | | | | BUG=43196 TEST=Spew gone. Review URL: http://codereview.chromium.org/1960002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46480 0039d316-1c4b-4281-b951-d872f2087c98
* Add EGLImage as one media type different than regular uncompressed video buffer.scherkus@chromium.org2010-05-0517-27/+106
| | | | | | | | | | | | | | Video renderer could get this info via decoder->media_format(). This is needed in case video renderer is the buffer allocator. Patch by wjia@chromium.org: http://codereview.chromium.org/1725021/show BUG=NONE TEST=compiles Review URL: http://codereview.chromium.org/1952003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46479 0039d316-1c4b-4281-b951-d872f2087c98
* Valid FDs are >= 0 (> -1), not >= -1.mark@chromium.org2010-05-051-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1937008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46478 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage after:mark@chromium.org2010-05-051-1/+1
| | | | | | | | | | | r46472 | aa@chromium.org | 2010-05-05 14:47:30 -0400 (Wed, 05 May 2010) BUG=none TEST=green TBR=aa Review URL: http://codereview.chromium.org/1965004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46477 0039d316-1c4b-4281-b951-d872f2087c98
* Tabbed Bookmark Manager: match the context menu items with the bookmarks bar.arv@chromium.org2010-05-051-3/+5
| | | | | | | | | | | | | BUG=None TEST=right click on a bookmark in the bookmarks bar (see the order of items), right click on a bookmark in the bookmark manager (see the order). They should match. Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1843001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46475 0039d316-1c4b-4281-b951-d872f2087c98
* Update the Native Client version from 2072 to 2200.msneck@google.com2010-05-051-1/+1
| | | | | | | | | BUG=none TEST=nacl_ui_tests (and all others) still pass. Review URL: http://codereview.chromium.org/1932008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46473 0039d316-1c4b-4281-b951-d872f2087c98
* Tell the app launcher about any newly installed apps. This is intended to be ↵aa@chromium.org2010-05-058-19/+89
| | | | | | | | used for a nice animation. Review URL: http://codereview.chromium.org/1906004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46472 0039d316-1c4b-4281-b951-d872f2087c98
* Add pyauto tests for Navigation.nirnimesh@chromium.org2010-05-055-2/+118
| | | | | | Review URL: http://codereview.chromium.org/1948002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46471 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the flaky mark from ErrorPage tests. Apparentlyphajdan.jr@chromium.org2010-05-051-22/+11
| | | | | | | | | | the tests are no longer flaky on the buildbots. TEST=ErrorPageTest.* BUG=22877 Review URL: http://codereview.chromium.org/1951007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46470 0039d316-1c4b-4281-b951-d872f2087c98
* Add logging to undersand exactly where CreateDirectory() is failing for users.skerner@google.com2010-05-051-2/+15
| | | | | | | | | BUG=35198 TEST=none Review URL: http://codereview.chromium.org/1948005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46468 0039d316-1c4b-4281-b951-d872f2087c98
* ScopedFD should handle EINTR on close.mark@chromium.org2010-05-051-2/+3
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1954003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46467 0039d316-1c4b-4281-b951-d872f2087c98
* Kernel zombie death race!mark@chromium.org2010-05-051-82/+132
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Harden process_watcher_mac against zombie-admitting holes. A race between the application and the kernel exists in that a process stops being kqueueable before it becomes waitable. If ProcessWatcher::EnsureProcessTerminated was called within this window, it would assume that the process had already been reaped. The process would then become waitable, but by then, the application forgot about it, and it would be leaked as a zombie until the application as a whole was quit. In order to kill the undead, this code now detects not-kqueueable not-waitable processes and does a blocking wait, with a kill thrown in for good measure. Other opportunities for this code to return early without making the best effort to kill the process have been plugged up too. If any of the kqueue operations fail, this will now fall through to kill and wait for the process. BUG=43150, 43244 TEST=A. Steps from bug 43150 comment 8: 1. Clean profile. 2. Launch. The home page, http://www.google.com/, will load. 3. Type (or paste) about:blank into the omnibox. Expect: no zombies. Observe: original renderer process almost always becomes undead. Note: Perform the test multiple times. It's timing-sensitive. I experienced varying degrees of success reproducing zombies when launching the app by double-clicking it, running it from a terminal window with stdout and stderr on the terminal, and running it from a terminal window with stdout and stderr redirected to a file. With this fix, no zombies should be condition. B. zombies.py test from bug 43244. Review URL: http://codereview.chromium.org/1915003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46466 0039d316-1c4b-4281-b951-d872f2087c98
* Move NPAPI to C99 typesstuartmorgan@chromium.org2010-05-057-128/+200
| | | | | | | | | BUG=42645 TEST=None; no behavioral change. Review URL: http://codereview.chromium.org/1910004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46463 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 58819:58820jeremy@chromium.org2010-05-051-1/+1
| | | | | | | | | | | | | | | | | | Fallout from Skia r561 merge. Mark remainging failures as such in test_expectations to green the tree. BUG=None TEST=None WebKit roll 58817:58819 More rebaselines need to bring us in line after rolling to Skia r561. BUG=None TEST=None Review URL: http://codereview.chromium.org/1919004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46462 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 58817:58819jeremy@chromium.org2010-05-051-1/+1
| | | | | | | | | | | More rebaselines need to bring us in line after rolling to Skia r561. BUG=None TEST=None Review URL: http://codereview.chromium.org/1902004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46461 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Roll 58811:58817jeremy@chromium.org2010-05-051-1/+1
| | | | | | | | | | | Roll in the (hopefully) final bits of the rebaseline needed after the roll to Skia r561. BUG=None TEST=None Review URL: http://codereview.chromium.org/1905004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46460 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure the directory for the brand file exists before trying to write to it.thomasvl@chromium.org2010-05-051-0/+12
| | | | | | | | BUG=42988 TEST=see bug Review URL: http://codereview.chromium.org/1903004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46458 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 58807:58811 .jeremy@chromium.org2010-05-051-1/+1
| | | | | | | | | | | | | | | Roll in first batch of rebaselines as the result of rolling Skia to r561. WebKit r58811 contains rebaselines of ~100 tests and changes to test expectations to cover additional Mac tests that started failing. ~900 tests left to rebaseline after this change. BUG=None TEST=None Review URL: http://codereview.chromium.org/1934003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46457 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run SpdyNetworkTransactionTest.CloseWithActiveStream under Valgrindtimurrrr@chromium.org2010-05-051-0/+1
| | | | | | | | BUG=43179 TBR=glider,rsesek,cbentzel Review URL: http://codereview.chromium.org/1921005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46456 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 396.0 to 397.0chrome-release@google.com2010-05-051-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46452 0039d316-1c4b-4281-b951-d872f2087c98
* Move the excluded test name to the right file...timurrrr@chromium.org2010-05-052-3/+2
| | | | | | | | BUG=43291 TBR=glider,eroman Review URL: http://codereview.chromium.org/1925004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46450 0039d316-1c4b-4281-b951-d872f2087c98
* Skia roll 560:561 .jeremy@chromium.org2010-05-051-1/+1
| | | | | | | | | | | | | | | | This Skia revision changes how lines with a width of 1 pixel are drawn. We're going to need to rebase ~1K tests after this lands. BUG=None TEST=None WebKit roll 58791:58807 BUG=None TEST=None Review URL: http://codereview.chromium.org/1942006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46449 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 58791:58807jeremy@chromium.org2010-05-051-1/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/1932007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46448 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress benign races in base/time_win.cctimurrrr@chromium.org2010-05-051-0/+7
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/1968002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46447 0039d316-1c4b-4281-b951-d872f2087c98
* Fix PYTHONPATH handling for heapchecker according toglider@chromium.org2010-05-053-11/+11
| | | | | | | | | http://codereview.chromium.org/1736026/show Review URL: http://codereview.chromium.org/1910003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46446 0039d316-1c4b-4281-b951-d872f2087c98
* temprarily commented out the dcheck that is causing try bot failures.oshima@chromium.org2010-05-051-2/+4
| | | | | | | | | | | | This is trybot only issue because build bot builds release binary. TBR=derat@chromium.org BUG=http://crosbug.com/3064 TEST=trybot should pass for changes that should pass. Review URL: http://codereview.chromium.org/1919003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46445 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run ConnectionTesterTest.DeleteWhileInProgress under Valgrindtimurrrr@chromium.org2010-05-051-1/+4
| | | | | | | | TBR=glider,eroman BUG=43291 Review URL: http://codereview.chromium.org/1908007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46444 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 2.2.8.ager@chromium.org2010-05-051-1/+1
| | | | | | | | | | | This update contains performance improvements in the x64 and ARM backends. TEST=None BUG=None Review URL: http://codereview.chromium.org/1937006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46443 0039d316-1c4b-4281-b951-d872f2087c98
* Screen Locker: 1st steposhima@chromium.org2010-05-059-11/+517
| | | | | | | | | | | | | | | * ScreenLocker screen currently reuses Background from Login screen. * GrabWidget is created to grab keyboard/mouse events. * Modified StubAuthentiator to fail when an empty password is entered. * Changed UserManager to explicitly remember the currently logged in user. UI is not hooked yet. BUG=43131, http://crosbug.com/2914 TEST=none Review URL: http://codereview.chromium.org/1897001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46442 0039d316-1c4b-4281-b951-d872f2087c98
* Close menu on grab broke event.oshima@chromium.org2010-05-053-2/+17
| | | | | | | | | | | This is necessary for screen locker to grab the input event. Technically, this can happen when another part of chrome tries to grab the input, so this is safer to handle this. BUG=none TEST=none Review URL: http://codereview.chromium.org/1900002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46441 0039d316-1c4b-4281-b951-d872f2087c98
* Repeat 10.6 perf regression suppression for 10.5.dpranke@chromium.org2010-05-051-1/+1
| | | | | | | | | | BUG=43276 TBR=chase TEST=none Review URL: http://codereview.chromium.org/1916003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46440 0039d316-1c4b-4281-b951-d872f2087c98
* Add transparency to TYPE_CHILD WidgetGtk.oshima@chromium.org2010-05-053-57/+196
| | | | | | | | | | | | | | | * This does not work with renderer as parent yet.(I need to investigate renderer what it's doing) * gtk_widget_set_back_pixmap is not necessary and removed. * changed to use clear operation to fill a background with transparent color. BUG=none TEST=manual: added transparent widget example to view_examples. I also tested with chrome and confirmed that info bubble, app launcher and tab dragging works. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46374 Review URL: http://codereview.chromium.org/1629024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46439 0039d316-1c4b-4281-b951-d872f2087c98
* Add integration test for autofill profiles.skrul@chromium.org2010-05-056-21/+374
| | | | | | | | I also expanded on the orignial autofill "steady" test to include removals. Plus a little refactoring of the WDS test. Review URL: http://codereview.chromium.org/1963001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46438 0039d316-1c4b-4281-b951-d872f2087c98
* Add icons to SimpleMenuModel.estade@chromium.org2010-05-056-49/+79
| | | | | | | | | | | | Also get rid of one of the MenuGtk constructors (now down to 2). Also, stamp out one more use of MenuGtk::Delegate as a controller class. BUG=31365 TEST=manual (in debug mode) + trybots Review URL: http://codereview.chromium.org/1915004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46434 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors animation to allow for cleaner subclassing. I'm doing thissky@chromium.org2010-05-0550-405/+622
| | | | | | | | | | | | for creating a different animation subclass (which you'll see shortly). BUG=none TEST=none Review URL: http://codereview.chromium.org/1961001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46433 0039d316-1c4b-4281-b951-d872f2087c98
* The latest WebKit roll seems to have caused a perf regression on the pagedpranke@chromium.org2010-05-051-1/+1
| | | | | | | | | | | | | | cycler for 10.6 for the intl1 tests by 750ms. I have no idea how to debug this yet, but I need to leave the tree rolled-forward in order to have the mac bots running the fix in r58789. BUG=43276 TBR=chase TEST=none Review URL: http://codereview.chromium.org/1974001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46432 0039d316-1c4b-4281-b951-d872f2087c98